Re: [WIP RFC PATCH v2 5/5] clone: use dir-iterator to avoid explicit dir traversal

2019-02-27 Thread Ævar Arnfjörð Bjarmason
On Wed, Feb 27 2019, Matheus Tavares Bernardino wrote: > On Tue, Feb 26, 2019 at 9:32 AM Duy Nguyen wrote: >> >> On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares >> wrote: >> > >> > Replace usage of opendir/readdir/closedir API to traverse directories >> > recursively, at copy_or_link_director

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread Duy Nguyen
On Wed, Feb 27, 2019 at 10:24 PM Brandon Richardson wrote: > > > +static int parse_file_arg_callback(const struct option *opt, > > > + const char *arg, int unset) > > > > I would suggest you do the same for -F, i.e. collect a string list of > > paths then do the heavy lifting afterwa

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread Duy Nguyen
On Wed, Feb 27, 2019 at 7:36 PM SZEDER Gábor wrote: > > On Wed, Feb 27, 2019 at 06:49:53PM +0700, Duy Nguyen wrote: > > On Wed, Feb 27, 2019 at 6:37 PM SZEDER Gábor wrote: > > > > > > On Wed, Feb 27, 2019 at 06:07:42PM +0700, Duy Nguyen wrote: > > > > > It was discovered that the --no-gpg-sign op

Re: [WIP RFC PATCH v2 5/5] clone: use dir-iterator to avoid explicit dir traversal

2019-02-27 Thread Duy Nguyen
On Thu, Feb 28, 2019 at 12:40 AM Matheus Tavares Bernardino wrote: > > > @@ -463,7 +460,11 @@ static void copy_or_link_directory(struct strbuf > > > *src, struct strbuf *dest, > > > if (copy_file_with_time(dest->buf, src->buf, 0666)) > > > die_errno(_("fail

Tags from each remote in a separate "name-space"?

2019-02-27 Thread Sergey Organov
Hello, How do I configure git to handle tags from remotes in a manner similar to branches? Specifically, I want tag 'tag_name' from remote 'origin' to have local name 'origin/tag_name', not 'tag_name', as it is by default. For a repo with a lot of remotes[*] it would allow to keep track of what t

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread Brandon Richardson
Hi Jeff, > One of the reasons I did not bother with that condition when I added the > OPT_NEG() and OPT_ARG() variants is that you can only get an unexpected > NULL argument if you explicitly give the NOARG or OPTARG flags. So it's > very easy to _forget_ to give such a flag, because you simply ar

[PATCH] rebase docs: fix "gitlink" typo

2019-02-27 Thread Kyle Meyer
Change it to "linkgit" so that the reference is properly rendered. Signed-off-by: Kyle Meyer --- Documentation/git-rebase.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt index 5629ba4c5d..6363d674b7 100644 --- a/

Re: [WIP RFC PATCH v2 4/5] clone: extract function from copy_or_link_directory

2019-02-27 Thread Matheus Tavares Bernardino
On Wed, Feb 27, 2019 at 7:45 PM Thomas Gummerer wrote: > > On 02/27, Matheus Tavares Bernardino wrote: > > On Tue, Feb 26, 2019 at 9:18 AM Duy Nguyen wrote: > > > > > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > > > wrote: > > > > +*/ > > > > + struct stat st; > > > > + > >

Re: [WIP RFC PATCH v2 4/5] clone: extract function from copy_or_link_directory

2019-02-27 Thread Thomas Gummerer
On 02/27, Matheus Tavares Bernardino wrote: > On Tue, Feb 26, 2019 at 9:18 AM Duy Nguyen wrote: > > > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > > wrote: > > > +*/ > > > + struct stat st; > > > + > > > + if (mkdir(pathname, mode)) { > > > > Good opportunity to uninde

RE: Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
On February 27, 2019 14:36, Johannes Sixt wrote: > Am 27.02.19 um 19:50 schrieb Randall S. Becker: > > On February 27, 2019 13:18, Michal Suchánek wrote: > >> What are your requirements, exactly? > > Source code and comments contain SJIS content. The requirement is to > > be able to move seamlessly

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Johannes Sixt
Am 27.02.19 um 19:50 schrieb Randall S. Becker: > On February 27, 2019 13:18, Michal Suchánek wrote: >> What are your requirements, exactly? > Source code and comments contain SJIS content. The requirement is to > be able to move seamlessly in and out of git, and have git show/diff/log > display SJ

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Michal Suchánek
On Wed, 27 Feb 2019 13:50:18 -0500 "Randall S. Becker" wrote: > On February 27, 2019 13:18, Michal Suchánek wrote: > > On Wed, 27 Feb 2019 12:59:15 -0500 > > "Randall S. Becker" wrote: > > > > > On February 27, 2019 12:51, Michal Suchánek wrote: > > > > To: Randall S. Becker > > > > Cc: gi

RE: Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
On February 27, 2019 13:18, Michal Suchánek wrote: > On Wed, 27 Feb 2019 12:59:15 -0500 > "Randall S. Becker" wrote: > > > On February 27, 2019 12:51, Michal Suchánek wrote: > > > To: Randall S. Becker > > > Cc: git@vger.kernel.org > > > Subject: Re: Need multibyte advice - Shift-JIS > > > > >

Re: [PATCH 1/3] Documentation/Makefile: add missing xsl dependencies for manpages

2019-02-27 Thread Martin Ågren
On Tue, 26 Feb 2019 at 13:47, Eric Sunshine wrote: > > On Tue, Feb 26, 2019 at 12:59 AM Martin Ågren wrote: > > Were you perhaps mislead by one of the similarly-named files? > > Yes, I was misled by similar names. Sorry for the noise. Hey, no problem. And thanks for the subtle hint about "misled

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Michal Suchánek
On Wed, 27 Feb 2019 12:59:15 -0500 "Randall S. Becker" wrote: > On February 27, 2019 12:51, Michal Suchánek wrote: > > To: Randall S. Becker > > Cc: git@vger.kernel.org > > Subject: Re: Need multibyte advice - Shift-JIS > > > I'm sorry if I was not clear about all this. NonStop is not a Linux

[PATCH v2 1/3] Documentation/Makefile: add missing xsl dependencies for manpages

2019-02-27 Thread Martin Ågren
These stylesheets very rarely change, but when they do, it really helps if the manpages depend on them. We're casting the net a bit too wide here, since we'll only ever use a subset of the stylesheets, but since these files change so rarely, that should be ok. It's better than missing a dependency.

[PATCH v2 2/3] Documentation/Makefile: add missing dependency on asciidoctor-extensions

2019-02-27 Thread Martin Ågren
asciidoctor-extensions.rb has never changed, but when it does -- such as in the next commit --, it helps if the xml-files depend on it. We're casting the net a bit too wide here, since we'll be rebuilding even with AsciiDoc, which won't look at this file. But since this file changes so rarely, that

[PATCH v2 3/3] asciidoctor-extensions: fix spurious space after linkgit

2019-02-27 Thread Martin Ågren
When we render, e.g., "linkgit:gitglossary[7]." with Asciidoctor, we get "gitglossary(7) ." with a space between the linkgit macro expansion and the punctuation. We can fix this by dropping the trailing newline after we've turned `linkgit:foo[bar]` into `..`. The diff produced by `USE_ASCIIDOCTOR=

[PATCH v2 0/3] asciidoctor-extensions: fix spurious space after linkgit

2019-02-27 Thread Martin Ågren
Just like v1 [1], this v2 removes a spurious space which shows up in a large number of places in our manpages when Asciidoctor expands the linkgit:foo[bar] macro. The only difference is a new paragraph in the commit message of the first patch to explain why we need to explicitly list a file we depe

RE: Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
On February 27, 2019 12:51, Michal Suchánek wrote: > To: Randall S. Becker > Cc: git@vger.kernel.org > Subject: Re: Need multibyte advice - Shift-JIS > > On Wed, 27 Feb 2019 12:38:06 -0500 > "Randall S. Becker" wrote: > > > On February 27, 2019 12:15, Michal Suchánek wrote: > > > To: Randall S.

I want to adapt the Integration Manager Workflow in-house

2019-02-27 Thread Dr. Rolf Jansen
Hello By reading the Git documentation and other resources, I am convinced that the Integration Manager Workflow would be best for continuing with the development on a broader basis of a certain project - this is out of question - I want the IMW. This project got a few years of history by a si

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Michal Suchánek
On Wed, 27 Feb 2019 12:38:06 -0500 "Randall S. Becker" wrote: > On February 27, 2019 12:15, Michal Suchánek wrote: > > To: Randall S. Becker > > Cc: git@vger.kernel.org > > Subject: Re: Need multibyte advice - Shift-JIS > > > > On Wed, 27 Feb 2019 12:03:58 -0500 > > "Randall S. Becker" wrote:

Re: [WIP RFC PATCH v2 5/5] clone: use dir-iterator to avoid explicit dir traversal

2019-02-27 Thread Matheus Tavares Bernardino
On Tue, Feb 26, 2019 at 9:32 AM Duy Nguyen wrote: > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > wrote: > > > > Replace usage of opendir/readdir/closedir API to traverse directories > > recursively, at copy_or_link_directory function, by the dir-iterator > > API. This simplifies the code

RE: Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
On February 27, 2019 12:15, Michal Suchánek wrote: > To: Randall S. Becker > Cc: git@vger.kernel.org > Subject: Re: Need multibyte advice - Shift-JIS > > On Wed, 27 Feb 2019 12:03:58 -0500 > "Randall S. Becker" wrote: > > > On February 27, 2019 11:52, Michal Suchánek wrote: > > > To: Randall S.

Re: [BUG] All files in folder are moved when cherry-picking commit that moves fewer files

2019-02-27 Thread Elijah Newren
On Wed, Feb 27, 2019 at 8:40 AM Jeff King wrote: > > On Wed, Feb 27, 2019 at 08:02:35AM -0800, Elijah Newren wrote: > > > > > I have found what I suspect to be a bug, or at least not desirable > > > > behavior in my case. In one branch, I have moved all files in a > > > > directory to another dire

Re: [WIP RFC PATCH v2 4/5] clone: extract function from copy_or_link_directory

2019-02-27 Thread Matheus Tavares Bernardino
On Tue, Feb 26, 2019 at 9:18 AM Duy Nguyen wrote: > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > wrote: > > > > Extract dir creation code snippet from copy_or_link_directory to its own > > function named mkdir_if_missing. This change will help removing > > copy_or_link_directory's explici

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Michal Suchánek
On Wed, 27 Feb 2019 12:03:58 -0500 "Randall S. Becker" wrote: > On February 27, 2019 11:52, Michal Suchánek wrote: > > To: Randall S. Becker > > Cc: git@vger.kernel.org > > Subject: Re: Need multibyte advice - Shift-JIS > > > > On Wed, 27 Feb 2019 11:33:47 -0500 > > "Randall S. Becker" wrote:

RE: Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
On February 27, 2019 11:52, Michal Suchánek wrote: > To: Randall S. Becker > Cc: git@vger.kernel.org > Subject: Re: Need multibyte advice - Shift-JIS > > On Wed, 27 Feb 2019 11:33:47 -0500 > "Randall S. Becker" wrote: > > > On February 27, 2019 11:29 Michal Suchánek wrote: > > > On Wed, 27 Feb

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Michal Suchánek
On Wed, 27 Feb 2019 11:33:47 -0500 "Randall S. Becker" wrote: > On February 27, 2019 11:29 Michal Suchánek wrote: > > On Wed, 27 Feb 2019 11:19:33 -0500 > > "Randall S. Becker" wrote: > > > > > On February 27, 2019 11:11, Michal Suchánek wrote: > > > > On Wed, 27 Feb 2019 10:54:23 -0500 > >

Re: [BUG] All files in folder are moved when cherry-picking commit that moves fewer files

2019-02-27 Thread Jeff King
On Wed, Feb 27, 2019 at 08:02:35AM -0800, Elijah Newren wrote: > > > I have found what I suspect to be a bug, or at least not desirable > > > behavior in my case. In one branch, I have moved all files in a > > > directory to another directory. The first directory is now empty > > > in this branch

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread Jeff King
On Wed, Feb 27, 2019 at 06:07:42PM +0700, Duy Nguyen wrote: > > +static int parse_parent_arg_callback(const struct option *opt, > > + const char *arg, int unset) > > +{ > > + struct object_id oid; > > + struct commit_list **parents = opt->value; > > + > > + BUG_ON_O

RE: Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
On February 27, 2019 11:29 Michal Suchánek wrote: > On Wed, 27 Feb 2019 11:19:33 -0500 > "Randall S. Becker" wrote: > > > On February 27, 2019 11:11, Michal Suchánek wrote: > > > On Wed, 27 Feb 2019 10:54:23 -0500 > > > "Randall S. Becker" wrote: > > > > > > > On February 27, 2019 9:09, Michal S

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Michal Suchánek
On Wed, 27 Feb 2019 11:19:33 -0500 "Randall S. Becker" wrote: > On February 27, 2019 11:11, Michal Suchánek wrote: > > On Wed, 27 Feb 2019 10:54:23 -0500 > > "Randall S. Becker" wrote: > > > > > On February 27, 2019 9:09, Michal Suchánek wrote: > > > > On Wed, 27 Feb 2019 08:04:08 -0500 > >

RE: Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
On February 27, 2019 11:11, Michal Suchánek wrote: > On Wed, 27 Feb 2019 10:54:23 -0500 > "Randall S. Becker" wrote: > > > On February 27, 2019 9:09, Michal Suchánek wrote: > > > On Wed, 27 Feb 2019 08:04:08 -0500 > > > "Randall S. Becker" wrote: > > > > > > > Hi Git Team, > > > > > > > > I have

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Michal Suchánek
On Wed, 27 Feb 2019 10:54:23 -0500 "Randall S. Becker" wrote: > On February 27, 2019 9:09, Michal Suchánek wrote: > > On Wed, 27 Feb 2019 08:04:08 -0500 > > "Randall S. Becker" wrote: > > > > > Hi Git Team, > > > > > > I have to admit being perplexed by this one. I have been asked to > > > su

Re: [PATCH v3 1/1] worktree add: sanitize worktree names

2019-02-27 Thread Jeff King
On Wed, Feb 27, 2019 at 09:23:33AM -0500, Eric Sunshine wrote: > > If we just cared about saying "is this worktree name valid", I'd suggest > > actually constructing a sample refname with the worktree name embedded > > in it and feeding that to check_refname_format(). But because you want > > to a

Re: [BUG] All files in folder are moved when cherry-picking commit that moves fewer files

2019-02-27 Thread Elijah Newren
Hi, On Wed, Feb 27, 2019 at 6:30 AM Phillip Wood wrote: > > Hi Linus > > On 27/02/2019 12:47, Linus Nilsson wrote: > > Hi > > > > I have found what I suspect to be a bug, or at least not desirable behavior > > in my case. In one branch, I have moved all files in a directory to another > > direc

RE: Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
On February 27, 2019 9:09, Michal Suchánek wrote: > On Wed, 27 Feb 2019 08:04:08 -0500 > "Randall S. Becker" wrote: > > > Hi Git Team, > > > > I have to admit being perplexed by this one. I have been asked to > > support the Shift-JIS character set in file contents, comments, and > > logs, for a

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread Brandon Richardson
Thank you all for the helpful comments :-) On Wed, 27 Feb 2019 at 07:08, Duy Nguyen wrote: > > It was discovered that the --no-gpg-sign option was documented > > but not implemented in 55ca3f99, and the existing implementation > > Most people refer to a commit with this format > > 55ca3f99ae (com

Re: Occasional git p4 test failures because of stray fast-import processes

2019-02-27 Thread Luke Diamand
On Wed, 27 Feb 2019 at 09:49, SZEDER Gábor wrote: > > Hi Luke, > > I saw rare failures in test 6 'git p4 sync uninitialized repo' in > 't9800-git-p4-basic.sh' on Travis CI, because the 'cleanup_git' > function failed to do its job. The (redacted) trace looks like this: Thanks for the *very* deta

Re: git case sensitivity issue

2019-02-27 Thread Konstantin Khomoutov
On Wed, Feb 27, 2019 at 12:38:04PM +, Adrian Wright wrote: > I am a git-for-windows user and have run into issues with casing on > Windows OS. > > I filed a GitHub issue directly on the git-for-windows repo: > > The issue can be found on URL: > https://github.com/git-for-windows/git/issues/

Re: [PATCH] doc/fsck: discuss mix of --connectivity-only and --dangling

2019-02-27 Thread Jeff King
On Wed, Feb 27, 2019 at 09:55:49AM -0500, Jeff King wrote: > We could make the two cases work identically by taking a separate pass > over the unreachable objects, parsing them and marking objects they > refer to as USED. That would still avoid parsing any blobs, but we'd pay > the cost to access

[PATCH] doc/fsck: discuss mix of --connectivity-only and --dangling

2019-02-27 Thread Jeff King
The --connectivity-only option avoids opening every object, and instead just marks reachable objects with a flag, and compares this to the set of all objects. This strategy is discussed in more detail in 3e3f8bd608 (fsck: prepare dummy objects for --connectivity-check, 2017-01-17). This means that

Re: [BUG] All files in folder are moved when cherry-picking commit that moves fewer files

2019-02-27 Thread Phillip Wood
Hi Linus On 27/02/2019 12:47, Linus Nilsson wrote: Hi I have found what I suspect to be a bug, or at least not desirable behavior in my case. In one branch, I have moved all files in a directory to another directory. The first directory is now empty in this branch (I haven't tested whether this

Re: [PATCH v3 1/1] worktree add: sanitize worktree names

2019-02-27 Thread Eric Sunshine
On Wed, Feb 27, 2019 at 7:09 AM Jeff King wrote: > On Tue, Feb 26, 2019 at 05:58:51PM +0700, Nguyễn Thái Ngọc Duy wrote: > > Update 'worktree add' code to remove special characters to follow > > these rules. The code could replace chars with '-' more than > > necessary, but it keeps the code simpl

Re: Need multibyte advice - Shift-JIS

2019-02-27 Thread Michal Suchánek
On Wed, 27 Feb 2019 08:04:08 -0500 "Randall S. Becker" wrote: > Hi Git Team, > > I have to admit being perplexed by this one. I have been asked to support > the Shift-JIS character set in file contents, comments, and logs, for a > partner of mine. I know there are a few ways to do this, but I'm

[RFC] pull --set-upstream implementation

2019-02-27 Thread BOMPARD CORENTIN p1603631
We are currently working on adding "--set-upstream " to pull, that will work like "push --set-upstream " The main usage should be "git pull --set-upstream " However: * could be a refspec like "refs/heads/*" * If there is an error such as invalid URL or unreachable host we don't want to edit

Re: [WIP RFC PATCH v2 1/5] dir-iterator: add flags parameter to dir_iterator_begin

2019-02-27 Thread Matheus Tavares Bernardino
On Tue, Feb 26, 2019 at 9:02 AM Duy Nguyen wrote: > > On Tue, Feb 26, 2019 at 12:18 PM Matheus Tavares > wrote: > > int dir_iterator_advance(struct dir_iterator *dir_iterator) > > { > > struct dir_iterator_int *iter = > > (struct dir_iterator_int *)dir_iterator; > > +

[ANNOUNCE] Git Rev News edition 48

2019-02-27 Thread Christian Couder
Hi everyone, The 48th edition of Git Rev News is now published: https://git.github.io/rev_news/2019/02/27/edition-48/ Thanks a lot to the contributors: David Pursehouse and Luca Milanesio! Enjoy, Christian, Jakub, Markus and Gabriel.

Need multibyte advice - Shift-JIS

2019-02-27 Thread Randall S. Becker
Hi Git Team, I have to admit being perplexed by this one. I have been asked to support the Shift-JIS character set in file contents, comments, and logs, for a partner of mine. I know there are a few ways to do this, but I'm looking for the official non-hacky way to do this. This is CLI only, and o

[BUG] All files in folder are moved when cherry-picking commit that moves fewer files

2019-02-27 Thread Linus Nilsson
Hi I have found what I suspect to be a bug, or at least not desirable behavior in my case. In one branch, I have moved all files in a directory to another directory. The first directory is now empty in this branch (I haven't tested whether this is significant). I cherry-picked the commit to ano

git case sensitivity issue

2019-02-27 Thread Adrian Wright
Hi, I am a git-for-windows user and have run into issues with casing on Windows OS. I filed a GitHub issue directly on the git-for-windows repo: The issue can be found on URL: https://github.com/git-for-windows/git/issues/2066 See the GitHub link above for more details on the bug. According t

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread SZEDER Gábor
On Wed, Feb 27, 2019 at 06:49:53PM +0700, Duy Nguyen wrote: > On Wed, Feb 27, 2019 at 6:37 PM SZEDER Gábor wrote: > > > > On Wed, Feb 27, 2019 at 06:07:42PM +0700, Duy Nguyen wrote: > > > > It was discovered that the --no-gpg-sign option was documented > > > > but not implemented in 55ca3f99, and

Re: [FIXUP] Fixup on tip of jt/http-auth-proto-v2-fix

2019-02-27 Thread Jeff King
On Mon, Feb 25, 2019 at 03:49:01PM -0800, Jonathan Tan wrote: > Thanks, Peff, for noticing this. It's because the client sometimes sends > "" as a single request (that is, it flushes, and then before it > sends any data, it flushes again). And post_rpc() assumes that it can > always read somet

Re: [PATCH v3 1/1] worktree add: sanitize worktree names

2019-02-27 Thread Jeff King
On Tue, Feb 26, 2019 at 05:58:51PM +0700, Nguyễn Thái Ngọc Duy wrote: > Worktree names are based on $(basename $GIT_WORK_TREE). They aren't > significant until 3a3b9d8cde (refs: new ref types to make per-worktree > refs visible to all worktrees - 2018-10-21), where worktree name could > be part of

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread Duy Nguyen
On Wed, Feb 27, 2019 at 6:37 PM SZEDER Gábor wrote: > > On Wed, Feb 27, 2019 at 06:07:42PM +0700, Duy Nguyen wrote: > > > It was discovered that the --no-gpg-sign option was documented > > > but not implemented in 55ca3f99, and the existing implementation > > > > Most people refer to a commit with

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread SZEDER Gábor
On Wed, Feb 27, 2019 at 06:07:42PM +0700, Duy Nguyen wrote: > > It was discovered that the --no-gpg-sign option was documented > > but not implemented in 55ca3f99, and the existing implementation > > Most people refer to a commit with this format > > 55ca3f99ae (commit-tree: add and document --no

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread Duy Nguyen
On Wed, Feb 27, 2019 at 6:43 AM Brandon Richardson wrote: > > Hi Andrei, > > > > would attempt to translate the option as a tree oid.It was also > > > > Missing space after period. > > Oops, thanks for pointing that out. > > > > > > + { OPTION_CALLBACK, 'p', NULL, &parents, "parent", >

Re: [PATCH] commit-tree: utilize parse-options api

2019-02-27 Thread Duy Nguyen
On Wed, Feb 27, 2019 at 3:10 AM Brandon wrote: > > From: Brandon Richardson > > Rather than parse options manually, which is both difficult to > read and error prone, parse options supplied to commit-tree > using the parse-options api. > > It was discovered that the --no-gpg-sign option was docum

Re: [PATCH v3 1/1] t3600: use test_path_is_* functions

2019-02-27 Thread Duy Nguyen
On Wed, Feb 27, 2019 at 5:49 AM Rohit Ashiwal via GitGitGadget wrote: > > From: Rohit Ashiwal > > Replace `test -(d|f|e)` calls in t3600-rm.sh > > Previously we were using `test -(d|f|e)` to verify > the presence of a directory/file, but we already > have helper functions, viz, `test_path_is_dir`

Re: Do test-path_is_{file,dir,exists} make sense anymore with -x?

2019-02-27 Thread Duy Nguyen
On Tue, Feb 26, 2019 at 11:10 PM Ævar Arnfjörð Bjarmason wrote: > > > On Tue, Feb 26 2019, Duy Nguyen wrote: > > > On Tue, Feb 26, 2019 at 8:42 PM Rohit Ashiwal via GitGitGadget > > wrote: > >> > >> From: Rohit Ashiwal > >> > >> t3600-rm.sh: Previously we were using `test -(d|f)` > >> to verify

Occasional git p4 test failures because of stray fast-import processes

2019-02-27 Thread SZEDER Gábor
Hi Luke, I saw rare failures in test 6 'git p4 sync uninitialized repo' in 't9800-git-p4-basic.sh' on Travis CI, because the 'cleanup_git' function failed to do its job. The (redacted) trace looks like this: + cleanup_git + retry_until_success rm -r /home/szeder/src/git/t/trash directory.t9

[PATCH 1/1] mingw: remove obsolete IPv6-related code

2019-02-27 Thread Tanushree Tumane via GitGitGadget
From: Tanushree Tumane To support IPv6, Git provided fall back functions for Windows versions that did not support IPv6. However, as Git dropped support for Windows XP and prior, those functions are not needed anymore. Remove those fallbacks by reverting fe3b2b7b827c (Enable support for IPv6 on

[PATCH 0/1] Drop Windows XP-specific code to support IPv6

2019-02-27 Thread Johannes Schindelin via GitGitGadget
We no longer support Windows XP, and can therefore rely on API functions that are available since Windows Vista. Tanushree Tumane (1): mingw: remove obsolete IPv6-related code compat/mingw.c | 178 + compat/mingw.h | 8 --- 2 files changed, 3 i