Dear Mr Carlson,
Yes, you are right. Thanks for the support.
Freundliche Grüße / Kind regards
i.A. Federico Celestino
Entwicklungsingenieur
Fon +49 2151 7830 324
Fax +49 2151 7830 499
www.xcmg-erc.com
celest...@xcmg-erc.com
--
Hi Rohit,
On Sun, Feb 24, 2019 at 11:08 AM Rohit Ashiwal
wrote:
> If you disregard that contribution, here is my approach to solving
> this microproject: search for `test -f` in `t/**` and replace all
> occurrences with `test_path_is_file` and similarly for other mentioned
> commands. Is it corr
Jeff King writes:
> On Fri, Feb 08, 2019 at 12:18:57PM +1030, Rusty Russell wrote:
>
>> This broke my "is this clean?" sanity check and very much violates
>> the man page description.
>
> Wow, this one had me scratching my head for a minute. What you're
> describing here:
>
>> $ git status
Hi, Christian and Ævar
First of all, thanks for the fast and attentive reviews.
I am a little confused about what I should do next. How should I
proceed with this series?
By what was said, I understood that the series:
1) Is indeed an improvement under --local, because it won't deference
symlink
Team,
the corresponding Git for Windows v2.21.0 will probably be published on
Tuesday, as we are waiting for a Git LFS version that fixes a known
regression that is considered critical.
In the meantime, feel free to grab the current snapshot (which differs
from the final v2.21.0 probably only in
I think this is actually legitimate a build error (see e.g.
https://dev.azure.com/gitgitgadget/git/_build/results?buildId=2394), and I
am quite surprised that GCC accepts this.
Note: after thinking about this for a while, I guess an empty string would
work, too (i.e. "" instead of " 0"), but I al
From: Johannes Schindelin
This fixes an issue pointed out by clang.
Signed-off-by: Johannes Schindelin
---
upload-pack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/upload-pack.c b/upload-pack.c
index 2365b707bc..534e8951a2 100644
--- a/upload-pack.c
+++ b/upload-pack.c
On 02/24, Matheus Tavares Bernardino wrote:
> I am part of a FLOSS group here at USP called FLUSP
> (https://flusp.ime.usp.br/), and I plan to write some posts on our
> website about what I am learning in the git community so that other
> people in the group can have as a base if they decide to sta
On 02/24, Matheus Tavares Bernardino wrote:
> On Sun, Feb 24, 2019 at 5:35 AM Christian Couder
> wrote:
> > On Sat, Feb 23, 2019 at 10:37 PM Thomas Gummerer
> > wrote:
> > > > int dir_iterator_advance(struct dir_iterator *dir_iterator)
> > > > @@ -71,6 +78,8 @@ int dir_iterator_advance(struct d
On Sat, Feb 23, 2019 at 6:48 PM Thomas Gummerer wrote:
>
> On 02/23, Matheus Tavares wrote:
> > ---
> > Changes in v2:
> > - Improved patch message
> > - Removed a now unused variable
>
> s/variable/parameter/ I believe?
Yes, you are right!
> > + while ((iter_status = dir_iterator_advance(
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'. The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.
Git 2.21 has been tagged and pushe
The latest feature release Git v2.21.0 is now available at the
usual places. It is comprised of 500 non-merge commits since
v2.20.0, contributed by 74 people, 20 of which are new faces.
The tarballs are found at:
https://www.kernel.org/pub/software/scm/git/
The following public repositories
On Sun, Feb 24, 2019 at 5:35 AM Christian Couder
wrote:
>
> On Sat, Feb 23, 2019 at 10:37 PM Thomas Gummerer wrote:
> >
> > On 02/23, Matheus Tavares wrote:
> > > Add the pedantic option to dir-iterator's initialization function,
> > > dir_iterator_begin. When this option is set to true,
> > > di
On Sat, Feb 23, 2019 at 6:59 PM Thomas Gummerer wrote:
>
> On 02/23, Matheus Tavares wrote:
> > Add pedantic option to dir_iterator_begin at dir-iterator.c and convert
> > explicit recursive directory traversal at copy_or_link_directory
> > (builtin/clone.c) to the dir-iterator API.
>
> Thanks for
Jonathan Tan writes:
> diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh
> index db4ae09f2f..6dbe2e9584 100755
> --- a/t/t5702-protocol-v2.sh
> +++ b/t/t5702-protocol-v2.sh
> @@ -656,6 +656,60 @@ test_expect_success 'when server does not send "ready",
> expect FLUSH' '
> test_i1
Jeff King writes:
>> Here's an attempt at that. I did drop a few comments that seemed
>> pointless to me, as they're just re-stating the lines they describe.
>
> It looks like the original got merged to next. I think we at least need
> to deal with the "Otherwise..." comment, but I think the lay
Jiang Xin writes:
> Hi Junio,
>
> Please pull the following l10n updates for Git 2.21. These updates come
> from nine l10n teams (Bulgarian, Catalan, German, Greek, Spanish, French,
> Italian, Swedish and Simplified Chinese). Jimmy contributed the essential
> translation for Greek and formed a
Hi Rohit,
On Sun, 24 Feb 2019, Rohit Ashiwal wrote:
> Hello
Hi there!
> I am Rohit Ashiwal, a computer science and engineering student from
> IIT Roorkee. I am a git user for 2 years now and want to contribute
> towards its development.
Great!
> I have read the microproject list available [he
On Sun, Feb 24 2019, Christian Couder wrote:
> On Sat, Feb 23, 2019 at 11:48 PM Ævar Arnfjörð Bjarmason
> wrote:
>>
>>
>> On Sat, Feb 23 2019, Matheus Tavares wrote:
>>
>> > Replace usage of opendir/readdir/closedir API to traverse directories
>> > recursively, at copy_or_link_directory functio
Hi Junio,
On Sat, 23 Feb 2019, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget"
> writes:
>
> > From: Johannes Schindelin
> >
> > During the six months of development of the Azure Pipelines support, the
> > patches went through quite a few iterations of changes, and to test
> > t
Hi,
On Sat, 23 Feb 2019, Junio C Hamano wrote:
> "Robert P. J. Day" writes:
>
> > On Sat, 23 Feb 2019, Johannes Schindelin wrote:
> >
> >> Robert, care to come up with an example demonstrating where it does not?
> >
> > sorry i wasn't clear, all i was pointing out was that "man
> > git-clean"
From: Pranit Bauva
Reimplement the `bisect_autostart()` shell function in C and add the
C implementation from `bisect_next()` which was previously left
uncovered. Also add a subcommand `--bisect-autostart` to
`git bisect--helper` be called from `bisect_state()` from
git-bisect.sh .
Using `--bise
From: Pranit Bauva
The `bisect-clean-state` subcommand is no longer used in the shell
script while the C code uses `bisect_clean_state()` thus remove the
subcommand.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
Signed-off-by: Tanushree Tumane
---
bui
From: Pranit Bauva
Reimplement the `bisect_replay` shell function in C and also add
`--bisect-replay` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--bisect-replay` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As mo
From: Pranit Bauva
The `--write-terms` subcommand is no longer used in the shell script and
the function `write_terms()` is called from the C implementation of
`set_terms()` and `bisect_start()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed
From: Pranit Bauva
Dequoting the arguments was introduced in 25b48b5c to port the function
`bisect_next()` but after the `bisect_replay()` porting, the dequoting
is carried out itself when it passes the arguments to `bisect_start()`
in a simpler way thus dequoting again isn't required. So remove
From: Tanushree Tumane
introduce `decide_next()` helper function from `bisect_next_check()`
for better and clear understanding.
convert `*...warning` char pointers to `...warning[]`char arrays, as
char [] only creates char array while char * creates both char array
and a pointer to that char arr
From: Pranit Bauva
Reimplement the `bisect_skip()` shell function in C and also add
`bisect-skip` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--bisect-skip` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As more fun
From: Pranit Bauva
The `--check-and-set-terms` subcommand is no longer used in the shell
script and the function `check_and_set_terms()` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-off-by: Pranit Bauva
From: Pranit Bauva
Reimplement the `bisect_state()` shell function in C and also add a
subcommand `--bisect-state` to `git-bisect--helper` to call it from
git-bisect.sh .
Using `--bisect-state` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As
From: Pranit Bauva
The `--next-all` subcommand is no longer used in the shell script and
the function `bisect_next_all()` is called from the C implementation of
`bisect_next()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
Signed-off-by: Tanushree Tuma
From: Pranit Bauva
The `--bisect-autostart` subcommand is no longer used in the shell
script and the function `bisect_autostart()` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-off-by: Pranit Bauva
Signe
From: Pranit Bauva
The `--bisect-auto-next` subcommand is no longer used in the shell
script and the function `bisect_auto_next()` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-off-by: Pranit Bauva
Signe
From: Pranit Bauva
Reimplement the `bisect_log()` shell function in C and also add
`--bisect-log` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
Using `--bisect-log` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As more fu
From: Pranit Bauva
The `--check-expected-revs` subcommand is no longer used in the shell
script and the function `check_expected_revs()` is called from the C
implementation of `bisect_next()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-of
From: Pranit Bauva
The `--bisect-write` subcommand is no longer used in the shell script
and the function `bisect_write()` is called from the C implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-off-by: Pranit Bauva
Signed-off-by
From: Tanushree Tumane
Conversion of variable `retval` to `res` to have a
uniformity of a single variable all over the patch series,
which makes the patch series unvaried.
Mentored-by: Christian Couder
Signed-off-by: Tanushree Tumane
---
builtin/bisect--helper.c | 50 -
Changes since pranit’s v15 patch series
===
bisect--helper: refer branch.buf before strbuf_release(...)
===
bisect--helper: change retval to res
bisect--helper: decide
From: Pranit Bauva
Reimplement the `bisect_next()` and the `bisect_auto_next()` shell function
in C and add the subcommands to `git bisect--helper` to call it from
git-bisect.sh .
Using `--bisect-next` and `--bisect-auto-start` subcommands is a
temporary measure to port shell function to C so as
From: Pranit Bauva
As more and more calls are happening to the subcommands in `git
bisect--helper`, more specifically when `bisect_start $rev` is converted to
`git bisect--helper --bisect-start $rev` it is necessary to dequote the
arguments because of shell to C conversion.
Mentored-by: Christia
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit()`
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit()`
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit()`
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit()`
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit()`
From: Pranit Bauva
With the conversion of `bisect_auto_next()` in previous commit,
`bisect_start()` has been successfully ported to C.
Add the subcommands to `git bisect--helper` and call it from
git-bisect.sh.
Remove `bisect_start()` shell method and call `git bisect--helper
--bisect-start` s
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Modify `cmd_bis
From: Tanushree Tumane
move `error("...%s...", branch.buf);` before `strbuf_release(&branch);`.
add ' ' before "reset.." in error message.
Mentored-by: Johannes Schindelin
Mentored-by: Christian Couder
Signed-off-by: Tanushree Tumane
---
builtin/bisect--helper.c | 7 ---
1 file changed,
On Fri, Feb 22, 2019 at 05:49:57PM +0100, Ævar Arnfjörð Bjarmason wrote:
> Yes. I didn't dig far enough into this and will re-word & re-submit,
> also with the feedback you had on 1/2.
>
> So here's my current understanding of this.
>
> It's b6266dc88b ("rebase--am: use --cherry-pick instead of
Hello
I am Rohit Ashiwal, a computer science and engineering student from
IIT Roorkee. I am a git user for 2 years now and want to contribute
towards its development.
I have read the microproject list available [here](1) and project
titled `Use test_path_is_* functions in test scripts` caught my e
On Sat, Feb 16, 2019 at 01:57:56AM -0500, Jeff King wrote:
> On Thu, Feb 14, 2019 at 11:47:02AM -0800, Junio C Hamano wrote:
>
> > > + if (no_index)
> > > + /* If this is a no-index diff, just run it and exit there. */
> > > + diff_no_index(&rev, argc, argv);
> > > +
> > > if (n
On Sat, Feb 23, 2019 at 11:48 PM Ævar Arnfjörð Bjarmason
wrote:
>
>
> On Sat, Feb 23 2019, Matheus Tavares wrote:
>
> > Replace usage of opendir/readdir/closedir API to traverse directories
> > recursively, at copy_or_link_directory function, by the dir-iterator
> > API. This simplifies the code a
On Sat, Feb 23, 2019 at 8:06 PM Matheus Tavares
wrote:
>
> Extract dir creation code snippet from copy_or_link_directory to its own
> function named mkdir_if_missing. This change will help removing
> copy_or_link_directory's explicit recursion, which will be done in a
> following patch. Also makes
On Sat, Feb 23, 2019 at 10:37 PM Thomas Gummerer wrote:
>
> On 02/23, Matheus Tavares wrote:
> > Add the pedantic option to dir-iterator's initialization function,
> > dir_iterator_begin. When this option is set to true,
> > dir_iterator_advance will immediately return ITER_ERROR when failing to
>
54 matches
Mail list logo
