[GIT PULL] l10n updates for 2.21 round 2

2019-02-23 Thread Jiang Xin
Hi Junio, Please pull the following l10n updates for Git 2.21. These updates come from nine l10n teams (Bulgarian, Catalan, German, Greek, Spanish, French, Italian, Swedish and Simplified Chinese). Jimmy contributed the essential translation for Greek and formed a new l10n team. Alessandro made

Re: does "git clean" deliberately ignore "core.excludesFile"?

2019-02-23 Thread Junio C Hamano
"Robert P. J. Day" writes: > On Sat, 23 Feb 2019, Johannes Schindelin wrote: > >> Robert, care to come up with an example demonstrating where it does not? > > sorry i wasn't clear, all i was pointing out was that "man > git-clean" *explicitly* mentioned two locations related to cleaning: > ...

Re: [PATCH 1/1] README: adjust for final Azure Pipeline ID

2019-02-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > During the six months of development of the Azure Pipelines support, the > patches went through quite a few iterations of changes, and to test > those iterations, a temporary build definition was used. > > In the mean

Re: [PATCH] Fix the quotation mark in the explanation of "git checkout -".

2019-02-23 Thread Junio C Hamano
Yoichi Nakayama writes: > Subject: Re: [PATCH] Fix the quotation mark in the explanation of "git > checkout -". I'd retitle it to something like Subject: [PATCH] checkout doc: fix an unmatched double-quote pair > Signed-off-by: Yoichi Nakayama > --- > Documentation/git-checkout.txt | 2

[WIP 6/7] upload-pack: refactor reading of pack-objects out

2019-02-23 Thread Jonathan Tan
Subsequent patches will change how the output of pack-objects is processed, so extract that processing into its own function. Currently, at most 1 character can be buffered (in the "buffered" local variable). One of those patches will require a larger buffer, so replace that "buffered" local varia

[WIP 5/7] Documentation: add Packfile URIs design doc

2019-02-23 Thread Jonathan Tan
Signed-off-by: Jonathan Tan --- Documentation/technical/packfile-uri.txt | 79 Documentation/technical/protocol-v2.txt | 6 +- 2 files changed, 84 insertions(+), 1 deletion(-) create mode 100644 Documentation/technical/packfile-uri.txt diff --git a/Documentation/techn

[WIP 4/7] Documentation: order protocol v2 sections

2019-02-23 Thread Jonathan Tan
The current C Git implementation expects Git servers to follow a specific order of sections when transmitting protocol v2 responses, but this is not explicit in the documentation. Make the order explicit. Signed-off-by: Jonathan Tan --- Documentation/technical/protocol-v2.txt | 18 --

[WIP 7/7] upload-pack: send part of packfile response as uri

2019-02-23 Thread Jonathan Tan
Teach upload-pack to send part of its packfile response as URIs. An administrator may configure a repository with one or more "uploadpack.blobpackfileuri" lines, each line containing an OID and a URI. A client may configure fetch.uriprotocols to be a comma-separated list of protocols that it is wi

[WIP 0/7] CDN offloading of fetch response

2019-02-23 Thread Jonathan Tan
It's been a while, so here is an updated version of what I previously sent [1]. The main difference is that fetch-pack now actually downloads whatever the server tells it to. The second main difference is that we no longer buffer progress messages and suspend keepalives - we no longer need to, beca

[WIP 3/7] http-fetch: support fetching packfiles by URL

2019-02-23 Thread Jonathan Tan
Teach http-fetch the ability to download packfiles directly, given a URL, and to verify them. The http_pack_request suite of functions have been modified to support a NULL target. When target is NULL, the given URL is downloaded directly instead of being treated as the root of a repository. Signe

[WIP 2/7] http: improve documentation of http_pack_request

2019-02-23 Thread Jonathan Tan
struct http_pack_request and the functions that use it will be modified in a subsequent patch. Using it is complicated (to use, call the initialization function, then set some but not all fields in the returned struct), so add some documentation to help future users. Signed-off-by: Jonathan Tan -

[WIP 1/7] http: use --stdin and --keep when downloading pack

2019-02-23 Thread Jonathan Tan
When Git fetches a pack using dumb HTTP, it does at least 2 things differently from when it fetches using fetch-pack or receive-pack: (1) it reuses the server's name for the packfile (which incorporates a hash) for the packfile, and (2) it does not create a .keep file to avoid race conditions with

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-23 Thread Ævar Arnfjörð Bjarmason
On Sat, Feb 23 2019, Matheus Tavares wrote: > Replace usage of opendir/readdir/closedir API to traverse directories > recursively, at copy_or_link_directory function, by the dir-iterator > API. This simplifies the code and avoid recursive calls to > copy_or_link_directory. Sounds good in princi

Re: [GSoC][PATCH 0/3] clone: convert explicit dir traversal to dir-iterator

2019-02-23 Thread Thomas Gummerer
On 02/23, Matheus Tavares wrote: > Add pedantic option to dir_iterator_begin at dir-iterator.c and convert > explicit recursive directory traversal at copy_or_link_directory > (builtin/clone.c) to the dir-iterator API. Thanks for another iteration of this. To make life easier for reviewers, pleas

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-23 Thread Thomas Gummerer
On 02/23, Matheus Tavares wrote: > Replace usage of opendir/readdir/closedir API to traverse directories > recursively, at copy_or_link_directory function, by the dir-iterator > API. This simplifies the code and avoid recursive calls to > copy_or_link_directory. > > This process also brings some s

Re: [GSoC][PATCH 1/3] dir-iterator: add pedantic option to dir_iterator_begin

2019-02-23 Thread Thomas Gummerer
On 02/23, Matheus Tavares wrote: > Add the pedantic option to dir-iterator's initialization function, > dir_iterator_begin. When this option is set to true, > dir_iterator_advance will immediately return ITER_ERROR when failing to > fetch the next entry. When set to false, dir_iterator_advance will

Re: [GSoC][PATCH 0/3] clone: convert explicit dir traversal to dir-iterator

2019-02-23 Thread Ævar Arnfjörð Bjarmason
On Sat, Feb 23 2019, Matheus Tavares Bernardino wrote: > On Sat, Feb 23, 2019 at 4:03 PM Matheus Tavares > wrote: >> >> Add pedantic option to dir_iterator_begin at dir-iterator.c and convert >> explicit recursive directory traversal at copy_or_link_directory >> (builtin/clone.c) to the dir-ite

Re: [GSoC][PATCH 0/3] clone: convert explicit dir traversal to dir-iterator

2019-02-23 Thread Matheus Tavares Bernardino
On Sat, Feb 23, 2019 at 4:03 PM Matheus Tavares wrote: > > Add pedantic option to dir_iterator_begin at dir-iterator.c and convert > explicit recursive directory traversal at copy_or_link_directory > (builtin/clone.c) to the dir-iterator API. > > This is my microproject for GSoC 2019. Idea taken f

[GSoC][PATCH 0/3] clone: convert explicit dir traversal to dir-iterator

2019-02-23 Thread Matheus Tavares
Add pedantic option to dir_iterator_begin at dir-iterator.c and convert explicit recursive directory traversal at copy_or_link_directory (builtin/clone.c) to the dir-iterator API. This is my microproject for GSoC 2019. Idea taken from https://git.github.io/SoC-2019-Microprojects/#use-dir-iterator-

[GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-23 Thread Matheus Tavares
Replace usage of opendir/readdir/closedir API to traverse directories recursively, at copy_or_link_directory function, by the dir-iterator API. This simplifies the code and avoid recursive calls to copy_or_link_directory. This process also brings some safe behaviour changes to copy_or_link_directo

[GSoC][PATCH 1/3] dir-iterator: add pedantic option to dir_iterator_begin

2019-02-23 Thread Matheus Tavares
Add the pedantic option to dir-iterator's initialization function, dir_iterator_begin. When this option is set to true, dir_iterator_advance will immediately return ITER_ERROR when failing to fetch the next entry. When set to false, dir_iterator_advance will emit a warning and keep looking for the

[GSoC][PATCH 2/3] clone: extract function from copy_or_link_directory

2019-02-23 Thread Matheus Tavares
Extract dir creation code snippet from copy_or_link_directory to its own function named mkdir_if_missing. This change will help removing copy_or_link_directory's explicit recursion, which will be done in a following patch. Also makes code more readable. Signed-off-by: Matheus Tavares --- Changes

Re: does "git clean" deliberately ignore "core.excludesFile"?

2019-02-23 Thread Robert P. J. Day
On Sat, 23 Feb 2019, Johannes Schindelin wrote: > Hi, > > On Sat, 23 Feb 2019, Johannes Schindelin wrote: > > > On Sat, 23 Feb 2019, Junio C Hamano wrote: > > > > > "Robert P. J. Day" writes: > > > > > > > am i misreading something? and if not, is there a reason git clean > > > > does not consu

Re: does "git clean" deliberately ignore "core.excludesFile"?

2019-02-23 Thread Johannes Schindelin
Hi, On Sat, 23 Feb 2019, Johannes Schindelin wrote: > On Sat, 23 Feb 2019, Junio C Hamano wrote: > > > "Robert P. J. Day" writes: > > > > > am i misreading something? and if not, is there a reason git clean > > > does not consult core.excludesFile? > > > > Can you ask "git log" and "git bla

Re: does "git clean" deliberately ignore "core.excludesFile"?

2019-02-23 Thread Johannes Schindelin
Hi, On Sat, 23 Feb 2019, Junio C Hamano wrote: > "Robert P. J. Day" writes: > > > am i misreading something? and if not, is there a reason git clean > > does not consult core.excludesFile? > > Can you ask "git log" and "git blame" whch of core.excludesFile and > "clean -x" features came ear

Re: on fedora, "man gitweb" exists but actual gitweb command is missing

2019-02-23 Thread Robert P. J. Day
On Sat, 23 Feb 2019, Todd Zullinger wrote: > Hi, > > Robert P. J. Day wrote: > > > > not so much a git issue as what looks like a fedora packaging > > issue. > > Yeah, it's just a minor packaging issue. The gitweb manpages are > included in the main git package rather than in the gitweb packa

Re: on fedora, "man gitweb" exists but actual gitweb command is missing

2019-02-23 Thread Todd Zullinger
Hi, Robert P. J. Day wrote: > > not so much a git issue as what looks like a fedora packaging issue. Yeah, it's just a minor packaging issue. The gitweb manpages are included in the main git package rather than in the gitweb package with the rest of the gitweb files. I'll fix that for future

[no subject]

2019-02-23 Thread Чарльз
-- Forwarded message -- From: Чарльз Date: Sat, 23 Feb 2019 17:49:05 +0100 Subject: To: ANDERSON LETTER.pdf Description: Adobe PDF document

Re: does "git clean" deliberately ignore "core.excludesFile"?

2019-02-23 Thread Junio C Hamano
"Robert P. J. Day" writes: > am i misreading something? and if not, is there a reason git clean > does not consult core.excludesFile? Can you ask "git log" and "git blame" whch of core.excludesFile and "clean -x" features came earlier and by how big a difference? Most likely this is because

does "git clean" deliberately ignore "core.excludesFile"?

2019-02-23 Thread Robert P. J. Day
not sure why i never noticed this before, but the "-x" option for "git clean" reads: -x Don’t use the standard ignore rules read from .gitignore (per directory) and $GIT_DIR/info/exclude, but do still use the ignore rules given with -e options. This allows removing all untr

[PATCH 1/1] README: adjust for final Azure Pipeline ID

2019-02-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin During the six months of development of the Azure Pipelines support, the patches went through quite a few iterations of changes, and to test those iterations, a temporary build definition was used. In the meantime, Azure Pipelines support made it to `master`, and we now

[PATCH 0/1] Adjust the Azure Pipeline badge in our README

2019-02-23 Thread Johannes Schindelin via GitGitGadget
We now have an official Azure Pipeline (not the temporary, for-testing one I used during development), thanks to Peff! Let's link to it, too. Johannes Schindelin (1): README: adjust for final Azure Pipeline ID README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: c65a2

Re: [PATCH 3/3] bisect: make diff-tree output prettier

2019-02-23 Thread Jeff King
On Fri, Feb 22, 2019 at 09:49:44AM -0800, Junio C Hamano wrote: > > Even though bisect might be driven by scripts, there's no reason to > > consider this part of the output as machine-readable (if anything, the > > initial "$hash is the first bad commit" might be parsed, but we won't > > touch tha

Re: [PATCH 3/3] format-patch: --no-clobber refrains from overwriting output files

2019-02-23 Thread Jeff King
On Fri, Feb 22, 2019 at 12:11:11PM -0800, Junio C Hamano wrote: > If you keep an output for an older iteration of the same topic in > the same directory around and use "git format-patch" to prepare a > newer iteration of the topic, those commits that happen to be at the > same position in the seri

Re: Students projects: looking for small and medium project ideas

2019-02-23 Thread Fabio Aiuto
Il giorno lun, 14/01/2019 alle 18.53 +0100, Matthieu Moy ha scritto: > Hi, > > I haven't been active for a while on this list, but for those who > don't > know me, I'm a CS teacher and I'm regularly offering my students to > contribute to open-source projects as part of their school projects. > A

Re: [PATCH 2/8] tests: always test fetch of unreachable with v0

2019-02-23 Thread Jeff King
On Fri, Feb 22, 2019 at 12:47:42PM -0800, Junio C Hamano wrote: > >> We can do so now either by "blaming" one and finding the originating > >> commit, or by searching for "support fetching unadvertised objects" (I > >> used the same comment everywhere in the commit [1] so that people can do > >> t

Re: [PATCH v2 2/6] Makefile: move "strip" assignment down from flags

2019-02-23 Thread Jeff King
On Fri, Feb 22, 2019 at 09:58:14PM +, Ramsay Jones wrote: > > This might annoy somebody expecting $STRIP in the environment to have > > precedence. But I agree that consistency is probably our best strategy > > here, and I don't see any reason the same argument would not apply to > > $SPATCH,

Re: [PATCH v2 0/6] Makefile: allow for combining DEVELOPER= and CFLAGS="..."

2019-02-23 Thread Jeff King
On Fri, Feb 22, 2019 at 10:59:20PM +0100, Ævar Arnfjörð Bjarmason wrote: > > My personal complaint is that you cannot override DEVELOPER flags via > > config.mak, because of the ordering. But it looks like your patch 6 > > specifically addresses that (yay!). > > Do you mean DEVOPTS? That works fo

on fedora, "man gitweb" exists but actual gitweb command is missing

2019-02-23 Thread Robert P. J. Day
not so much a git issue as what looks like a fedora packaging issue. on my updated fedora 29 system, "man gitweb" works: GITWEB(1)Git ManualGITWEB(1) NAME gitweb - Git web interface (web frontend to Git repositories) SYNOPSIS To get

Re: Looking for my fisrt task

2019-02-23 Thread Fabio Aiuto
Maybe I need more things to know. First of all, if there is a maintainer I could keep in touch with to have some fix to work. Il giorno sab, 23/02/2019 alle 12.46 +0100, Ævar Arnfjörð Bjarmason ha scritto: > On Sat, Feb 23 2019, Fabio Aiuto wrote: > > > Hello, > > > > I'm looking for my first ta

Re: Looking for my fisrt task

2019-02-23 Thread Ævar Arnfjörð Bjarmason
On Sat, Feb 23 2019, Fabio Aiuto wrote: > Hello, > > I'm looking for my first task as a participant, something simple to get > used to submitting patches and all other facilities needed for > community development. > Thank you in advance. This recent thread has a bunch of good pointers: https:/

Re: git format-patch can clobber existing patch

2019-02-23 Thread Σταύρος Ντέντος
Ντέντος Σταύρος On Fri, Feb 22, 2019 at 9:38 PM Junio C Hamano wrote: > > "brian m. carlson" writes: > > > On Thu, Feb 21, 2019 at 03:40:09PM -0800, Junio C Hamano wrote: > >> Σταύρος Ντέντος writes: > >> > Would it make sense / be easy enough to have some clobbering check / > >> > flag? > >>

Looking for my fisrt task

2019-02-23 Thread Fabio Aiuto
Hello, I'm looking for my first task as a participant, something simple to get used to submitting patches and all other facilities needed for community development. Thank you in advance. Fabio.

Re: Am a newby and I cannot compile git

2019-02-23 Thread Fabio Aiuto
Hello Santiago, how could I get a first task? A simple one please, I'd like being introduced to git developing as a participant in order to get used to submitting patches, and all the tools I need. Thank you in advance. Fabio. Il giorno ven, 15/02/2019 alle 20.13 +0100, Fabio Aiuto ha scritto: > T

Re: Am a newby and I cannot compile git

2019-02-23 Thread Fabio Aiuto
Hello Santiago, how could I get a first task? A simple one please, I'd like being introduced to git developing as a participant in order to get used to submitting patches, and all the tools I need. Thank you in advance. Fabio. Il giorno dom, 10/02/2019 alle 17.48 -0500, Santiago Torres ha scritto:

Re: [PATCH 7/8] commit-graph write: don't die if the existing graph is corrupt

2019-02-23 Thread Eric Sunshine
On Fri, Feb 22, 2019 at 6:13 PM Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > > @@ -408,7 +414,7 @@ test_expect_success 'detect permission problem' ' > > # "chmod 000 file" does not yield EACCES on e.g. "cat fil