Re: There should be a `.gitbless; file, protecting files from git clean

2019-01-27 Thread Sebastian Gniazdowski
I like the idea of the backup-log, I hope it gets commited! On 28 stycznia 2019 at 06:05:31, Duy Nguyen (pclo...@gmail.com) wrote: > > There's a patch that adds "precious" git attribute [1]. I was going to > resend once the backup-log [2] got reviewed but I might just send it > separately to hand

Re: There should be a `.gitbless; file, protecting files from git clean

2019-01-27 Thread Sebastian Gniazdowski
On 28 stycznia 2019 at 06:05:31, Duy Nguyen (pclo...@gmail.com) wrote: > On Mon, Jan 28, 2019 at 9:54 AM Sebastian Gniazdowski > wrote: > > > > Hello, > > Could a .gitbless file be a solution? I would list in it, e.g.: > > > > TODO > > > > and this way be able to use `git -dxf' again. What do you t

Re: There should be a `.gitbless; file, protecting files from git clean

2019-01-27 Thread Duy Nguyen
On Mon, Jan 28, 2019 at 9:54 AM Sebastian Gniazdowski wrote: > > Hello, > Keepiing repo clean with `git clean -dxf' is a very pleasant experience. > However, ability to use it ends when one gets untracked but *wanted* files in > the repo, like an untracked TODO. > > Could a .gitbless file be a s

There should be a `.gitbless; file, protecting files from git clean

2019-01-27 Thread Sebastian Gniazdowski
Hello, Keepiing repo clean with `git clean -dxf' is a very pleasant experience. However, ability to use it ends when one gets untracked but *wanted* files in the repo, like an untracked TODO. Could a .gitbless file be a solution? I would list in it, e.g.: TODO and this way be able to use `git

Re: [PATCH v2] git-submodule.sh: shorten submodule SHA-1s using rev-parse

2019-01-27 Thread Junio C Hamano
Eric Sunshine writes: > This could be made a bit easier to follow by using indentation and || > rather than &&. For instance, rewriting the entire block as: > > # Shorten with hard-coded fallback if rev-parse fails > sha1_abbr_src=$(GIT_DIR="$name/.git" git rev-parse --short $sha1_src ||

Re: [PATCH v4 18/21] t0061: fix with --with-dashes and RUNTIME_PREFIX

2019-01-27 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > When building Git with RUNTIME_PREFIX and starting a test helper from > t/helper/, it fails to detect the system prefix correctly. > > This is the reason that the warning > > RUNTIME_PREFIX requested, but prefix

Re: [PATCH v3 4/8] evolve: Add support for parsing metacommits

2019-01-27 Thread Junio C Hamano
sxe...@google.com writes: > +/* > + * Search the commit buffer for a line starting with the given key. Unlike > + * find_commit_header, this also searches the commit message body. > + */ > +static const char *find_key(const char *msg, const char *key, size_t > *out_len) > +{ > + int key_len =

Re: [PATCH v3 2/8] sha1-array: Implement oid_array_readonly_contains

2019-01-27 Thread Junio C Hamano
sxe...@google.com writes: > Subject: Re: [PATCH v3 2/8] sha1-array: Implement oid_array_readonly_contains Style: s/: Implement/: implement/ > From: Stefan Xenos This line wants to say "Stefan Xenos " to match S-o-b below (I am assuming that you are following your employer's open source recomme

Re: [PATCH 00/14] nd/diff-parseopt part 1

2019-01-27 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This is the first part of converting diff_opt_parse() to use > parse_options(). Compared to the full series [1] I sent earlier, 03/76 > is dropped and 02/14 is updated to allow KEEP_UNKNOWN and > STOP_AT_NON_OPTION combination, but only for one shot mode. Looked r

Re: [PATCH] log,diff-tree: add --combined-with-paths options for merges with renames

2019-01-27 Thread Junio C Hamano
Elijah Newren writes: > ... Instead, I decided that > instead of having a "from" and a "to" header, we would have N "from" > headers (since all parents are what we came from) and 1 "to" header. > I hope that makes sense, because otherwise I think this become to > unwieldy of a change. Yeah, it m

Re: [PATCH v1] git-instaweb: Add Python builtin http.server support

2019-01-27 Thread Junio C Hamano
"brian m. carlson" writes: > On Fri, Jan 25, 2019 at 05:22:45PM +0200, Arti Zirk wrote: >> This is the built in http server that Python comes with (like Ruby >> users have builtin webrick server). While it is possible to install >> something else, I don't think many casual git-instaweb users woul

Re: [PATCH v2] git-submodule.sh: shorten submodule SHA-1s using rev-parse

2019-01-27 Thread Eric Sunshine
On Sun, Jan 27, 2019 at 2:28 PM Sven van Haastregt wrote: > Until now, `git submodule summary` was always emitting 7-character > SHA-1s that have a higher chance of being ambiguous for larger > repositories. Use `git rev-parse --short` instead, which will > determine suitable short SHA-1 lengths.

[PATCH v5 18/21] t0061: fix with --with-dashes and RUNTIME_PREFIX

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When building Git with RUNTIME_PREFIX and starting a test helper from t/helper/, it fails to detect the system prefix correctly. This is the reason that the warning RUNTIME_PREFIX requested, but prefix computation failed. [...] to be printed. In t0061, we did

[PATCH v5 16/21] mingw: try to work around issues with the test cleanup

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin It seems that every once in a while in the Git for Windows SDK, there are some transient file locking issues preventing the test clean up to delete the trash directory. Let's be gentle and try again five seconds later, and only error out if it still fails the second time

[PATCH v5 17/21] tests: add t/helper/ to the PATH with --with-dashes

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin We really need to be able to find the test helpers... Really. This change was forgotten when we moved the test helpers into t/helper/ Signed-off-by: Johannes Schindelin --- t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/test-lib.sh

[PATCH v5 08/21] ci/lib.sh: add support for Azure Pipelines

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This patch introduces a conditional arm that defines some environment variables and a function that displays the URL given the job id (to identify previous runs for known-good trees). Because Azure Pipeline's macOS agents already have git-lfs and gettext installed, we c

[PATCH v5 02/21] ci: rename the library of common functions

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The name is hard-coded to reflect that we use Travis CI for continuous testing. In the next commits, we will extend this to be able use Azure DevOps, too. So let's adjust the name to make it more generic. Signed-off-by: Johannes Schindelin --- ci/install-dependencie

[PATCH v5 10/21] ci: add a Windows job to the Azure Pipelines definition

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Previously, we did not have robust support for Windows in our CI definition, simply because Travis cannot accommodate our needs (even after Travis added experimental Windows support very recently, it takes longer than Travis' 50 minute timeout to build Git and run the te

[PATCH v5 06/21] test-date: add a subcommand to measure times in shell scripts

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin In the next commit, we want to teach Git's test suite to optionally output test results in JUnit-style .xml files. These files contain information about the time spent. So we need a way to measure time. While we could use `date +%s` for that, this will give us only seco

[PATCH v5 15/21] tests: include detailed trace logs with --write-junit-xml upon failure

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The JUnit XML format lends itself to be presented in a powerful UI, where you can drill down to the information you are interested in very quickly. For test failures, this usually means that you want to see the detailed trace of the failing tests. With Travis CI, we pa

[PATCH v5 01/21] travis: fix skipping tagged releases

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When building a PR, TRAVIS_BRANCH refers to the *target branch*. Therefore, if a PR targets `master`, and `master` happened to be tagged, we skipped the build by mistake. Fix this by using TRAVIS_PULL_REQUEST_BRANCH (i.e. the *source branch*) when available, falling bac

[PATCH v5 05/21] ci: use a junction on Windows instead of a symlink

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Symbolic links are still not quite as easy to use on Windows as on Linux (for example, on versions older than Windows 10, only administrators can create symlinks, and on Windows 10 you still need to be in developer mode for regular users to have permission), but NTFS jun

[PATCH v5 19/21] tests: optionally skip bin-wrappers/

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This speeds up the tests by a bit on Windows, where running Unix shell scripts (and spawning processes) is not exactly a cheap operation. Signed-off-by: Johannes Schindelin --- t/README | 9 + t/test-lib.sh | 19 +-- 2 files changed, 22 i

[PATCH v5 07/21] tests: optionally write results as JUnit-style .xml

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This will come in handy when publishing the results of Git's test suite during an automated Azure DevOps run. Note: we need to make extra sure that invalid UTF-8 encoding is turned into valid UTF-8 (using the Replacement Character, \uFFFD) because t9902's trace contains

[PATCH v5 13/21] README: add a build badge (status of the Azure Pipelines build)

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Just like so many other OSS projects, we now also have a build badge. Signed-off-by: Johannes Schindelin --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index f920a42fad..764c480c66 100644 --- a/README.md +++ b/README.md @@ -1

[PATCH v5 04/21] ci: inherit --jobs via MAKEFLAGS in run-build-and-tests

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Let's not decide in the generic ci/ part how many jobs to run in parallel; different CI configurations would favor a different number of parallel jobs, and it is easy enough to hand that information down via the `MAKEFLAGS` variable. Signed-off-by: Johannes Schindelin

[PATCH v5 20/21] ci: speed up Windows phase

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin As Unix shell scripting comes at a hefty price on Windows, we have to see where we can save some time to run the test suite. Let's skip the chain linting and the bin-wrappers/ redirection on Windows; this seems to shave of anywhere between 10-30% from the overall runtim

[PATCH v5 09/21] Add a build definition for Azure DevOps

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This commit adds an azure-pipelines.yml file which is Azure DevOps' equivalent to Travis CI's .travis.yml. The main idea is to replicate the Travis configuration as faithfully as possible, to make it easy to compare the Azure Pipeline builds to the Travis ones (spoiler:

[PATCH v5 00/21] Offer to run CI/PR builds in Azure Pipelines

2019-01-27 Thread Johannes Schindelin via GitGitGadget
For a long time already, we have tested Git's source code continuously via Travis CI, see e.g. https://travis-ci.org/git/git/builds/421738884. It has served us well, and more and more developers actually pay attention and benefit from the testing this gives us. It is also an invaluable tool for co

[PATCH v5 21/21] ci: parallelize testing on Windows

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The fact that Git's test suite is implemented in Unix shell script that is as portable as we can muster, combined with the fact that Unix shell scripting is foreign to Windows (and therefore has to be emulated), results in pretty abysmal speed of the test suite on that p

[PATCH v5 14/21] tests: avoid calling Perl just to determine file sizes

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin It is a bit ridiculous to spin up a full-blown Perl instance (especially on Windows, where that means spinning up a full POSIX emulation layer, AKA the MSYS2 runtime) just to tell how large a given file is. So let's just use the test-tool to do that job instead. This c

[PATCH v5 03/21] ci/lib.sh: encapsulate Travis-specific things

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The upcoming patches will allow building git.git via Azure Pipelines (i.e. Azure DevOps' Continuous Integration), where variable names and URLs look a bit different than in Travis CI. Also, the configurations of the available agents are different. For example, Travis' a

[PATCH v5 12/21] mingw: be more generous when wrapping up the setitimer() emulation

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Every once in a while, the Azure Pipeline fails with some semi-random error: timer thread did not terminate timely This error message means that the thread that is used to emulate the setitimer() function did not terminate within 1,000 milliseconds. The most l

[PATCH v5 11/21] ci: use git-sdk-64-minimal build artifact

2019-01-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Instead of a shallow fetch followed by a sparse checkout, we are better off by using a separate, dedicated Pipeline that bundles the SDK as a build artifact, and then consuming that build artifact here. In fact, since this artifact will be used a lot, we spent substanti

Re: [PATCH v4 03/21] ci/lib.sh: encapsulate Travis-specific things

2019-01-27 Thread Junio C Hamano
Johannes Schindelin writes: > No, not really. Actually, not at all. > >> It would be, under this new arrangement of the code, most natural for >> Those who want to use gnu-time to arrange it to be somehow added to >> $BREW_INSTALL_PACKAGES, no? > > The purpose of BREW_INSTALL_PACKAGES is to list

Re: [PATCH v4 06/21] test-date: add a subcommand to measure times in shell scripts

2019-01-27 Thread Junio C Hamano
Junio C Hamano writes: > I think the goal to have our own stopwatch so that we do not have to > worry about differences among system-provided ones makes sense. > > The only thing that may become an issue is how widely available > getnanotime() is. As "test-date" itself is built on any platform a

Re: [PATCH v4 08/10] midx: implement midx_repack()

2019-01-27 Thread Junio C Hamano
Derrick Stolee writes: > On 1/24/2019 4:52 PM, Derrick Stolee via GitGitGadget wrote: >> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh >> index acc5e65ecc..d6c1353514 100755 >> --- a/t/t5319-multi-pack-index.sh >> +++ b/t/t5319-multi-pack-index.sh >> @@ -383,7 +383,8 @@ t

Re: [PATCH/RFC v2 1/1] test-lint: Only use only sed [-n] [-e command] [-f command_file]

2019-01-27 Thread Junio C Hamano
Torsten Bögershausen writes: >> Thanks, both. Eric's proposed message looks good to me too. > > Do you want to ammend the patch locally ? I just amended it; thanks.

Re: [PATCH v4 03/21] ci/lib.sh: encapsulate Travis-specific things

2019-01-27 Thread Johannes Schindelin
Hi Gábor, On Fri, 25 Jan 2019, SZEDER Gábor wrote: > On Wed, Jan 23, 2019 at 06:40:16AM -0800, Johannes Schindelin via > GitGitGadget wrote: > > From: Johannes Schindelin > > > > The upcoming patches will allow building git.git via Azure Pipelines > > (i.e. Azure DevOps' Continuous Integration)

[PATCH v3 6/8] evolve: Add support for writing metacommits

2019-01-27 Thread sxenos
From: Stefan Xenos metacommit.c supports the creation of metacommits and adds the API needed to create and update changes. Create the "modify_change" function that can be called from modification commands like "rebase" and "git amend" to record obsolescences in the change graph. Create the "rec

[PATCH v3 5/8] evolve: Add the change-table structure

2019-01-27 Thread sxenos
From: Stefan Xenos A change table stores a list of changes, and supports efficient lookup from a commit hash to the list of changes that reference that commit directly. It can be used to look up content commits or metacommits at the head of a change, but does not support lookup of commits refere

[PATCH v3 8/8] evolve: Add the git change list command

2019-01-27 Thread sxenos
From: Stefan Xenos This command lists the ongoing changes from the refs/metas namespace. Signed-off-by: Stefan Xenos --- builtin/change.c | 53 1 file changed, 53 insertions(+) diff --git a/builtin/change.c b/builtin/change.c index ff7eb3b113..

[PATCH v3 7/8] evolve: Implement the git change command

2019-01-27 Thread sxenos
From: Stefan Xenos Implement the git change update command, which are sufficient for constructing change graphs. For example, to create a new change (a stable name) that refers to HEAD: git change update -c HEAD To record a rebase or amend in the change graph: git change update -c -r To re

[PATCH v3 2/8] sha1-array: Implement oid_array_readonly_contains

2019-01-27 Thread sxenos
From: Stefan Xenos Implement a "readonly_contains" function for oid_array that won't sort the array if it is unsorted. This can be used to test containment in the rare situations where the array order matters. The function has intentionally been given a name that is more cumbersome than the "loo

[PATCH v3 3/8] ref-filter: Add the metas namespace to ref-filter

2019-01-27 Thread sxenos
From: Stefan Xenos The metas namespace will contain refs for changes in progress. Add support for searching this namespace. Signed-off-by: Stefan Xenos --- ref-filter.c | 8 ++-- ref-filter.h | 5 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ref-filter.c b/ref-filte

[PATCH v3 1/8] technical doc: add a design doc for the evolve command

2019-01-27 Thread sxenos
From: Stefan Xenos This document describes what a change graph for git would look like, the behavior of the evolve command, and the changes planned for other commands. Signed-off-by: Stefan Xenos --- Documentation/technical/evolve.txt | 1034 1 file changed, 1034 i

[PATCH v3 4/8] evolve: Add support for parsing metacommits

2019-01-27 Thread sxenos
From: Stefan Xenos This patch adds the get_metacommit_content method, which can classify commits as either metacommits or normal commits, determine whether they are abandoned, and extract the content commit's object id from the metacommit. Signed-off-by: Stefan Xenos --- Makefile|

[PATCH v2 5/8] evolve: Add the change-table structure

2019-01-27 Thread sxenos
From: Stefan Xenos A change table stores a list of changes, and supports efficient lookup from a commit hash to the list of changes that reference that commit directly. It can be used to look up content commits or metacommits at the head of a change, but does not support lookup of commits refere

[PATCH v2 7/8] evolve: Implement the git change command

2019-01-27 Thread sxenos
From: Stefan Xenos Implement the git change update command, which are sufficient for constructing change graphs. For example, to create a new change (a stable name) that refers to HEAD: git change update -c HEAD To record a rebase or amend in the change graph: git change update -c -r To re

[PATCH v2 2/8] sha1-array: Implement oid_array_readonly_contains

2019-01-27 Thread sxenos
From: Stefan Xenos Implement a "readonly_contains" function for oid_array that won't sort the array if it is unsorted. This can be used to test containment in the rare situations where the array order matters. The function has intentionally been given a name that is more cumbersome than the "loo

[PATCH v2 1/8] technical doc: add a design doc for the evolve command

2019-01-27 Thread sxenos
From: Stefan Xenos This document describes what a change graph for git would look like, the behavior of the evolve command, and the changes planned for other commands. Signed-off-by: Stefan Xenos --- Documentation/technical/evolve.txt | 1034 1 file changed, 1034 i

[PATCH v2 8/8] evolve: Add the git change list command

2019-01-27 Thread sxenos
From: Stefan Xenos This command lists the ongoing changes from the refs/metas namespace. Signed-off-by: Stefan Xenos --- builtin/change.c | 53 1 file changed, 53 insertions(+) diff --git a/builtin/change.c b/builtin/change.c index ff7eb3b113..

[PATCH v2 6/8] evolve: Add support for writing metacommits

2019-01-27 Thread sxenos
From: Stefan Xenos metacommit.c supports the creation of metacommits and adds the API needed to create and update changes. Create the "modify_change" function that can be called from modification commands like "rebase" and "git amend" to record obsolescences in the change graph. Create the "rec

[PATCH v2 3/8] ref-filter: Add the metas namespace to ref-filter

2019-01-27 Thread sxenos
From: Stefan Xenos The metas namespace will contain refs for changes in progress. Add support for searching this namespace. Signed-off-by: Stefan Xenos --- ref-filter.c | 8 ++-- ref-filter.h | 5 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ref-filter.c b/ref-filte

[PATCH v2 4/8] evolve: Add support for parsing metacommits

2019-01-27 Thread sxenos
From: Stefan Xenos This patch adds the get_metacommit_content method, which can classify commits as either metacommits or normal commits, determine whether they are abandoned, and extract the content commit's object id from the metacommit. Signed-off-by: Stefan Xenos --- Makefile|

[PATCH v2] git-submodule.sh: shorten submodule SHA-1s using rev-parse

2019-01-27 Thread Sven van Haastregt
Until now, `git submodule summary` was always emitting 7-character SHA-1s that have a higher chance of being ambiguous for larger repositories. Use `git rev-parse --short` instead, which will determine suitable short SHA-1 lengths. We cannot rely on always successfully invoking `git rev-parse` in

Re: [PATCH 2/8] evolve: Implement oid_array_contains_nondestructive

2019-01-27 Thread Stefan Xenos
On Tue, Jan 22, 2019 at 11:51 AM Stefan Beller wrote: > > On Mon, Jan 21, 2019 at 2:32 PM wrote: > > > > > evolve: Implement oid_array_contains_nondestructive > > I'd think I would word this > > sha1-array: implement oid_array_contains_nondestructive Good point. Done. > as for this patch it

Re: [PATCH v4 10/21] ci: move the Windows job to the top

2019-01-27 Thread Johannes Schindelin
Hi Junio, On Wed, 23 Jan 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > The Windows job currently takes a whopping ~1h20m to complete. Which is > > *far* longer than the next-longest job takes (linux-gcc, ~35m). As such, >

Re: [PATCH] object_as_type: initialize commit-graph-related fields of 'struct commit'

2019-01-27 Thread Derrick Stolee
On 1/27/2019 8:28 AM, SZEDER Gábor wrote: > On Sun, Jan 27, 2019 at 02:08:32PM +0100, SZEDER Gábor wrote: >> When the commit graph and generation numbers were introduced in >> commits 177722b344 (commit: integrate commit graph with commit >> parsing, 2018-04-10) and 83073cc994 (commit: add generati

Re: [PATCH v4 17/21] tests: add t/helper/ to the PATH with --with-dashes

2019-01-27 Thread Johannes Schindelin
Hi Junio, On Wed, 23 Jan 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > We really need to be able to find the test helpers... Really. This > > change was forgotten when we moved the test helpers into t/helper/ > > > > Sign

Re: [PATCH v4 09/21] Add a build definition for Azure DevOps

2019-01-27 Thread Johannes Schindelin
Hi Junio, On Wed, 23 Jan 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > This commit adds an azure-pipelines.yml file which is Azure DevOps' > > equivalent to Travis CI's .travis.yml. > > > > To make things a bit easier to

Re: [PATCH v4 08/21] ci/lib.sh: add support for Azure Pipelines

2019-01-27 Thread Johannes Schindelin
Hi Junio, On Wed, 23 Jan 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > This patch introduces a conditional arm that defines some environment > > variables and a function that displays the URL given the job id (to > > iden

Re: [PATCH v4 10/21] ci: move the Windows job to the top

2019-01-27 Thread Johannes Schindelin
Hi Junio, On Wed, 23 Jan 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > The Windows job currently takes a whopping ~1h20m to complete. Which is > > *far* longer than the next-longest job takes (linux-gcc, ~35m). As such, >

Re: [PATCH v4 06/21] test-date: add a subcommand to measure times in shell scripts

2019-01-27 Thread Johannes Schindelin
Hi Junio, On Wed, 23 Jan 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > In the next commit, we want to teach Git's test suite to optionally > > output test results in JUnit-style .xml files. These files contain > > informa

Re: [PATCH] object_as_type: initialize commit-graph-related fields of 'struct commit'

2019-01-27 Thread SZEDER Gábor
On Sun, Jan 27, 2019 at 02:08:32PM +0100, SZEDER Gábor wrote: > When the commit graph and generation numbers were introduced in > commits 177722b344 (commit: integrate commit graph with commit > parsing, 2018-04-10) and 83073cc994 (commit: add generation number to > struct commit, 2018-04-25), they

[PATCH] object_as_type: initialize commit-graph-related fields of 'struct commit'

2019-01-27 Thread SZEDER Gábor
When the commit graph and generation numbers were introduced in commits 177722b344 (commit: integrate commit graph with commit parsing, 2018-04-10) and 83073cc994 (commit: add generation number to struct commit, 2018-04-25), they tried to make sure that the corresponding 'graph_pos' and 'generation

Re: unclear docs

2019-01-27 Thread Sergey Lukashev
A follow up on my previous mail. Well, I have two problems: 1) The endings I get with core.autocrlf=false depend on whether I have * text=auto (a file was commited with LFs). At least in git 2.20.1 2) If the quote holds true then autocrlf=false is actually "true" (for output conversion) on Windo

unclear docs

2019-01-27 Thread Sergey Lukashev
Hello! Could somebody please explain what 'core.autocrlf overrides core.eol' means  given that we have the following statement in core.eol docs: "Sets the line ending type to use in the working directory for files that have the text property set when core.autocrlf is false". I would like to know