Re: testing some changes to a public-inbox .onion

2019-01-23 Thread Eric Wong
Johannes Schindelin wrote: > On Mon, 21 Jan 2019, Eric Wong wrote: > >http://hjrcffqmbrq6wope.onion/git/ > > > > Tested with Netsurf and dillo. > > Nice. > > Do you also plan on taking care of the regular thread view? I still find > it *very* hard to navigate it, and I have to admit tha

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Jonathan Nieder
Hi, Junio C Hamano wrote: > Thomas Gummerer writes: >> Jonathan Nieder wrote: >>> Is this analogous to "git add --ignore-removal"? If so, can we just >>> call it --ignore-removal? >> >> Yes, it seems like they are very similar. > > Hmm, I am not sure if the word "removal" makes sense in the con

[PATCH v3 2/2] pack-objects: merge read_lock and lock in packing_data struct

2019-01-23 Thread Patrick Hogg
Upgrade the packing_data lock to a recursive mutex to make it suitable for current read_lock usages. Additionally remove the superfluous #ifndef NO_PTHREADS guard around mutex initialization in prepare_packing_data as the mutex functions themselves are already protected. Signed-off-by: Patrick Hog

[PATCH v3 1/2] pack-objects: move read mutex to packing_data struct

2019-01-23 Thread Patrick Hogg
ac77d0c37 ("pack-objects: shrink size field in struct object_entry", 2018-04-14) added an extra usage of read_lock/read_unlock in the newly introduced oe_get_size_slow for thread safety in parallel calls to try_delta(). Unfortunately oe_get_size_slow is also used in serial code, some of which is ca

Re: git status OOM on mmap of large file

2019-01-23 Thread brian m. carlson
On Tue, Jan 22, 2019 at 06:07:14PM -0400, Joey Hess wrote: > joey@darkstar:~/tmp/t> ls -l big-file > -rw-r--r-- 1 joey joey 11811160064 Jan 22 17:48 big-file > joey@darkstar:~/tmp/t> git status > fatal: Out of memory, realloc failed > > This file is checked into git, but using a smudge/clean filte

Re: [PATCH v3 2/2] setup: fix memory leaks with `struct repository_format`

2019-01-23 Thread brian m. carlson
On Wed, Jan 23, 2019 at 12:57:05AM -0500, Jeff King wrote: > This uses designated initializers, which is a C99-ism, but one we've > used previously and feel confident in. But... > > > +void clear_repository_format(struct repository_format *format) > > +{ > > + string_list_clear(&format->unknown_

Re: [PATCH 6/6] commit-graph: test verifying a corrupt v2 header

2019-01-23 Thread Jonathan Tan
> From: Derrick Stolee > > The commit-graph file format v2 changes the v1 data only in the > header information. Add tests that check the 'verify' subcommand > catches corruption in the v2 header. Ah, I should have read this patch before I wrote [1]. I think the commit message of that patch shou

Re: [PATCH 5/6] commit-graph: implement file format version 2

2019-01-23 Thread Jonathan Tan
> +Version 2: > + > + 1-byte number (C) of "chunks" > + > + 1-byte reachability index version number: > + Currently, the only valid number is 1. > + > + 1-byte (reserved for later use) > + Current clients expect this value to be zero, and will not > + try to read the commit-graph

Re: [PATCH v4 09/21] Add a build definition for Azure DevOps

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > This commit adds an azure-pipelines.yml file which is Azure DevOps' > equivalent to Travis CI's .travis.yml. > > To make things a bit easier to understand, we refrain from using the > `matrix` feature here because (wh

Re: [PATCH v4 04/21] ci: inherit --jobs via MAKEFLAGS in run-build-and-tests

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > Let's not decide in the generic ci/ script how many jobs to run in > parallel; it is easy enough to hand that information down via the > `MAKEFLAGS`. > > Signed-off-by: Johannes Schindelin > --- > ci/run-build-and-t

Re: [PATCH v4 03/21] ci/lib.sh: encapsulate Travis-specific things

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > index fe65144152..bcdcc71592 100755 > --- a/ci/install-dependencies.sh > +++ b/ci/install-dependencies.sh > @@ -37,7 +37,8 @@ osx-clang|osx-gcc) > brew update --quiet >

Re: [PATCH v4 00/21] Offer to run CI/PR builds in Azure Pipelines

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > This patch series took wy more time than I had originally > anticipated, but I think that in particular the advanced display of the test > results and the reduction of the overall run time was worth it. Please let > me know what you think a

Re: [PATCH v4 20/21] ci: speed up Windows phase

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > As Unix shell scripting comes at a hefty price on Windows, we have to > see where we can save some time to run the test suite. > > Let's skip the chain linting and the bin-wrappers/ redirection on > Windows; this seem

Re: [PATCH v4 17/21] tests: add t/helper/ to the PATH with --with-dashes

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > We really need to be able to find the test helpers... Really. This > change was forgotten when we moved the test helpers into t/helper/ > > Signed-off-by: Johannes Schindelin > --- > t/test-lib.sh | 2 +- > 1 file c

Re: [PATCH v4 02/21] ci: rename the library of common functions

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > The name is hard-coded to reflect that we use Travis CI for continuous > testing. > > In the next commits, we will extend this to be able use Azure DevOps, > too. > > So let's adjust the name to make it more generic.

Re: [PATCH v4 06/21] test-date: add a subcommand to measure times in shell scripts

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > In the next commit, we want to teach Git's test suite to optionally > output test results in JUnit-style .xml files. These files contain > information about the time spent. So we need a way to measure time. > > While

Re: [PATCH v4 10/21] ci: move the Windows job to the top

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > The Windows job currently takes a whopping ~1h20m to complete. Which is > *far* longer than the next-longest job takes (linux-gcc, ~35m). As such, > it makes sense to start the Windows job first, to minimize the overa

Re: [PATCH v4 08/21] ci/lib.sh: add support for Azure Pipelines

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > This patch introduces a conditional arm that defines some environment > variables and a function that displays the URL given the job id (to > identify previous runs for known-good trees). > > For example, we do not ha

Re: [PATCH v4 01/21] travis: fix skipping tagged releases

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > When building a PR, TRAVIS_BRANCH refers to the *target branch*. > Therefore, if a PR targets `master`, and `master` happened to be tagged, > we skipped the build by mistake. > > Fix this by using TRAVIS_PULL_REQUEST_

Re: [PATCH v6 1/3] ref-filter: add worktreepath atom

2019-01-23 Thread Nickolai Belakovski
On Wed, Jan 23, 2019 at 10:57 AM Junio C Hamano wrote: > > Missing sign-off? > My mistake, forgot -s on format-patch. Will remember to add it next go-around. > > +static int ref_to_worktree_map_cmpfnc(const void *unused_lookupdata, const > > void *existing_hashmap_entry_to_test, > > +

Re: [PATCH v4 10/21] ci: move the Windows job to the top

2019-01-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > The Windows job currently takes a whopping ~1h20m to complete. Which is > *far* longer than the next-longest job takes (linux-gcc, ~35m). As such, > it makes sense to start the Windows job first, to minimize the overa

Re: [PATCH v3 0/9] Create 'expire' and 'repack' verbs for git-multi-pack-index

2019-01-23 Thread Jonathan Tan
> The multi-pack-index provides a fast way to find an object among a large > list of pack-files. It stores a single pack-reference for each object id, so > duplicate objects are ignored. Among a list of pack-files storing the same > object, the most-recently modified one is used. > > Create new su

Re: [PATCH v3 7/9] multi-pack-index: prepare 'repack' subcommand

2019-01-23 Thread Jonathan Tan
> diff --git a/Documentation/git-multi-pack-index.txt > b/Documentation/git-multi-pack-index.txt > index 6186c4c936..cc63531cc0 100644 > --- a/Documentation/git-multi-pack-index.txt > +++ b/Documentation/git-multi-pack-index.txt > @@ -36,6 +36,17 @@ expire:: > have no objects referenced by t

Re: [PATCH v3 8/9] midx: implement midx_repack()

2019-01-23 Thread Jonathan Tan
> From: Derrick Stolee > > To repack using a multi-pack-index, first sort all pack-files by > their modified time. Second, walk those pack-files from oldest > to newest, adding the packs to a list if they are smaller than the > given pack-size. Finally, collect the objects from the multi-pack- >

Re: [PATCH v3 6/9] multi-pack-index: implement 'expire' verb

2019-01-23 Thread Jonathan Tan
> From: Derrick Stolee > > The 'git multi-pack-index expire' command looks at the existing > mult-pack-index, counts the number of objects referenced in each > pack-file, deletes the pack-fils with no referenced objects, and > rewrites the multi-pack-index to no longer reference those packs. Tha

[PATCH 6/6] commit-graph: test verifying a corrupt v2 header

2019-01-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The commit-graph file format v2 changes the v1 data only in the header information. Add tests that check the 'verify' subcommand catches corruption in the v2 header. Signed-off-by: Derrick Stolee --- t/t5318-commit-graph.sh | 31 +++ 1 file chan

[PATCH 3/6] commit-graph: create new version flags

2019-01-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee In anticipation of a new commit-graph file format version, create a flag for the write_commit_graph() and write_commit_graph_reachable() methods to take a version number. When there is no specified version, the implementation selects a default value. Currently, the only vali

[PATCH 5/6] commit-graph: implement file format version 2

2019-01-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The commit-graph file format had some shortcomings which we now correct: 1. The hash algorithm was determined by a single byte, instead of the 4-byte format identifier. 2. There was no way to update the reachability index we used. We currently only support gen

[PATCH 2/6] commit-graph: collapse parameters into flags

2019-01-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() and write_commit_graph_reachable() methods currently take two boolean parameters: 'append' and 'report_progress'. We will soon expand the possible options to send to these methods, so instead of complicating the parameter list, first simplify it. Col

[PATCH 4/6] commit-graph: add --version= option

2019-01-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee Allo the commit-graph builtin to specify the file format version using the '--version=' option. Specify the version exactly in the verification tests as using a different version would change the offsets used in those tests. Signed-off-by: Derrick Stolee --- Documentation/

[PATCH 1/6] commit-graph: return with errors during write

2019-01-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method uses die() to report failure and exit when confronted with an unexpected condition. This use of die() in a library function is incorrect and is now replaced by error() statements and an int return type. Now that we use 'goto cleanup' to jump t

[PATCH 0/6] Create commit-graph file format v2

2019-01-23 Thread Derrick Stolee via GitGitGadget
The commit-graph file format has some shortcomings that were discussed on-list: 1. It doesn't use the 4-byte format ID from the_hash_algo. 2. There is no way to change the reachability index from generation numbers to corrected commit date [1]. 3. The unused byte in the

Re: [PATCH v3 0/2] Fix regression in checkout -b

2019-01-23 Thread Junio C Hamano
Ben Peart writes: > From: Ben Peart > > Minor update to comment from V2. Also wrapped commit messages to be <80 > chars wide. Perfect. Thanks.

Re: [PATCH] doc: tidy asciidoc style

2019-01-23 Thread Junio C Hamano
Jean-Noël AVILA writes: > These styling fixes were raised by warning of po4a when processing > the files. Otherwise, there's no hurry in pushing them. Yeah, but as we postpone it, all the topics in flight that wants to touch documentation may get blocked (or cause this large patch to be redone

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Junio C Hamano
Thomas Gummerer writes: >> I had no idea what --overlay would mean and am still not clear on it. >> Is this analogous to "git add --ignore-removal"? If so, can we just >> call it --ignore-removal? > > Yes, it seems like they are very similar. Hmm, I am not sure if the word "removal" makes sense

Re: [PATCH v3 5/9] midx: refactor permutation logic and pack sorting

2019-01-23 Thread Jonathan Tan
Following Stolee's wishes [1], I'll stick to the technical aspects here. Patches 1-4 look correct technically to me, so let me start here. [1] https://public-inbox.org/git/3aa0a7ea-6c30-2c61-0815-2b9ab8304...@gmail.com/ > +struct pack_info { > + uint32_t orig_pack_int_id; > + char *pack_n

[PATCH v5 16/16] rebase--interactive: move transform_todo_file() to rebase--interactive.c

2019-01-23 Thread Alban Gruin
As transform_todo_file() is only needed inside of rebase--interactive.c, it is moved there from sequencer.c. Signed-off-by: Alban Gruin --- Unchanged since v4. builtin/rebase--interactive.c | 26 +- sequencer.c | 23 --- sequencer.h

[PATCH v5 11/16] sequencer: refactor skip_unnecessary_picks() to work on a todo_list

2019-01-23 Thread Alban Gruin
This refactors skip_unnecessary_picks() to work on a todo_list. As this function is only called by complete_action() (and thus is not used by rebase -p), the file-handling logic is completely dropped here. Instead of truncating the todo list’s buffer, the items are moved to the beginning of the l

[PATCH v5 14/16] rebase-interactive: rewrite edit_todo_list() to handle the initial edit

2019-01-23 Thread Alban Gruin
edit_todo_list() is changed to work on a todo_list, and to handle the initial edition of the todo list (ie. making a backup of the todo list). It does not check for dropped commits yet, as todo_list_check() does not take the commits that have already been processed by the rebase (ie. the todo list

[PATCH v5 09/16] sequencer: make sequencer_make_script() write its script to a strbuf

2019-01-23 Thread Alban Gruin
This makes sequencer_make_script() write its script to a strbuf (ie. the buffer of a todo_list) instead of a FILE. This reduce the amount of read/write made by rebase interactive. Signed-off-by: Alban Gruin --- Unchanged since v4. builtin/rebase--interactive.c | 13 ++- sequencer.c

[PATCH v5 00/16] sequencer: refactor functions working on a todo_list

2019-01-23 Thread Alban Gruin
At the center of the "interactive" part of the interactive rebase lies the todo list. When the user starts an interactive rebase, a todo list is generated, presented to the user (who then edits it using a text editor), read back, and then is checked and processed before the actual rebase takes pla

[PATCH v5 03/16] sequencer: remove the 'arg' field from todo_item

2019-01-23 Thread Alban Gruin
The 'arg' field of todo_item used to store the address of the first byte of the parameter of a command in a todo list. It was associated with the length of the parameter (the 'arg_len' field). This replaces the 'arg' field by 'arg_offset'. This new field does not store the address of the paramet

[PATCH v5 15/16] sequencer: use edit_todo_list() in complete_action()

2019-01-23 Thread Alban Gruin
This changes complete_action() to use edit_todo_list(), now that it can handle the initial edit of the todo list. Signed-off-by: Alban Gruin --- Unchanged since v4. sequencer.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/sequencer.c b/sequencer.c i

[PATCH v5 06/16] sequencer: refactor check_todo_list() to work on a todo_list

2019-01-23 Thread Alban Gruin
This refactors check_todo_list() to work on a todo_list to avoid redundant reads and writes to the disk. The function is renamed todo_list_check(). The parsing of the two todo lists is left to the caller. As rebase -p still need to check the todo list from the disk, a new function is introduced,

[PATCH v5 10/16] sequencer: change complete_action() to use the refactored functions

2019-01-23 Thread Alban Gruin
complete_action() used functions that read the todo-list file, made some changes to it, and wrote it back to the disk. The previous commits were dedicated to separate the part that deals with the file from the actual logic of these functions. Now that this is done, we can call directly the "logic

[PATCH v5 02/16] sequencer: make the todo_list structure public

2019-01-23 Thread Alban Gruin
This makes the structures todo_list and todo_item, and the functions todo_list_release() and parse_insn_buffer(), accessible outside of sequencer.c. Signed-off-by: Alban Gruin --- Unchanged since v4. sequencer.c | 69 ++--- sequencer.h | 50 ++

[PATCH v5 12/16] rebase-interactive: use todo_list_write_to_file() in edit_todo_list()

2019-01-23 Thread Alban Gruin
Just like complete_action(), edit_todo_list() used a function (transform_todo_file()) that read the todo list from the disk and wrote it back, resulting in useless disk accesses. This changes edit_todo_list() to call directly todo_list_write_to_file() instead. Signed-off-by: Alban Gruin --- Squa

[PATCH v5 13/16] rebase-interactive: append_todo_help() changes

2019-01-23 Thread Alban Gruin
This moves the writing of the comment "Rebase $shortrevisions onto $shortonto ($command_count commands)" from todo_list_write_to_file() to append_todo_help(). shortrevisions, shortonto, and command_count are passed as parameters to append_todo_help(). During the initial edit of the todo list, sho

[PATCH v5 01/16] sequencer: changes in parse_insn_buffer()

2019-01-23 Thread Alban Gruin
This clears the number of items of a todo_list before parsing it to allow to parse the same list multiple times without issues. As its items are not dynamically allocated, or don’t need to allocate memory, no additionnal memory management is required here. Furthermore, if a line is invalid, the t

[PATCH v5 08/16] sequencer: refactor rearrange_squash() to work on a todo_list

2019-01-23 Thread Alban Gruin
This refactors rearrange_squash() to work on a todo_list to avoid redundant reads and writes. The function is renamed todo_list_rearrange_squash(). The old version created a new buffer, which was directly written to the disk. This new version creates a new item list by just copying items from th

[PATCH v5 07/16] sequencer: refactor sequencer_add_exec_commands() to work on a todo_list

2019-01-23 Thread Alban Gruin
This refactors sequencer_add_exec_commands() to work on a todo_list to avoid redundant reads and writes to the disk. Instead of inserting the `exec' commands between the other commands and re-parsing the buffer at the end, they are appended to the buffer once, and a new list of items is created.

[PATCH v5 04/16] sequencer: refactor transform_todos() to work on a todo_list

2019-01-23 Thread Alban Gruin
This refactors transform_todos() to work on a todo_list. The function is renamed todo_list_transform(). As rebase -p still need to check the todo list from the disk, a new function is introduced, transform_todo_file(). It is still used by complete_action() and edit_todo_list() for now, but they

[PATCH v5 05/16] sequencer: introduce todo_list_write_to_file()

2019-01-23 Thread Alban Gruin
This introduces a new function to recreate the text of a todo list from its commands and write it to a file. This will be useful as the next few commits will change the use of the buffer in struct todo_list so it will no longer be a mirror of the file on disk. This functionality already exists in

Re: [PATCH 01/14] trace2: Documentation/technical/api-trace2.txt

2019-01-23 Thread Junio C Hamano
"Jeff Hostetler via GitGitGadget" writes: > +These high-level events are written to one or more Trace2 Targets > +in a target-specific format. Each Trace2 Target defines a different > +purpose-specific view onto the event data stream. In this mannor, "In this manner" > +a single set of Trace2

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Jonathan Nieder
Thomas Gummerer wrote: > On 01/22, Jonathan Nieder wrote: >> I had no idea what --overlay would mean and am still not clear on it. >> Is this analogous to "git add --ignore-removal"? If so, can we just >> call it --ignore-removal? > > Yes, it seems like they are very similar. I'm happy to rename

Re: [PATCH] doc: tidy asciidoc style

2019-01-23 Thread Jean-Noël AVILA
On Wednesday, 23 January 2019 20:36:46 CET Junio C Hamano wrote: > I somehow misread the title as "tiny asciidoc style (fixes)". This > is a huge clean-up. Thanks for working on it. > These styling fixes were raised by warning of po4a when processing the files. Otherwise, there's no hurry in

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Thomas Gummerer
On 01/22, Jonathan Nieder wrote: > Hi, > > Thomas Gummerer wrote: > > > Currently 'git checkout' is defined as an overlay operation, which > > means that if in 'git checkout -- []' we have an > > entry in the index that matches , but that doesn't exist in > > , that entry will not be removed fro

[PATCH v3 1/2] checkout: add test demonstrating regression with checkout -b on initial commit

2019-01-23 Thread Ben Peart
From: Ben Peart Commit fa655d8411 (checkout: optimize "git checkout -b ", 2018-08-16) introduced an unintentional change in behavior for 'checkout -b' after doing 'clone --no-checkout'. Add a test to demonstrate the changed behavior to be used in a later patch to verify the fix. Signed-off-by:

[PATCH v3 0/2] Fix regression in checkout -b

2019-01-23 Thread Ben Peart
From: Ben Peart Minor update to comment from V2. Also wrapped commit messages to be <80 chars wide. Base Ref: master Web-Diff: https://github.com/benpeart/git/commit/fef76edbdc Checkout: git fetch https://github.com/benpeart/git initial-checkout-v3 && git checkout fef76edbdc ### Interdiff (v

[PATCH v3 2/2] checkout: fix regression in checkout -b on intitial checkout

2019-01-23 Thread Ben Peart
From: Ben Peart When doing a 'checkout -b' do a full checkout including updating the working tree when doing the initial checkout. As the new test involves an filesystem access, do it later in the sequence to give chance to other cheaper tests to leave early. This fixes the regression in behavior

Re: [PATCH] doc: tidy asciidoc style

2019-01-23 Thread Junio C Hamano
Junio C Hamano writes: > Jean-Noël Avila writes: > >> This mainly refers to enforcing indentation on additional lines of >> items of lists. >> >> Signed-off-by: Jean-Noël Avila >> --- > > I somehow misread the title as "tiny asciidoc style (fixes)". This > is a huge clean-up. Thanks for worki

Re: [PATCH] doc: tidy asciidoc style

2019-01-23 Thread Junio C Hamano
Jean-Noël Avila writes: > This mainly refers to enforcing indentation on additional lines of > items of lists. > > Signed-off-by: Jean-Noël Avila > --- I somehow misread the title as "tiny asciidoc style (fixes)". This is a huge clean-up. Thanks for working on it. > diff --git a/Documentatio

Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

2019-01-23 Thread Junio C Hamano
Barret Rhoden writes: >> So... I dunno. > > I guess if you swap the lines as well as change them,... > ... Then it won't have the semantic knowledge that "one" == "1". If a user > is ignoring a commit, we don't have an oracle that knows exactly what > that commit did to determine what commit the

Fwd: Re: [git-users] List of ignore configuration file

2019-01-23 Thread Konstantin Khomoutov
A user over there at the git-users ML is having troubles with the wording of the `git check-ignore` manual page which, in their opinion, fails to clearly communicate the twist about tracked files being not eligible for ignored/non-ignored checks: - Forwarded message from cl.robitai...@gmail.co

Re: [PATCH v2 0/2] Fix regression in checkout -b

2019-01-23 Thread Junio C Hamano
Ben Peart writes: >> This is curious. The location the new special case is added is >> different, and the way the new special case is detected is also >> different, between v1 and v2. Are both of them significant? IOW, >> if we moved the check down but kept using is_cache_unborn(), would >> it

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Junio C Hamano
Jonathan Nieder writes: > I'm nervous about the config with no associated warning or plan for > phasing it out. This was discussed long ago (in my panda-brain timescale) but my recollection is to keep "checkout" default to the traditional "overlay what was read from the tree on top of the curren

Re: [PATCH v6 1/3] ref-filter: add worktreepath atom

2019-01-23 Thread Junio C Hamano
nbelakov...@gmail.com writes: > From: Nickolai Belakovski > > Add an atom providing the path of the linked worktree where this ref is > checked out, if it is checked out in any linked worktrees, and empty > string otherwise. > --- Missing sign-off? > +static int ref_to_worktree_map_cmpfnc(const

Re: [PATCH v2 1/2] checkout: add test to demonstrate regression with checkout -b on initial commit

2019-01-23 Thread SZEDER Gábor
On Mon, Jan 21, 2019 at 02:50:07PM -0500, Ben Peart wrote: > From: Ben Peart > > Commit fa655d8411 (checkout: optimize "git checkout -b ", > 2018-08-16) > introduced an unintentional change in behavior for 'checkout -b' after doing > 'clone --no-checkout'. Add a test to demonstrate the changed

Re: [PATCH/RFC v2 1/1] test-lint: Only use only sed [-n] [-e command] [-f command_file]

2019-01-23 Thread Junio C Hamano
Torsten Bögershausen writes: >> I'd still prefer to see a more terse[1] (and not capitalized) message >> to be consistent with existing error messages and to keep the reported >> errors more compact overall to make them easier to digest[2,3]: >> >> err 'sed option not portable (use only -n, -

Re: [PATCH v6 00/10] commit-graph write: progress output improvements

2019-01-23 Thread Junio C Hamano
Derrick Stolee writes: > On 1/19/2019 3:21 PM, Ævar Arnfjörð Bjarmason wrote: >> Improvements since v6: >> >> * Integrate my "commit-graph write: use pack order when finding >> commits" patch, and per Junio's suggestion put it at the start so >> it's easier to split the two apart. >> >>

Re: [PATCH v2] pack-objects: Use packing_data lock instead of read_mutex

2019-01-23 Thread Junio C Hamano
Patrick Hogg writes: > On Tue, Jan 22, 2019 at 5:43 PM Junio C Hamano wrote: >> >> Patrick Hogg writes: >> >> > As I mentioned in the prior thread I think that it will be simpler >> > to simply use the existing lock in packing_data instead of moving >> > read_mutex. I can go back to simply movi

[PATCH v6.1 03/10] commit-graph: don't call write_graph_chunk_extra_edges() unnecessarily

2019-01-23 Thread SZEDER Gábor
The optional 'Extra Edge List' chunk of the commit graph file stores parent information for commits with more than two parents. Since the chunk is optional, write_commit_graph() looks through all commits to find those with more than two parents, and then writes the commit graph file header accordi

RE:

2019-01-23 Thread Randall S. Becker
On January 23, 2019 11:00, Christopher Hagler wrote: > Send the email to this address > majord...@vger.kernel.org and it will work > > On Jan 23, 2019, at 8:16 AM, Cody Kratzer > > I've sent this same email 3 times. I don't think it works. I'm > > researching this morning how to unsubscribe from t

Fast CI for all branches in gitster/git, was Re: [PATCH v4 00/21] Offer to run CI/PR builds in Azure Pipelines

2019-01-23 Thread Johannes Schindelin
Hi all, On Wed, 23 Jan 2019, Johannes Schindelin via GitGitGadget wrote: > * The Windows job was split into a job to build Git and 10 parallel > jobs to run the test suite with the artifacts built by the first job. > This reduces the overall run time from ~1h20 (which was the run time by > th

Re:

2019-01-23 Thread Christopher Hagler
Send the email to this address majord...@vger.kernel.org and it will work Sent from my iPhone > On Jan 23, 2019, at 8:16 AM, Cody Kratzer wrote: > > I've sent this same email 3 times. I don't think it works. I'm > researching this morning how to unsubscribe from this git group. > > CODY KRATZ

[PATCH v4 05/21] ci: use a junction on Windows instead of a symlink

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Symbolic links are still not quite as easy to use on Windows as on Linux (for example, on versions older than Windows 10, only administrators can create symlinks, and on Windows 10 you still need to be in developer mode for regular users to have permission), but NTFS jun

[PATCH v4 00/21] Offer to run CI/PR builds in Azure Pipelines

2019-01-23 Thread Johannes Schindelin via GitGitGadget
For a long time already, we have tested Git's source code continuously via Travis CI, see e.g. https://travis-ci.org/git/git/builds/421738884. It has served us well, and more and more developers actually pay attention and benefit from the testing this gives us. It is also an invaluable tool for co

[PATCH v4 02/21] ci: rename the library of common functions

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The name is hard-coded to reflect that we use Travis CI for continuous testing. In the next commits, we will extend this to be able use Azure DevOps, too. So let's adjust the name to make it more generic. Signed-off-by: Johannes Schindelin --- ci/install-dependencie

[PATCH v4 08/21] ci/lib.sh: add support for Azure Pipelines

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This patch introduces a conditional arm that defines some environment variables and a function that displays the URL given the job id (to identify previous runs for known-good trees). For example, we do not have to install the git-lfs and gettext packages on Azure Pipel

[PATCH v4 10/21] ci: move the Windows job to the top

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The Windows job currently takes a whopping ~1h20m to complete. Which is *far* longer than the next-longest job takes (linux-gcc, ~35m). As such, it makes sense to start the Windows job first, to minimize the overall run time (which is now pretty safely the run time of th

[PATCH v4 17/21] tests: add t/helper/ to the PATH with --with-dashes

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin We really need to be able to find the test helpers... Really. This change was forgotten when we moved the test helpers into t/helper/ Signed-off-by: Johannes Schindelin --- t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/test-lib.sh

[PATCH v4 04/21] ci: inherit --jobs via MAKEFLAGS in run-build-and-tests

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Let's not decide in the generic ci/ script how many jobs to run in parallel; it is easy enough to hand that information down via the `MAKEFLAGS`. Signed-off-by: Johannes Schindelin --- ci/run-build-and-tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v4 01/21] travis: fix skipping tagged releases

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When building a PR, TRAVIS_BRANCH refers to the *target branch*. Therefore, if a PR targets `master`, and `master` happened to be tagged, we skipped the build by mistake. Fix this by using TRAVIS_PULL_REQUEST_BRANCH (i.e. the *source branch*) when available, falling bac

[PATCH v4 13/21] README: add a build badge (status of the Azure Pipelines build)

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Just like so many other OSS projects, we now also have a build badge. Signed-off-by: Johannes Schindelin --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index f920a42fad..764c480c66 100644 --- a/README.md +++ b/README.md @@ -1

[PATCH v4 20/21] ci: speed up Windows phase

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin As Unix shell scripting comes at a hefty price on Windows, we have to see where we can save some time to run the test suite. Let's skip the chain linting and the bin-wrappers/ redirection on Windows; this seems to shave of anywhere between 10-30% from the overall runtim

[PATCH v4 14/21] tests: avoid calling Perl just to determine file sizes

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin It is a bit ridiculous to spin up a full-blown Perl instance (especially on Windows, where that means spinning up a full POSIX emulation layer, AKA the MSYS2 runtime) just to tell how large a given file is. So let's just use the test-tool to do that job instead. This c

[PATCH v4 21/21] ci: parallelize testing on Windows

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The fact that Git's test suite is implemented in Unix shell script that is as portable as we can muster, combined with the fact that Unix shell scripting is foreign to Windows (and therefore has to be emulated), results in pretty abysmal speed of the test suite on that p

[PATCH v4 18/21] t0061: fix with --with-dashes and RUNTIME_PREFIX

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When building Git with RUNTIME_PREFIX and starting a test helper from t/helper/, it fails to detect the system prefix correctly. This is the reason that the warning RUNTIME_PREFIX requested, but prefix computation failed. [...] to be printed. In t0061, we did

[PATCH v4 19/21] tests: optionally skip bin-wrappers/

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This speeds up the tests by a bit on Windows, where running Unix shell scripts (and spawning processes) is not exactly a cheap operation. Signed-off-by: Johannes Schindelin --- t/README | 9 + t/test-lib.sh | 19 +-- 2 files changed, 22 i

[PATCH v4 12/21] mingw: be more generous when wrapping up the setitimer() emulation

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Every once in a while, the Azure Pipeline fails with some semi-random error: timer thread did not terminate timely This error message means that the thread that is used to emulate the setitimer() function did not terminate within 1,000 milliseconds. The most l

[PATCH v4 15/21] tests: include detailed trace logs with --write-junit-xml upon failure

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The JUnit XML format lends itself to be presented in a powerful UI, where you can drill down to the information you are interested in very quickly. For test failures, this usually means that you want to see the detailed trace of the failing tests. With Travis CI, we pa

[PATCH v4 09/21] Add a build definition for Azure DevOps

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This commit adds an azure-pipelines.yml file which is Azure DevOps' equivalent to Travis CI's .travis.yml. To make things a bit easier to understand, we refrain from using the `matrix` feature here because (while it is powerful) it can be a bit confusing to users who ar

[PATCH v4 07/21] tests: optionally write results as JUnit-style .xml

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This will come in handy when publishing the results of Git's test suite during an automated Azure DevOps run. Note: we need to make extra sure that invalid UTF-8 encoding is turned into valid UTF-8 (using the Replacement Character, \uFFFD) because t9902's trace contains

[PATCH v4 11/21] ci: use git-sdk-64-minimal build artifact

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Instead of a shallow fetch followed by a sparse checkout, we are better off by using a separate, dedicated Pipeline that bundles the SDK as a build artifact, and then consuming that build artifact here. In fact, since this artifact will be used a lot, we spent substanti

[PATCH v4 16/21] mingw: try to work around issues with the test cleanup

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin It seems that every once in a while in the Git for Windows SDK, there are some transient file locking issues preventing the test clean up to delete the trash directory. Let's be gentle and try again five seconds later, and only error out if it still fails the second time

[PATCH v4 06/21] test-date: add a subcommand to measure times in shell scripts

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin In the next commit, we want to teach Git's test suite to optionally output test results in JUnit-style .xml files. These files contain information about the time spent. So we need a way to measure time. While we could use `date +%s` for that, this will give us only seco

[PATCH v4 03/21] ci/lib.sh: encapsulate Travis-specific things

2019-01-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The upcoming patches will allow building git.git via Azure Pipelines (i.e. Azure DevOps' Continuous Integration), where variable names and URLs look a bit different than in Travis CI. Signed-off-by: Johannes Schindelin --- ci/install-dependencies.sh | 3 ++- ci/lib.s

Re:

2019-01-23 Thread Thomas Braun
Am 23.01.2019 um 15:16 schrieb Cody Kratzer: > I've sent this same email 3 times. I don't think it works. I'm > researching this morning how to unsubscribe from this git group. Hi Cody, https://git-scm.com/community says to subscribe you should send an email with body content subscribe git to

[no subject]

2019-01-23 Thread Cody Kratzer
unsubscribe git

Re:

2019-01-23 Thread Cody Kratzer
I've sent this same email 3 times. I don't think it works. I'm researching this morning how to unsubscribe from this git group. CODY KRATZER WEB DEVELOPMENT MANAGER 866-344-3875 x145 c...@lightingnewyork.com M - F 9 - 5:30 On Wed, Jan 23, 2019 at 5:51 AM Christopher Hagler wrote: > > Unsubscrib

  1   2   >