git-gui child windows are still blank

2019-01-12 Thread Rob McDonald
The release of Mac OS Mojave has broken git-gui such that it is unusable. This issue was raised by Ken Sebesta back in November, but I can't reply directly via gmail. Message-ID: CAABTFJPpmThrrwP6pb5gZ82fb8yKteLpDcXTCQS8p_7WZ0Ne5Q at mail dot gmail dot com The main window opens fine, but any chi

git blame --reverse reports on lines that were not asked for

2019-01-12 Thread Julia Lawall
Version: git version 2.17.1, git version 2.20.1 Git tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable 7566ec393f4161572ba6f11ad5171fd5d59b0fbd The command git blame --reverse 91e4f1b6073dd680d86cdb7e42d7a9db39d8..HEAD -L1176,1176 -L1173,1173 arch/mips/kvm/emu

Re: [PATCH v5 2/3] branch: Mark and color a branch differently if it is checked out in a linked worktree

2019-01-12 Thread Nickolai Belakovski
On Thu, Jan 10, 2019 at 1:43 PM Philip Oakley wrote: > > On 07/01/2019 19:04, Junio C Hamano wrote: > > I do not think it is warranted to paint the safety features as > > "limitations". > > Is this not just a case of needing to clarify that this is 'safety' > related to the _users_ mental model (o

Gitignore documentation

2019-01-12 Thread Maris Razvan
Hello, I was reading the gitignore documentation (https://git-scm.com/docs/gitignore), especially the following paragraph: "If the pattern does not contain a slash /, Git treats it as a shell glob pattern and checks for a match against the pathname relative to the location of the .gitign

Re: [PATCH 0/6] getenv() timing fixes

2019-01-12 Thread Stefan Beller
> I wonder, and not as "you should do this" feedback on this series, just There is a getenv_safe() in environment.c, but I guess a xgetenv() that takes the same parameters as getenv() is better for ease of use.

Re: [PATCH 0/6] getenv() timing fixes

2019-01-12 Thread Ævar Arnfjörð Bjarmason
On Fri, Jan 11 2019, Jeff King wrote: > Similar to the recent: > > https://public-inbox.org/git/20190109221007.21624-1-kgyb...@infogroep.be/ > > there are some other places where we do not follow the POSIX rule that > getenv()'s return value may be invalidated by other calls to getenv() or > s

Re: [PATCH v4 2/3] commit-graph: fix buffer read-overflow

2019-01-12 Thread SZEDER Gábor
On Thu, Dec 13, 2018 at 11:43:57AM -0800, Josh Steadmon wrote: > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > index 5fe21db99f..a1b5a75882 100755 > --- a/t/t5318-commit-graph.sh > +++ b/t/t5318-commit-graph.sh > @@ -366,21 +366,26 @@ GRAPH_OCTOPUS_DATA_OFFSET=$(($GRAPH_COMMIT_DA

Re: [PATCH 2/6] commit: copy saved getenv() result

2019-01-12 Thread Jeff King
On Fri, Jan 11, 2019 at 07:07:15PM -0800, Junio C Hamano wrote: > > diff --git a/builtin/commit.c b/builtin/commit.c > > index 004b816635..7d2e0b61e5 100644 > > --- a/builtin/commit.c > > +++ b/builtin/commit.c > > @@ -351,7 +351,7 @@ static const char *prepare_index(int argc, const char > > **ar

OK

2019-01-12 Thread Ahmed Ahmed
Greetings Compliment of the day to you. I am Mr Ahmed Zama, I am sending this brief letter to solicit your partnership to transfer €15 million Euros into your account for investment in your country. I shall send you more information and procedures when I receive positive response from you. Thanks

[PATCH v6 1/5] t5323: test cases for git-pack-redundant

2019-01-12 Thread Jiang Xin
From: Jiang Xin Add test cases for git pack-redundant to validate new algorithm for git pack-redundant. Signed-off-by: Jiang Xin Reviewed-by: SZEDER Gábor --- t/t5323-pack-redundant.sh | 207 ++ 1 file changed, 207 insertions(+) create mode 100755 t/t5323-

[PATCH v6 2/5] pack-redundant: new algorithm to find min packs

2019-01-12 Thread Jiang Xin
From: Sun Chao When calling `git pack-redundant --all`, if there are too many local packs and too many redundant objects within them, the too deep iteration of `get_permutations` will exhaust all the resources, and the process of `git pack-redundant` will be killed. The following script could cr

[PATCH v6 0/5] pack-redundant: new algorithm to find min packs

2019-01-12 Thread Jiang Xin
> Sun Chao (my former colleague at Huawei) found a bug of > git-pack-redundant. If there are too many packs and many of them > overlap each other, running `git pack-redundant --all` will > exhaust all memories and the process will be killed by kernel. > > There is a script in commit log of commit

[PATCH v6 5/5] pack-redundant: consistent sort method

2019-01-12 Thread Jiang Xin
From: Jiang Xin SZEDER reported that test case t5323 has different test result on MacOS. This is because `cmp_pack_list_reverse` cannot give identical result when two pack being sorted has the same size of remaining_objects. Changes to the sorting function will make consistent test result for t5

[PATCH v6 3/5] pack-redundant: remove unused functions

2019-01-12 Thread Jiang Xin
From: Sun Chao Remove unused functions to find `min` packs, such as `get_permutations`, `pll_free`, etc. Signed-off-by: Sun Chao Signed-off-by: Jiang Xin Signed-off-by: Junio C Hamano --- builtin/pack-redundant.c | 86 1 file changed, 86 deletions(-)

[PATCH v6 4/5] pack-redundant: rename pack_list.all_objects

2019-01-12 Thread Jiang Xin
From: Jiang Xin New algorithm uses `pack_list.all_objects` to track remaining objects, so rename it to `pack_list.remaining_objects`. Signed-off-by: Jiang Xin --- builtin/pack-redundant.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a