On Wed, Jan 02, 2019 at 11:43:55PM -0800, William Chargin wrote:
> > IMHO this is a bug in --parse. It was always meant to give sane,
> > normalized output
>
> Okay; this is good to hear. In that case, what would you think about
> changing `interpret-trailers` as a whole to always emit colons? (N
On Sun, Dec 30, 2018 at 05:31:50PM -0700, Stephen P. Smith wrote:
> The `human` date format varies based on two inputs: the date in the
> reference time which is constant and the local computers date which
> varies. Using hardcoded test expected output dates would require
> holding the local mach
> That's what "%(trailers:only)" does (even if the original separator was
> something else). It also trims any extra whitespace.
Ooh, this is good to know: thanks. (I had found `print_tok_val` in
`trailer.c` and assumed that this was the only place with the output
logic, but I now see that `format
On Sun, Dec 30, 2018 at 05:31:48PM -0700, Stephen P. Smith wrote:
> Also add 'auto' date mode, which defaults to human if we're using the
> pager. So you can do
>
> git config --add log.date auto
>
> and your "git log" commands will show the human-legible format unless
> you're scripting
On Sun, Dec 30, 2018 at 10:34:26PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Sun, Dec 30 2018, Xheroz 128 wrote:
>
> > Currently, I’m doing my Final Year Project that requires a hook that
> > executes automatically on the server side of the repository, before the
> > objects been pulled to
Duy Nguyen writes:
> On Wed, Jan 2, 2019 at 3:09 AM Albert Burt wrote:
>>
>> Remove TODO that was left in from:
>> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
>>
>> Todo can be removed as:
>> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
>> de
On Wed, Jan 02, 2019 at 12:55:51PM -0800, Junio C Hamano wrote:
> > Signed-off-by: Randall S. Becker
> > ---
> > transport-helper.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/transport-helper.c b/transport-helper.c
> > index bf225c698f..a290695a12 100644
> > -
On Sun, Dec 23, 2018 at 02:41:20PM -0800, William Chargin wrote:
> I'm interested in parsing the output of `git-interpret-trailers` in a
> script. I had hoped that the `--parse` option would make this easy, but
> it seems that the `trailer.separators` configuration option is used to
> specify both
Stephen & Linda Smith writes:
> On Wednesday, January 2, 2019 11:15:02 AM MST Junio C Hamano wrote:
>> 'date +%s' is used everywhere in this patch but has never been used
>> in our test suite before. It is not portable.
> So I don't make this mistake again, Is there a reference somewhere for tha
On Mon, Dec 24, 2018 at 12:47:56AM -0800, nbelakov...@gmail.com wrote:
> From: Nickolai Belakovski
>
> ---
> builtin/branch.c | 4
> 1 file changed, 4 insertions(+)
This patch should describe the new behavior in Documentation/git-branch.txt,
I'd think.
-Peff
On Mon, Dec 24, 2018 at 12:47:54AM -0800, nbelakov...@gmail.com wrote:
> [...]
Thanks for keeping with this. I think we're getting quite close, though
I did find a few small-ish issues.
> @@ -34,6 +36,8 @@ static struct ref_msg {
> "ahead %d, behind %d"
> };
>
> +static struct worktree
On Mon, Dec 24, 2018 at 12:47:53AM -0800, nbelakov...@gmail.com wrote:
> From: Nickolai Belakovski
>
> > I don't think that works. The default function is always_equal(), which
> > will treat two entries equal if they have the same hash value. I.e., any
> > collisions would be considered a match
On Thu, Dec 27, 2018 at 03:36:29PM -0800, Erin Dahlgren wrote:
> Before this change are two misleading additional behaviors:
>
> - GIT_DIR_HIT_CEILING: setup_nongit() changes to the cwd for no
> apparent reason. We never had the chance to change directories
> up to this point so chd
On Thu, Dec 27, 2018 at 03:46:10PM -0800, Erin Dahlgren wrote:
> > Heh, I should learn to cut and paste better. This should be:
> >
> > if (!nongit_ok || !*nongit_ok)
> >
> > (which comes from the current code).
>
> Yep, but I think we can benefit from De Morgan's law here, where:
>
> (!nong
On Sun, Dec 30, 2018 at 08:04:19PM +0100, SZEDER Gábor wrote:
> > (in fact, given that this is just
> > the internal tests, I am tempted to say that we should just make it
> > "-r" for the sake of simplicity and consistency. But maybe somebody
> > would be annoyed. I have never used "-r" ever myse
On Wed, Jan 02, 2019 at 01:20:47AM +0100, Johannes Sixt wrote:
> > diff --git a/t/test-lib.sh b/t/test-lib.sh
> > index 0f1faa24b2..f47a191e3b 100644
> > --- a/t/test-lib.sh
> > +++ b/t/test-lib.sh
> > @@ -324,9 +324,12 @@ do
> > # isn't executed with a suitable Bash version.
> >
On Wed, Jan 02, 2019 at 09:38:46AM +, Eric Wong wrote:
> strncat() has the same quadratic behavior as strcat() and is
> difficult-to-read and bug-prone. While it hasn't yet been a
> problem in git iself, strncat() found it's way into 'master'
> of cgit and caused segfaults on my system.
I'm
On Wednesday, January 2, 2019 11:15:02 AM MST Junio C Hamano wrote:
> 'date +%s' is used everywhere in this patch but has never been used
> in our test suite before. It is not portable.
So I don't make this mistake again, Is there a reference somewhere for that is
and is not portable?
>
> We pe
On 02/01/2019 15:38, Tanushree Tumane via GitGitGadget wrote:
[snip]
> base-commit: 7f4e64169352e03476b0ea64e7e2973669e491a2
> Published-As:
> https://github.com/gitgitgadget/git/releases/tag/pr-101%2Ftanushree27%2Fgit-bisect_part2_fixup-v17
> Fetch-It-Via: git fetch https://github.com/gitgitga
Thomas Gummerer writes:
> In the previous patch we introduced a new no-overlay mode for git
> checkout. Some users (such as the author of this commit) may want to
> have this mode turned on by default as it matches their mental model
> more closely. Make that possible by introducing a new confi
Josh Steadmon writes:
> When communicating with a remote server or a subprocess, use expanded
> numbers rather than abbreviated numbers in the object filter spec (e.g.
> "limit:blob=1k" becomes "limit:blob=1024").
>
> Update the protocol docs to note that clients should always perform this
> expa
"Derrick Stolee via GitGitGadget" writes:
> From: Derrick Stolee
>
> When writing a commit-graph, we write GRAPH_MISSING_PARENT if the
> parent's object id does not appear in the list of commits to be
> written into the commit-graph. This was done as the initial design
> allowed commits to have
William Hubbs writes:
> Subject: Re: [PATCH 1/1] Add author and committer configuration settings
Perhaps something like this
Subject: config: allow giving separate author and committer idents
would fit better in "git shortlog --no-merges" output.
> The author.email, author.nam
When a submodule is renamed, git log gives incorrect output:
commit 350ebece9bce8d9c495f9a51e6f5529749c5c3cc (HEAD -> master)
Author:
David Turner
Date: Wed Jan 2 17:09:56 2019 -0500
move
diff --git a/.gitmodules b/.gitmodules
index da1a767..f4baf2a 100644
--- a/.gitmodules
+++ b/.gitmodu
randall.s.bec...@rogers.com writes:
> From: "Randall S. Becker"
>
> This fix was needed on HPE NonStop NSE and NSX where SSIZE_MAX is less than
> BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c
> was the only place outside of wrapper.c where it is used instead of xread.
Th
> -Original Message-
> From: Marc Balmer
> Sent: Monday, December 31, 2018 5:24 AM
> To: Duy Nguyen
> Cc: Git Mailing List ; Strain, Roger L.
> ; Junio C Hamano
> Subject: Re: Regression in git-subtree.sh, introduced in 2.20.1, after
> 315a84f9aa0e2e629b0680068646b0032518ebed
>
>
>
>
Stan Hu writes:
> - if (len < 4 || name[len-1] != '}')
> + if (len < 4)
> return -1;
The original does not expect any string given after the ^{}
dereferencer, like :, and that is why this function returns
very early for anything when name[len-1] is not a closing brace.
We
issac.tro...@gmail.com writes:
> From: Issac Trotts
I think you want to have
From: Issac Trotts
instead, so that the authorship actually matches your sign-off.
> - if (source) {
> + if (source || (rev->pretty_given && (rev->commit_format ==
> CMIT_FMT_USERFORMAT) && w.sourc
"brian m. carlson" writes:
> +test_expect_success SYMLINKS 'diff --no-index --literally with symlinks' '
> + test_write_lines a b c >f1 &&
> + test_write_lines a d c >f2 &&
> + ln -s f1 s1 &&
> + ln -s f2 s2 &&
> + cat >expect <<-\EOF &&
> + diff --git a/s1 b/s2
> + --
Tested-By: Carlo Marcelo Arenas Belón
"Stephen P. Smith" writes:
> +# Subtract some known constant time and look for expected field format
> +TODAY_REGEX='5 hours ago'
> +THIS_YEAR_REGEX='[A-Z][a-z][a-z] [A-Z][a-z][a-z] [0-9]*
> [012][0-9]:[0-6][0-9]'
> +MORE_THAN_A_YEAR_REGEX='[A-Z][a-z][a-z] [A-Z][a-z][a-z] [0-9]*
> [0-9][0-9][0-
On Tue, Jan 1, 2019 at 6:20 PM SZEDER Gábor wrote:
> [...]
> To my understanding both shells are right and conform to POSIX,
> because the standard allows both behavior by stating the following
s/behavior/behaviors/
> under '2.8.1 Consequences of Shell Errors':
>
> Reported-by: Max Kirillov
> S
On Wed, Jan 2, 2019 at 4:38 AM Eric Wong wrote:
>
> strncat() has the same quadratic behavior as strcat() and is
> difficult-to-read and bug-prone. While it hasn't yet been a
> problem in git iself, strncat() found it's way into 'master'
s/iself/itself/
> of cgit and caused segfaults on my syst
Ævar Arnfjörð Bjarmason writes:
> We do not have such a pre-upload hook, but could have one. There's an
> old thread from 2011 detailing some potential downsides:
>
> https://public-inbox.org/git/CAMK1S_jaEWV=f6ihkzw_6u5ncdw0bposnx-03w9bolofeee...@mail.gmail.com/
>
> FWIW I think most servers who
Johannes Sixt writes:
> Would it perhaps be simpler to just hide the syntax behind eval? Like
>
> if test -z "$test_untraceable" || {
>test -n "$BASH_VERSION" && eval '
> test ${BASH_VERSINFO[0]} -gt 4 || {
>test ${BAS
On Wed, Jan 2, 2019 at 3:08 AM Duy Nguyen wrote:
>
> On Wed, Jan 2, 2019 at 6:36 AM Anthony Sottile wrote:
> >
> > Here's a simple regression test -- haven't had time to bisect this
>
> I can't reproduce with either 2.20.0, 2.20.1 or 'master'. It would be
> great if you could bisect this.
>
> The
Hi Orgad,
On Sat, 29 Dec 2018, org...@gmail.com wrote:
> From: Orgad Shaneh
>
> The scripted version of rebase used to run this hook on the initial
> checkout. The transition to built-in introduced a regression.
>
> Signed-off-by: Orgad Shaneh
ACK!
For lurkers: there was a "pre-review" at
h
From: Pranit Bauva
Reimplement `bisect_next_check` shell function in C and add
`bisect-next-check` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
`bisect_voc` shell function is no longer useful now and is replaced by
using a char *[] of "new|bad" and "good|old" values.
Using
From: Pranit Bauva
Reimplement the `get_terms` and `bisect_terms` shell function in C and
add `bisect-terms` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
Using `--bisect-terms` subcommand is a temporary measure to port shell
function in C so as to use the existing test suit
Changes since Pranit's v16:
===
bisect--helper: bisect_reset shell function in C
* The return !printf(...); construct was considered unsafe and disentangled
into printf(...); return 0;
* It is more elegant to release br
From: Pranit Bauva
Reimplement the `bisect_start` shell function partially in C and add
`bisect-start` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
The last part is not converted because it calls another shell function.
`bisect_start` shell function will be completed after
From: Pranit Bauva
Reimplement `bisect_reset` shell function in C and add a `--bisect-reset`
subcommand to `git bisect--helper` to call it from git-bisect.sh .
Using `bisect_reset` subcommand is a temporary measure to port shell
functions to C so as to use the existing test suite. As more functi
From: Pranit Bauva
is_empty_file() can help to refactor a lot of code. This will be very
helpful in porting "git bisect" to C.
Suggested-by: Torsten Bögershausen
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/am.c | 20 ++--
From: Pranit Bauva
Reimplement the `bisect_write` shell function in C and add a
`bisect-write` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--bisect-write` subcommand is a temporary measure to port shell
function in C so as to use the existing test suite. As more funct
From: Pranit Bauva
Reimplement the `check_and_set_terms` shell function in C and add
`check-and-set-terms` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--check-and-set-terms` subcommand is a temporary measure to port
shell function in C so as to use the existing test s
On Wed, Jan 2, 2019 at 3:09 AM Albert Burt wrote:
>
> Remove TODO that was left in from:
> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
>
> Todo can be removed as:
> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
> deletes commit->util.
>
> Signed
On Wed, Jan 2, 2019 at 6:36 AM Anthony Sottile wrote:
>
> Here's a simple regression test -- haven't had time to bisect this
I can't reproduce with either 2.20.0, 2.20.1 or 'master'. It would be
great if you could bisect this.
There are no suspicious commits from 2.27.1 touching
builtin/checkout
strncat() has the same quadratic behavior as strcat() and is
difficult-to-read and bug-prone. While it hasn't yet been a
problem in git iself, strncat() found it's way into 'master'
of cgit and caused segfaults on my system.
Signed-off-by: Eric Wong
---
banned.h | 2 ++
1 file changed, 2 insert
> [...]
>
>>
>
> Hmm.. I'm not that familiar with git-subtree.sh, so here's one last
> blind shot.
>
> There's a format change between git-show and git-rev-parse. The former
> separates commits by spaces while the latter by newlines. Will this
> help?
>
> diff --git a/contrib/subtree/git-su
49 matches
Mail list logo
