Re: "IMAP IDLE"-like long-polling "git fetch"

2018-12-28 Thread Eric Wong
Konstantin Ryabitsev wrote: > On Sat, Dec 29, 2018 at 03:56:21AM +, Eric Wong wrote: > > Hey all, I just added this to the TODO file for public-inbox[1] but > > obviously it's intended for git.git (meta@public-inbox cc-ed): > > > > > +* Contribute something like IMAP IDLE for "git fetch". > >

[PATCH v3] sha1-name.c: Fix handling of revisions that contain paths with brackets

2018-12-28 Thread Stan Hu
Previously, calling ls-tree with a revision such as `master^{tree}:foo/{{path}}` would show the root tree instead of the correct tree pointed by foo/{{path}}. We improve this by ensuring peel_onion() consumes all "len" characters or none. Note that it's also possible to have directories named ^{tr

Re: [PATCH 1/2] t5403: Refactor

2018-12-28 Thread Ramsay Jones
On 28/12/2018 22:34, Junio C Hamano wrote: > org...@gmail.com writes: > >> Subject: Re: [PATCH 1/2] t5403: Refactor > [snip] >> if test "$(git config --bool core.filemode)" = true; then > > This is a tangent but this conditional came from an ancient d42ec126 > ("disable post-checkout test on

Re: "IMAP IDLE"-like long-polling "git fetch"

2018-12-28 Thread Konstantin Ryabitsev
On Sat, Dec 29, 2018 at 03:56:21AM +, Eric Wong wrote: > Hey all, I just added this to the TODO file for public-inbox[1] but > obviously it's intended for git.git (meta@public-inbox cc-ed): > > > +* Contribute something like IMAP IDLE for "git fetch". > > + Inboxes (and any git repos) can be

"IMAP IDLE"-like long-polling "git fetch"

2018-12-28 Thread Eric Wong
Hey all, I just added this to the TODO file for public-inbox[1] but obviously it's intended for git.git (meta@public-inbox cc-ed): > +* Contribute something like IMAP IDLE for "git fetch". > + Inboxes (and any git repos) can be kept up-to-date without > + relying on polling. I would've thought

Re: a git svn bug

2018-12-28 Thread Eric Wong
肖建晶 <06271...@bjtu.edu.cn> wrote: > hi, >git developers. I found a bug when i want to convert webkit to git >there are some branch named safari... in webkit svn repo. >when i want to convert them to branch in git. a problem happen. > >if you want to reproduce the problem, just foll

[PATCH v4 1/4] transport-helper: use xread instead of read

2018-12-28 Thread randall . s . becker
From: "Randall S. Becker" This fix was needed on HPE NonStop NSE and NSX where SSIZE_MAX is less than BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c was the only place outside of wrapper.c where it is used instead of xread. Signed-off-by: Randall S. Becker --- transport

Re: [PATCH] completion: escape metacharacters when completing paths

2018-12-28 Thread Junio C Hamano
Chayoung You writes: > Subject: Re: [PATCH] completion: escape metacharacters when completing paths I am not a zsh user, but from the patch text I am getting the impression that this patch is only about zsh. If so, please help readers of "git shortlog" by saying so in the title. Subjec

Re: [PATCH 2/2] Rebase: Run post-checkout hook on checkout

2018-12-28 Thread Junio C Hamano
org...@gmail.com writes: > From: Orgad Shaneh > Re: [PATCH 2/2] Rebase: Run post-checkout hook on checkout There is no explanation here? Is this a regression fix (i.e. scripted version of "rebase" used to run the hook)? Or a new feature (i.e. no earlier version of "rebase" run the hook but

Re: [PATCH 1/2] t5403: Refactor

2018-12-28 Thread Junio C Hamano
org...@gmail.com writes: > Subject: Re: [PATCH 1/2] t5403: Refactor Hmph. "Refactor" alone leaves readers wondering "refactor what?", "refactor for what?" and "refactor how?". Given that the overfall goal this change seeks seems to be to simplify it by losing about 20 lines, how about justifyin

Re: [PATCH 0/2] Improve documentation on UTF-16

2018-12-28 Thread Philip Oakley
On 28/12/2018 08:59, Johannes Sixt wrote: Am 28.12.18 um 00:45 schrieb brian m. carlson: On Thu, Dec 27, 2018 at 08:55:27PM +0100, Johannes Sixt wrote: But why do you add another U+FEFF on the way to UTF-8? There is one in the incoming UTF-16 data, and only *that* one must be converted. If the

RE: [PATCH v1 1/4] transport-helper: use xread instead of read

2018-12-28 Thread Randall S. Becker
On December 28, 2018 15:11, Junio C Hamano wrote: > randall.s.bec...@rogers.com writes: > > > From: "Randall S. Becker" > > > > This fix was needed on HPE NonStop NSE and NSX where SSIZE_MAX is less > > than BUFFERSIZE resulting in EINVAL. The call to read in > > transport-helper.c was the only

Re: [PATCH 0/2] Improve documentation on UTF-16

2018-12-28 Thread Philip Oakley
On 28/12/2018 08:46, Ævar Arnfjörð Bjarmason wrote: On Thu, Dec 27 2018, brian m. carlson wrote: We've recently fielded several reports from unhappy Windows users about our handling of UTF-16, UTF-16LE, and UTF-16BE, none of which seem to be suitable for certain Windows programs. Just for cont

RE: [PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config.

2018-12-28 Thread Randall S. Becker
On December 28, 2018 15:07, Junio C Hamano > "Randall S. Becker" writes: > > > On December 27, 2018 12:03, Eric Sunshine wrote: > >> On Wed, Dec 26, 2018 at 6:05 PM wrote: > >> > A number of configuration options are not automatically detected by > >> > configure mechanisms, including the locati

Re: ag/sequencer-reduce-rewriting-todo, was Re: What's cooking in git.git (Dec 2018, #02; Fri, 28)

2018-12-28 Thread Junio C Hamano
Alban Gruin writes: >> With too many topics in-flight that touch sequencer and rebaser, >> this need to wait giving precedence to other topics that fix bugs. >> > > Most of these topics have reached master and have been released in git > 2.20. Currently, there is four topics actually touching

Re: [PATCH v3] log -G: ignore binary files

2018-12-28 Thread Junio C Hamano
Thomas Braun writes: > - The internally used algorithm for generating patch text is based on > xdiff and its states in [1] > > > The output format of the binary patch file is proprietary > > (and binary) and it is basically a collection of copy and insert > > commands [..] > > which mea

Re: [PATCH v12 04/26] ident: add the ability to provide a "fallback identity"

2018-12-28 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Wed, 26 Dec 2018, Junio C Hamano wrote: > >> Paul-Sebastian Ungureanu writes: >> >> > +static void set_env_if(const char *key, const char *value, int *given, >> > int bit) >> > +{ >> > + if ((*given & bit) || getenv(key)) >> > + return;

Re: [PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config.

2018-12-28 Thread Junio C Hamano
"Randall S. Becker" writes: > On December 27, 2018 12:03, Eric Sunshine wrote: >> On Wed, Dec 26, 2018 at 6:05 PM wrote: >> > A number of configuration options are not automatically detected by >> > configure mechanisms, including the location of Perl and Python. >> > [...] >> > Signed-off-by: R

Re: [PATCH] imap-send: Fix compilation without deprecated OpenSSL APIs

2018-12-28 Thread Junio C Hamano
Rosen Penev writes: > On Wed, Dec 26, 2018 at 10:32 PM Junio C Hamano wrote: >> >> Rosen Penev writes: >> >> > Initialization in OpenSSL has been deprecated in version 1.1. >> >> https://www.openssl.org/docs/man1.0.2/ssl/SSL_library_init.html says >> >> SSL_library_init() must be called

Re: [PATCH v2 1/6] ref-filter: add objectsize:disk option

2018-12-28 Thread Junio C Hamano
Olga Telezhnaya writes: > @@ -880,7 +886,10 @@ static void grab_common_values(struct atom_value *val, > int deref, struct expand_ > name++; > if (!strcmp(name, "objecttype")) > v->s = xstrdup(type_name(oi->type)); > - else if

Re: [PATCH v2 0/4] Allow 'cherry-pick -m 1' for non-merge commits

2018-12-28 Thread Junio C Hamano
Sergey Organov , Sergey Organov writes: > Hi Junio, > > What's the status of these patches? The status of these patches is "Just updated on the list", as far as I am concerned, and its cover letter would have described what's improved relative to the previous round better than whatever answer I

Re: [PATCH 1/4] submodule update: add regression test with old style setups

2018-12-28 Thread Junio C Hamano
Stefan Beller writes: > The place to add such a regression test may look odd in t7412, but > that is the best place as there we setup old style submodule setups > explicitly. Makes sense; thanks. > > Signed-off-by: Stefan Beller > --- > t/t7412-submodule-absorbgitdirs.sh | 7 ++- > 1 file

Re: [PATCH 00/23] sb/more-repo-in-api

2018-12-28 Thread Junio C Hamano
Stefan Beller writes: > I realized next has not been rewound, so I can resend sb/more-repo-in-api, > which I hereby do. The changes are minimal and address the only comment > by Jonathan so far. Yeah, the only change I see matches what is in your range-diff after applying them to my tree. Will

Re: [PATCH 2/4] submodule: unset core.worktree if no working tree is present

2018-12-28 Thread Junio C Hamano
Stefan Beller writes: > 2018-09-07). The revert was needed as the nearby commit e98317508c > (submodule: ensure core.worktree is set after update, 2018-06-18) is > faulty and at the time of 7e25437d35 (Merge branch > 'sb/submodule-core-worktree', 2018-07-18) we could not revert the faulty > commi

Re: [PATCH v1 1/4] transport-helper: use xread instead of read

2018-12-28 Thread Junio C Hamano
randall.s.bec...@rogers.com writes: > From: "Randall S. Becker" > > This fix was needed on HPE NonStop NSE and NSX where SSIZE_MAX is less than > BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c > was the only place outside of wrapper.c where it is used instead of xread. > >

[PATCH v4 2/4] config.mak.uname: support for modern HPE NonStop config.

2018-12-28 Thread randall . s . becker
From: "Randall S. Becker" A number of configuration options are not automatically detected by configure mechanisms, including the location of Perl and Python. There was a problem at a specific set of operating system versions that caused getopt to have compile errors. Account for this by providi

RE: [PATCH v3 2/4] config.mak.uname: support for modern HPE NonStop config.

2018-12-28 Thread Randall S. Becker
On December 28, 2018 14:43, Eric Sunshine wrote: > On Thu, Dec 27, 2018 at 5:39 PM wrote: > > A number of configuration options are not automatically detected by > > configure mechanisms, including the location of Perl and Python. > > > > There was a problem at a specific set of operating system v

Re: [PATCH 2/2] Unset CURLOPT_FAILONERROR

2018-12-28 Thread Masaya Suzuki
On Fri, Dec 28, 2018 at 11:58 AM Eric Sunshine wrote: > > On Fri, Dec 28, 2018 at 2:51 PM Masaya Suzuki wrote: > > On Fri, Dec 28, 2018 at 11:37 AM Eric Sunshine > > wrote: > > > On Thu, Dec 27, 2018 at 8:47 PM Masaya Suzuki > > > wrote: > > > > +test_expect_success 'failure in git-upload-pac

Re: [PATCH v2] sha1-name.c: Fix handling of revisions that contain paths with brackets

2018-12-28 Thread Junio C Hamano
Duy Nguyen writes: > Note that it also shows another corner case we need to be careful > about: master^{/regex} syntax _can_ contain colons in regex. I suppose > doing strchr to find the closing '}' here is better than what I did > below. Yes, the posted patch breaks master^{/foo:bar}, I suppose

Re: [PATCH 2/2] Unset CURLOPT_FAILONERROR

2018-12-28 Thread Eric Sunshine
On Fri, Dec 28, 2018 at 2:51 PM Masaya Suzuki wrote: > On Fri, Dec 28, 2018 at 11:37 AM Eric Sunshine > wrote: > > On Thu, Dec 27, 2018 at 8:47 PM Masaya Suzuki > > wrote: > > > +test_expect_success 'failure in git-upload-pack is shown' ' > > > + (GIT_CURL_VERBOSE=1 git clone --bare > >

Re: [PATCH 2/2] Unset CURLOPT_FAILONERROR

2018-12-28 Thread Masaya Suzuki
On Fri, Dec 28, 2018 at 11:37 AM Eric Sunshine wrote: > > On Thu, Dec 27, 2018 at 8:47 PM Masaya Suzuki wrote: > > When GIT_CURL_VERBOSE is set, libcurl produces request/response headers > > to stderr. However, if the response is an error response and > > CURLOPT_FAILONERROR is set, libcurl stops

Re: [PATCH v3 2/4] config.mak.uname: support for modern HPE NonStop config.

2018-12-28 Thread Eric Sunshine
On Thu, Dec 27, 2018 at 5:39 PM wrote: > A number of configuration options are not automatically detected by > configure mechanisms, including the location of Perl and Python. > > There was a problem at a specific set of operating system versions > that caused getopt to have compile errors. Accoun

Re: [PATCH v3 06/16] sequencer: refactor sequencer_add_exec_commands() to work on a todo_list

2018-12-28 Thread Alban Gruin
Hi Phillip and Johannes, many thanks for your suggestions and feedback, I really appreciate it. Le 10/12/2018 à 15:33, Phillip Wood a écrit : > On 30/11/2018 19:06, Johannes Schindelin wrote: >> Hi, >> >> On Fri, 30 Nov 2018, Phillip Wood wrote: >> diff --git a/sequencer.c b/sequencer.c

Re: [PATCH 2/2] Unset CURLOPT_FAILONERROR

2018-12-28 Thread Eric Sunshine
On Thu, Dec 27, 2018 at 8:47 PM Masaya Suzuki wrote: > When GIT_CURL_VERBOSE is set, libcurl produces request/response headers > to stderr. However, if the response is an error response and > CURLOPT_FAILONERROR is set, libcurl stops parsing the response, and it > won't ump the headers. Showing HT

ag/sequencer-reduce-rewriting-todo, was Re: What's cooking in git.git (Dec 2018, #02; Fri, 28)

2018-12-28 Thread Alban Gruin
Hi Junio, Le 28/12/2018 à 19:04, Junio C Hamano a écrit : > * ag/sequencer-reduce-rewriting-todo (2018-11-12) 16 commits > . rebase--interactive: move transform_todo_file() to rebase--interactive.c > . sequencer: fix a call to error() in transform_todo_file() > . sequencer: use edit_todo_list()

Re: What's cooking in git.git (Dec 2018, #02; Fri, 28)

2018-12-28 Thread Elijah Newren
On Fri, Dec 28, 2018 at 10:04 AM Junio C Hamano wrote: > Sorry for being slow to recover from the year-end slowness; the 2.20 > release being rather large-ish and needed brown-paper-bag fixes soon > after it, my temporary trans-pacific migration, or me catching cold > that I haven't shaken off, di

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-28 Thread Junio C Hamano
Derrick Stolee writes: >> +++ b/Documentation/pretty-formats.txt >> @@ -134,6 +134,8 @@ The placeholders are: >> - '%cI': committer date, strict ISO 8601 format >> - '%d': ref names, like the --decorate option of linkgit:git-log[1] >> - '%D': ref names without the " (", ")" wrapping. >> +-

What's cooking in git.git (Dec 2018, #02; Fri, 28)

2018-12-28 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. The current state is that 'next' h

Re: RFE: version-controlled merge rules

2018-12-28 Thread Duy Nguyen
On Fri, Dec 28, 2018 at 4:46 PM H. Peter Anvin wrote: > > On 12/27/18 3:55 PM, Jonathan Nieder wrote: > > Hi, > > > > H. Peter Anvin wrote: > > > >> [merge "version"] > >> name = Version file merge driver > >> driver = sort -V -r %O %A %B | head -1 > %A.tmp.1 && mv -f > >> %A.tmp.

Re: Can git choose perl at runtime?

2018-12-28 Thread John Passaro
On Sun, Dec 23, 2018 at 9:20 PM brian m. carlson wrote: > > I think we should just ask Homebrew to ship a functional, complete Git. They are doing just that: https://github.com/Homebrew/homebrew-core/pull/35446 If for some reason this patch doesn't make it in, I'll keep bugging them about it, but

Re: RFE: version-controlled merge rules

2018-12-28 Thread Junio C Hamano
Jonathan Nieder writes: > The main issue I see is that this would make it a little *too* easy to > run arbitrary code on the user's machine. Build systems often already > lead to that, but users are more familiar with the risks for build > than for version control. > > See [1] for some related d

Re: Bug in git-remote

2018-12-28 Thread SZEDER Gábor
On Mon, Dec 17, 2018 at 01:50:56PM +0100, Johannes Schindelin wrote: > Hi Gábor, > > On Sat, 15 Dec 2018, SZEDER Gábor wrote: > > > On Sat, Dec 15, 2018 at 02:14:56AM -0500, Gennady Uraltsev wrote: > > > I am on git version 2.20.0 > > > > > > $ git remote > > > > > > does not show remotes confi

Re: [PATCH 0/2] Improve documentation on UTF-16

2018-12-28 Thread Johannes Sixt
Am 28.12.18 um 00:45 schrieb brian m. carlson: On Thu, Dec 27, 2018 at 08:55:27PM +0100, Johannes Sixt wrote: But why do you add another U+FEFF on the way to UTF-8? There is one in the incoming UTF-16 data, and only *that* one must be converted. If there is no U+FEFF in the UTF-16 data, the shou

Re: [PATCH 0/2] Improve documentation on UTF-16

2018-12-28 Thread Ævar Arnfjörð Bjarmason
On Thu, Dec 27 2018, brian m. carlson wrote: > We've recently fielded several reports from unhappy Windows users about > our handling of UTF-16, UTF-16LE, and UTF-16BE, none of which seem to be > suitable for certain Windows programs. Just for context, is "we" here $DAYJOB or a reference to som

Re: RFE: version-controlled merge rules

2018-12-28 Thread Ævar Arnfjörð Bjarmason
On Thu, Dec 27 2018, H. Peter Anvin wrote: > Right now, merge rules can get selected in .gitattributes, which is > version-controlled. However, there does not appear to be any way to *define* > custom merge rules which is version controlled. > > There are a lot of different files which can benef