[PATCH] Specify -Wformat along with -Wformat-security

2018-12-26 Thread Masaya Suzuki
Without -Wformat, -Wformat-security won't work. > cc1: error: -Wformat-security ignored without -Wformat > [-Werror=format-security] Signed-off-by: Masaya Suzuki --- config.mak.dev | 1 + 1 file changed, 1 insertion(+) diff --git a/config.mak.dev b/config.mak.dev index bbeeff44f..aae9db67d 10

[PATCH] Use packet_reader instead of packet_read_line

2018-12-26 Thread Masaya Suzuki
By using and sharing a packet_reader while handling a Git pack protocol request, the same reader option is used throughout the code. This makes it easy to set a reader option to the request parsing code. Signed-off-by: Masaya Suzuki --- builtin/archive.c | 19 ++--- builtin/receive-

Re: [PATCH] imap-send: Fix compilation without deprecated OpenSSL APIs

2018-12-26 Thread Junio C Hamano
Rosen Penev writes: > Initialization in OpenSSL has been deprecated in version 1.1. https://www.openssl.org/docs/man1.0.2/ssl/SSL_library_init.html says SSL_library_init() must be called before any other action takes place. https://www.openssl.org/docs/man1.1.0/ssl/SSL_library

RE: git-rebase is ignoring working-tree-encoding

2018-12-26 Thread Alexandre Grigoriev
> -Original Message- > From: brian m. carlson [mailto:sand...@crustytoothpaste.net] > Sent: Wednesday, December 26, 2018 11:25 AM > To: Alexandre Grigoriev > Cc: 'Torsten Bögershausen'; 'Adrián Gimeno Balaguer'; git@vger.kernel.org > Subject: Re: git-rebase is ignoring working-tree-encodi

[PATCH] imap-send: Fix compilation without deprecated OpenSSL APIs

2018-12-26 Thread Rosen Penev
Initialization in OpenSSL has been deprecated in version 1.1. This makes compilation fail when deprecated APIs for OpenSSL are compile-time disabled. Signed-off-by: Rosen Penev --- imap-send.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/imap-send.c b/imap-send.c index b4eb886e2..21f741

[PATCH 1/2] Documentation: document UTF-16-related behavior

2018-12-26 Thread brian m. carlson
There are a number of broken Windows programs which want to process files in a UTF-16 variant that is always little endian and always contains a BOM. Git cannot produce or accept such an encoding for the working-tree-encoding because no such encoding has been defined with IANA or implemented in ico

[PATCH 0/2] Improve documentation on UTF-16

2018-12-26 Thread brian m. carlson
We've recently fielded several reports from unhappy Windows users about our handling of UTF-16, UTF-16LE, and UTF-16BE, none of which seem to be suitable for certain Windows programs. In an effort to communicate the reasons for our behavior more effectively, explain in the documentation that the U

[PATCH 2/2] utf8: add comment explaining why BOMs are rejected

2018-12-26 Thread brian m. carlson
A source of confusion for many Git users is why UTF-16LE and UTF-16BE do not allow a BOM, instead treating it as a ZWNBSP, according to the Unicode FAQ[0]. Explain in a comment why we cannot allow that to occur due to our use of UTF-8 internally. [0] https://unicode.org/faq/utf_bom.html#bom9 Sign

[PATCH v1 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop

2018-12-26 Thread randall . s . becker
From: "Randall S. Becker" The HPE NonStop (a.k.a. __TANDEM) platform cannot build git without using the FLOSS package supplied by HPE. The convenient location for including the relevant headers is in this file. The NSIG define is also not defined on __TANDEM, so we define it here as 100 if it is

[PATCH v1 0/4] HPE NonStop Port Commits

2018-12-26 Thread randall . s . becker
From: "Randall S. Becker" This set of patches is a distilled version of the minimal set of changes to git that will allow it to run as client and server on HPE NonStop NSE and NSX systems. NSR systems are no longer under support so references to them have been removed. Each patch in this set is i

[PATCH v1 4/4] compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStop

2018-12-26 Thread randall . s . becker
From: "Randall S. Becker" The system definition header files on HPE NonStop do not define intptr_t and uintptr_t as do other platforms. These typedefs are added specifically wrapped in a __TANDEM ifdef. Signed-off-by: Randall S. Becker --- compat/regex/regcomp.c | 8 1 file changed, 8

[PATCH v1 1/4] transport-helper: use xread instead of read

2018-12-26 Thread randall . s . becker
From: "Randall S. Becker" This fix was needed on HPE NonStop NSE and NSX where SSIZE_MAX is less than BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c was the only place outside of wrapper.c where it is used instead of xread. Signed-off-by: Randall S. Becker --- transport

[PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config.

2018-12-26 Thread randall . s . becker
From: "Randall S. Becker" A number of configuration options are not automatically detected by configure mechanisms, including the location of Perl and Python. There was a problem at a specific set of operating system versions that caused getopt to have compile errors. Accounted for this by provi

Re: [PATCH v4 0/3] Add commit-graph fuzzer and fix buffer overflow

2018-12-26 Thread Junio C Hamano
Jeff King writes: > On Tue, Dec 18, 2018 at 01:05:51PM -0800, Josh Steadmon wrote: > >> On 2018.12.18 12:35, Jeff King wrote: >> > On Thu, Dec 13, 2018 at 11:43:55AM -0800, Josh Steadmon wrote: >> > >> > > Add a new fuzz test for the commit graph and fix a buffer read-overflow >> > > that it dis

Re: [PATCH v2] Simplify handling of setup_git_directory_gently() failure cases.

2018-12-26 Thread Junio C Hamano
Jeff King writes: > On Tue, Dec 18, 2018 at 12:54:02PM -0800, Erin Dahlgren wrote: > ... >> GIT_DIR_HIT_MOUNT_POINT. I'm not sure how important of a guarantee it >> is, but we should respect what's documented. > > Yeah, agreed. > > Another benefit of avoiding the early return is that we hit the c

Re: [PATCH v2 8/8] tests: mark tests broken under GIT_TEST_PROTOCOL_VERSION=2

2018-12-26 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > The genreal ways I see forward from that are: > > A) Say that v2 has a security issue and that this is a feature that > works in some circumstances, but given Jeff's explanation here we > should at least improve our "SECURITY" docs to be less handwaivy.

Re: Parsing trailers

2018-12-26 Thread William Chargin
> Yeah, but you can perhaps check that the input doesn't contain '|' > before doing the above. If it does contain '|' then you can probably > find another char that it doesn't contain and use that char instead of > '|'. This sounds true in the usual case, though of course there are pathological ca

Re: [PATCH v12 04/26] ident: add the ability to provide a "fallback identity"

2018-12-26 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > +static void set_env_if(const char *key, const char *value, int *given, int > bit) > +{ > + if ((*given & bit) || getenv(key)) > + return; /* nothing to do */ > + setenv(key, value, 0); > + *given |= bit; > +} We call setenv(3) with ove

Reg SVN to Git Migration

2018-12-26 Thread Kodavati, Anilchowdari
Hi, I am getting below error while doing migration from svn to git. Is there a solution available to over this issue. Can you please help here to solve this issue. Error details:- Software caused connection abort: Error running context: Software caused connection abort at C:/Program Files/Git/

Re: git-rebase is ignoring working-tree-encoding

2018-12-26 Thread brian m. carlson
On Tue, Dec 25, 2018 at 04:56:11PM -0800, Alexandre Grigoriev wrote: > Many tools in Windows still do not understand UTF-8, although it's getting > better. I think Windows is about the only OS where tools still require > UTF-16 for full internationalization. > Many tools written in C use MSVC RTL,

Re: [PATCH] doc: improve grammar in git-update-index

2018-12-26 Thread Junio C Hamano
Philip Oakley writes: > On 14/12/2018 21:25, Anthony Sottile wrote: >> Signed-off-by: Anthony Sottile >> --- >> Documentation/git-update-index.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/git-update-index.txt >> b/Documentation/git-update-inde

[PATCH v2] completion: fix typo in git-completion.bash

2018-12-26 Thread Chayoung You
Signed-off-by: Chayoung You --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 9e8ec95c3..86a9719a5 100644 --- a/contrib/completion/git-completion.bas

[PATCH] completion: fix typo in git-completion.bash

2018-12-26 Thread Chayoung You
--- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 9e8ec95c3..86a9719a5 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/gi

[PATCH] completion: escape metacharacters when completing paths

2018-12-26 Thread Chayoung You
The following is the description of -Q flag of zsh compadd [1]: This flag instructs the completion code not to quote any metacharacters in the words when inserting them into the command line. Let's say there is a file named 'foo bar.txt' in repository, but it's not yet added to the repository

[Bug] t0410 breakages at 2.20.1 on NonStop platform

2018-12-26 Thread Randall S. Becker
Hi All, We’re getting some new breakages in t0410 that I can’t explain easily or either it is the test itself at commit 0d0ac3826a. [Filtered] *** t0410-partial-clone.sh *** not ok 5 - missing ref object, but promised, passes fsck not ok 6 - missing object, but promised, passes fsck not ok 7 - m

Missed Commit in 2.20.1

2018-12-26 Thread Randall S. Becker
On April 2, 2018 4:02 PM, Stefan Beller found my change: > On Mon, Apr 2, 2018 at 12:57 PM, Randall S. Becker > wrote: > > On April 2, 2018 3:34 PM, Junio C Hamano wrote: > >> The latest feature release Git v2.17.0 is now available at the usual > >> places. It is comprised of 516 non-merge commit