Re: Parsing trailers

2018-12-25 Thread Christian Couder
Hi William, On Mon, Dec 24, 2018 at 7:52 PM William Chargin wrote: > > Hi Christian: thanks for your reply. > > > Changing the default separator as shown above, should make it easier > > to parse the result. > > But this actually also changes which lines are considered trailers, > right? Yes. >

RE: git-rebase is ignoring working-tree-encoding

2018-12-25 Thread Alexandre Grigoriev
> -Original Message- > From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On > Behalf Of Torsten Bogershausen > Sent: Thursday, November 8, 2018 9:03 AM > To: Adrián Gimeno Balaguer > Cc: git@vger.kernel.org > Subject: Re: git-rebase is ignoring working-tree-encoding > > On

[PATCH v5 4/4] merge: add scissors line on merge conflict

2018-12-25 Thread Denton Liu
This fixes a bug where the scissors line is placed after the Conflicts: section, in the case where a merge conflict occurs and commit.cleanup = scissors. Next, if commit.cleanup = scissors is specified, don't produce a scissors line in commit if one already exists in the MERGE_MSG file. Signed-of

[PATCH v5 3/4] merge: cleanup messages like commit

2018-12-25 Thread Denton Liu
This change allows git-merge messages to be cleaned up with the commit.cleanup configuration or --cleanup option, just like how git-commit does it. We also give git-pull the passthrough option of --cleanup so that it can also take advantage of this change. Finally, add testing to ensure that mess

[PATCH v5 2/4] t7600: clean up 'merge --squash c3 with c7' test

2018-12-25 Thread Denton Liu
This cleans up the original test by removing some unnecessary braces and removing a pipe. Helped-by: SZEDER Gábor Signed-off-by: Denton Liu --- t/t7600-merge.sh | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/t/t7600-merge.sh b/t/t7600-merge.sh index 106148254d..d879e

[PATCH v5 1/4] commit: extract cleanup_mode functions to sequencer

2018-12-25 Thread Denton Liu
Signed-off-by: Denton Liu --- builtin/commit.c | 21 ++--- sequencer.c | 29 + sequencer.h | 4 3 files changed, 35 insertions(+), 19 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index c021b119bb..9eb745b7ce 100644 ---

[PATCH v5 0/4] Add git-merge --cleanup support

2018-12-25 Thread Denton Liu
Merry Christmas, everyone! I've finally had some free time to throw together the changes I promised a couple weeks ago, so now git-merge will support --cleanup just like git-commit. Not related to this but while I was making my changes, I noticed that -F and -m don't die properly in git-merge whe

Re: [PATCH v2 0/4] Allow 'cherry-pick -m 1' for non-merge commits

2018-12-25 Thread Sergey Organov
Hi Junio, What's the status of these patches? Thanks, -- Sergey Sergey Organov writes: > When cherry-picking multiple commits, it's impossible to have both > merge- and non-merge commits on the same command-line. Not specifying > '-m 1' results in cherry-pick refusing to handle merge commits,

Re: [PATCH v2 1/1] abspath_part_inside_repo: respect core.fileMode

2018-12-25 Thread Torsten Bögershausen
Should it be s/respect core.fileMode/respect core.ignoreCase/ in the header line ?

Re: [PATCH v3 1/1] abspath_part_inside_repo: respect core.fileMode

2018-12-25 Thread Junio C Hamano
Junio C Hamano writes: > the resulting index entry is "blub" or "BLUB". Shouldn't we verify > that "git add" adds an expected path to the index, instead of > blindly trusting that it says "Yeah, I did as I was told" with its > exit status? Would we be adding 'blub' as that is what we told > 'gi