Re: [PATCH v4] http-backend: allow empty CONTENT_LENGTH

Max Kirillov wrote: > Reported-By: Jelmer Vernooij > Authored-by: Jeff King > Signed-off-by: Max Kirillov Nit: for this kind of case of forwarding someone else's patch, we put a From field at the beginning of the body of the message. "git format-patch" can produce a message with that format if

Re: [PATCH v3] http-backend: allow empty CONTENT_LENGTH

From: Max Kirillov Subject: http-backend test: make empty CONTENT_LENGTH test more realistic This is a test of smart HTTP, so it should use the smart HTTP endpoints (e.g. /info/refs?service=git-receive-pack), not dumb HTTP (HEAD). Signed-off-by: Max Kirillov Signed-off-by: Jonathan Nieder ---

Re: [PATCH 1/6] t/helper: keep test-tool command list sorted

On Sun, Sep 09, 2018 at 07:36:26PM +0200, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Makefile | 2 +- > t/helper/test-tool.c | 2 +- > t/helper/test-tool.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile >

Re: [Possible GIT Bug]

On Sun, Sep 9, 2018 at 6:31 AM Dylan Young wrote: > > Works: > > git show -C --find-copies-harder 055f6c89fa4506037d1621761f13430f469b8029 > > git show -C --find-copies-harder > 055f6c89fa4506037d1621761f13430f469b8029 --name-status Here, because you didn't provide _any_ paths, Git is allowed to

Re: [PATCH 0/6] Merge remaining t/helper binaries to test-tool

On Sun, Sep 9, 2018 at 8:09 PM Ævar Arnfjörð Bjarmason wrote: > > > On Sun, Sep 09 2018, Nguyễn Thái Ngọc Duy wrote: > > > Last time when I added test-tool in 27f25845cf (Merge branch > > 'nd/combined-test-helper' - 2018-04-11) I left out a few test programs > > because there were a couple in-flig

Re: [PATCH 0/6] Merge remaining t/helper binaries to test-tool

On Sun, Sep 09 2018, Nguyễn Thái Ngọc Duy wrote: > Last time when I added test-tool in 27f25845cf (Merge branch > 'nd/combined-test-helper' - 2018-04-11) I left out a few test programs > because there were a couple in-flight new tests that used them. All > those topics are merged now. So we can

[PATCH 6/6] Makefile: add a hint about TEST_BUILTINS_OBJS

Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index ea7454632d..39d39257e0 100644 --- a/Makefile +++ b/Makefile @@ -744,6 +744,8 @@ TEST_BUILTINS_OBJS += test-urlmatch-normalization.o TEST_BUILTINS_OBJS += test-wildmatc

[PATCH 5/6] t/helper: merge test-dump-fsmonitor into test-tool

Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-dump-fsmonitor.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t7519-status-fsmonitor.sh| 10 +- 5 files changed, 10 insertions(+), 7 deletions(-)

[PATCH 3/6] t/helper: merge test-pkt-line into test-tool

Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-pkt-line.c | 3 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t5701-git-serve.sh | 36 +++--- t/t5702-pr

[PATCH 2/6] t/helper: merge test-dump-untracked-cache into test-tool

Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-dump-untracked-cache.c | 3 +- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t7063-status-untracked-cache.sh| 68 ++-- t/t

[PATCH 4/6] t/helper: merge test-parse-options into test-tool

Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-parse-options.c | 5 ++- t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0040-parse-options.sh | 70 +-- 5 files changed, 41 insertions

[PATCH 0/6] Merge remaining t/helper binaries to test-tool

Last time when I added test-tool in 27f25845cf (Merge branch 'nd/combined-test-helper' - 2018-04-11) I left out a few test programs because there were a couple in-flight new tests that used them. All those topics are merged now. So we can merge these to test-tool and call it done. Nguyễn Thái Ngọc

[PATCH 1/6] t/helper: keep test-tool command list sorted

Signed-off-by: Nguyễn Thái Ngọc Duy --- Makefile | 2 +- t/helper/test-tool.c | 2 +- t/helper/test-tool.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 5a969f5830..1208584fa1 100644 --- a/Makefile +++ b/Makefile @@ -729,8 +729,8 @@ T

Re: [PATCH v6 17/21] range-diff: populate the man page

On Sun, Sep 09 2018, SZEDER Gábor wrote: > On Sun, Sep 09, 2018 at 01:14:25PM +0200, Ævar Arnfjörð Bjarmason wrote: >> >> On Mon, Aug 13 2018, Johannes Schindelin via GitGitGadget wrote: >> >> I realize this topic has long since landed, just seemed like a good >> thing to reply to to ask this qu

Re: [PATCH v6 17/21] range-diff: populate the man page

On Sun, Sep 09, 2018 at 01:14:25PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Aug 13 2018, Johannes Schindelin via GitGitGadget wrote: > > I realize this topic has long since landed, just seemed like a good > thing to reply to to ask this question: > > > [...] > > + ( | ... |) > >

Re: Temporary git files for the gitdir created on a separate drive in workdir

Since this thread started I haven't seen a single file mentioned being created, Usually they appear during work days when there is more activity. I've never seen the files created directly, only a larger amount of them once in a while. I will run process monitor and get back once I find out more.

[GIT PULL] l10n updates for 2.19.0 round 2

Hi Junio, The following changes since commit 2f743933341f27603550fbf383a34dfcfd38: Git 2.19-rc1 (2018-08-28 12:01:01 -0700) are available in the Git repository at: git://github.com/git-l10n/git-po tags/l10n-2.19.0-rnd2 for you to fetch changes up to c1ac5258dccbb62438c8df73d728271f7a31

Fwd: [Possible GIT Bug]

Works: git show -C --find-copies-harder 055f6c89fa4506037d1621761f13430f469b8029 git show -C --find-copies-harder 055f6c89fa4506037d1621761f13430f469b8029 --name-status Doesn’t Work: git show -C --find-copies-harder 055f6c89fa4506037d1621761f13430f469b8029 -- PATH_TO_MY_COPIED_FILE

Re: [PATCH v6 17/21] range-diff: populate the man page

On Mon, Aug 13 2018, Johannes Schindelin via GitGitGadget wrote: I realize this topic has long since landed, just seemed like a good thing to reply to to ask this question: > [...] > + ( | ... |) > [...] > + :: > + Compare the commits specified by the two ranges, where > + ``

[PATCH v3 22/23] revision.c: remove implicit dependency on the_index

--- .../technical/api-revision-walking.txt| 2 +- bisect.c | 4 +-- builtin/add.c | 4 +-- builtin/am.c | 6 ++-- builtin/blame.c | 2 +- builtin/checkou

[PATCH v3 12/23] merge-blobs.c: remove implicit dependency on the_index

--- builtin/merge-tree.c | 2 +- merge-blobs.c| 15 +++ merge-blobs.h| 7 +-- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/builtin/merge-tree.c b/builtin/merge-tree.c index f8023bae1e..f32941fdab 100644 --- a/builtin/merge-tree.c +++ b/builtin/m

[PATCH v3 23/23] revision.c: reduce implicit dependency the_repository

--- list-objects.c | 8 +--- revision.c | 44 +++- revision.h | 2 +- 3 files changed, 29 insertions(+), 25 deletions(-) diff --git a/list-objects.c b/list-objects.c index c99c47ac18..0c2989d5ca 100644 --- a/list-objects.c +++ b/list-objects.c

[PATCH v3 11/23] ll-merge.c: remove implicit dependency on the_index

--- apply.c| 9 ++--- builtin/checkout.c | 3 ++- diff.c | 2 +- ll-merge.c | 17 + ll-merge.h | 5 - merge-blobs.c | 3 ++- merge-recursive.c | 3 ++- notes-merge.c | 3 ++- rerere.c | 10 ++ 9 fil

[PATCH v3 20/23] tree-diff.c: remove implicit dependency on the_index

--- tree-diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tree-diff.c b/tree-diff.c index 57a15f51f0..16b28ff6d6 100644 --- a/tree-diff.c +++ b/tree-diff.c @@ -605,7 +605,7 @@ static void try_to_follow_renames(const struct object_id *old_oid, choice = q->queue[0]

[PATCH v3 21/23] ws.c: remove implicit dependency on the_index

--- apply.c | 8 +--- cache.h | 2 +- diff.c | 6 +++--- ws.c| 5 ++--- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/apply.c b/apply.c index 571b89c2e0..fdae1d423b 100644 --- a/apply.c +++ b/apply.c @@ -2131,10 +2131,12 @@ static int parse_chunk(struct apply_state *sta

[PATCH v3 16/23] rerere.c: remove implicit dependency on the_index

The reason rerere(), rerere_forget() and rerere_remaining() take a struct repository instead of struct index_state is not obvious from the patch: Deep in update_paths() and find_conflict(), hold_locked_index() and read_index() are called. These functions assumes the index path at $GIT_DIR/index wh

[PATCH v3 14/23] patch-ids.c: remove implicit dependency on the_index

--- builtin/log.c | 2 +- patch-ids.c | 4 ++-- patch-ids.h | 3 ++- revision.c| 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index 4b602236d6..978fe7c10f 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -914,7 +914,7 @@ static void ge

[PATCH v3 15/23] sha1-file.c: remove implicit dependency on the_index

--- builtin/difftool.c | 2 +- builtin/hash-object.c | 2 +- builtin/replace.c | 2 +- builtin/update-index.c | 2 +- cache.h| 4 ++-- diff.c | 20 - notes-merge.c | 2 +- read-cache.c | 25 - sh

[PATCH v3 19/23] submodule.c: remove implicit dependency on the_index

--- builtin/pull.c | 2 +- submodule.c| 28 +--- submodule.h| 9 ++--- transport.c| 9 ++--- 4 files changed, 30 insertions(+), 18 deletions(-) diff --git a/builtin/pull.c b/builtin/pull.c index 33b7100837..9c455984d1 100644 --- a/builtin/pull.c +++

[PATCH v3 18/23] line-range.c: remove implicit dependency on the_index

--- builtin/blame.c | 2 +- line-log.c | 4 ++-- line-range.c| 22 ++ line-range.h| 6 -- 4 files changed, 21 insertions(+), 13 deletions(-) diff --git a/builtin/blame.c b/builtin/blame.c index c2da673ac8..97632828db 100644 --- a/builtin/blame.c +++ b/built

[PATCH v3 17/23] userdiff.c: remove implicit dependency on the_index

--- archive-zip.c | 14 +- builtin/grep.c | 3 ++- combine-diff.c | 2 +- diff.c | 40 +++- diff.h | 3 ++- diffcore-pickaxe.c | 4 ++-- grep.c | 21 - grep.h | 3 +

[PATCH v3 07/23] grep.c: remove implicit dependency on the_index

--- builtin/grep.c | 4 ++-- builtin/log.c | 2 +- grep.c | 13 - grep.h | 7 +-- revision.c | 4 ++-- 5 files changed, 18 insertions(+), 12 deletions(-) diff --git a/builtin/grep.c b/builtin/grep.c index 601f801158..0667ffde84 100644 --- a/builtin/grep.c

[PATCH v3 02/23] read-cache.c: remove 'const' from index_has_changes()

This function calls do_diff_cache() which eventually needs to set this "istate" to unpack_options->src_index (*). This is an unfortunate fact that unpack_trees() _will_ destroy src_index so we can't really pass a const index_state there. Just remove 'const'. (*) Right now diff_cache() in diff-lib.

[PATCH v3 00/23] Kill the_index part 4

The last patch 24/24 has been merged into individual patches to add repo_ prefix and avoid breaking in-flight topics. "repo" argument is also moved up in rerere(), diff_setup() and init_revisions(). All three macros that take the_repository is wrapped in NO_THE_REPO... similar to NO_THE_INDEX_...

[PATCH v3 03/23] diff.c: reduce implicit dependency on the_index

diff and textconv code has so widespread use that it's hard to simply update their api and all call sites at once because it would result in a big patch. For now reduce the_index references to two places: diff_setup() and fill_textconv(). --- builtin/reset.c | 1 + diff.c| 176

[PATCH v3 10/23] diff-lib.c: remove implicit dependency on the_index

--- diff-lib.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/diff-lib.c b/diff-lib.c index 88a98b1c06..c54773fe12 100644 --- a/diff-lib.c +++ b/diff-lib.c @@ -70,7 +70,7 @@ static int match_stat_with_submodule(struct diff_options *diffopt,

[PATCH v3 13/23] merge.c: remove implicit dependency on the_index

--- builtin/merge.c | 8 +--- builtin/pull.c | 7 +-- cache.h | 6 -- merge.c | 20 +++- sequencer.c | 6 +++--- 5 files changed, 28 insertions(+), 19 deletions(-) diff --git a/builtin/merge.c b/builtin/merge.c index 592cb19caf..5f79fc5fd7 1006

[PATCH v3 04/23] combine-diff.c: remove implicit dependency on the_index

--- combine-diff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/combine-diff.c b/combine-diff.c index de7695e728..4fa7707b57 100644 --- a/combine-diff.c +++ b/combine-diff.c @@ -1054,7 +1054,8 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent,

[PATCH v3 09/23] read-cache.c: remove implicit dependency on the_index

--- read-cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/read-cache.c b/read-cache.c index 6f772b2885..563500fe98 100644 --- a/read-cache.c +++ b/read-cache.c @@ -823,7 +823,7 @@ struct cache_entry *make_cache_entry(struct index_state *istate, ce->ce_namele

[PATCH v3 06/23] diff.c: remove the_index dependency in textconv() functions

--- blame.c| 7 --- builtin/cat-file.c | 6 -- builtin/log.c | 3 ++- combine-diff.c | 27 --- diff.c | 17 + diff.h | 9 +++-- diffcore-pickaxe.c | 4 ++-- grep.c | 2 +- 8 files cha

[PATCH v3 08/23] diff.c: remove implicit dependency on the_index

A new variant repo_diff_setup() is added that takes 'struct repository *' and diff_setup() becomes a thin macro around it that is protected by NO_THE_REPOSITORY_COMPATIBILITY_MACROS, similar to NO_THE_INDEX_ The plan is these macros will always be defined for all library files and the macros ar

[PATCH v3 05/23] blame.c: rename "repo" argument to "r"

The current naming convention for 'struct repository *' is 'r' for temporary variables or arguments. I did not notice this. Since we're updating blame.c again in the next patch, let's fix this. --- blame.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-)

[PATCH v3 01/23] archive.c: remove implicit dependency the_repository

The new "repo" field in archive_args has been added since b612ee202a (archive.c: avoid access to the_index - 2018-08-13). Use it instead of hard coding the_repository. --- archive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archive.c b/archive.c index 0a07b140fe..994495af

Re: [PATCH v2 24/24] Rename functions to avoid breaking in-flight topics

On Wed, Sep 5, 2018 at 11:04 PM Junio C Hamano wrote: > > now and here, but at some later date, we would want to > > 'git revert 24/24' after fixing all in-flights of today. > > No. We do not want to revert the whole thing. > > If the function that takes a_repository is called repo_rerere(), as >

Re: [PATCH 12/21] patch-ids.c: remove implicit dependency on the_index

On Tue, Sep 4, 2018 at 9:54 PM Stefan Beller wrote: > > On Mon, Sep 3, 2018 at 11:03 AM Duy Nguyen wrote: > > > > On Mon, Aug 27, 2018 at 9:13 PM Stefan Beller wrote: > > > > > > > -int init_patch_ids(struct patch_ids *ids) > > > > +int init_patch_ids(struct patch_ids *ids, struct repository *re

Re: [PATCH 1/2] t0051: test GIT_TRACE to a windows named pipe

On 9/7/2018 8:19 PM, Jeff Hostetler via GitGitGadget wrote: +test_expect_success MINGW 'o_append write to named pipe' ' Shouldn't this be "test_expect_failure" here, and then be changed to "test_expect_success" by your second patch? -- Sebastian Schuberth