Re: [PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-09-09 Thread René Scharfe
Am 06.09.2017 um 21:51 schrieb Junio C Hamano: > Rene Scharfe writes: > >> Signed-off-by: Rene Scharfe >> --- >> builtin/clone.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/builtin/clone.c b/builtin/clone.c >> index 8d11b570a1..dbddd98f80 100644 >> --- a/builti

Re: [PATCH 34/34] wt-status: release strbuf after use in wt_longstatus_print_tracking()

2017-09-09 Thread René Scharfe
Am 06.09.2017 um 21:51 schrieb Junio C Hamano: > Rene Scharfe writes: > >> If format_tracking_info() returns 0 only if it didn't touch its strbuf >> parameter, so it's OK to exit early in that case. Clean up sb in the >> other case. > > These two "if"s confuse me; perhaps the first one is not n

Re: [PATCH v2 08/11] t1404: demonstrate two problems with reference transactions

2017-09-09 Thread Michael Haggerty
On 09/09/2017 01:17 PM, Jeff King wrote: > On Fri, Sep 08, 2017 at 03:51:50PM +0200, Michael Haggerty wrote: > [...] > So if we get what we want, we execute ":" which should be a successful > exit code. I think the `:` is superfluous even if we care about the exit code of the `case`. I'll remove i

Re: [PATCH 00/12] Clean up notes-related code around `load_subtree()`

2017-09-09 Thread Michael Haggerty
On 09/09/2017 12:31 PM, Jeff King wrote: > On Sat, Aug 26, 2017 at 10:28:00AM +0200, Michael Haggerty wrote: > >> It turns out that the comment is incorrect, but there was nevertheless >> plenty that could be cleaned up in the area: >> >> * Make macro `GIT_NIBBLE` safer by adding some parentheses

Hello

2017-09-09 Thread DAVID JIM
Hello , This is to inform you that this bank has appointed a New managing Director and on this note informing you about your withheld fund $950,000 Dollars been held by pass administration. As the New appointed manager, collaboration with Benin republic government and governor central bank direct

Unexpected pass for t6120-describe.sh on cygwin

2017-09-09 Thread Ramsay Jones
Hi Adam, I ran the test-suite on the 'pu' branch last night (simply because that was what I had built at the time!), which resulted in a PASS, but t6120 was showing a 'TODO passed' for #52. This is a test introduced by Michael's 'mg/name-rev-tests-with-short-stack' branch, which uses 'ulimit -s'

Re: Donation

2017-09-09 Thread Mavis Wanczyk Foundation
Greetings To You, My Name is Mavis wanczyk , the winner of the Power ball jackpot of $ $758.7 million in the AUGUST 24, 2017, My jackpot was a gift from God to me hence my Entire family/foundation has AGREED to do this. My foundation is donating $500,000.00USD to you. please contac maviswanczy

Re: git diff doesn't quite work as documented?

2017-09-09 Thread Yubin Ruan
2017-09-08 0:31 GMT+08:00 Olaf Klischat : > oklischat@oklischat:/tmp$ mkdir gittest > oklischat@oklischat:/tmp$ cd gittest/ > oklischat@oklischat:/tmp/gittest$ git init > Initialized empty Git repository in /private/tmp/gittest/.git/ > oklischat@oklischat:/tmp/gittest$ echo foo > foo.txt > oklischa

Re: [PATCH v2 00/11] Implement transactions for the packed ref store

2017-09-09 Thread Jeff King
On Fri, Sep 08, 2017 at 03:51:42PM +0200, Michael Haggerty wrote: > This is v2 of a patch series to implement reference transactions for > the packed refs-store. Thanks to Stefan, Brandon, Junio, and Peff for > your review of v1 [1]. I believe I have addressed all of your > comments. > > Changes

Re: [PATCH v2 08/11] t1404: demonstrate two problems with reference transactions

2017-09-09 Thread Jeff King
On Fri, Sep 08, 2017 at 03:51:50PM +0200, Michael Haggerty wrote: > +test_expect_failure 'no bogus intermediate values during delete' ' > + prefix=refs/slow-transaction && > + # Set up a reference with differing loose and packed versions: > + git update-ref $prefix/foo $C && > + gi

Re: [PATCH v4 0/4] Rerolling ma/split-symref-update-fix

2017-09-09 Thread Jeff King
On Sat, Sep 09, 2017 at 08:57:14AM +0200, Martin Ågren wrote: > > I'll take Peff's hint, tweak/add comments for correctness and symmetry > > with the previous patch and add an if-BUG for symmetry. > > Here's a reroll of ma/split-symref-update-fix. The first three patches > are v3 plus Michael's R

Re: [PATCH 00/12] Clean up notes-related code around `load_subtree()`

2017-09-09 Thread Jeff King
On Sat, Aug 26, 2017 at 10:28:00AM +0200, Michael Haggerty wrote: > It turns out that the comment is incorrect, but there was nevertheless > plenty that could be cleaned up in the area: > > * Make macro `GIT_NIBBLE` safer by adding some parentheses > * Remove some dead code > * Fix some memory le

Funds

2017-09-09 Thread Barrister Henry van loo
I am Henry Ivan Loo,an Attorney at law have a Next of Kin Proposal for you. A deceased client of mine left a total sum of ($50,600,000.00 USD) without any next of Kin as regards his funds. This totally legal with all documents to back you up as the next of kin. for more details if interested, co