Re: [PATCH v4 1/3] update-unicode.sh: automatically download newer definition files

2016-12-03 Thread Torsten Bögershausen
On Sat, Dec 03, 2016 at 10:00:47PM +0100, Beat Bolli wrote: > Checking just for the unicode data files' existence is not sufficient; > we should also download them if a newer version exists on the Unicode > consortium's servers. Option -N of wget does this nicely for us. > > Reviewed-by: Torsten B

Re: Git v2.11.0 breaks max depth nested alternates

2016-12-03 Thread Jeff King
On Sat, Dec 03, 2016 at 04:24:02PM -0800, Kyle J. McKay wrote: > When the incoming quarantine takes place the current objects directory > is demoted to an alternate thereby increasing its depth (and any > alternates it references) by one and causing any object store that was > previously at

[PATCH v2] tag, branch, for-each-ref: add --ignore-case for sorting and filtering

2016-12-03 Thread Nguyễn Thái Ngọc Duy
This options makes sorting ignore case, which is great when you have branches named bug-12-do-something, Bug-12-do-some-more and BUG-12-do-what and want to group them together. Sorting externally may not be an option because we lose coloring and column layout from git-branch and git-tag. The same

Re: git reset --hard should not irretrievably destroy new files

2016-12-03 Thread Julian de Bhal
On Sat, Dec 3, 2016 at 6:11 PM, Christian Couder wrote: > On Sat, Dec 3, 2016 at 6:04 AM, Julian de Bhal > wrote: >> but I'd be nearly as happy if a >> commit was added to the reflog when the reset happens (I can probably make >> that happen with some configuration now that I've been bitten). >

Git v2.11.0 breaks max depth nested alternates

2016-12-03 Thread Kyle J. McKay
The recent addition of pre-receive quarantining breaks nested alternates that are already at the maximum alternates nesting depth. In the file sha1_file.c in the function link_alt_odb_entries we have this: > if (depth > 5) { > error("%s: ignoring alternate object stores, nesting too

Re: git reset --hard should not irretrievably destroy new files

2016-12-03 Thread Julian de Bhal
On Sat, Dec 3, 2016 at 5:49 PM, Johannes Sixt wrote: > Am 03.12.2016 um 06:04 schrieb Julian de Bhal: >> >> If you `git add new_file; git reset --hard`, new_file is gone forever. > > AFAIC, this is a feature ;-) I occasionally use it to remove a file when I > already have git-gui in front of me. T

[PATCH v4 3/3] unicode_width.h: update the tables to Unicode 9.0

2016-12-03 Thread Beat Bolli
Rerunning update-unicode.sh that we fixed in the two previous commits produces these new tables. Signed-off-by: Beat Bolli --- unicode_width.h | 131 +--- 1 file changed, 107 insertions(+), 24 deletions(-) diff --git a/unicode_width.h b/unicod

[PATCH v4 2/3] update-unicode.sh: strip the plane offsets from the double_width[] table

2016-12-03 Thread Beat Bolli
The function bisearch() in utf8.c does a pure binary search in double_width. It does not care about the 17 plane offsets which unicode/uniset/uniset prepends. Leaving the plane offsets in the table may cause wrong results. Filter out the plane offsets in update-unicode.sh. Reviewed-by: Torsten Bö

[PATCH v4 1/3] update-unicode.sh: automatically download newer definition files

2016-12-03 Thread Beat Bolli
Checking just for the unicode data files' existence is not sufficient; we should also download them if a newer version exists on the Unicode consortium's servers. Option -N of wget does this nicely for us. Reviewed-by: Torsten Boegershausen Signed-off-by: Beat Bolli --- Diff to v3: - change th

[PATCH] docs: warn about possible '=' in clean/smudge filter process values

2016-12-03 Thread larsxschneider
From: Lars Schneider A pathname value in a clean/smudge filter process "key=value" pair can contain the '=' character (introduced in edcc858). Make the user aware of this issue in the docs, add a corresponding test case, and fix the issue in filter process value parser of the example implementati

Re: [RFC/PATCH v3 00/16] Add initial experimental external ODB support

2016-12-03 Thread Lars Schneider
> On 30 Nov 2016, at 22:04, Christian Couder wrote: > > Goal > > > Git can store its objects only in the form of loose objects in > separate files or packed objects in a pack file. > > To be able to better handle some kind of objects, for example big > blobs, it would be nice if Git could

Re: [PATCH v3 1/3] update-unicode.sh: automatically download newer definition files

2016-12-03 Thread Beat Bolli
On 03.12.16 17:40, Torsten =?unknown-8bit?Q?B=C3=B6gershausen?= wrote: > On Sat, Dec 03, 2016 at 02:19:31PM +0100, Beat Bolli wrote: >> Checking just for the unicode data files' existence is not sufficient; >> we should also download them if a newer version exists on the Unicode >> consortium's ser

Re: [PATCH v3 1/3] update-unicode.sh: automatically download newer definition files

2016-12-03 Thread Torsten B??gershausen
On Sat, Dec 03, 2016 at 02:19:31PM +0100, Beat Bolli wrote: > Checking just for the unicode data files' existence is not sufficient; > we should also download them if a newer version exists on the Unicode > consortium's servers. Option -N of wget does this nicely for us. > > Cc: Torsten B??gershau

Re: [PATCH] commit: make --only --allow-empty work without paths

2016-12-03 Thread Jeff King
On Sat, Dec 03, 2016 at 07:59:49AM +0100, Andreas Krey wrote: > > OK. I'm not sure why you would want to create an empty commit in such a > > case. > > User: Ok tool, make me a pullreq. > > Tool: But you haven't mentioned any issue > in your commit messages. Which are they? > > User: Ok,

[PATCH v3 1/3] update-unicode.sh: automatically download newer definition files

2016-12-03 Thread Beat Bolli
Checking just for the unicode data files' existence is not sufficient; we should also download them if a newer version exists on the Unicode consortium's servers. Option -N of wget does this nicely for us. Cc: Torsten Bögershausen Signed-off-by: Beat Bolli --- Diff to v2: - reorder the commits

[PATCH v3 2/3] update-unicode.sh: strip the plane offsets from the double_width[] table

2016-12-03 Thread Beat Bolli
The function bisearch() in utf8.c does a pure binary search in double_width. It does not care about the 17 plane offsets which unicode/uniset/uniset prepends. Leaving the plane offsets in the table may cause wrong results. Filter out the plane offsets in update-unicode.sh. Cc: Torsten Bögershause

[PATCH v3 3/3] unicode_width.h: update the tables to Unicode 9.0

2016-12-03 Thread Beat Bolli
Rerunning update-unicode.sh that we fixed in the two previous commits produces these new tables. Signed-off-by: Beat Bolli --- unicode_width.h | 131 +--- 1 file changed, 107 insertions(+), 24 deletions(-) diff --git a/unicode_width.h b/unicod

[PATCH v2 1/3] update-unicode.sh: automatically download newer definition files

2016-12-03 Thread Beat Bolli
Checking just for the unicode data files' existence is not sufficient; we should also download them if a newer version exists on the Unicode consortium's servers. Option -N of wget does this nicely for us. Cc: Torsten Bögershausen Signed-off-by: Beat Bolli --- Diff to v1: - reword the commit m

[PATCH v2 2/3] unicode_width.h: update the tables to Unicode 9.0

2016-12-03 Thread Beat Bolli
Rerunning update-unicode.sh fixed in the previous commit produces these new tables. Signed-off-by: Beat Bolli --- Diff to v1: - reword the commit message unicode_width.h | 122 +++- 1 file changed, 111 insertions(+), 11 deletions(-) diff --

[PATCH v2 3/3] unicode_width.h: fix the double_width[] table

2016-12-03 Thread Beat Bolli
The function bisearch() in utf8.c does a pure binary search in double_width. It does not care about the 17 plane offsets which unicode/uniset/uniset prepends. Leaving the plane offsets in the table may cause wrong results. Filter out the plane offsets in update-unicode.sh and regenerate the table.

[PATCH 3/3] unicode_width.h: fix the double_width[] table

2016-12-03 Thread Beat Bolli
The function bisearch() in utf8.c does a pure binary search in double_width. It does not care about the 17 plane offsets which unicode/uniset/uniset prepends. Leaving the plane offsets in the table may cause wrong results. Filter out the plane offsets in the update-unicode.sh and regenerate the ta

Re: git reset --hard should not irretrievably destroy new files

2016-12-03 Thread Christian Couder
On Sat, Dec 3, 2016 at 6:04 AM, Julian de Bhal wrote: > If you `git add new_file; git reset --hard`, new_file is gone forever. > > This is totally what git says it will do on the box, but it caught me out. Yeah, you are not the first one, and probably not the last unfortunately, to be caught by i