Re: [PATCH v8 00/10] refs backend pre-vtable

2015-11-19 Thread Michael Haggerty
On November 19, 2015 3:58:48 PM GMT+01:00, Jeff King wrote: > [...] >Thanks. Looks like patch 7 didn't make it to the list due to its size. >I picked it up from Michael's GitHub fork. Oh, thanks. I hadn't noticed the problem. >Just so I'm sure, this is replacing all of what Junio had queued in >

Re: [PATCH v2] blame: avoid checking if a file exists on the working tree if a revision is provided

2015-11-19 Thread Eric Sunshine
On Tue, Nov 17, 2015 at 6:22 PM, Jeff King wrote: > On Tue, Nov 17, 2015 at 06:01:25PM -0500, Eric Sunshine wrote: >> On Tue, Nov 17, 2015 at 5:48 PM, Jeff King wrote: >> > Hmm. Out of curiosity I tried: >> > >> > git blame v2.4.0 -- t/t6031-merge-recursive.sh >> > >> > and it segfaults. This b

Re: [PATCH 0/7] Modernize t9300-fast-import

2015-11-19 Thread Eric Sunshine
On Thu, Nov 19, 2015 at 2:09 PM, Johannes Sixt wrote: > Some time ago, I had to dig into t9300-fast-import and found it quite > unhelpful that it does not follow our modern best-practices. This series > brings it up-to-date. I thought I submit it now while it is quiet in > the area. > > The larger

[PATCH v4 2/2] completion: add support for completing email aliases

2015-11-19 Thread Jacob Keller
From: Jacob Keller Using the new --dump-aliases option from git-send-email, add completion for --to, --cc, --bcc, and --from with the available configured aliases. Signed-off-by: Jacob Keller --- Notes: - v2 * Use git-send-email for parsing instead of re-implementing it in awk

[PATCH v4 1/2] sendemail: teach git-send-email to dump alias names

2015-11-19 Thread Jacob Keller
From: Jacob Keller Add an option "--dump-aliases" which changes the default behavior of git-send-email. This mode will simply read the alias files configured by sendemail.aliasesfile and sendemail.aliasfiletype and dump a list of all configured aliases, one per line. The intended use case for thi

Re: Local git repository url

2015-11-19 Thread Jacob Keller
On Thu, Nov 19, 2015 at 3:06 AM, Konstantin Khomoutov wrote: > On Thu, 19 Nov 2015 10:48:51 + > "Vambara, JayaPrakash (Infosys)" > wrote: > >> I am trying to setup a local git repository and manage it from local >> Jenkins set-up. So, both Jenkins and git are on my local desktop. >> >> Howeve

Re: [PATCH 1/2] t1450: add tests for NUL in headers of commits and tags

2015-11-19 Thread René Scharfe
Am 19.11.2015 um 21:33 schrieb Eric Sunshine: On Thu, Nov 19, 2015 at 11:20 AM, René Scharfe wrote: Signed-off-by: Rene Scharfe --- diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh @@ -176,6 +176,18 @@ test_expect_success 'integer overflow in timestamps is reported' ' +test_expect_success 'comm

Re: [PATCH 1/2] t1450: add tests for NUL in headers of commits and tags

2015-11-19 Thread Eric Sunshine
On Thu, Nov 19, 2015 at 11:20 AM, René Scharfe wrote: > Signed-off-by: Rene Scharfe > --- > diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh > @@ -176,6 +176,18 @@ test_expect_success 'integer overflow in timestamps is > reported' ' > +test_expect_success 'commit with NUL in header' ' > + gi

[PATCH 7/7] modernize t9300: move test preparations into test_expect_success

2015-11-19 Thread Johannes Sixt
Our usual style these days is to execute everything inside test_expect_success. Make it so. Signed-off-by: Johannes Sixt --- t/t9300-fast-import.sh | 2580 1 file changed, 1297 insertions(+), 1283 deletions(-) diff --git a/t/t9300-fast-import.sh

[PATCH 5/7] modernize t9300: use test_when_finished for clean-up

2015-11-19 Thread Johannes Sixt
A number of clean-ups of test cases are performed outside of test_expect_success. Replace these cases by using test_when_finished. Signed-off-by: Johannes Sixt --- t/t9300-fast-import.sh | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/t/

git@vger.kernel.org

2015-11-19 Thread Johannes Sixt
It is customary to have each command in test snippets on its own line. Fix those instances that do not follow this guideline. Signed-off-by: Johannes Sixt --- t/t9300-fast-import.sh | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --g

[PATCH 6/7] modernize t9300: mark here-doc words to ignore tab indentation

2015-11-19 Thread Johannes Sixt
In the next commit, we will indent test case preparations. This will require that here-documents ignore the tab indentation. Prepare for this change by marking the here-doc words accordingly. This does not have an effect now, but will remove some noise from the git diff -b output of the next commit

[PATCH 2/7] modernize t9300: use test_must_fail

2015-11-19 Thread Johannes Sixt
One test case open-codes a test for an expected failure. Replace it by test_must_fail. Signed-off-by: Johannes Sixt --- t/t9300-fast-import.sh | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh index 566f7bd..e9c

[PATCH 3/7] modernize t9300: use test_must_be_empty

2015-11-19 Thread Johannes Sixt
Instead of comparing actual output to an empty file, use test_must_be_empty. In addition to the better error message provided by the helper, allocation of an empty file during the setup sequence can be avoided. Signed-off-by: Johannes Sixt --- t/t9300-fast-import.sh | 8 +++- 1 file changed,

[PATCH 0/7] Modernize t9300-fast-import

2015-11-19 Thread Johannes Sixt
Some time ago, I had to dig into t9300-fast-import and found it quite unhelpful that it does not follow our modern best-practices. This series brings it up-to-date. I thought I submit it now while it is quiet in the area. The larger patches are best viewed using -w -color-words because the regular

[PATCH 1/7] modernize t9300: single-quote placement and indentation

2015-11-19 Thread Johannes Sixt
Many test cases do not follow our modern style that places the single-quotes that surround the shell code snippets before and after the shell code. Make it so. Many of the lines changed in this way are indented other than by a single tab. Change them (and some additional lines) to be indented with

[PATCH 2/2] fsck: treat a NUL in a tag header as an error

2015-11-19 Thread René Scharfe
We check the return value of verify_header() for commits already, so do the same for tags as well. Signed-off-by: Rene Scharfe --- fsck.c | 3 ++- t/t1450-fsck.sh | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fsck.c b/fsck.c index e41e753..4060f1f 100644 --- a/f

[PATCH 1/2] t1450: add tests for NUL in headers of commits and tags

2015-11-19 Thread René Scharfe
Signed-off-by: Rene Scharfe --- t/t1450-fsck.sh | 32 1 file changed, 32 insertions(+) diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh index dc09797..6c96953 100755 --- a/t/t1450-fsck.sh +++ b/t/t1450-fsck.sh @@ -176,6 +176,18 @@ test_expect_success 'integer overf

Re: [PATCH v8 00/10] refs backend pre-vtable

2015-11-19 Thread Jeff King
On Mon, Nov 16, 2015 at 01:51:08PM -0500, David Turner wrote: > > Since patch 01/11 of v7 was omitted, the patches in this version are > > numbered differently. In particular, it is now patches 01 through 07 > > that form the core of this patch series. The last three patches can > > easily be post

Re: [PATCHv2] ident.c: add support for IPv6

2015-11-19 Thread Jeff King
On Thu, Nov 19, 2015 at 02:54:20PM +0100, Elia Pinto wrote: > Add IPv6 support by implementing name resolution with the > protocol agnostic getaddrinfo(3) API. The old gethostbyname(3) > code is still available when git is compiled with NO_IPV6. > > Signed-off-by: Elia Pinto > Helped-by: Jeff Ki

Re: [PATCH v6 6/6] Add Travis CI support

2015-11-19 Thread Jeff King
On Thu, Nov 19, 2015 at 09:58:11AM +0100, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > The tests are currently executed on "Ubuntu 12.04 LTS Server Edition > 64 bit" and on "OS X Mavericks" using gcc and clang. > > Perforce and Git-LFS are installed and therefore available for the

Re: [PATCH v6 0/6] Add Travis CI support

2015-11-19 Thread Jeff King
On Thu, Nov 19, 2015 at 09:58:05AM +0100, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > diff to v5: > * check if PID file still exists on P4D cleanup (thanks Luke) > * fix space/tab formatting error > * add sleep to timeout loops (thanks Luke) > * replace 'date +%s' with platform in

Re: [PATCH v2] add test to demonstrate that shallow recursive clones fail

2015-11-19 Thread Jeff King
On Wed, Nov 18, 2015 at 03:40:02PM -0800, Terry Parker wrote: > > +Terry, who did optimize the JGit implementation for bitmaps, > > as we also had a "lots of refs" hoarder repo, which underperformed > > before. > > The performance issue with the "hoarder" repo was that the bitmap > commit selecti

[PATCHv2] ident.c: add support for IPv6

2015-11-19 Thread Elia Pinto
Add IPv6 support by implementing name resolution with the protocol agnostic getaddrinfo(3) API. The old gethostbyname(3) code is still available when git is compiled with NO_IPV6. Signed-off-by: Elia Pinto Helped-by: Jeff King Helped-by: Eric Sunshine --- This is the second version of the patc

Re: Local git repository url

2015-11-19 Thread Konstantin Khomoutov
On Thu, 19 Nov 2015 10:48:51 + "Vambara, JayaPrakash (Infosys)" wrote: > I am trying to setup a local git repository and manage it from local > Jenkins set-up. So, both Jenkins and git are on my local desktop. > > However, I am trying to give the Repository URL but with no luck. > > My repo

Local git repository url

2015-11-19 Thread Vambara, JayaPrakash (Infosys)
Hi Team, I am trying to setup a local git repository and manage it from local Jenkins set-up. So, both Jenkins and git are on my local desktop. However, I am trying to give the Repository URL but with no luck. My repository is in D drive in location D:\Git-Try I tried to configure this Reposit

[PATCH v6 6/6] Add Travis CI support

2015-11-19 Thread larsxschneider
From: Lars Schneider The tests are currently executed on "Ubuntu 12.04 LTS Server Edition 64 bit" and on "OS X Mavericks" using gcc and clang. Perforce and Git-LFS are installed and therefore available for the respective tests. Signed-off-by: Lars Schneider --- .travis.yml | 131 +

[PATCH v6 4/6] git-p4: add p4d timeout in tests

2015-11-19 Thread larsxschneider
From: Lars Schneider In rare cases p4d seems to hang. This watchdog will kill the p4d process after 300s in any case. That means each individual git p4 test needs to finish before 300s or it will fail. Signed-off-by: Lars Schneider Acked-by: Luke Diamand --- t/lib-git-p4.sh | 20 +

[PATCH v6 5/6] git-p4: add trap to kill p4d on test exit

2015-11-19 Thread larsxschneider
From: Lars Schneider Sometimes the "prove" test runner hangs on test exit because p4d is still running. Add a trap to always kill "p4d" on test exit. You can reproduce the problem by commenting "P4D_TIMEOUT" in "lib-git-p4.sh" and running "prove ./t9800-git-p4-basic.sh". Signed-off-by: Lars Sch

[PATCH v6 0/6] Add Travis CI support

2015-11-19 Thread larsxschneider
From: Lars Schneider diff to v5: * check if PID file still exists on P4D cleanup (thanks Luke) * fix space/tab formatting error * add sleep to timeout loops (thanks Luke) * replace 'date +%s' with platform independent Python function (thanks Eric and Luke) With the patches of this series the Tr

[PATCH v6 1/6] implement test_might_fail using a refactored test_must_fail

2015-11-19 Thread larsxschneider
From: Lars Schneider Add an (optional) first parameter "ok=" to test_must_fail and return success for "". Add "success" as "" and use it to implement "test_might_fail". This removes redundancies in test-lib-function.sh. Signed-off-by: Junio C Hamano Signed-off-by: Lars Schneider --- t/test-li

[PATCH v6 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-19 Thread larsxschneider
From: Lars Schneider In rare cases kill/cleanup operations in tests fail. Retry these operations with a timeout to make the test less flaky. Signed-off-by: Lars Schneider --- t/lib-git-p4.sh | 42 ++ 1 file changed, 34 insertions(+), 8 deletions(-) diff

[PATCH v6 2/6] add "ok=sigpipe" to test_must_fail and use it to fix flaky tests

2015-11-19 Thread larsxschneider
From: Lars Schneider t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" is flaky in the following case: 1. remote upload-pack finds out "not our ref" 2. remote sends a response and closes the pipe 3. fetch-pack still tries to write commands to the remote upload-pack 4. write call i