Signed-off-by: Stefan Beller
---
git-submodule.sh | 164 ---
1 file changed, 84 insertions(+), 80 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index c40d60f..2c9f1f2 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -625,
Signed-off-by: Stefan Beller
---
Documentation/fetch-options.txt | 7 +++
builtin/fetch.c | 5 -
builtin/pull.c | 6 ++
t/t5526-fetch-submodules.sh | 19 +++
4 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/Document
There are no tests, which fail by this.
Signed-off-by: Stefan Beller
---
git-submodule.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 8b0eb9a..7ef3247 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -663,7 +663,7 @@ cm
split the recursion part out to its own function
Signed-off-by: Stefan Beller
---
git-submodule.sh | 47 ++-
1 file changed, 26 insertions(+), 21 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 3ccb0b6..52c2967 100755
--- a/git-sub
Signed-off-by: Stefan Beller
---
git-submodule.sh | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 52c2967..c40d60f 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -607,6 +607,24 @@ cmd_update_r
We should not pass --prefix NULL into the helper. Although the helper
can deal with it, it's just messy.
Signed-off-by: Stefan Beller
---
git-submodule.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 7ef3247..3ccb0b6 100755
--- a/g
This allows to run external commands in parallel with ordered output
on stderr.
If we run external commands in parallel we cannot pipe the output directly
to the our stdout/err as it would mix up. So each process's output will
flow through a pipe, which we buffer. One subprocess can be directly
pi
We need to read from pipes without blocking in a later patch.
Signed-off-by: Stefan Beller
---
strbuf.c | 25 +++--
strbuf.h | 6 ++
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/strbuf.c b/strbuf.c
index cce5eed..4130ee2 100644
--- a/strbuf.c
+++ b/str
> I didn't say this in the previous round because it smelled like an
> RFC, but for a real submission, 2/2 may be doing too many things at
> once. I suspect this is more or less "taste" thing, so I won't mind
> too much as long as the reviewers are OK with it.
The patch 2/2 is now broken up into
We will need computing the return value in a later patch without the
wait.
Signed-off-by: Stefan Beller
---
run-command.c | 54 --
1 file changed, 32 insertions(+), 22 deletions(-)
diff --git a/run-command.c b/run-command.c
index 28e1d55..c892
In a later patch we enable parallel processing of submodules, this
only adds the possibility for it. So this change should not change
any user facing behavior.
Signed-off-by: Stefan Beller
---
builtin/fetch.c | 3 +-
submodule.c | 119 +++
Expanding `insteadOf` is a part of ls-remote --url and there is no way
to expand `pushInsteadOf` as well. Add a get-url subcommand to be able
to query both as well as a way to get all configured urls.
Signed-off-by: Ben Boeckel
---
Documentation/git-remote.txt | 10
builtin/remote.c
On Fri, 2015-09-04 at 12:01 -0400, David Turner wrote:
> On Thu, 2015-09-03 at 16:10 -0700, Junio C Hamano wrote:
> > David Turner writes:
> >
> > > I think I've broken about all of the standalone stuff out, so here's
> > > the main enchilada.
> > >
> > > This series depends on at least the follo
On Wed, Sep 16, 2015 at 3:36 PM, Mike Hommey wrote:
> On Wed, Sep 16, 2015 at 03:06:32PM -0700, Jacob Keller wrote:
>> This topic depends on mh/notes-allow-reading-treeish and actually
>> expands what this topic allowed before. Previously, treeishes such as
>> notes@{1} were made allowable, but th
On Wed, Sep 16, 2015 at 03:06:32PM -0700, Jacob Keller wrote:
> This topic depends on mh/notes-allow-reading-treeish and actually
> expands what this topic allowed before. Previously, treeishes such as
> notes@{1} were made allowable, but the ref still had to be found under
> refs/notes.
I haven't
On Wed, Sep 16, 2015 at 3:34 PM, Junio C Hamano wrote:
> Jacob Keller writes:
>
>> From: Jacob Keller
>>
>> The documentation for --refs says that it will treat unqualified refs as
>> under refs/notes. Current behavior is to prefix refs/notes to all
>> strings that do not start with refs/notes o
On Wed, Sep 16, 2015 at 03:54:50PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> >> Is this conversion correct? This seems to me that the caller wants
> >> to create an IMAP folder name immediately under the root hierarchy
> >> and wants to have the leading slash in the result.
> >
> > U
Jeff King writes:
>> Is this conversion correct? This seems to me that the caller wants
>> to create an IMAP folder name immediately under the root hierarchy
>> and wants to have the leading slash in the result.
>
> Ugh, you're right. This is the "other" style Eric mentioned earlier.
>
> This lo
Ben Boeckel writes:
> +get_url_test () {
> + cat >expect &&
> + test_expect_success "get-url $*" "
> + git remote get-url $* >actual &&
> + test_cmp expect actual
> + "
> +}
This makes any use of get_url_test inside test_expect_success wrong,
I suspect. Try r
On Wed, Sep 16, 2015 at 03:18:59PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > diff --git a/imap-send.c b/imap-send.c
> > index 01aa227..f5d2b06 100644
> > --- a/imap-send.c
> > +++ b/imap-send.c
> > @@ -1412,8 +1412,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
> >
Jacob Keller writes:
> From: Jacob Keller
>
> The documentation for --refs says that it will treat unqualified refs as
> under refs/notes. Current behavior is to prefix refs/notes to all
> strings that do not start with refs/notes or notes/, resulting in
> performing actions on refs such as "ref
Jacob Keller writes:
> On Tue, Sep 15, 2015 at 6:52 PM, Junio C Hamano wrote:
>>
>> * Enhance the "--pretty=format:" thing so that the current set of
>>hardcoded --pretty=medium,short,... formats and your modified
>>"medium" can be expressed as a custom format string.
>>
>> * Introduce
Jeff King writes:
> diff --git a/imap-send.c b/imap-send.c
> index 01aa227..f5d2b06 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1412,8 +1412,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
> curl_easy_setopt(curl, CURLOPT_PASSWORD, server.pass);
>
> strbuf_addst
From: Jacob Keller
Allow non-destructive notes actions which do not require write
permission to be performed on refs outside of refs/notes/. The primary
advantage of this is to allow fetching remote refs to such location as
"refs/remote-notes//foo" and then performing merges into
refs/notes/
It
From: Jacob Keller
The documentation for --refs says that it will treat unqualified refs as
under refs/notes. Current behavior is to prefix refs/notes to all
strings that do not start with refs/notes or notes/, resulting in
performing actions on refs such as "refs/notes/refs/foo/bar" instead of
a
From: Jacob Keller
The primary purpose of this series is to allow fetching remote notes
into a namespace such as "refs/remote-notes//foo". Currently,
git-notes refuses to operate on refs outside of refs/notes/* including
merging from them, listing or showing them. This makes it difficult to
share
Jeff King writes:
> I think we can save even more in ownbuf, which holds only octal
> modes. That was out of scope for this patch, though. :)
Sure. Also the variable is misnamed. It is modebuf[], I think.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a messag
On Wed, Sep 16, 2015 at 02:51:13PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > diff --git a/builtin/merge-index.c b/builtin/merge-index.c
> > index 1d66111..4ed0a83 100644
> > --- a/builtin/merge-index.c
> > +++ b/builtin/merge-index.c
> > @@ -9,7 +9,7 @@ static int merge_entry(int po
Jeff King writes:
> diff --git a/builtin/merge-index.c b/builtin/merge-index.c
> index 1d66111..4ed0a83 100644
> --- a/builtin/merge-index.c
> +++ b/builtin/merge-index.c
> @@ -9,7 +9,7 @@ static int merge_entry(int pos, const char *path)
> {
> int found;
> const char *arguments[] =
On Wed, Sep 16, 2015 at 02:27:57PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > - memcpy(buffer, filename, dirlen);
> > - strcpy(buffer + dirlen, "tmp_obj_XX");
> > - fd = git_mkstemp_mode(buffer, 0444);
> > + strbuf_reset(tmp);
> > + strbuf_add(tmp, filename, dirlen);
>
On Wed, Sep 16, 2015 at 5:09 PM, Eric Sunshine wrote:
> On Mon, Sep 14, 2015 at 1:44 PM, Mike Rappazzo wrote:
>> On Sat, Sep 12, 2015 at 11:19 PM, Eric Sunshine
>> wrote:
>>> On Fri, Sep 4, 2015 at 5:39 PM, Michael Rappazzo wrote:
+ while (!matched && worktree_list) {
+
Jeff King writes:
> - memcpy(buffer, filename, dirlen);
> - strcpy(buffer + dirlen, "tmp_obj_XX");
> - fd = git_mkstemp_mode(buffer, 0444);
> + strbuf_reset(tmp);
> + strbuf_add(tmp, filename, dirlen);
> + strbuf_addstr(tmp, "tmp_obj_XX");
> + fd = git_mkstemp_
On Wed, Sep 16, 2015 at 01:18:03PM -0700, Junio C Hamano wrote:
> > + /* Now go back and fill in the size */
> > + if (buffer.len > 0x)
> > die("Request too large to send");
> > + xsnprintf(buffer.buf, buffer.alloc, "%04x", (unsigned)buffer.len);
>
> So we now write "som
On Mon, Sep 14, 2015 at 1:44 PM, Mike Rappazzo wrote:
> On Sat, Sep 12, 2015 at 11:19 PM, Eric Sunshine
> wrote:
>> On Fri, Sep 4, 2015 at 5:39 PM, Michael Rappazzo wrote:
>>> + while (!matched && worktree_list) {
>>> + if (strcmp("HEAD", symref)) {
>>> +
On Wed, Sep 16, 2015 at 4:32 PM, Eric Sunshine wrote:
> On Mon, Sep 14, 2015 at 8:20 AM, Mike Rappazzo wrote:
>> On Sat, Sep 12, 2015 at 10:39 PM, Eric Sunshine
>> wrote:
+struct worktree {
+ char *path;
+ char *git_dir;
+ char *head_ref;
+ unsig
On Wed, Sep 16, 2015 at 12:52:26PM -0700, Junio C Hamano wrote:
> > diff --git a/remote.c b/remote.c
> > index 5ab0f7f..1b69751 100644
> > --- a/remote.c
> > +++ b/remote.c
> > @@ -297,7 +297,6 @@ static void read_branches_file(struct remote *remote)
> > int n = 1000;
> > FILE *f = fopen(g
On Mon, Sep 14, 2015 at 1:41 PM, Junio C Hamano wrote:
> Mike Rappazzo writes:
>> On Sat, Sep 12, 2015 at 10:39 PM, Eric Sunshine
>> wrote:
+struct worktree_list *get_worktree_list()
>>>
>>> Can we be more concise and call this get_worktrees()?
>>
>> I prefer 'get_worktree_list' because I
On Wed, Sep 16, 2015 at 12:19:10PM -0700, Stefan Beller wrote:
> > That will make future readers wonder "Is this a typo, and if it is,
> > which index is a mistake I can fix?" and may lead to an unnecessary
> > confusion. I do not want to see a correctly written
> >
> > xsnprintf(ownbuf[s
On Mon, Sep 14, 2015 at 8:20 AM, Mike Rappazzo wrote:
> On Sat, Sep 12, 2015 at 10:39 PM, Eric Sunshine
> wrote:
>>> +struct worktree {
>>> + char *path;
>>> + char *git_dir;
>>> + char *head_ref;
>>> + unsigned char head_sha1[20];
>>> + int is_detached;
>>> +
On Wed, Sep 16, 2015 at 12:07:30PM -0700, Junio C Hamano wrote:
> > Correct. The original is sane and gcc does the right thing. The question
> > is whether some compiler would complain that "stage" is not a constant
> > in the sizeof() expression. I don't know if any compiler would do so,
> > but
On Wed, Sep 16, 2015 at 11:43:49AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > + alloc = path_len + strlen(".pack") + 1;
> > + p = alloc_packed_git(alloc);
> > + memcpy(p->pack_name, path, path_len); /* NUL from zero-ed struct */
>
> This comment is confusing, isn't it? Yes, t
On Wed, Sep 16, 2015 at 11:13:37AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > + free(file);
> > + file = xstrfmt("%s/%s", maildir, list.items[i].string);
>
> Repeated pattern makes one wonder if a thin wrapper
>
> xstrfmt_to(&file, "%s/%s", maildir, list.i
Jeff King writes:
> static void send_git_request(int stdin_fd, const char *serv, const char
> *repo,
> const char *vhost)
> {
> - size_t bufferspace;
> - size_t wpos = 0;
> - char *buffer;
> + struct strbuf buffer = STRBUF_INIT;
>
> - /*
> - * Request needs 12
Hello all,
I've recently started to note an issue with git rebase -i failing with
alarming frequency, especially on one of my repositories, claiming
that index.lock could not be created because it exists, even though it
doesn't and nothing else seems to be locking the index. The rebase
bombs more
On Wed, Sep 16, 2015 at 03:14:24PM -0400, Eric Sunshine wrote:
> On Wed, Sep 16, 2015 at 3:12 PM, Junio C Hamano wrote:
> > Jeff King writes:
> >
> >> Speaking of which, how do you want the next round of patches? I'm
> >> hesitant to spam the list with 67 patches again, when only a fraction
> >>
Jeff King writes:
> This code is exactly replicating strdup, so let's just use
> that. It's shorter, and eliminates some confusion (such as
> whether "p - s" is really enough to hold the result; it is,
> because we write NULs as we shrink "p").
>
> Signed-off-by: Jeff King
> ---
> remote.c | 5
On Wed, Sep 16, 2015 at 3:38 PM, Eric Sunshine wrote:
> On the other hand, as far as I know, it's *always* safe to replace
> 'ar' with 'libtool' on this platform, so we could just do it
> unconditionally.
>
> --- 8< ---
> ifeq ($(uname_S),Darwin)
> + AR = libtool
> + ARFLAGS = -static
On Sun, Sep 13, 2015 at 10:52:36PM -0700, Junio C Hamano wrote:
> On Sun, Sep 13, 2015 at 9:59 PM, Jeff King wrote:
> >
> > My follow-up question was going to be: is this something we should be
> > setting in config.mak.uname for appropriate versions of Darwin? It
> > wasn't clear to me from Eric'
Jeff King writes:
> The ref-filter code comes from for-each-ref, and inherited a
> number of raw sprintf and strcpy calls. These are generally
> all safe, as we custom-size the buffers, or are formatting
> numbers into sufficiently large buffers. But we can make the
> resulting code even simpler
On Wed, Sep 16, 2015 at 12:07 PM, Junio C Hamano wrote:
> Jeff King writes:
>
>> On Wed, Sep 16, 2015 at 11:24:27AM -0700, Junio C Hamano wrote:
>>
>>> Jeff King writes:
>>>
>>> > On Tue, Sep 15, 2015 at 11:19:21PM -0400, Eric Sunshine wrote:
>>> >
>>> >> > strcpy(hexbuf[stage],
On Wed, Sep 16, 2015 at 3:12 PM, Junio C Hamano wrote:
> Jeff King writes:
>
>> Speaking of which, how do you want the next round of patches? I'm
>> hesitant to spam the list with 67 patches again, when only a fraction
>> have changed (and for all but the _to/_r thing, I've posted my changes
>> a
Jeff King writes:
> Speaking of which, how do you want the next round of patches? I'm
> hesitant to spam the list with 67 patches again, when only a fraction
> have changed (and for all but the _to/_r thing, I've posted my changes
> already).
Cannot tell yet, as I am only halfway thru myself. I
Jeff King writes:
> On Wed, Sep 16, 2015 at 11:24:27AM -0700, Junio C Hamano wrote:
>
>> Jeff King writes:
>>
>> > On Tue, Sep 15, 2015 at 11:19:21PM -0400, Eric Sunshine wrote:
>> >
>> >> > strcpy(hexbuf[stage], sha1_to_hex(ce->sha1));
>> >> > - sprintf(ownbuf[sta
On Wed, Sep 16, 2015 at 11:24:27AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > On Tue, Sep 15, 2015 at 11:19:21PM -0400, Eric Sunshine wrote:
> >
> >> > strcpy(hexbuf[stage], sha1_to_hex(ce->sha1));
> >> > - sprintf(ownbuf[stage], "%o", ce->ce_mode);
> >>
Jeff King writes:
> + alloc = path_len + strlen(".pack") + 1;
> + p = alloc_packed_git(alloc);
> + memcpy(p->pack_name, path, path_len); /* NUL from zero-ed struct */
This comment is confusing, isn't it? Yes, there is a NUL, but you
will going to overwrite it with "." in ".keep" imm
Jeff King writes:
> We generally use 32-byte buffers to format git's "type size"
> header fields. These should not generally overflow unless
> you can produce some truly gigantic objects (and our types
> come from our internal array of constant strings). But it is
> a good idea to use xsnprintf t
Jeff King writes:
> On Tue, Sep 15, 2015 at 11:19:21PM -0400, Eric Sunshine wrote:
>
>> > strcpy(hexbuf[stage], sha1_to_hex(ce->sha1));
>> > - sprintf(ownbuf[stage], "%o", ce->ce_mode);
>> > + xsnprintf(ownbuf[stage], sizeof(ownbuf[stage]), "%o",
>> >
Jeff King writes:
> I think a core file is even more useful than a backtrace. Having BUG()
> call abort() would be even more useful, I think.
Sounds like a plan ;-)
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
Mor
Acked-by: Phillip Sz
> Signed-off-by: Ralf Thielow
> ---
> po/de.po | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/po/de.po b/po/de.po
> index e5b523d..c9b4d16 100644
> --- a/po/de.po
> +++ b/po/de.po
> @@ -10530,9 +10530,8 @@ msgstr ""
> "hash[=]] [--abbrev[=]
Jeff King writes:
> + free(file);
> + file = xstrfmt("%s/%s", maildir, list.items[i].string);
Repeated pattern makes one wonder if a thin wrapper
xstrfmt_to(&file, "%s/%s", maildir, list.items[i].string);
that first frees the existing value and then overwrites i
On Wed, Sep 16, 2015 at 11:04:49AM -0700, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > Hi Peff,
> >
> > On 2015-09-15 17:24, Jeff King wrote:
> >> Commit 02976bf (fsck: introduce `git fsck --connectivity-only`,
> >> 2015-06-22) recently gave fsck an option to perform only a
> >> sub
Johannes Schindelin writes:
> Hi Peff,
>
> On 2015-09-15 17:24, Jeff King wrote:
>> Commit 02976bf (fsck: introduce `git fsck --connectivity-only`,
>> 2015-06-22) recently gave fsck an option to perform only a
>> subset of the checks, by skipping the fsck_object_dir()
>> call. However, it does so
On Tue, Sep 15, 2015 at 06:14:26PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > It seems like nobody is actually that interested in what "blame
> > --first-parent --reverse" does in the first place, though, and there's
> > no reason for its complexity to hold up vanilla --first-parent.
Translate 2 messages came from git.pot update in e447091
(l10n: git.pot: v2.6.0 round 2 (3 improvements)).
Signed-off-by: Ralf Thielow
---
po/de.po | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/po/de.po b/po/de.po
index e5b523d..c9b4d16 100644
--- a/po/de.po
+++ b/po/
On Wed, Sep 16, 2015 at 10:06:10AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > On Wed, Sep 16, 2015 at 10:15:02AM +0200, Johannes Schindelin wrote:
> >
> >> Maybe we should stick to the established practice of the many, many
> >> reentrant POSIX functions following the *_r() naming co
Jeff King writes:
> On Wed, Sep 16, 2015 at 10:15:02AM +0200, Johannes Schindelin wrote:
>
>> Maybe we should stick to the established practice of the many, many
>> reentrant POSIX functions following the *_r() naming convention? I.e.
>> the reentrant version of localtime() is called localtime_r(
On Wed, Sep 16, 2015 at 06:40:23AM -0700, Victor Leschuk wrote:
> Unfortunately using patch didn't change the situation. I will run some
> tests with alternate allocators (looking at jemalloc and tcmalloc). As
> for alternate tools: as far as I understood svn2git calls 'git svn'
> itself. So I ass
"Philip Oakley" writes:
> Oops..
> ...
>> Shall I just rework/resend the V2 patch-up ($gmane/277829) that also
>> links to 'merge's' usage as a fresh patch (would be tonight UK)?
>
> I now see that the full V2 patch is already there at 4934a96.
OK. I was wondering what I missed. 4934a96^2 is a
Michael Haggerty writes:
> I'm not sure what behavior you want. At one point you say "puts the file
> to a final place if it is non-empty" but later you say "leave it if
> non-empty". Should the file be written directly, or should it be written
> to a lockfile and renamed into place only when com
Lars Schneider writes:
>>> +git-p4.largeFileSystem::
>>> + Specify the system that is used for large (binary) files. Please note
>>> + that large file systems do not support the 'git p4 submit' command.
>>
>> Why is that? Is it just that you haven't implemented support, or
>> is it fundament
On Wed, Sep 16, 2015 at 06:50:38AM -0400, Jeff King wrote:
> On Wed, Sep 16, 2015 at 12:38:12AM -0400, Eric Sunshine wrote:
> > > @@ -1524,9 +1525,9 @@ int finish_http_pack_request(struct
> > > http_pack_request *preq)
> > > lst = &((*lst)->next);
> > > *lst = (*lst)->next;
On Wed, Sep 16, 2015 at 06:31:14AM -0400, Jeff King wrote:
> On Tue, Sep 15, 2015 at 08:55:58PM -0400, Eric Sunshine wrote:
> > On Tue, Sep 15, 2015 at 11:28 AM, Jeff King wrote:
> > > static const char *quote_crnl(const char *path)
> > > {
> > > - static char new_path[PATH_MAX];
> > > +
On Wed, Sep 16, 2015 at 05:57:41AM -0400, Jeff King wrote:
> On Tue, Sep 15, 2015 at 06:27:49PM -0700, Junio C Hamano wrote:
> > Eric Sunshine writes:
> > >> +static inline void strbuf_complete(struct strbuf *sb, char term)
> > >> +{
> > >> + if (sb->len && sb->buf[sb->len - 1] != term)
> >
On Wed, Sep 16, 2015 at 02:05:40PM +0200, Lars Schneider wrote:
> On 16 Sep 2015, at 10:36, Luke Diamand wrote:
> > On 14/09/15 14:26, larsxschnei...@gmail.com wrote:
> >> +test_file_in_mock () {
> >> + FILE="$1"
> > Missing &&
> > Plus the next few lines
> Are they strictly necessary? I believe
Hello Jeff, thanks for the advice.
Unfortunately using patch didn't change the situation. I will run some tests
with alternate allocators (looking at jemalloc and tcmalloc). As for alternate
tools: as far as I understood svn2git calls 'git svn' itself. So I assume it
can't fix the memory usage
From: Lars Schneider
If a path with non-ASCII characters is detected then print the
encoding and the encoded string in verbose mode.
Signed-off-by: Lars Schneider
---
git-p4.py | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index
From: Lars Schneider
Follow up patch for a9e38359 (git-p4: add config git-p4.pathEncoding,
2015-09-03) which is already on 'next'.
diff to v1 (wrongly called v7 in "[PATCH v7] git-p4: add config
git-p4.pathEncoding")
* make path encoding for utf-8 default case more explicit (thanks Junio!)
* im
On 16 Sep 2015, at 10:36, Luke Diamand wrote:
> On 14/09/15 14:26, larsxschnei...@gmail.com wrote:
>> From: Lars Schneider
>>
>> Perforce repositories can contain large (binary) files. Migrating these
>> repositories to Git generates very large local clones. External storage
>> systems such as
On Wed, Sep 16, 2015 at 04:00:48AM -0700, Victor Leschuk wrote:
> * git svn clone of trac takes about 1 hour
> * git svn clone of FreeBSD has already taken more than 3 days and
> still running (currently has cloned about 40% of revisions)
I haven't worked with git-svn in a long time, but I d
On 16 Sep 2015, at 00:12, Luke Diamand wrote:
> On 15/09/15 16:38, Lars Schneider wrote:
>>
>> On 15 Sep 2015, at 08:43, Luke Diamand wrote:
>>
>
>
>>> Do we know the mechanism by which we end up in this state?
>> Unfortunately no. I tried hard to reproduce the error with “conventional”
>>
Hello all,
We are currently getting acquainted with git-svn tool and have experienced few
problems with it. The main issue is memory usage during "git svn clone": on
large repositories the perl and git processes are using significant amount of
memory.
I have conducted several tests with diffe
On Wed, Sep 16, 2015 at 12:38:12AM -0400, Eric Sunshine wrote:
> > @@ -1524,9 +1525,9 @@ int finish_http_pack_request(struct http_pack_request
> > *preq)
> > lst = &((*lst)->next);
> > *lst = (*lst)->next;
> >
> > - tmp_idx = xstrdup(preq->tmpfile);
> > - strcp
On Wed, Sep 16, 2015 at 12:24:38AM -0400, Eric Sunshine wrote:
> On Tue, Sep 15, 2015 at 11:45 AM, Jeff King wrote:
> > replace trivial malloc + sprintf /strcpy calls to xstrfmt
>
> s/to/with/
>
> Also, do you want either to add a space after '/' or drop the one before it?
Thanks, fixed both.
On Tue, Sep 15, 2015 at 06:54:28PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > Obviously this is not intended for v2.6.0. But all of the spots touched
> > here are relatively quiet right now, so I wanted to get it out onto the
> > list. There are a few minor conflicts against "pu", b
On Wed, Sep 16, 2015 at 10:15:02AM +0200, Johannes Schindelin wrote:
> Maybe we should stick to the established practice of the many, many
> reentrant POSIX functions following the *_r() naming convention? I.e.
> the reentrant version of localtime() is called localtime_r(), the
> reentrant version
On Tue, Sep 15, 2015 at 08:55:58PM -0400, Eric Sunshine wrote:
> On Tue, Sep 15, 2015 at 11:28 AM, Jeff King wrote:
> > When we output GIT_TRACE_SETUP paths, we quote any
> > meta-characters. But our buffer to hold the result is only
> > PATH_MAX bytes, and we could double the size of the input
>
On Wed, Sep 16, 2015 at 06:14:18AM -0400, Jeff King wrote:
> I guess we could get away with always calling free() right before
> assigning (the equivalent of strbuf_reset()), and then rely on exiting
> the loop to "out" to do the final free. And then the result (versus the
> original code, not my
On Tue, Sep 15, 2015 at 08:51:26PM -0400, Eric Sunshine wrote:
> > if (strbuf_getwholeline(&buf, f, '\n')) {
> > - error("cannot read mail %s (%s)", file,
> > strerror(errno));
> > + error("cannot read mail %s (%s)", file.buf,
> > strer
On Tue, Sep 15, 2015 at 06:27:49PM -0700, Junio C Hamano wrote:
> Eric Sunshine writes:
>
> >> +static inline void strbuf_complete(struct strbuf *sb, char term)
> >> +{
> >> + if (sb->len && sb->buf[sb->len - 1] != term)
> >> + strbuf_addch(sb, term);
> >> +}
> >
> > Hmm, so
On Tue, Sep 15, 2015 at 11:19:21PM -0400, Eric Sunshine wrote:
> > strcpy(hexbuf[stage], sha1_to_hex(ce->sha1));
> > - sprintf(ownbuf[stage], "%o", ce->ce_mode);
> > + xsnprintf(ownbuf[stage], sizeof(ownbuf[stage]), "%o",
> > ce->ce_mode);
>
> Interest
On Tue, Sep 15, 2015 at 01:38:42PM -0700, Stefan Beller wrote:
> Some off topic thoughts:
>
> Having an "assert" behavior is not a good user experience though
> and should be fixed. To fix it we need stack traces. And the git
> version. And telling the user to send it to the mailing list.
Yes, a
Hi Alexey,
On 2015-09-16 10:01, Alexey Kasyanchuk wrote:
> I tried add one of node.js module to git project. But add operation failed:
>
> libgit2 returned: Invalid path for filesystem
> 'E:/Projects/vsteams/node_modules/gulp-imagemin/node_modules/imagemin/node_modules/imagemin-gifsicle/node_modu
On 09/14/2015 07:37 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Thanks, will queue.
>
> Ehh, I spoke a bit too early.
>
>>> diff --git a/builtin/gc.c b/builtin/gc.c
>>> index bcc75d9..2c3aaeb 100644
>>> --- a/builtin/gc.c
>>> +++ b/builtin/gc.c
>>> @@ -43,9 +43,20 @@ static struct a
On 14/09/15 14:26, larsxschnei...@gmail.com wrote:
From: Lars Schneider
Perforce repositories can contain large (binary) files. Migrating these
repositories to Git generates very large local clones. External storage
systems such as Git LFS [1], Git Fat [2], Git Media [3], git-annex [4]
try to a
Hi Junio, Jeff & Ramsay,
On 2015-09-16 03:32, Junio C Hamano wrote:
> Jeff King writes:
>
>>> Hmm, I haven't read any other patches yet (including those which use these
>>> new '_to' functions), but I can't help feeling they should be named
>>> something
>>> like 'sha1_to_hex_str()' and 'find_u
I tried add one of node.js module to git project. But add operation failed:
libgit2 returned: Invalid path for filesystem
'E:/Projects/vsteams/node_modules/gulp-imagemin/node_modules/imagemin/node_modules/imagemin-gifsicle/node_modules/gifsicle/node_modules/bin-build/node_modules/decompress/node_m
96 matches
Mail list logo
