Re: [PATCH v2] sha1_file: pass empty buffer to index empty file

2015-05-15 Thread Jim Hill
On Fri, May 15, 2015 at 11:01:34AM -0700, Junio C Hamano wrote: > That would mean that you found _another_ bug, wouldn't it? If > copy-fd failed to read input to feed the external filter with, it > must have returned an error to its caller, and somebody in the > callchain is not paying attention t

Re: [PATCH v7 5/5] help.c: output the typical Git workflow

2015-05-15 Thread Eric Sunshine
On Fri, May 15, 2015 at 2:35 PM, Sébastien Guimmara wrote: > Subject: help.c: output the typical Git workflow A more meaningful summary might be: help: respect new common command grouping or something. > 'git help' shows common commands in alphabetical order: > > The most commonly used git

Re: [PATCH v7 0/5] git help: group common commands by theme

2015-05-15 Thread Junio C Hamano
Eric Sunshine writes: >> rebased on 'next' (a2776d4) > > Something to keep in mind for the future: It's usually easier to > manage preparatory cleanup patches by incorporating them into the > series which needs/wants them rather than posting them as separate > topics. That way, your patch series

Re: [PATCH v7 1/5] command-list.txt: prepare with [commands] header

2015-05-15 Thread Junio C Hamano
Sébastien Guimmara writes: > diff --git a/Makefile b/Makefile > index 25a453b..0cb2045 100644 > --- a/Makefile > +++ b/Makefile > @@ -2454,7 +2454,7 @@ check-docs:: > esac ; \ > test -f "Documentation/$$v.txt" || \ > echo "no doc: $$v"; \ > -

[PATCH v7 2/5] command-list.txt: add a [common] block

2015-05-15 Thread Sébastien Guimmara
Add a [common] block at the beginning of command-list.txt: [common] init start a working area (see also: git help tutorial) worktree work on the current change (see also:[...] info examine the history and state (see also: git [...] history grow, mark an

Re: [PATCH 2/2] http-backend: spool ref negotiation requests to buffer

2015-05-15 Thread Junio C Hamano
Jeff King writes: > The solution is fairly straight-forward: we read the request > body into an in-memory buffer in http-backend, freeing up > Apache, and then feed the data ourselves to upload-pack. But > there are a few important things to note: > > 1. We limit in-memory buffer to no larger t

Re: determine a linux kernel version of a patch file

2015-05-15 Thread Johannes Schindelin
Hi, On 2015-05-15 19:03, Kelvin Li wrote: > On Fri, 2015-05-15 at 14:08 +0200, Matthieu Moy wrote: >> Pawel Por writes: >> >> > At the beginning I'm sorry if this post is completely unrelated to >> > this mailing list. >> > I'm trying to find the base linux kernel version from which a patch >> >

Re: [PATCH 0/2] fix http deadlock on giant ref negotiations

2015-05-15 Thread Jeff King
On Fri, May 15, 2015 at 09:41:20AM +0200, Dennis Kaarsemaker wrote: > > I have no clue how to write a test that would trigger this reliably > > without requiring a gigantic test fixture. However, I did confirm that > > it fixes the problem on the chromium case you provided (which otherwise > > dea