Re: support git+mosh for unreliable connections

2015-04-21 Thread Andreas Krey
On Wed, 15 Apr 2015 21:25:44 +, Dennis Kaarsemaker wrote: ... > It does not and cannot work. The way mosh works, is that it uses ssh to > log in and launch a mosh-server daemon. This daemon and the mosh client > then communicate via a custom UDP protocol. The SSH connection is closed > after th

Re: git's directory is _prepended_ to PATH when called with an absolute path

2015-04-21 Thread Andreas Krey
On Tue, 21 Apr 2015 18:37:29 +, David Rodríguez wrote: ... > This causes issues with Ruby git hooks, because Ruby version managers > rely on custom settings in PATH to select the Ruby executable, Even if git wouldn't modify PATH this is still a broken way to do that. What ruby to execute a ho

Wrong gitignore precedence?

2015-04-21 Thread Yohei Endo
Hello All, I read the document of gitignore (http://git-scm.com/docs/gitignore), and learned that $GIT_DIR/info/exclude has higher precedence than the file specified by core.excludesfile. But I noticed that patterns in core.excludesfile override patterns in $GIT_DIR/info/exclude. I tested as bel

Re: [BUG] Performance regression due to #33d4221: write_sha1_file: freshen existing objects

2015-04-21 Thread Stefan Saasen
> Perhaps companies like Atlassian that rely on the stability of the > open source Git can spare some resources and join forces with like > minded folks on LTS of older maintenance tracks, if they are truly > interested in. We certainly can and would like to. I'm not entirely sure what that would

Re: PATH modifications for git-hook processes

2015-04-21 Thread David Rodríguez
Jeff King peff.net> writes: > > If we can get away with just dropping this element from the PATH, I'd > much rather do that than try to implement a complicated path-precedence > scheme. > > -Peff > I agree, GIT_EXEC_DIR should be enough and this surprising behavior would be avoided. -- To uns

[PATCH] builtin/merge.c: add the merge.verifysignatures config option

2015-04-21 Thread Bruno Vieira
Signed-off-by: Bruno Vieira --- This seemed to be missing. Sorry if otherwise or if I'm doing something wrong (first time contributing). builtin/merge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/builtin/merge.c b/builtin/merge.c index 3b0f8f9..5dbc10f 100644 --- a/builtin/merge.c +

Re: [BUG] Performance regression due to #33d4221: write_sha1_file: freshen existing objects

2015-04-21 Thread Stefan Saasen
>> I've noticed Peff's patches on pu which suggest they will be available >> in git 2.5? > > Being on 'pu' (or 'next' for that matter) is not a suggestion for a > change to appear in any future version at all, even though it often > means that it would soon be merged to 'master' and will be in the

Re: [PATCH 0/3] Another approach to large transactions

2015-04-21 Thread Jeff King
On Mon, Apr 20, 2015 at 05:31:11PM -0700, Stefan Beller wrote: > When running the test locally, i.e. not in the test suite, but typing > the commands > myself into the shell, Git is fine with having just 5 file descriptors left. > The additional 4 required fds come from beign run inside the test s

[PATCH] RFC/Add documentation for version protocol 2

2015-04-21 Thread Stefan Beller
This adds the design document for protocol version 2. It's better to rewrite the design document instead of trying to squash it into the existing pack-protocol.txt and then differentiating between version 1 and 2 all the time. Signed-off-by: Stefan Beller --- As we discussed at Git Merge in P

Re: git's directory is _prepended_ to PATH when called with an absolute path

2015-04-21 Thread David Rodríguez
I'm actually not sure how to reply to an old thread... From the thread I gather that the intention is to prevent this behavior and stop prepending git's directory to the path. Is that right? On 21/04/15 18:59, David Rodríguez wrote: Thanks Junio for the useful link, I'll comment there. On 21

Re: [PATCH 7/9] strbuf_getwholeline: use getdelim if it is available

2015-04-21 Thread Jeff King
On Fri, Apr 17, 2015 at 06:16:48AM -0400, Eric Sunshine wrote: > > If somebody has a FreeBSD or OS X system to test on, I'd > > love to see what is needed to compile with HAVE_GETDELIM > > there. > > Modern Mac OS X, 10.10.x Yosemite, has getdelim() and git builds fine > with HAVE_GETDELIM. I als

[PATCH 3/3] git-multimail: Add stdout option to config

2015-04-21 Thread Dave Boutcher
Add a stdout option to the config that is equivalent to the --stdout command line option. This allows for easier debugging for a hook Signed-off-by: Dave Boutcher --- git-multimail/README | 5 + git-multimail/git_multimail.py | 10 +- 2 files changed, 14 insertions(+), 1 d

[PATCH 1/3] git-multimail: Add an option to filter on branches

2015-04-21 Thread Dave Boutcher
Add a branches option to the config. Only changes pushed to specified branches will generate emails. Changes to tags will continue to generate emails. Signed-off-by: Dave Boutcher --- git-multimail/README | 7 +++ git-multimail/git_multimail.py | 44 ++

[PATCH 2/3] git-multimail: Add a quiet option to prevent outputting email addresses from hook

2015-04-21 Thread Dave Boutcher
We have a very log list of recipients...displaying that list on every push is annoying Add an option to prevent printing the list of email addresses from the hook Signed-off-by: Dave Boutcher --- git-multimail/README | 3 +++ git-multimail/git_multimail.py | 11 ++- 2 files c

Re: How do I resolve conflict after popping stash without adding the file to index?

2015-04-21 Thread Jeff King
On Wed, Apr 22, 2015 at 01:35:05AM +0300, Dmitry Gutov wrote: > >But we seem to skip that safety valve when the content has been staged, > >which seems questionable to me (technically we are slightly better off > >than the protected case because "b" was written to a git blob > >object, so you

[PATCH V3 0/2] git-p4: improve client path detection when branches are used

2015-04-21 Thread Vitor Antunes
The updates introduced in the third revision of these two patches consist only on updates to the commit messages to better clarify what they implement. Vitor Antunes (2): t9801: check git-p4's branch detection with client spec enabled git-p4: improve client path detection when branches are use

[PATCH V3 2/2] git-p4: improve client path detection when branches are used

2015-04-21 Thread Vitor Antunes
Perforce allows client side file/directory remapping through the use of the client view definition that is part of the user's client spec. To support this functionality while branch detection is enabled it is important to determine the branch location in the workspace such that the correct files a

[PATCH V3 1/2] t9801: check git-p4's branch detection with client spec enabled

2015-04-21 Thread Vitor Antunes
Add failing scenario when branch detection (--detect-branches) is enabled together with use client spec (--use-client-spec). In this specific scenario git-p4 will break when the Perforce client view removes part of the depot path, as in the following example: //depot/branch1/base/... //client/br

Re: How do I resolve conflict after popping stash without adding the file to index?

2015-04-21 Thread Dmitry Gutov
On 04/22/2015 12:29 AM, Jeff King wrote: Hmm, interestingly, if you do _not_ stage the changes (i.e., drop the final "git add" there), you get: $ git stash pop error: Your local changes to the following files would be overwritten by merge: test Please, commit your changes or s

Re: git's directory is _prepended_ to PATH when called with an absolute path

2015-04-21 Thread David Rodríguez
Thanks Junio for the useful link, I'll comment there. On 21/04/15 18:48, Junio C Hamano wrote: http://thread.gmane.org/gmane.comp.version-control.git/267143/focus=267251 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More

[ANNOUNCE] Git v2.3.6

2015-04-21 Thread Junio C Hamano
The latest maintenance release Git v2.3.6 is now available at the usual places. It is comprised of 14 non-merge commits since v2.3.5, contributed by 8 people, 4 of which are new faces. There is not much to see there (the changes are mostly documentation and test updates), except for updates to di

Re: git's directory is _prepended_ to PATH when called with an absolute path

2015-04-21 Thread Junio C Hamano
http://thread.gmane.org/gmane.comp.version-control.git/267143/focus=267251 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [BUG] Performance regression due to #33d4221: write_sha1_file: freshen existing objects

2015-04-21 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Saasen writes: > >> I've noticed Peff's patches on pu which suggest they will be available >> in git 2.5? > > Being on 'pu' (or 'next' for that matter) is not a suggestion for a > change to appear in any future version at all, even though it often > means that it

git's directory is _prepended_ to PATH when called with an absolute path

2015-04-21 Thread David Rodríguez
For example, if I run git using: $ /usr/bin/git then /usr/bin is prepended to the path. Is this intentional? If it is, why? This causes issues with Ruby git hooks, because Ruby version managers rely on custom settings in PATH to select the Ruby executable, and there's usually a system Ruby li

Re: How do I resolve conflict after popping stash without adding the file to index?

2015-04-21 Thread Jeff King
On Tue, Apr 21, 2015 at 01:54:56AM +0300, Dmitry Gutov wrote: > I'm not really sure what "higher stage entries" are, but this scenario seems > to be a counter-example: > > git init > echo "a" > test > git add test > git commit -m "first" > echo "aaa" > test > git stash save > echo "b" > t

Re: [PATCH/RFC v3 0/4] Improving performance of git clean

2015-04-21 Thread Jeff King
On Tue, Apr 21, 2015 at 08:21:37PM +0200, erik elfström wrote: > Ok, thanks for looking into this. > > I have no well founded opinions on the implementation but I do > think the performance tests would be more meaningful if the > setup/cleanup code could be removed from the timed section. > If th

Re: Regular Rebase Failure

2015-04-21 Thread Jeff King
On Tue, Apr 21, 2015 at 11:34:37AM -0700, Stefan Beller wrote: > [+mailing list] > > On Tue, Apr 21, 2015 at 11:20 AM, Adam wrote: > > I'm using git version 2.3.2 (Apple Git-55). > > We should loop in the maintainers of the Apple Git version, they'd know > what changed in git about two weeks ag

Re: [PATCH] pathspec: adjust prefixlen after striping trailing slash

2015-04-21 Thread Junio C Hamano
Duy Nguyen writes: > On Mon, Apr 20, 2015 at 12:37 PM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> But if you look at it another way, "cd subrepo; git add ." should be >>> the same as "git add subrepo" ... >> >> Once you cd into "subrepo", you are in a different world, a world >> differe

Re: [PATCH v8 2/4] cat-file: teach cat-file a '--literally' option

2015-04-21 Thread Junio C Hamano
Eric Sunshine writes: > It's easy to be blinded into thinking that cat-file's new option > should be named --literally since it was inspired by the --literally > option of hash-object, but indeed it may not be the best choice. Yeah, I wouldn't even say "inspired". It was envisioned as a counter

Re: [PATCHv2] refs.c: enable large transactions

2015-04-21 Thread Stefan Beller
> > * Removed unneeded braces in the condition to check if we want to close > the lock file. > * made the counter for the remaining fds an unsigned int. That is what > get_max_fd_limit() returns, so there are no concerns for an overflow. > Also it cannot go below 0 any more. > * moved the ini

Re: [PATCH v8 2/4] cat-file: teach cat-file a '--literally' option

2015-04-21 Thread Eric Sunshine
On Tue, Apr 21, 2015 at 6:16 AM, Charles Bailey wrote: > On Mon, Apr 20, 2015 at 09:22:47PM +0530, karthik nayak wrote: >> On 04/20/2015 02:49 PM, Charles Bailey wrote: >> >As far as I could tell - and please correct me if I've misunderstood, >> >cat-file's literally is about dealing with unrecogn

Re: [BUG] Git does not convert CRLF=>LF on files with \r not before \n

2015-04-21 Thread Torsten Bögershausen
On 2015-04-21 15.51, Alexandre Garnier wrote: > Here is a test: > > git init -q crlf-test > cd crlf-test > echo '* text=auto' > .gitattributes > git add .gitattributes > git commit -q -m "Normalize EOL" > echo -ne 'some content\r\nother \rcontent with CR\r\ncontent\r\nagain > content with\r\

[PATCHv2] refs.c: enable large transactions

2015-04-21 Thread Stefan Beller
This is another attempt on enabling large transactions (large in terms of open file descriptors). We keep track of how many lock files are opened by the ref_transaction_commit function. When more than a reasonable amount of files is open, we close the file descriptors to make sure the transaction c

Re: [PATCH/RFC v3 0/4] Improving performance of git clean

2015-04-21 Thread Junio C Hamano
erik elfström writes: > Ok, thanks for looking into this. > > I have no well founded opinions on the implementation but I do > think the performance tests would be more meaningful if the > setup/cleanup code could be removed from the timed section. > If the community agrees on an implementation I

Re: Regular Rebase Failure

2015-04-21 Thread Stefan Beller
[+mailing list] On Tue, Apr 21, 2015 at 11:20 AM, Adam wrote: > I'm using git version 2.3.2 (Apple Git-55). We should loop in the maintainers of the Apple Git version, they'd know what changed in git about two weeks ago. I have no idea who that is though. > > That explains why I can't find the

Re: [PATCH/RFC v3 0/4] Improving performance of git clean

2015-04-21 Thread erik elfström
Ok, thanks for looking into this. I have no well founded opinions on the implementation but I do think the performance tests would be more meaningful if the setup/cleanup code could be removed from the timed section. If the community agrees on an implementation I would be happy to convert the new

Re: [PATCH/RFC v3 0/4] Improving performance of git clean

2015-04-21 Thread erik elfström
On Sun, Apr 19, 2015 at 3:14 AM, Junio C Hamano wrote: > Erik Elfström writes: > >> Known Problems: >> * Unsure about the setup.c:read_gitfile refactor, feels a bit >> messy? > > The interface indeed feels somewhat messy. I suspect that a better > interface might be more like setup_git_directo

Re: [PATCH] refs.c: enable large transactions

2015-04-21 Thread Junio C Hamano
Stefan Beller writes: > I thought about putting a cap on it to not let it go negative in the first > place, but I did not find an easily accessible max() function, as I'd like > to write it as > > int remaining_fds = max(get_max_fd_limit() - 32, 0); > > to have it in one line. The alternative

Re: Regular Rebase Failure

2015-04-21 Thread Stefan Beller
On Tue, Apr 21, 2015 at 10:16 AM, Adam wrote: > About two weeks ago I started getting a regular rebase failure. I get this > error several times a day and at least once a day I lose work to it. Which git version are you using? > --- > fatal: Unable to create '/Users/asteel/path/to/repo/.git/inde

Re: [PATCH] squash! bash-completion: add support for git-log --merges= and log.merges

2015-04-21 Thread Junio C Hamano
Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [BUG] Git does not convert CRLF=>LF on files with \r not before \n

2015-04-21 Thread Junio C Hamano
Alexandre Garnier writes: > echo '* text=auto' > .gitattributes > git add .gitattributes > git commit -q -m "Normalize EOL" > echo -ne 'some content\r\nother \rcontent with CR\r\ncontent\r\nagain With text=auto, the user instructs us to guess, and we expect either LF or CRLF line-terminate

Re: [PATCH 0/3] Another approach to large transactions

2015-04-21 Thread Stefan Beller
On Tue, Apr 21, 2015 at 10:19 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Mon, Apr 20, 2015 at 3:51 PM, Junio C Hamano wrote: >> >>> On the core management side, xmalloc() and friends retry upon >>> failure, after attempting to free the resource. I wonder if your >>> codepath can

Re: [PATCH] refs.c: enable large transactions

2015-04-21 Thread Stefan Beller
On Tue, Apr 21, 2015 at 10:16 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> + /* >> + * We may want to open many files in a large transaction, so come up >> with >> + * a reasonable maximum, keep some spares for stdin/out and other open >> + * files. >> + */ >> +

Re: [PATCH] refs.c: enable large transactions

2015-04-21 Thread Junio C Hamano
Stefan Beller writes: > This replaces the latest patch on origin/sb/remove-fd-from-ref-lock Thanks, will replace. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

Re: [PATCH 0/3] Another approach to large transactions

2015-04-21 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Apr 20, 2015 at 3:51 PM, Junio C Hamano wrote: > >> On the core management side, xmalloc() and friends retry upon >> failure, after attempting to free the resource. I wonder if your >> codepath can do something similar to that, perhaps? > > But then we'd need to

Re: [PATCH] refs.c: enable large transactions

2015-04-21 Thread Junio C Hamano
Stefan Beller writes: > + /* > + * We may want to open many files in a large transaction, so come up > with > + * a reasonable maximum, keep some spares for stdin/out and other open > + * files. > + */ > + int remaining_fds = get_max_fd_limit() - 32; Can this go nega

Regular Rebase Failure

2015-04-21 Thread Adam
About two weeks ago I started getting a regular rebase failure. I get this error several times a day and at least once a day I lose work to it. --- fatal: Unable to create '/Users/asteel/path/to/repo/.git/index.lock': File exists. If no other git process is currently running, this probably means

Re: [BUG] Performance regression due to #33d4221: write_sha1_file: freshen existing objects

2015-04-21 Thread Junio C Hamano
Stefan Saasen writes: > I've noticed Peff's patches on pu which suggest they will be available > in git 2.5? Being on 'pu' (or 'next' for that matter) is not a suggestion for a change to appear in any future version at all, even though it often means that it would soon be merged to 'master' and

Re: Why does "git log -G" works with "regexp-ignore-case" but not with other regexp-related options?

2015-04-21 Thread Junio C Hamano
Michael J Gruber writes: > We have engine-switching options and engine-modification options. The > latter are certainly good in the expression itself. Maybe even the > former, though I don't know how to switch away from fixed-strings in > that way... I do not think mixing matching engines in a s

Re: git-p4 Question

2015-04-21 Thread Luke Diamand
Can you post up the output from 'git p4 clone', and also see what the output from doing this is: $ p4 print //depot/some/branch/missingfile.c On 21 April 2015 at 14:33, FusionX86 wrote: > Hi Luke, > > Using -v was a good suggestion. Unfortunately I still don't see what > the problem is. I'm st

Re: [PATCH v8 1/4] sha1_file.c: support reading from a loose object of unknown type

2015-04-21 Thread Jeff King
On Tue, Apr 21, 2015 at 04:56:08PM +0530, karthik nayak wrote: > >>+ status = unpack_sha1_header(stream, map, mapsize, buffer, bufsiz); > > > >I wonder if we would feel comfortable just running this NUL-check as > >part of unpack_sha1_header (i.e., in all code paths). It _shouldn't_ > >trigg

[BUG] Git does not convert CRLF=>LF on files with \r not before \n

2015-04-21 Thread Alexandre Garnier
Here is a test: git init -q crlf-test cd crlf-test echo '* text=auto' > .gitattributes git add .gitattributes git commit -q -m "Normalize EOL" echo -ne 'some content\r\nother \rcontent with CR\r\ncontent\r\nagain content with\r\r\n' > inline-cr.txt echo "Working directory content:" cat -A in

Re: git-p4 Question

2015-04-21 Thread FusionX86
Hi Luke, Using -v was a good suggestion. Unfortunately I still don't see what the problem is. I'm starting to think that maybe I should just create the client views I need and setup a cron job that p4 syncs and then git commits/pushes. The --preserve-user option is for submitting back to Perforce

Re: git-p4 Question

2015-04-21 Thread FusionX86
Thanks Sam, I'll check it out. On Mon, Apr 20, 2015 at 12:23 PM, Sam Vilain wrote: > On 04/20/2015 09:41 AM, FusionX86 wrote: >> >> Hopefully this is an appropriate place to ask questions about git-p4. >> >> I started at a company that wants to migrate from Perforce to Git. I'm >> new to Perforce

[PATCH] squash! bash-completion: add support for git-log --merges= and log.merges

2015-04-21 Thread SZEDER Gábor
--- The patch at the tip of kk/log-merges-config misindented one of the case arms, this one amends it. contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index

Re: [PATCH 0/3] Another approach to large transactions

2015-04-21 Thread Michael Haggerty
On 04/21/2015 12:51 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> The problem comes from guessing the number of fds we're allowed to use. >> At first I thought it was a fundamental issue with the code being broken, but >> it turns out we just need a larger offset as we apparently have 9

Re: [PATCH v8 1/4] sha1_file.c: support reading from a loose object of unknown type

2015-04-21 Thread karthik nayak
On 04/21/2015 12:21 AM, Jeff King wrote: On Tue, Apr 21, 2015 at 12:13:30AM +0530, karthik nayak wrote: +static int unpack_sha1_header_to_strbuf(git_zstream *stream, unsigned char *map, + unsigned long mapsize, void *buffer, +

[PATCH] Documentation/git-merge.txt: improve SYNOPSIS

2015-04-21 Thread sorganov
From: Sergey Organov Get rid of outdated explicit list of options. Reflect that the obsolete form: 'git merge' HEAD ... could also have options. Signed-off-by: Sergey Organov --- Documentation/git-merge.txt | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documenta

Re: [PATCH v8 2/4] cat-file: teach cat-file a '--literally' option

2015-04-21 Thread Charles Bailey
On Mon, Apr 20, 2015 at 09:22:47PM +0530, karthik nayak wrote: > > > On 04/20/2015 02:49 PM, Charles Bailey wrote: > >As far as I could tell - and please correct me if I've misunderstood, > >cat-file's literally is about dealing with unrecognized types whereas > >hash-object's --literally is abou

Re: Why does "git log -G" works with "regexp-ignore-case" but not with other regexp-related options?

2015-04-21 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 20.04.2015 20:44: > Linus Torvalds writes: > >> And to clarify: I don't suggest always building with libpcre. I >> literally suggest having something like >> >> /* hacky mac-hack hack */ >> if (strncmp("(?i)", p->pattern, 4)) { >> p->pattern +=

Re: [BUG] "git pull" will regress between 'master' and 'pu'

2015-04-21 Thread Johannes Schindelin
Hi Junio, On 2015-04-20 21:28, Junio C Hamano wrote: > Junio C Hamano writes: > >> This is primarily note-to-self; even though I haven't got around >> bisecting yet, I think I know I did some bad change myself. >> >> "git pull $URL $tag" seems to: >> >> * fail to invoke the editor without "--ed

Re: [PATCH V2 1/2] t9801: check git-p4's branch detection and client view together

2015-04-21 Thread Vitor Antunes
On April 20, 2015 11:45:15 PM GMT+01:00, Junio C Hamano wrote: >Vitor Antunes writes: > >> On April 20, 2015 6:43:49 AM GMT+01:00, Junio C Hamano > wrote: >>>Vitor Antunes writes: >>> Add failing scenario where branch detection is enabled together >with use client view. In this specif