On 3 September 2014 00:12, Junio C Hamano wrote:
> Arjun Sreedharan writes:
>
>> @number first, @size second argument.
>>
>> Signed-off-by: Arjun Sreedharan
>> ---
>> builtin/for-each-ref.c| 2 +-
>
> Thanks. compat/regex/ being borrowed code, I'd prefer not to touch
> them, though.
>
Am 03.09.2014 00:06, schrieb Junio C Hamano:
> * jt/timer-settime (2014-08-29) 9 commits
> - use timer_settime() for new platforms
> - autoconf: check for timer_settime()
> - autoconf: check for struct itimerspec
> - autoconf: check for struct sigevent
> - autoconf: check for struct timespec
>
On Wed, Sep 3, 2014 at 5:17 AM, Peter Wu wrote:
> Hi,
>
> The `git archive` seems to accept a pathspec judging from the error message
> (git
> version 2.1.0):
>
> git archive HEAD -- :x
> fatal: pathspec 'x' did not match any files
>
> When I try to use deeper glob specs however, it throw
On Wed, Sep 3, 2014 at 5:22 PM, Chris Packham wrote:
> Hi Paul,
>
> Just noticed something in the version of gitk included in git 2.0.3.
>
> When I right click on a commit and select "write commit to file" the
> resulting file has the diff from the selected commit but the commit
> message from the
Hi Paul,
Just noticed something in the version of gitk included in git 2.0.3.
When I right click on a commit and select "write commit to file" the
resulting file has the diff from the selected commit but the commit
message from the previous commit.
Attached is an example from running gitk on git
Am 02.09.2014 um 21:23 schrieb Junio C Hamano:
René Scharfe writes:
Use starts_with() instead of memcmp() to check if NUL-terminated
strings match prefixes. This gets rid of some magic string length
constants.
Signed-off-by: Rene Scharfe
---
imap-send.c | 9 ++---
1 file changed, 6 i
On Tue, 2014-09-02 at 15:39 -0700, Junio C Hamano wrote:
> We punt from repairing the cache-tree during a branch switching if
> it involves having to create a new tree object that does not yet
> exist in the object store. "mkdir dir && >dir/file && git add dir"
> followed by "git checkout" is one
On Tue, Aug 19, 2014 at 4:35 PM, Chris Packham wrote:
> On Tue, Aug 19, 2014 at 4:33 PM, Chris Packham
> wrote:
>> Hi,
>>
>> I was just setting up a new project using submodules and have run into
>> what appears to be a hang when git status is invoked. I haven't tried
>> to reproduce this but th
> -Original Message-
> From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On
> Behalf Of Jonas 'Sortie' Termansen
> Sent: Friday, August 29, 2014 12:44 PM
> To: Junio C Hamano
> Cc: git@vger.kernel.org; Keller, Jacob E; Johannes Sixt
> Subject: Re: [PATCH 1/9] git-compat-uti
Hi,
The `git archive` seems to accept a pathspec judging from the error message (git
version 2.1.0):
git archive HEAD -- :x
fatal: pathspec 'x' did not match any files
When I try to use deeper glob specs however, it throws an error (this also
happens if I use `:(glob)**/Makefile`, tested
We punt from repairing the cache-tree during a branch switching if
it involves having to create a new tree object that does not yet
exist in the object store. "mkdir dir && >dir/file && git add dir"
followed by "git checkout" is one example, when a tree that records
the state of such "dir/" is not
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.
The first batch of topics have graduated to 'master'.
You can find the changes described here in the integration branches
of the repositories l
We punt from "repair"ing the hash tree during a branch switching if
it involves having to create a new tree object that does not yet
exist in the object store. "mkdir dir && >dir/file && git add dir"
followed by "git checkout" is one example, when a tree that records
the state of such "dir/" is no
This makes it more obvious at a glance where the output of functions
parsing the --stdin stream goes.
No functional change intended.
Signed-off-by: Jonathan Nieder
Reviewed-by: Michael Haggerty
---
Thanks for reading.
builtin/update-ref.c | 27 +++
1 file changed, 15 i
Junio C Hamano writes:
> John Keeping writes:
>
>> On Fri, Jul 11, 2014 at 09:44:33PM -0700, David Turner wrote:
>>> When git checkout checks out a branch, create or update the
>>> cache-tree so that subsequent operations are faster.
>>>
>>> update_main_cache_tree learned a new flag, WRITE_TREE
Making the strbuf local in each function that needs to print errors
saves the reader from having to think about action at a distance,
such as
* errors piling up and being concatenated with no newline between
them
* errors unhandled in one function, to be later handled in another
* concurrenc
From: Ronnie Sahlberg
Date: Wed, 30 Apr 2014 09:22:45 -0700
Change delete_ref to use a ref transaction for the deletion. At the same time
since we no longer have any callers of repack_without_ref we can now delete
this function.
Change delete_ref to return 0 on success and 1 on failure instead o
From: Ronnie Sahlberg
Date: Wed, 30 Apr 2014 09:03:36 -0700
Change prune_ref to delete the ref using a ref transaction. To do this we also
need to add a new flag REF_ISPRUNING that will tell the transaction that we
do not want to delete this ref from the packed refs. This flag is private to
refs.
From: Ronnie Sahlberg
Date: Tue, 29 Apr 2014 15:45:52 -0700
lock_ref_sha1 was only called from one place in refs.c and only provided
a check that the refname was sane before adding back the initial "refs/"
part of the ref path name, the initial "refs/" that this caller had already
stripped off be
From: Ronnie Sahlberg
Date: Tue, 29 Apr 2014 13:42:07 -0700
Since we only call update_ref_write from a single place and we only call it
with onerr==QUIET_ON_ERR we can just as well get rid of it and just call
write_ref_sha1 directly. This changes the return status for _commit from
1 to -1 on fail
From: Ronnie Sahlberg
Date: Tue, 29 Apr 2014 12:14:47 -0700
Since we now only call update_ref_lock with onerr==QUIET_ON_ERR we no longer
need this function and can replace it with just calling lock_any_ref_for_update
directly.
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed
From: Ronnie Sahlberg
Date: Mon, 28 Apr 2014 15:38:47 -0700
No external callers reference lock_ref_sha1 any more so let's declare it
static.
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed-off-by: Jonathan Nieder
---
refs.c | 7 +--
refs.h | 6 --
2 files changed,
From: Ronnie Sahlberg
Date: Thu, 17 Apr 2014 11:31:06 -0700
Switch to using ref transactions in walker_fetch(). As part of the refactoring
to use ref transactions we also fix a potential memory leak where in the
original code if write_ref_sha1() would fail we would end up returning from
the funct
From: Ronnie Sahlberg
Date: Mon, 28 Apr 2014 15:23:58 -0700
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed-off-by: Jonathan Nieder
---
fast-import.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/fast-import.c b/fast-imp
From: Ronnie Sahlberg
Date: Mon, 28 Apr 2014 14:36:15 -0700
Wrap all the ref updates inside a transaction.
In the new API there is no distinction between failure to lock and
failure to write a ref. Both can be permanent (e.g., a ref
"refs/heads/topic" is blocking creation of the lock file
"refs
From: Ronnie Sahlberg
Date: Thu, 24 Apr 2014 16:36:55 -0700
Change the update_ref helper function to use a ref transaction internally.
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed-off-by: Jonathan Nieder
---
refs.c | 30 ++
1 file changed, 2
From: Ronnie Sahlberg
Date: Wed, 16 Apr 2014 16:21:53 -0700
Change create_branch to use a ref transaction when creating the new branch.
This also fixes a race condition in the old code where two concurrent
create_branch could race since the lock_any_ref_for_update/write_ref_sha1
did not protect
From: Ronnie Sahlberg
Date: Wed, 16 Apr 2014 16:21:13 -0700
Change update_branch() to use ref transactions for updates.
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed-off-by: Jonathan Nieder
---
fast-import.c | 25 +++--
1 file changed, 15 insertions(
From: Ronnie Sahlberg
Date: Wed, 16 Apr 2014 15:37:45 -0700
Change to use ref transactions for all updates to refs.
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed-off-by: Jonathan Nieder
---
sequencer.c | 26 ++
1 file changed, 18 insertions(+), 8
From: Ronnie Sahlberg
Date: Wed, 16 Apr 2014 15:34:19 -0700
Change commit.c to use ref transactions for all ref updates.
Make sure we pass a NULL pointer to ref_transaction_update if have_old
is false.
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed-off-by: Jonathan Nieder
From: Ronnie Sahlberg
Date: Wed, 16 Apr 2014 15:32:29 -0700
Update replace.c to use ref transactions for updates.
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed-off-by: Jonathan Nieder
---
builtin/replace.c | 14 --
1 file changed, 8 insertions(+), 6 deletion
From: Ronnie Sahlberg
Date: Wed, 16 Apr 2014 15:30:41 -0700
Change tag.c to use ref transactions for all ref updates.
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael Haggerty
Signed-off-by: Jonathan Nieder
---
builtin/tag.c | 16 ++--
1 file changed, 10 insertions(+), 6 delet
From: Ronnie Sahlberg
Date: Tue, 29 Apr 2014 12:06:19 -0700
Track the state of a transaction in a new state field. Check the field for
sanity, i.e. that state must be OPEN when _commit/_create/_delete or
_update is called or else die(BUG:...)
Signed-off-by: Ronnie Sahlberg
Reviewed-by: Michael
From: Ronnie Sahlberg
Date: Mon, 19 May 2014 10:42:34 -0700
Add an err argument to _begin so that on non-fatal failures in future ref
backends we can report a nice error back to the caller.
While _begin can currently never fail for other reasons than OOM, in which
case we die() anyway, we may add
From: Ronnie Sahlberg
Date: Wed, 16 Apr 2014 15:27:45 -0700
Change ref_transaction_delete() to do basic error checking and return
non-zero on error. Update all callers to check the return for
ref_transaction_delete(). There are currently no conditions in _delete that
will return error but there w
Hi Junio,
Michael reviewed the rest of rs/ref-transaction-1 (thanks!) and some
more small tweaks resulted --- in particular, there was a missing call
to ref_transaction_free. Interdiff below. This is meant to replace
rs/ref-transaction-1 in 'pu' and should be ready for 'next'.
These patches are
From: Ronnie Sahlberg
Date: Wed, 16 Apr 2014 15:26:44 -0700
Do basic error checking in ref_transaction_create() and make it return
non-zero on error. Update all callers to check the result of
ref_transaction_create(). There are currently no conditions in _create that
will return error but there w
John Keeping writes:
> On Fri, Jul 11, 2014 at 09:44:33PM -0700, David Turner wrote:
>> When git checkout checks out a branch, create or update the
>> cache-tree so that subsequent operations are faster.
>>
>> update_main_cache_tree learned a new flag, WRITE_TREE_REPAIR. When
>> WRITE_TREE_REPA
Torsten Bögershausen writes:
>> Should this be marked with "From: Brice Lambson "?
>>
>> Thanks.
> Yes. If possible please squeeze.
OK, thanks. Please double check the result on 'pu' in several
hours.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
On 2014-09-02 21.10, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> Integrate commit b1d07649588102 from msysgit:
>> MinGW: Update tests to handle a native eol of crlf
>>
>> Some of the tests were written with the assumption that the native eol
>> would
>> always be lf. After de
Hi José,
Am 02.09.2014 um 09:53 schrieb Jose Paredes:
Is there any way to run "git submodule update" in multiple threads?
The use case:
---
"git submodule update" seems to be inefficient when running
sequentially on a large .gitmodules file.
Assuming a git forest with over 7K gi
René Scharfe writes:
> Use starts_with() instead of memcmp() to check if NUL-terminated
> strings match prefixes. This gets rid of some magic string length
> constants.
>
> Signed-off-by: Rene Scharfe
> ---
> imap-send.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff
On Tue, Sep 02, 2014 at 11:32:02AM -0700, Junio C Hamano wrote:
> David Aguilar writes:
>
> > Remove includes that have already been included by another header.
>
> Hmm, I am not sure if that is a good move, and suspect that it is
> incompatible with what your 2/3 attempts to do, at least at the
Junio C Hamano writes:
> Nguyễn Thái Ngọc Duy writes:
>
>> In the --auto code path, gc_before_repack() is called once in parent
>> process then again in the forked process. Stop the second run.
>
> Hmph. Is the true reason why this happens because we have two calls
> to gc_before_repack() in t
Torsten Bögershausen writes:
> Integrate commit b1d07649588102 from msysgit:
> MinGW: Update tests to handle a native eol of crlf
>
> Some of the tests were written with the assumption that the native eol would
> always be lf. After defining NATIVE_CRLF on MinGW, these tests began
> failin
Torsten Bögershausen writes:
> From: Pat Thoyts
>
> Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
> incorrectly set on Mingw git. However, the Makefile variable is not
> propagated to the C preprocessor and results in no change. This patch
> pushes the definition to the C
Johan Herland writes:
> On Sat, Aug 30, 2014 at 9:56 PM, Alex Henrie wrote:
>> Hi, I submitted this patch a week ago and got no reply, so I'm sending
>> it again and CC'ing the original authors this time...
>>
>> Signed-off-by: Alex Henrie
>
> Looks good to me.
>
> Acked-by: Johan Herland
Loo
Arjun Sreedharan writes:
> @number first, @size second argument.
>
> Signed-off-by: Arjun Sreedharan
> ---
> builtin/for-each-ref.c| 2 +-
Thanks. compat/regex/ being borrowed code, I'd prefer not to touch
them, though.
> compat/regex/regcomp.c| 12 ++--
> compat/reg
David Aguilar writes:
> Remove includes that have already been included by another header.
Hmm, I am not sure if that is a good move, and suspect that it is
incompatible with what your 2/3 attempts to do, at least at the
philosophical level.
I am guessing that your 2/3 wants to see
gcc
Jeff King writes:
> On Thu, Aug 28, 2014 at 02:25:16PM -0700, Junio C Hamano wrote:
>
>> Johannes Schindelin writes:
>>
>> > We inspect commit objects pretty much in detail in git-fsck, but we just
>> > glanced over the tag objects. Let's be stricter.
>> >
>> > This work was sponsored by GitHub
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
David Aguilar writes:
> Add missing includes or forward declarations where needed.
Sorry, but I am not sure what the "missing includes" refers to in
the above.
As far as I know, we never aimed to make "gcc -c $header.h" happy.
I suspect that that is what you are trying to do here?
--
To unsubsc
Nguyễn Thái Ngọc Duy writes:
> In the --auto code path, gc_before_repack() is called once in parent
> process then again in the forked process. Stop the second run.
Hmph. Is the true reason why this happens because we have two calls
to gc_before_repack() in the main, and one is before daemoniz
Max Kirillov writes:
> HEAD is not explicitly used as a starting commit for
> calculating reachability, so if it's detached and reflogs
> are disabled it may be pruned.
>
> Add tests which demonstrate it. Test 'prune: prune former HEAD after checking
> out branch' also reverts changes to reposito
Stefan Beller writes:
> On 22.08.2014 22:30, Junio C Hamano wrote:
>> @@ -1226,12 +1232,28 @@ static int delete_only(struct command *commands)
>> return 1;
>> }
>>
>> +static char *prepare_push_cert_nonce(const char *sitename, const char *dir)
>> +{
>> +struct strbuf buf = STRBUF_INIT
Marc Branchaud writes:
> On 14-09-02 08:27 AM, Duy Nguyen wrote:
>> After reading this "multiple checkout mode" in git-checkout.txt, I'm
>> tempted to rewrite it like this. I think the example makes it clearer
>> what I mean. If nobody has any comments, I'm going to send v2 with
>> this (and othe
Nguyễn Thái Ngọc Duy writes:
> This collapes some bug fix patches into the main ones, adds a few more
> tests to cover recent changes, and removes advice.checkoutLocked (when
> things are controversal, probably best to go without them until they
> are settled).
This essentially replaces how the
Jeff King writes:
> We used to do that because the only way to correctly resolve them was by
> introducing a duplicate base object, and we did not allow that. Patch 2
> from my series loosened this, which makes index-pack work, but not
> necessarily the rest of git. And since index-pack is the ga
Max Kirillov writes:
> btw, manpage for git-rev-parse says "Show all refs found in
> refs/.", should it also be changed?
I would rather see "rev-parse --all" not to include HEAD, especially
if it has been documented that way.
--
To unsubscribe from this list: send the line "unsubscribe git" in
On 14-09-02 08:27 AM, Duy Nguyen wrote:
> After reading this "multiple checkout mode" in git-checkout.txt, I'm
> tempted to rewrite it like this. I think the example makes it clearer
> what I mean. If nobody has any comments, I'm going to send v2 with
> this (and other comments collected so far)
O
Gaining financial freedom is what everyone wishes for and you can achieve that
with the help of a legitimate loan lender. If you honestly want to gain
financial stability, kindly email us back to enable us proceed further.Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git"
On Tue, Sep 02, 2014 at 07:21:17AM -0400, Theodore Ts'o wrote:
> On Tue, Sep 02, 2014 at 08:20:42AM +0100, Luca Milanesio wrote:
> > Hi Chris,
> > Seattle is a very inconvenient location for most of the people
> > coming from Europe: somewhere in the Bay area would be better and
> > less expensive
GitTogether has been hosted at Google's for quite some time :-)
Last one was in 2011
http://google-opensource.blogspot.co.uk/2011/12/gittogether-2011.html
It would be nice to have a joint conference again in the Bay Area.
P.S. Possibly you heard of the global crisis in Europe ... that means nobo
After reading this "multiple checkout mode" in git-checkout.txt, I'm
tempted to rewrite it like this. I think the example makes it clearer
what I mean. If nobody has any comments, I'm going to send v2 with
this (and other comments collected so far)
MULTIPLE CHECKOUT MODE
--
Nor
On Tue, Sep 02, 2014 at 08:20:42AM +0100, Luca Milanesio wrote:
> Hi Chris,
> Seattle is a very inconvenient location for most of the people
> coming from Europe: somewhere in the Bay area would be better and
> less expensive for us.
Well, the fact that Seattle is inconvnient might not matter that
Dear Git community
Is there any way to run "git submodule update" in multiple threads?
The use case:
---
"git submodule update" seems to be inefficient when running
sequentially on a large .gitmodules file.
Assuming a git forest with over 7K gits it takes hours to complete the
upd
Hi Chris,
Seattle is a very inconvenient location for most of the people coming from
Europe: somewhere in the Bay area would be better and less expensive for us.
Luca.
On 2 Sep 2014, at 07:21, Christian Couder wrote:
> Hi everyone,
>
> It looks like there will be no Git conference or Git deve
67 matches
Mail list logo
