On Sun, Apr 20, 2014 at 02:09:49AM +0400, Max L wrote:
> One more note: at this moment the problem is slightly deeper. This
> array is next passed to the execvp function, which now falls with
> EFAULT on two my machines (both faced this problem after upgrading to
> ubuntu 14.04, everything 'worked
On Sat, Apr 19, 2014 at 3:17 PM, Jeff King wrote:
> We currently generate the command-line for the external
> command using a fixed-length array of size 10. But if there
> is a rename, we actually need 11 elements (10 items, plus a
> NULL), and end up writing a random NULL onto the stack.
>
> Rath
One more note: at this moment the problem is slightly deeper. This
array is next passed to the execvp function, which now falls with
EFAULT on two my machines (both faced this problem after upgrading to
ubuntu 14.04, everything 'worked' fine before, looks like now execvp
checks input more strictly)
Signed-off-by: Max Kirillov
---
Documentation for the option introduced in e632b3c0d3
Documentation/config.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index bbba728..41e31ce 100644
--- a/Documentation/config.txt
+++ b/Documentati
On Sat, Apr 19, 2014 at 8:42 PM, Heiko Voigt wrote:
> But AFAIK its not ready for production use yet. I guess Sebastian would
> not mind contributions.
Not at all!
--
Sebastian Schuberth
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vge
On 19.04.2014 15:35, Marat Radchenko wrote:
But in practice, msysgit is:
1) outdated msys that was patched in multiple ways without
sending patches upstream
It's not true that we are not sending patches upstream to MSYS, see [1].
It's just that most of them don't get included due to a la
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote:
> Switch to using ref transactions in walker_fetch(). As part of the refactoring
> to use ref transactions we also fix a potential memory leak where in the
> original code if write_ref_sha1() would fail we would end up returning from
> the function wit
On Sat, Apr 19, 2014 at 08:58:32PM +0400, Marat Radchenko wrote:
> On Sat, Apr 19, 2014 at 05:24:33PM +0200, Johannes Schindelin wrote:
> > Marat, please do not add to the confusion. "msysGit" is the name of the
> > *development environment* for developing Git for Windows.
>
> This confusion comes
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote:
> Change commit.c to use ref transactions for all ref updates.
>
> Signed-off-by: Ronnie Sahlberg
> ---
> builtin/commit.c | 22 --
> 1 file changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/builtin/commit.c b/builtin/
The current logic makes it hard to see what gets put onto
the command line in which cases. Pulling out a helper
function lets us see that we have two sets of file data, and
the second set either uses the original name, or the "other"
renamed/copy name.
Signed-off-by: Jeff King
---
The last patch
Whether we have diff_filespecs to give to the diff command
or not, we always are going to run the program and pass it
the pathname. Let's pull that duplicated part out of the
conditional to make it more obvious.
Signed-off-by: Jeff King
---
diff.c | 8 +++-
1 file changed, 3 insertions(+), 5
This fflush was added in d5535ec (Use run_command() to spawn
external diff programs instead of fork/exec., 2007-10-19),
because flushing buffers before forking is a good habit.
But later, 7d0b18a (Add output flushing before fork(),
2008-08-04) added it to the generic run-command interface,
meaning
When the external diff reports an error, we try to clean up
and die. However, we can make this process a bit simpler:
1. We do not need to bother freeing memory, since we are
about to exit. Nor do we need to clean up our
tempfiles, since the atexit() handler will do it for
us. So
We currently use static buffers and a static array for
formatting the environment passed to the external diff.
There's nothing wrong in the code, but it is much easier to
verify that it is correct if we use a dynamic argv_array.
Signed-off-by: Jeff King
---
diff.c | 14 +-
1 file cha
We currently generate the command-line for the external
command using a fixed-length array of size 10. But if there
is a rename, we actually need 11 elements (10 items, plus a
NULL), and end up writing a random NULL onto the stack.
Rather than bump the limit, let's just an argv_array, which
makes
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote:
> Update replace.c to use ref transactions for updates.
>
> Signed-off-by: Ronnie Sahlberg
> ---
> builtin/replace.c | 15 +--
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/builtin/replace.c b/builtin/replace.c
> in
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote:
> Change tag.c to use ref transactions for all ref updates.
>
> Signed-off-by: Ronnie Sahlberg
> ---
> builtin/tag.c | 15 +--
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/builtin/tag.c b/builtin/tag.c
> index 4035
It's possible to overflow an array in run_external_diff and write a
single NULL onto the stack. The first patch below fixes that. The rest
are cleanups and modernizations I noticed while in the area. It's
possible that patch 3 is also a bug fix, depending on your
interpretation.
[1/6]: run_exter
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote:
> Change ref_transaction_delete() to do basic error checking and return
> status. Update all callers to check the return for ref_transaction_delete()
>
> Signed-off-by: Ronnie Sahlberg
> ---
> builtin/update-ref.c | 5 +++--
> refs.c
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote:
> Do basic error checking in ref_transaction_create() and make it return
> status. Update all callers to check the result of ref_transaction_create()
>
> Signed-off-by: Ronnie Sahlberg
> ---
> builtin/update-ref.c | 4 +++-
> refs.c |
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote:
> Update ref_transaction_update() do some basic error checking and return
> true on error. Update all callers to check ref_transaction_update() for error.
>
> Signed-off-by: Ronnie Sahlberg
> ---
> builtin/update-ref.c | 11 +++
> refs.c
On 04/17/2014 09:46 PM, Ronnie Sahlberg wrote:
> ref_transaction_create|delete|update has no need to modify the sha1
> arguments passed to it so it should use const unsigned char* instead
> of unsigned char*.
>
> Some functions, such as fast_forward_to(), already have its old/new
> sha1 arguments
On Sat, Apr 19, 2014 at 05:35:07PM +0400, Marat Radchenko wrote:
> > there are no 64 bit binaries shipped with msysgit is that nobody
> > needed them
>
> That's wrong. Google for 'windows x64 git' or 'msysgit x64'. People
> need it. There's even an issue [3] (stalled several years ago) in
> msysgi
Hi John,
> Have you tried `git config gpg.program gpgsm`?
wau, thanks a lot for this hint!, it works :-)
I think a "seamless" integration for all certificate-types would be better,
but I try to motivate GnuPG to merge the function of gpgsm.exe into gpg.exe.
This would give a great benefit for a
Translate 45 new messages came from git.pot update in 5e078fc
(l10n: git.pot: v2.0.0 round 1 (45 new, 28 removed)).
Signed-off-by: Ralf Thielow
---
po/de.po | 123 +--
1 file changed, 49 insertions(+), 74 deletions(-)
diff --git a/po/d
Hi Marat,
On Sat, 19 Apr 2014, Marat Radchenko wrote:
> But in practice, msysgit is:
> 1) outdated msys that was patched in multiple ways without
> sending patches upstream
> 2) heavily patched git, again not upstreamed
Again, this time explicitly: I wish you had done a little more research
Am 19.04.2014 15:35, schrieb Marat Radchenko:
>> So the reason for this new package is that you need 64bit
>> binaries?
>
> That's the most important bit. Plus, weird ssh transfer speeds [1]
> caused by ansient openssh bundled in msysgit.
Yes the msysgit openssh is ancient and slow. Openssh in m
On Sat, Apr 19, 2014 at 05:24:33PM +0200, Johannes Schindelin wrote:
> Marat, please do not add to the confusion. "msysGit" is the name of the
> *development environment* for developing Git for Windows.
This confusion comes from the fact that major part of msysGit is packaged
with Git for Windows
Hi,
On Sat, 19 Apr 2014, Heiko Voigt wrote:
> On Thu, Apr 03, 2014 at 05:18:50PM +0400, ma...@slonopotamus.org wrote:
> > I'm proud to announce WinGit:
> > an attempt to bring Git powers to 64-bit Windows.
>
> So the reason for this new package is that you need 64bit binaries?
>
> > Relationshi
On Sat, Apr 19, 2014 at 11:03:07AM +, Schittli Thomas wrote:
> last night, brian m. Carlson explained, that "Git wants a key that can
> be used by GnuPG" and therefore X.509 certificates are not supported.
>
> As you probably know, since 3 years gpg supports X.509 -
> unfortunately, gpg does n
T0 get your entitlement, write me via; siedm...@outlook.com--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> So the reason for this new package is that you need 64bit binaries?
That's the most important bit. Plus, weird ssh transfer speeds [1] caused by
ansient openssh bundled in msysgit.
> I can see the need for a pure Windows solution (no msys tools at least for
> runtime).
Several Git scripts ar
Johan Herland wrote:
> Feel free to add/squash this on top.
Thanks! Squashed and pushed.
The following changes since commit cc291953df19aa4a97bee3590e708dc1fc557500:
Git 2.0-rc0 (2014-04-18 11:21:43 -0700)
are available in the git repository at:
git://bogomips.org/git-svn.git master
for
Dear Git community
last night, brian m. Carlson explained, that "Git wants a key that can be used
by GnuPG" and therefore X.509 certificates are not supported.
As you probably know, since 3 years gpg supports X.509 - unfortunately, gpg
does not automatically detect X.509 certificates and we hav
Add a description of <=1.9 behavior in the manpage. Users on
long-term-support systems are likely to continue using ancient
git installations for some time (5-10 years, even?), but may
come across the current documentation online.
Suggested-by: Eric Wong
Signed-off-by: Johan Herland
---
> We sh
According to the help, without -x option git clean should let alone the ignored
files, but it doesn't.
[il@reallin test]$ cat .gitignore
*.sar
[il@reallin test]$ mkdir -p conf/sar && touch conf/sar/aaa.sar
[il@reallin test]$ git status
# On branch master
nothing to commit,
Johan Herland wrote:
> --- a/Documentation/git-svn.txt
> +++ b/Documentation/git-svn.txt
> @@ -86,14 +86,7 @@ COMMANDS
> (refs/remotes/$remote/*). Setting a prefix is also useful
> if you wish to track multiple projects that share a common
> repository.
> -+
> -NOTE: In Git v2.0,
Hi,
Since Git v2.0.0-rc0 had already been released, it's time to start new round
of git l10n. This time there are 45 new messages need to be translated since
last update for v1.9.0:
l10n: git.pot: v2.0.0 round 1 (45 new, 28 removed)
Generate po/git.pot from v2.0.0-rc0 for git v2.0.0 l10n
Johan Herland writes:
> On Fri, Apr 18, 2014 at 9:37 PM, Junio C Hamano wrote:
>> An early preview release Git v2.0.0-rc0 is now available for
>> testing at the usual places.
>
> This is supposed to have _all_ the v2.0 topics, correct?
>
> I'm unable to find the commit that actually _changes_ th
From: Felipe Contreras
It's cleaner, and will allow us to do something sensible on errors
later.
Signed-off-by: Felipe Contreras
Signed-off-by: Junio C Hamano
---
transport-helper.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/transport-helper.c b/tr
From: Felipe Contreras
It's simpler to store the file names directly, and form the fast-export
arguments only when needed, and re-use the same strbuf with a format.
Signed-off-by: Felipe Contreras
Signed-off-by: Junio C Hamano
---
transport-helper.c | 24
1 file chang
From: Felipe Contreras
It's only used once, we can just call the two functions inside directly.
Signed-off-by: Felipe Contreras
Signed-off-by: Junio C Hamano
---
transport-helper.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/transport-helper.c b/transport-help
From: Felipe Contreras
Instead of exiting directly, make it the duty of the caller to do so.
Signed-off-by: Felipe Contreras
Signed-off-by: Junio C Hamano
---
transport-helper.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/transport-helper.c b/tra
From: Felipe Contreras
When a remote helper crashes while pushing we should revert back to the
state before the push, however, it's possible that `git fast-export`
already finished its job, and therefore has exported the marks already.
This creates a synchronization problem because from that mom
44 matches
Mail list logo
