Re: [PATCH 02/12] Convert starts_with() to skip_prefix() for option parsing

2013-12-20 Thread Duy Nguyen
On Sat, Dec 21, 2013 at 4:31 AM, Junio C Hamano wrote: > Jeff King writes: > >> /* here we care if we saw the prefix, as above */ >> if (parse_prefix(foo, prefix, &the_rest)) >> ... >> >> /* >>* and here we do not care, and just want to optionally strip the >>* prefix, and tak

Re: [PATCH v2 00/21] Support multiple worktrees

2013-12-20 Thread Duy Nguyen
On Sat, Dec 21, 2013 at 3:32 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> I've got a better version [1] that fixes everything I can think of >> (there's still some room for improvements). I'm going to use it a bit >> longer before reposting again. But here's its basic design without >> goi

Re: [RFH/PATCH] graph: give an extra gap after showing root commit

2013-12-20 Thread Junio C Hamano
Junio C Hamano writes: > Note that this still does not work very well for --boundary case > (see the last test added to t6016). > ... > +test_expect_failure 'multi-root does not emit unnecessary post-root gap' ' > + git log --oneline --graph merge210~1...merge210~1^2~2 >actual && > + !

Re: [PATCH 02/12] Convert starts_with() to skip_prefix() for option parsing

2013-12-20 Thread Junio C Hamano
Jeff King writes: > /* here we care if we saw the prefix, as above */ > if (parse_prefix(foo, prefix, &the_rest)) > ... > > /* >* and here we do not care, and just want to optionally strip the >* prefix, and take the full value otherwise; we just have to ignore >* the retu

Re: [PATCH v2 00/21] Support multiple worktrees

2013-12-20 Thread Junio C Hamano
Duy Nguyen writes: > I've got a better version [1] that fixes everything I can think of > (there's still some room for improvements). I'm going to use it a bit > longer before reposting again. But here's its basic design without > going down to code > > New .git file format includes two lines: >

[RFH/PATCH] graph: give an extra gap after showing root commit

2013-12-20 Thread Junio C Hamano
With a history with more than one root commit, if a root commit falls on one display column and another commit that is unrelated to that root's history is shown on the next line on the same column, the resulting graph would appear as if the latter is a parent of the former, like this (there are two

gitk: file viewer call even for an binary document ?

2013-12-20 Thread Toralf Förster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 dev-vcs/git-1.8.3.2-r1 at a stable 32 bit Gentoo Linux: If I right click onto a file in the right pane and choose "Blame parent commit" then even for a binary file (open doc sheet) the file viewer is started - works as designed or a bug ? - --

Re: Bug when moving submodules (I think?)

2013-12-20 Thread Jens Lehmann
Am 19.12.2013 00:32, schrieb fREW Schmidt: > I tried to make a script to repro this from scratch but ran into other > issues, which may or may not be a bug. I'll put that at the end. > > To repro all you have to do is: > > git checkout git://github.com/frioux/dotfiles > git reset --hard 92c85

Re: [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors

2013-12-20 Thread Jonathan Nieder
Hi, Nguyễn Thái Ngọc Duy wrote: > Use strcmp() instead of starts_with() to stop accepting > --informative-errors-just-a-little > > Signed-off-by: Nguyễn Thái Ngọc Duy Good catch. When this use of prefixcmp was introduced in v1.7.8-rc0~28^2 (daemon: give friendlier error messages to clients, 20

[PATCH] name-hash: retire unused index_name_exists()

2013-12-20 Thread Eric Sunshine
db5360f3f496 (name-hash: refactor polymorphic index_name_exists(); 2013-09-17) split index_name_exists() into index_file_exists() and index_dir_exists() but retained index_name_exists() as a thin wrapper to avoid disturbing possible in-flight topics. Since this change landed in 'master' some time a

[PATCH] wt-status.c: disable those distracting -Wformat-zero-length warnings

2013-12-20 Thread Samuel Bronson
These warnings don't really seem to make much sense for this file. Signed-off-by: Samuel Bronson --- wt-status.c | 5 + 1 file changed, 5 insertions(+) diff --git a/wt-status.c b/wt-status.c index 4e55810..542cc65 100644 --- a/wt-status.c +++ b/wt-status.c @@ -17,6 +17,11 @@ #include "strb

Re: RLIMIT_NOFILE fallback

2013-12-20 Thread Torsten Bögershausen
On 2013-12-20 10.12, Jeff King wrote: > On Thu, Dec 19, 2013 at 09:39:55AM -0800, Junio C Hamano wrote: > >> Torsten Bögershausen writes: >> >>> Thanks for an interesting reading, >>> please allow a side question: >>> Could it be, that "-1 == unlimited" is Linux specific? >>> And therefore not 10

It-service Desk

2013-12-20 Thread Gerald Krystal
This is It-service Desk sending you this E-mail for your account upgrade, We are conducting an upgrade in all email account, All users are to verify his/her account for upgrade, Click Here: http://heloadms.moy.su/microsoftoutlook.htm to upgrade your account. Yours, System Administrator -- To u

I have a better plans

2013-12-20 Thread HK China
I have a better plans for us reply me ASAP. 2721745...@qq.com Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] daemon: be strict at parsing parameters --[no-]informative-errors

2013-12-20 Thread Nguyễn Thái Ngọc Duy
Use strcmp() instead of starts_with() to stop accepting --informative-errors-just-a-little Signed-off-by: Nguyễn Thái Ngọc Duy --- daemon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon.c b/daemon.c index 7bee953..503e039 100644 --- a/daemon.c +++ b/daemon.c @@ -

Re: [PATCH 02/12] Convert starts_with() to skip_prefix() for option parsing

2013-12-20 Thread René Scharfe
Am 20.12.2013 08:04, schrieb Jeff King: > On Fri, Dec 20, 2013 at 07:51:00AM +0100, Johannes Sixt wrote: > >>> for (i = 1; i < argc && *argv[i] == '-'; i++) { >>> const char *arg = argv[i]; >>> + const char *optarg; >>> >>> - if (starts_with(arg, "--upload-pa

[PATCH] git-quiltimport: add a --series option

2013-12-20 Thread Wang Nan
This patch add a --series option to git-quiltimport to allow users to select the name of series file. This option is an analog of quilt's QUILT_SERIES environment variable. Signed-off-by: Wang Nan --- Documentation/git-quiltimport.txt | 5 + git-quiltimport.sh| 21 ++

Re: [PATCH 1/3] prune-packed: fix a possible buffer overflow

2013-12-20 Thread Jeff King
On Thu, Dec 19, 2013 at 05:33:55PM +0100, Michael Haggerty wrote: > > But we don't loop on ENOENT. So if the rmdir happens in the middle, > > after the mkdir but before we call open again, we'd fail, because we > > don't treat ENOENT specially in the second call to open. That is > > unlikely to ha

Re: RLIMIT_NOFILE fallback

2013-12-20 Thread Jeff King
On Thu, Dec 19, 2013 at 09:39:55AM -0800, Junio C Hamano wrote: > Torsten Bögershausen writes: > > > Thanks for an interesting reading, > > please allow a side question: > > Could it be, that "-1 == unlimited" is Linux specific? > > And therefore not 100% portable ? > > > > And doesn't "unlimite

Re: [PATCH 02/12] Convert starts_with() to skip_prefix() for option parsing

2013-12-20 Thread Christian Couder
On Fri, Dec 20, 2013 at 8:04 AM, Jeff King wrote: > On Fri, Dec 20, 2013 at 07:51:00AM +0100, Johannes Sixt wrote: > >> > for (i = 1; i < argc && *argv[i] == '-'; i++) { >> > const char *arg = argv[i]; >> > + const char *optarg; >> > >> > - if (starts_with(arg,