Brandon Casey wrote:
> Ensure buffer length is non-zero before attempting to access the last
> element.
>
> Signed-off-by: Brandon Casey
> ---
> contrib/credential/gnome-keyring/git-credential-gnome-keyring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/crede
Mark global variable and functions as static.
Signed-off-by: Brandon Casey
---
.../gnome-keyring/git-credential-gnome-keyring.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
b/contrib/
Rather than roll our own, let's use the memory allocation/free routines
provided by glib.
Signed-off-by: Brandon Casey
---
.../gnome-keyring/git-credential-gnome-keyring.c | 48 --
1 file changed, 16 insertions(+), 32 deletions(-)
diff --git a/contrib/credential/gnome-keyr
Produce an error message when we fail to store a password to the keyring.
Signed-off-by: Brandon Casey
---
contrib/credential/gnome-keyring/git-credential-gnome-keyring.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/contrib/credential/gnome-keyring/git-credential-g
Since this is a Gnome application, let's set the application name to
something reasonable. This will be displayed in Gnome dialog boxes
e.g. the one that prompts for the user's keyring password.
We add an include statement for glib.h and add the glib-2.0 cflags and
libs to the compilation argumen
Signed-off-by: Brandon Casey
---
.../credential/gnome-keyring/git-credential-gnome-keyring.c| 10 --
1 file changed, 10 deletions(-)
diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
index 1
Rather than roll our own, let's use the messaging functions provided
by glib.
Signed-off-by: Brandon Casey
---
.../gnome-keyring/git-credential-gnome-keyring.c | 33 +++---
1 file changed, 4 insertions(+), 29 deletions(-)
diff --git a/contrib/credential/gnome-keyring/git-crede
The gnome-keyring lib distributed with RHEL 5.X is ancient and does
not provide a few of the functions/defines that more recent versions
do, but mostly the API is the same. Let's provide the missing bits
via macro definitions and function implementation.
Signed-off-by: Brandon Casey
---
.../gno
Ensure buffer length is non-zero before attempting to access the last
element.
Signed-off-by: Brandon Casey
---
contrib/credential/gnome-keyring/git-credential-gnome-keyring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/credential/gnome-keyring/git-credential-gnom
The gnome-keyring lib (0.4) distributed with RHEL 4.X is really ancient
and does not provide most of the synchronous functions that even ancient
releases do. Thankfully, we're only using one function that is missing.
Let's emulate gnome_keyring_item_delete_sync() by calling the asynchronous
functi
gnome-keyring provides functions for allocating non-pageable memory (if
possible) intended to be used for storing passwords. Let's use them.
Signed-off-by: Brandon Casey
---
.../gnome-keyring/git-credential-gnome-keyring.c| 21 ++---
1 file changed, 6 insertions(+), 15 delet
gnome-keyring provides functions to allocate non-pageable memory (if
possible). Let's use them to allocate memory that may be used to hold
secure data read from the keyring.
Signed-off-by: Brandon Casey
---
.../credential/gnome-keyring/git-credential-gnome-keyring.c | 12 +---
1 file c
Rather than carefully allocating memory for sprintf() to write into,
let's make use of the glib helper function g_strdup_printf(), which
makes things a lot easier and less error-prone.
Signed-off-by: Brandon Casey
---
.../gnome-keyring/git-credential-gnome-keyring.c | 14 +++---
These are all defined before they are used, so it is not necessary to
pre-declare them. Remove the pre-declarations.
Signed-off-by: Brandon Casey
---
.../credential/gnome-keyring/git-credential-gnome-keyring.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/contrib/credential/
A few cleanups, followed by improved usage of the glib library (no need
to reinvent the wheel when glib provides the necessary functionality), and
then the addition of support for RHEL 4.x and 5.x.
Brandon Casey (15):
contrib/git-credential-gnome-keyring.c: remove unnecessary
pre-declaration
If the correct arguments were not specified, this program should exit
non-zero. Let's do so.
Signed-off-by: Brandon Casey
---
contrib/credential/gnome-keyring/git-credential-gnome-keyring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/credential/gnome-keyring/git-
Also, initialization is not necessary since it is assigned before it is
used.
Signed-off-by: Brandon Casey
---
contrib/credential/gnome-keyring/git-credential-gnome-keyring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/credential/gnome-keyring/git-credential-gnome
Richard Hansen wrote:
> On 2013-08-29 11:23, Felipe Contreras wrote:
> > Otherwise they cannot know when to force the push or not (other than
> > hacks).
> >
> > Signed-off-by: Felipe Contreras
> > ---
> > transport-helper.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tran
Richard Hansen wrote:
> On 2013-08-29 11:23, Felipe Contreras wrote:
> > So that we can covert the exported ref names.
> >
> > Signed-off-by: Felipe Contreras
> > ---
> > Documentation/git-fast-export.txt | 4
> > builtin/fast-export.c | 30 ++
> > t
On 2013-08-29 11:23, Felipe Contreras wrote:
> Otherwise they cannot know when to force the push or not (other than
> hacks).
>
> Signed-off-by: Felipe Contreras
> ---
> transport-helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/transport-helper.c b/transport-helper.c
> inde
Richard Hansen wrote:
> On 2013-08-29 11:23, Felipe Contreras wrote:
> > For remote-helpers that use 'export' to push.
> >
> > Signed-off-by: Felipe Contreras
> > ---
> > t/t5801-remote-helpers.sh | 8
> > transport-helper.c| 11 ++-
> > 2 files changed, 14 insertions(+
Richard Hansen wrote:
> On 2013-08-29 11:23, Felipe Contreras wrote:
> > Here are the patches that allow transport helpers to be completely
> > transparent;
> > renaming branches, deleting them, custom refspecs, --force, --dry-run,
> > reporting forced update, everything works.
>
> What is the st
On 2013-08-29 11:23, Felipe Contreras wrote:
> So that we can covert the exported ref names.
>
> Signed-off-by: Felipe Contreras
> ---
> Documentation/git-fast-export.txt | 4
> builtin/fast-export.c | 30 ++
> t/t9350-fast-export.sh| 7
On 2013-08-29 11:23, Felipe Contreras wrote:
> For remote-helpers that use 'export' to push.
>
> Signed-off-by: Felipe Contreras
> ---
> t/t5801-remote-helpers.sh | 8
> transport-helper.c| 11 ++-
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
[...]
> diff --gi
On 2013-08-29 11:23, Felipe Contreras wrote:
> Here are the patches that allow transport helpers to be completely
> transparent;
> renaming branches, deleting them, custom refspecs, --force, --dry-run,
> reporting forced update, everything works.
What is the status of these patches?
I would like
On Sun, Sep 22, 2013 at 05:00:44PM -0700, Junio C Hamano wrote:
> - Moving away from higher-level scripting languages such as shell and Perl.
>Recent "clean --interactive" may have added some code that could be
>reused for a rewrite of "add -i" (which I think is in Perl), for example.
>
[on vacaion, with only gmail webmail UI; please excuse me if this message comes
out badly formatted or gets dropped by vger.kernel.org]
On Sat, Sep 21, 2013 at 4:56 PM, brian m. carlson
wrote:
> On Sat, Sep 21, 2013 at 05:52:05PM -0500, Felipe Contreras wrote:
>> On Sat, Sep 21, 2013 at 4:29 PM,
On 21/09/2013 23:16, Keshav Kini wrote:
[SNIP]
This situation came about because the BFG Repo-Cleaner doesn't write new
reflog entries after creating its new objects and moving refs around.
True enough - I don't think the BFG does write new entires to the
reflog when it does the final ref-updat
- Ursprungligt meddelande -
> Från: "David Loyall"
> Till: git@vger.kernel.org
> Skickat: onsdag, 18 sep 2013 21:00:46
> Ämne: suspected bug(s) in git-cvsexportcommit.perl
>
> Hello.
>
> I don't believe that git-cvsexportcommit.perl is working properly.
>
> First off, invocations of "
> > HEAD:/some/path/to/foo.txt
> > HEAD:some/path/to/foo.txt
>
> With my patch it prints the latter.
>
> This is because get_sha1_with_context("HEAD:"...) returns an empty
> 'path' string. The code decides to use ':' as the delimiter in that
> case, but it sees there already is one at th
Benoit Person writes:
> Mediawiki introduced a new API for queries w/ more than 500 results in
> version 1.21. That change triggered an infinite loop while cloning a
> mediawiki with such a page.
>
> Fix that while still preserving the old behavior for old APIs.
That would be nice to explain a b
Mediawiki introduced a new API for queries w/ more than 500 results in
version 1.21. That change triggered an infinite loop while cloning a
mediawiki with such a page.
Fix that while still preserving the old behavior for old APIs.
Signed-off-by: Benoit Person
Reported-by: Benjamin Cathey
---
Pa
Hello,
I am George Daniels, a Banker and credit system programmer (HSBC bank).
I saw your email address while browsing through the bank D.T.C Screen in
my office
yesterday so I decided to use this very chance to know you. I believe
we should use every opportunity to know each other better.
Ho
Jens Lehmann writes:
> Am 21.09.2013 00:29, schrieb Junio C Hamano:
>> Jens Lehmann writes:
>>
>>> Am 10.09.2013 00:53, schrieb Junio C Hamano:
* bc/submodule-status-ignored (2013-09-04) 2 commits
- submodule: don't print status output with ignore=all
- submodule: fix confusing
Hi, Git l10n teams
I created a new branch "pu" in the l10 coordinator repository to
hold proposed updates of "po/git.pot" for translations. See commit
log for hints:
commit e9d227174abf2b7f66a7027a509886f9cba1adea
l10n: git.pot: proposed updates since v1.8.4 (48+)
The 1st round of Git l
Am 21.09.2013 00:29, schrieb Junio C Hamano:
> Jens Lehmann writes:
>
>> Am 10.09.2013 00:53, schrieb Junio C Hamano:
>>> * bc/submodule-status-ignored (2013-09-04) 2 commits
>>> - submodule: don't print status output with ignore=all
>>> - submodule: fix confusing variable name
>>>
>>> Origina
Felipe Contreras wrote:
>David Aguilar wrote:
>> Felipe Contreras wrote:
>> >On Sat, Sep 21, 2013 at 1:58 PM, Johannes Sixt wrote:
>> >> Am 21.09.2013 13:47, schrieb Felipe Contreras:
>> >>> diff --git a/Makefile b/Makefile
>> >>> index 3588ca1..18081bf 100644
>> >>> --- a/Makefile
>> >>> +++ b/
On Sun, Sep 22, 2013 at 3:12 AM, Fredrik Gustafsson wrote:
> On Sun, Sep 22, 2013 at 02:43:39AM -0500, Felipe Contreras wrote:
>> > It would actually be usefull to know stats on where git is runned. In my
>> > world of embedded computing, ruby support definitely isn't a standard,
>> > nor is glibc
On Sun, Sep 22, 2013 at 02:43:39AM -0500, Felipe Contreras wrote:
> > It would actually be usefull to know stats on where git is runned. In my
> > world of embedded computing, ruby support definitely isn't a standard,
> > nor is glibc.
>
> I come from the embedded world as well, and I've never see
On Sun, Sep 22, 2013 at 2:31 AM, Fredrik Gustafsson wrote:
> On Sun, Sep 22, 2013 at 12:36:51AM -0500, Felipe Contreras wrote:
>> > I think it's a bad idea to introduce an entirely new runtime, especially
>> > one known to occasionally blow up on less-common architectures, without
>> > some advanc
On Sun, Sep 22, 2013 at 12:36:51AM -0500, Felipe Contreras wrote:
> > I think it's a bad idea to introduce an entirely new runtime, especially
> > one known to occasionally blow up on less-common architectures, without
> > some advance notice.
>
> This is just FUD. What do you mean blow up on less
41 matches
Mail list logo
