On Sat, Jul 27, 2013 at 09:35:40PM +0530, Ramkumar Ramachandra wrote:
> Duy Nguyen wrote:
> > I was involved with this code (the gitdir setup code, not submodule)
> > and am interested to know what's going on too. Could you produce a
> > small script to reproduce it?
>
> Here's your reduced testca
On Sun, Jul 28, 2013 at 5:53 AM, Torsten Bögershausen wrote:
>> Does this have any effects on non-utf8 users? I'm on utf-8, so this is
>> not really my concern, that is unless it changes something on LANG=C..
>>
> Not sure if I fully understand the question.
>
> Mac OS will always use UTF-8, and w
On Sat, Jul 27, 2013 at 11:05 PM, Ramkumar Ramachandra
wrote:
> Here's your reduced testcase. Just point mygit to a HEAD build.
>
> #!/bin/sh
>
> mygit=~/src/git/git
> cd /tmp
> $mygit clone https://github.com/artagnon/clayoven
> cd clayoven
> $mygit submodule add https://github.com/le
Hi David,
Thanks for massaging it to apply to master and cleaning up the style conflicts.
On Jul 27, 2013, at 13:31, David Aguilar wrote:
> From: Jeremy Huddleston
>
> Use Apple's supported functions for base64 encoding instead
> of the deprecated OpenSSL functions.
>
> Signed-off-by: Jeremy
Jiang Xin wrote:
> I change the EDITOR(GIT_EDITOR) environment in your test script
> as follows:
>
> GIT_EDITOR="echo PWD: $(pwd); echo REALPATH: $(pwd -P); echo" \
> git commit --amend
See, what stumps be about this is the no-submodule case:
#!/bin/sh
mygit=~/src/git/git
cd /tmp
2013/7/28 Ramkumar Ramachandra :
> Duy Nguyen wrote:
>> I was involved with this code (the gitdir setup code, not submodule)
>> and am interested to know what's going on too. Could you produce a
>> small script to reproduce it?
>
> Here's your reduced testcase. Just point mygit to a HEAD build.
>
>
On 2013-07-27 17.23, Duy Nguyen wrote:
> On Sat, Jul 27, 2013 at 8:21 AM, Torsten Bögershausen wrote:
>> When core.precomposeunicode was introduced, it was set to false
>> by default, to be compatible with older versions of Git.
>>
>> Whenever UTF-8 file names are used in a mixed environment,
>> t
From: Jeremy Huddleston
Use Apple's supported functions for base64 encoding instead
of the deprecated OpenSSL functions.
Signed-off-by: Jeremy Huddleston
Signed-off-by: David Aguilar
---
This is Jeremy's original patch rebased onto the latest master.
Jeremy, the only way I could get this to w
Sparse issues an "symbol 'saved_parents_slab' was not declared. Should
it be static?" warning. In order to suppress the warning, since this
symbol does not require more than file visibility, we simply add the
static modifier to its declaration.
Signed-off-by: Ramsay Jones
---
Hi Thomas,
In add
The slab initialization code includes the calculation of the
slab 'elem_size', which is in turn used to determine the size
(capacity) of the slab. Each element of the slab represents an
array, of length 'stride', of 'elemtype'. (Note that it may be
clearer if the define_commit_slab macro parameter
Duy Nguyen wrote:
> I was involved with this code (the gitdir setup code, not submodule)
> and am interested to know what's going on too. Could you produce a
> small script to reproduce it?
Here's your reduced testcase. Just point mygit to a HEAD build.
#!/bin/sh
mygit=~/src/git/git
cd /tm
On Sat, Jul 27, 2013 at 8:21 AM, Torsten Bögershausen wrote:
> When core.precomposeunicode was introduced, it was set to false
> by default, to be compatible with older versions of Git.
>
> Whenever UTF-8 file names are used in a mixed environment,
> the Mac OS users need to find out that this con
On Sat, Jul 27, 2013 at 9:33 PM, Ramkumar Ramachandra
wrote:
> Duy Nguyen wrote:
>> 044bbbc (Make git_dir a path relative to work_tree in
>> setup_work_tree() - 2008-06-19)
>
> Okay, so it does seem to be a significant optimization. Frankly,
> e02ca72 only improves the relative_path() algorithm,
Duy Nguyen wrote:
> 044bbbc (Make git_dir a path relative to work_tree in
> setup_work_tree() - 2008-06-19)
Okay, so it does seem to be a significant optimization. Frankly,
e02ca72 only improves the relative_path() algorithm, and it's not
really doing anything Wrong: it's has just uncovered a pre
Fredrik Gustafsson wrote:
> When I hear submodules
The only reason this bug has something to do with submodules is
because of the relative path in the gitfile (although I'm yet to
corner the exact issue). Otherwise, it doesn't exercise any new code
in submodule.c/ git-submodule.sh.
--
To unsubscr
On Sat, Jul 27, 2013 at 7:31 PM, Ramkumar Ramachandra
wrote:
> Ramkumar Ramachandra wrote:
>> e02ca72 (path.c: refactor relative_path(), not only strip prefix,
>> 2013-06-25) is the offender.
>
> The problem is the callsite in setup.c:setup_work_tree(). When
> relative_path() is called with
> "/ho
Ramkumar Ramachandra wrote:
> e02ca72 (path.c: refactor relative_path(), not only strip prefix,
> 2013-06-25) is the offender.
The problem is the callsite in setup.c:setup_work_tree(). When
relative_path() is called with
"/home/artagnon/dotfiles/.git/modules/.elisp/flx" and
"/home/artagnon/dotfile
On Sat, Jul 27, 2013 at 04:40:12PM +0530, Ramkumar Ramachandra wrote:
> Hi,
>
> I noticed a regression in the latest master, and I've been trying to
> debug it for 30 minutes now. I'm still clueless about the root cause,
> but I'll list whatever I found so far:
>
> I suddenly noticed that I wasn
`echo -n` is non-portable. The POSIX specification says:
Conforming applications that wish to do prompting without
characters or that could possibly be expecting to echo a -n, should
use the printf utility derived from the Ninth Edition system.
Since all of the affected shell scripts
Ramkumar Ramachandra wrote:
> *scratches head*
Just took a much-needed shower and came back. It was trivial to find.
$ git log v1.8.3.4.. -- path.c
e02ca72 (path.c: refactor relative_path(), not only strip prefix,
2013-06-25) is the offender.
--
To unsubscribe from this list: send the line "u
On Sat, Jul 27, 2013 at 6:10 PM, Ramkumar Ramachandra
wrote:
> I tried looking through the logs to see what has changed in
> path.c/environment.c, but have come up with nothing so far. I think
> I'll have to resort to using a hammer like bisect now.
>
> *scratches head*
Try bisect with GIT_TRACE
On 07/27/2013 01:26 PM, Philip Oakley wrote:
> Try 'git format-patch' and 'git send-email'. The format-patch man page
> even has a note about Thunderbird corruptions.
>
> Philip
>
Well I use Thunderbird as well for regular communication except for
sending patches.
The kernel documentation has
From: "Daniele Segato"
On 07/26/2013 09:06 PM, Jeff King wrote:
On Fri, Jul 26, 2013 at 07:33:01PM +0200, Daniele Segato wrote:
stress the difference between the two with suggestion on when the
user
should use one in place of the other.
Signed-off-by: Daniele Segato
The intent of your pa
Hi,
I noticed a regression in the latest master, and I've been trying to
debug it for 30 minutes now. I'm still clueless about the root cause,
but I'll list whatever I found so far:
I suddenly noticed that I wasn't able to commit to a certain
repository with submodules anymore. This was because
On 07/26/2013 09:06 PM, Jeff King wrote:
On Fri, Jul 26, 2013 at 07:33:01PM +0200, Daniele Segato wrote:
stress the difference between the two with suggestion on when the user
should use one in place of the other.
Signed-off-by: Daniele Segato
The intent of your patch seems reasonable to me
Stefan Beller writes:
> My approach would have been:
>
> sorted_internal_cmds: git.c
> { awk '/cmd_struct commands/,/};/ { if (match($2,/"/)) print $2 }'
> builtin.actual && \
> sort builtin.expect && \
> cmp -s builtin.expect builtin.actual && \
> rm builtin.expect built
There are currently 115 commands built into the git executable.
Before this commit, it was iterated over these commands in a linear
order, i.e. each command was checked.
As it turns out the commands are already sorted alphabetically, it is easy
to perform a binary search instead of linear searchin
On 07/26/2013 10:57 PM, Jonathan Nieder wrote:
> Hi,
>
> Stefan Beller wrote:
>
>> --- a/git.c
>> +++ b/git.c
>> @@ -309,9 +309,18 @@ static int run_builtin(struct cmd_struct *p, int argc,
>> const char **argv)
>> return 0;
>> }
>>
>> +static int compare_internal_command(const void *a, c
Скрытые Спецтехнологии спецслужб http://tidi.us/739266
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jonathan Nieder wrote:
>> Your patch is just swapping out "git reset" for "cherry-pick --abort",
>> so I think that is a good improvement in the meantime.
>
> Um, wasn't the idea of the original message that you can run "git
> reset" and then "git cherry-pick --continue"?
No, and I don't know wher
Jeff King wrote:
> builtin/commit.c | 25 ++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
Overall, highly inelegant. The single-commit pick has been special
cased only because we needed to preserve backward compatibility: I
would hate for the detail to be user-visibl
31 matches
Mail list logo
