POSIX like file systems allows to create a file when the user has
write permissions to the directory.
Filesystems like VFAT or NTFS allow to create files regardless of
the write permissions of the directory.
Therefore "mktemp to unwritable directory" in t0700 will always fail on
Windows using NTF
Felipe Contreras wrote:
> sequencer.c => builtin/sequencer.c | 160 +---
> sequencer.h => builtin/sequencer.h | 4 -
Why exactly? The plan was to unify continuation semantics, and get
all the continuation-commands to use the sequencer. That clearly
hasn't materi
Felipe Contreras wrote:
> diff --git a/t/t3420-rebase-autostash.sh b/t/t3420-rebase-autostash.sh
> index a5e69f3..ff370a3 100755
> --- a/t/t3420-rebase-autostash.sh
> +++ b/t/t3420-rebase-autostash.sh
> @@ -71,8 +71,7 @@ testrebase() {
> test_must_fail git rebase$type related-onto-b
On Fri, Jun 07, 2013 at 11:42:03PM +0200, Célestin Matte wrote:
> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
> b/contrib/mw-to-git/git-remote-mediawiki.perl
> index 4893442..e60793a 100755
> --- a/contrib/mw-to-git/git-remote-mediawiki.perl
> +++ b/contrib/mw-to-git/git-remote-media
On Sat, Jun 8, 2013 at 3:32 AM, Felipe Contreras
wrote:
> Let's show the output so it's clear why it failed.
I think you can always look into trash-directory.t3400 and figure why.
But if you show this, I think you should use test_cmp to make it clear
what is not wanted. Something like
: >expecte
On Sat, Jun 8, 2013 at 5:16 AM, Felipe Contreras
wrote:
> This code is only useful for cherry-pick and revert built-ins, nothing
> else, so let's make it a builtin object, but make sure 'git-sequencer'
> is not generated.
As you can see, the convention is builtin/foo.c corresponds to git-foo
(and
On Sat, Jun 8, 2013 at 3:24 AM, Felipe Contreras
wrote:
>> The reviewer pool for code written in a new language _must_ be
>> seeded by some from the current set of reviewers whose judgement
>> I/we can trust.
>
> By that standard nothing will ever change. Ever.
>
> Even twenty years from now, you
On Thu, Jun 6, 2013 at 11:22 PM, Johannes Schindelin
wrote:
> Hi Greg,
>
> On Thu, 6 Jun 2013, Greg Troxel wrote:
>
>> As one of the people who helps maintain git packages in pkgsrc, my
>> initial reaction is negative to adding a ruby dependency.
>
> My initial reaction, too. It was hard enough to
On Mon, Mar 25, 2013 at 09:30:44AM +0100, Jens Lehmann wrote:
> Am 23.03.2013 17:28, schrieb Ilya Kulakov:
> > The `git submodule` commands seem to ignore modules which paths contain
> > unicode characters.
> >
> > Consider the following steps to reproduce the problem:
> >
> > 1. Create a direc
Hey Git Experts,
I need your advice. I have lot of png/jpg images in my codebase (which
is currently under git) which causes the repo size to be very heavy.
We have migrated these images to a storage server using git exile
technique. This has been working fine so far (with some glitches) on
unix p
I am Mrs.Flora Yu Yeung, a staff of Lloyd's TSB Group Plc. here in
Hong Kong; I
have a secured business proposal for you. If you are interested please
reach me
on my email: (mrs.floraye...@live.com) for more details.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the
On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
wrote:
> This follows the following rule:
> InputOutput::RequireBracedFileHandleWithPrint (Severity: 1)
> The `print' and `printf' functions have a unique syntax that supports an
> optional file handle argument. Conway suggests wrapping this a
On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
wrote:
> - strings which don't need interpolation are single-quoted for more clarity
> and
> slight gain of performance
> - interpolation is preferred over concatenation in many cases, for more
> clarity
> - variables are always used with the ${} op
On Fri, Jun 07, 2013 at 02:25:54PM -0500, Felipe Contreras wrote:
> On Fri, Jun 7, 2013 at 2:09 PM, Ramkumar Ramachandra
> wrote:
> > 77c130 (completion: clarify ls-tree, archive, show completion,
> > 2013-06-02) removed __git_complete_file () because it had no callers
> > left in the file. Howe
On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
wrote:
> Signed-off-by: Célestin Matte
> Signed-off-by: Matthieu Moy
> ---
> contrib/mw-to-git/git-remote-mediawiki.perl | 42
> +--
> 1 file changed, 26 insertions(+), 16 deletions(-)
>
> diff --git a/contrib/mw-to-git/g
On Fri, Jun 07, 2013 at 01:38:16PM -0700, Junio C Hamano wrote:
> Ramkumar Ramachandra writes:
>
> > 77c130 (completion: clarify ls-tree, archive, show completion,
> > 2013-06-02) removed __git_complete_file () because it had no callers
> > left in the file. However, to avoid breaking user scrip
On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
wrote:
> Signed-off-by: Célestin Matte
> Signed-off-by: Matthieu Moy
> ---
> contrib/mw-to-git/git-remote-mediawiki.perl |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
>
On Fri, Jun 07, 2013 at 02:53:02PM -0700, Junio C Hamano wrote:
> SZEDER Gábor writes:
>
> > On Fri, Jun 07, 2013 at 12:46:25PM -0700, Junio C Hamano wrote:
> >> Thanks for a pointer. I think what I was suggesting was slightly
> >> different in that I was hoping to see a single helper that knows
On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
wrote:
> - Remove m modifier when useless (m// and // was used randomly; this makes the
> code more coherent)
> - Remove stringy split (split('c', ...) instead of split(/c/, ...))
> - Use {}{} instead of /// when slashes are used inside the regexp so
We should call 'git rebase --abort', like a normal user would do.
Signed-off-by: Felipe Contreras
---
t/t3420-rebase-autostash.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/t/t3420-rebase-autostash.sh b/t/t3420-rebase-autostash.sh
index a5e69f3..ff370a3 100755
--- a/t/
On Fri, Jun 7, 2013 at 5:42 PM, Célestin Matte
wrote:
> @$var structures are re-written in the following way: @{$var}
> It makes them more readable.
>
> Signed-off-by: Célestin Matte
> Signed-off-by: Matthieu Moy
> ---
> contrib/mw-to-git/git-remote-mediawiki.perl | 12 ++--
> 1 file
Felipe Contreras writes:
> It is generated, in next. If it's not generated, there's no need to
> add it to NO_INSTALL.
OK, that makes sense.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at htt
On Fri, Jun 7, 2013 at 5:49 PM, Junio C Hamano wrote:
> I thought the conclusion was that combination of c8d1351 and 706728a
> we already queued was the right change. Is this meant to replace
> them?
Yes, those would do, but I'm not going to work on that series any more.
--
Felipe Contreras
--
Thanks.
I thought the conclusion was that combination of c8d1351 and 706728a
we already queued was the right change. Is this meant to replace
them?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at htt
On Fri, Jun 7, 2013 at 5:40 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>>> Perhaps like this?
>>>
>>> Makefile | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index a748133..03fda50 100644
>>> --- a/Makefile
>>> +++ b/Makefile
Felipe Contreras writes:
>> Perhaps like this?
>>
>> Makefile | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index a748133..03fda50 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -2239,6 +2239,7 @@ endif
>>
>> test_bindir_programs := $(pat
On Fri, Jun 7, 2013 at 5:28 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> On Fri, Jun 7, 2013 at 5:03 PM, Felipe Contreras
>> wrote:
>>
>>> -all:: $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) $(OTHER_PROGRAMS)
>>> GIT-BUILD-OPTIONS
>>> +all:: $(ALL_PROGRAMS) $(SCRIPTS_GEN) $(SCRIPT_LI
We are not freeing 'istate->cache' properly.
We can't rely on 'initialized' to keep track of the 'istate->cache',
because it doesn't really mean it's initialized. So assume it always has
data, and free it before overwriting it.
Signed-off-by: Felipe Contreras
---
read-cache.c | 4
1 file c
Before overwriting the destination index, first let's discard its
contents.
Signed-off-by: Felipe Contreras
---
unpack-trees.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/unpack-trees.c b/unpack-trees.c
index 57b4074..abe2576 100644
--- a/unpack-trees.c
+++ b/unpack-tr
Felipe Contreras (2):
unpack-trees: plug a memory leak
read-cache: plug a few leaks
read-cache.c | 4
unpack-trees.c | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
--
1.8.3.698.g079b096
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a mes
Felipe Contreras writes:
> On Fri, Jun 7, 2013 at 5:03 PM, Felipe Contreras
> wrote:
>
>> -all:: $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) $(OTHER_PROGRAMS)
>> GIT-BUILD-OPTIONS
>> +all:: $(ALL_PROGRAMS) $(SCRIPTS_GEN) $(SCRIPT_LIB) $(BUILT_INS)
>> $(OTHER_PROGRAMS) GIT-BUILD-OPTIONS
>
> Alte
Clarify that ce can be NULL by adding a check (probably more efficient
also), and get rid of unnecessary indentation (since it's a single line
it doesn't matter, but in the future it might).
Signed-off-by: Felipe Contreras
---
unpack-trees.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletion
Hi,
This patch series moves the sequencer code which is only useful for builtin
commands, to builtin. This also creates the concept of 'builtin helpers'.
Felipe Contreras (2):
log-tree: remove dependency from sequencer
Move sequencer to builtin
Makefile | 9 ++-
Move the relevant code from sequencer to log-tree. This code is not
specific to sequencer, and this allows the sequencer to move out of
libgit.
Signed-off-by: Felipe Contreras
---
log-tree.c | 161 +++-
log-tree.h | 3 ++
sequencer.c |
This code is only useful for cherry-pick and revert built-ins, nothing
else, so let's make it a builtin object, but make sure 'git-sequencer'
is not generated.
Signed-off-by: Felipe Contreras
---
Makefile | 9 ++---
sequencer.c => builtin/sequencer.c | 0
sequencer.
100% means the person was involved in all the commits, in one way or the
other.
Signed-off-by: Felipe Contreras
---
It's barely useful for me without this.
This sits on top of the last git-related series.
contrib/related/git-related | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Fri, Jun 7, 2013 at 5:03 PM, Felipe Contreras
wrote:
> -all:: $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) $(OTHER_PROGRAMS)
> GIT-BUILD-OPTIONS
> +all:: $(ALL_PROGRAMS) $(SCRIPTS_GEN) $(SCRIPT_LIB) $(BUILT_INS)
> $(OTHER_PROGRAMS) GIT-BUILD-OPTIONS
Alternatively, we could add $(NO_INSTALL) h
Thanks; the interdiff looks sane.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Commit 416fda6 (build: do not install git-remote-testpy) made it so
git-remote-testpy is not only not installed, but also not generated by
default, let's make sure all the scripts are generated.
Signed-off-by: Felipe Contreras
---
Makefile | 7 ++-
1 file changed, 6 insertions(+), 1 deletion
Felipe Contreras (2):
build: generate test scripts
build: do not install git-remote-testgit
Makefile | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
--
1.8.3.698.g079b096
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vg
Signed-off-by: Felipe Contreras
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 126be01..02e3d43 100644
--- a/Makefile
+++ b/Makefile
@@ -491,6 +491,7 @@ SCRIPT_PERL += git-svn.perl
SCRIPT_PYTHON += git-remote-testpy.py
SCRIPT_PYTHON += git-p4.py
+NO
Jakub Narębski writes:
>>> Instead, clear $search_regexp before dispatching each request.
>>>
>>> Signed-off-by: Charles McGarvey
>
> Acked-by: Jakub Narebski
Thanks (the ack was a few hours too late and the commit is already
in 'next', so I won't be able to rewind it though).
>> By the way,
Junio C Hamano wrote:
> Stefan (as your name appears in 76bf6ff93e, I am assuming that you
> were the OSX-osascript guru in that commit) could you keep an eye on
> the list traffic to see if users of latest gitk have issues with
> that change, please?
Sure, will do.
--
Stefan Haller
Berlin, G
On Mac OS X, any application that is started from the Terminal will open
behind all running applications; as a work-around, manually bring ourselves
to the front. (Stolen from gitk, commit 76bf6ff93e.)
We do this as the very first thing, so that any message boxes that might pop
up during the rest
SZEDER Gábor writes:
> On Fri, Jun 07, 2013 at 12:46:25PM -0700, Junio C Hamano wrote:
>> Thanks for a pointer. I think what I was suggesting was slightly
>> different in that I was hoping to see a single helper that knows to
>> complete to object names (possibly including trees/blobs with the
>
From: Benoit Person
The #7 issue on git-mediawiki's issue tracker [1] states that the ability to
preview content without pushing would be a nice thing to have.
This commit is a first attempt to achieve it. It adds a new git command,
named `git mw`. This command accepts the subcommands `help` and
@$var structures are re-written in the following way: @{$var}
It makes them more readable.
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/contrib/mw-to-g
- Remove m modifier when useless (m// and // was used randomly; this makes the
code more coherent)
- Remove stringy split (split('c', ...) instead of split(/c/, ...))
- Use {}{} instead of /// when slashes are used inside the regexp so as not to
escape it.
A "split ' '" is turned into a "split / /"
Non-trivial numeric values (e.g., different from 0, 1 and 2) are placed in
constants at the top of the code to be easily modifiable and to make more sense
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 20 ++--
1 fil
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index ae6dd2e..1c34ada 1
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index cf8dfc8..7fbc9
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 42 +--
1 file changed, 26 insertions(+), 16 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index 94a0411..be860c8 1
Follow Subroutines::RequireFinalReturn
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 18 ++
1 file changed, 18 insertions(+)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
Empty strings are replaced by an $EMPTY constant.
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/co
%basetimestamps declaration was lost in the middle of subroutines
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b
- strings which don't need interpolation are single-quoted for more clarity and
slight gain of performance
- interpolation is preferred over concatenation in many cases, for more clarity
- variables are always used with the ${} operator inside strings
- strings including double-quotes are written w
Explicitly assign local variable $/ as undef and make a proper
one-instruction-by-line indentation
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-g
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index 68fd129..a6c7d
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index 1024de1..1
This follows the following rule:
InputOutput::RequireBracedFileHandleWithPrint (Severity: 1)
The `print' and `printf' functions have a unique syntax that supports an
optional file handle argument. Conway suggests wrapping this argument in
braces to make it visually stand out from the ot
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |1 -
1 file changed, 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index a6c7de2..cf8dfc8 100755
--- a/contrib/m
Subroutines' parameters should be affected to variable before doing anything
else
Besides, existing instruction affected a variable inside a "if", which break
Git's coding style
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |3 ++-
Follow ValuesAndExpressions::ProhibitConstantPragma
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki
Put first parameter of map inside a block, for better readability.
Follow BuiltinFunctions::RequireBlockMap
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --gi
Local variable $url has the same name as a global variable. Changing the name
of the local variable prevents future possible misunderstanding.
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |6 +++---
1 file changed, 3 insertions(+)
Follow perlcritic's InputOutput::RequireEncodingWithUTF8Layer policy
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
v2 of patch to follow perlcritic's recommandations ([1])
Changes with v1:
- split first commit into 6 different commits
- remove commit [17/18] about moving open() call
- took every other comment into account
[1]: http://thread.gmane.org/gmane.comp.version-control.git/226533
Célestin Matte (22):
There are many instances where the treatment of symbolic links in the
object model and the algorithms are tested, but where it is not
necessary to actually have a symbolic link in the worktree. Make
adjustments to the tests and remove the SYMLINKS prerequisite when
appropriate in trivial cases, whe
The part of the test that is about symbolic links in the index does not
require that the corresponding file system entry is actually a symbolic
link. Use test_ln_s_add to insert a symbolic link in the index. When
the file system does not support symbolic links, we actually have a
regular file in th
Add a new function that creates a symbolic link and adds it to the index
to be used in cases where a symbolic link is not required on the file
system. We will use it to remove many SYMLINKS prerequisites from test
cases.
Signed-off-by: Johannes Sixt
---
t/README| 14 +
All tests in t6035 are protected by SYMLINKS. But that is not necessary,
because a lot of the functionality can be tested provided symbolic link
entries enter the index and object data base. Use test_ln_s_add for this
purpose.
Some test cases do test the presence of symbolic links on the file syst
This undoes the special casing introduced in this test by 704a3143
(Use prerequisite tags to skip tests that depend on symbolic links,
2009-03-04).
Signed-off-by: Johannes Sixt
---
t/t3100-ls-tree-restrict.sh | 42 +++---
1 file changed, 15 insertions(+), 27 d
t-basic hard-codes many object IDs. To cater to file systems that do
not support symbolic links, different IDs are used depending on the
SYMLINKS prerequisite. But we can observe the symbolic links are only
needed to generate index entries. Use test_ln_s_add to generate the
index entries and ge
In t4023 and t4114, we have to remove the entries using 'git rm' because
otherwise the entries that must turn from symbolic links to regular files
would stay symbolic links in the index. For the same reason, we have to
use 'git mv' instead of plain 'mv' in t3509.
Signed-off-by: Johannes Sixt
---
Many tests that involve symbolic links actually check only whether our
algorithms are correct by investigating the contents of the object
database and the index. Only some of them check the filesystem.
This series introduces a function test_ln_s_add that inserts a symbolic
link in the index even i
In particular:
- move test preparations inside test_expect_success
- place test description on the test_expect_success line
- indent with a tab
Signed-off-by: Johannes Sixt
---
t/t3010-ls-files-killed-modified.sh | 123 ++--
1 file changed, 61 insertions(+), 62
The test cases include many corner-cases of merge-recursive's behavior,
some of them involve type changes and symbolic links. All cases, including
those that are protected by SYMLINKS check only whether the result of
merge-recursive is correctly stored in the database and the index; the
file system
MinGW's bash does not recognize an exit code -1 as failure. See also
47e3de0e (MinGW: truncate exit()'s argument to lowest 8 bits) and 2488df84
(builtin run_command: do not exit with -1). Exit code 1 is good enough.
Signed-off-by: Johannes Sixt
---
test-chmtime.c | 8
1 file changed, 4
On Fri, Jun 07, 2013 at 12:46:25PM -0700, Junio C Hamano wrote:
> Thanks for a pointer. I think what I was suggesting was slightly
> different in that I was hoping to see a single helper that knows to
> complete to object names (possibly including trees/blobs with the
> treeish:path notation), ran
On Wed, Jun 5, 2013 at 9:17 PM, Junio C Hamano wrote:
> Charles McGarvey writes:
>
>> The bug is manifest when running gitweb in a persistent process (e.g.
>> FastCGI, PSGI), and it's easy to reproduce. If a gitweb request
>> includes the searchtext parameter (i.e. s), subsequent requests using
Ramkumar Ramachandra writes:
> 77c130 (completion: clarify ls-tree, archive, show completion,
> 2013-06-02) removed __git_complete_file () because it had no callers
> left in the file. However, to avoid breaking user scripts that may
> depend on this, add it back as a deprecated alias.
>
> Signe
Let's show the output so it's clear why it failed.
Signed-off-by: Felipe Contreras
---
t/t3400-rebase.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh
index b58fa1a..fb39531 100755
--- a/t/t3400-rebase.sh
+++ b/t/t3400-rebase.sh
@@ -185,6 +185,7 @@ tes
read_cache() already does that check.
Signed-off-by: Felipe Contreras
---
submodule.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/submodule.c b/submodule.c
index ad476ce..8685424 100644
--- a/submodule.c
+++ b/submodule.c
@@ -603,9 +603,8 @@ int fetch_populated_submo
We should free objects before leaving.
Signed-off-by: Felipe Contreras
---
sequencer.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index ab6f8a7..7eeae2f 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -626,12 +626,15 @@ static int do_pick_c
Felipe Contreras (3):
sequencer: trivial fix
test: improve rebase -q test
submodule: remove unnecessary check
sequencer.c | 7 +--
submodule.c | 5 ++---
t/t3400-rebase.sh | 1 +
3 files changed, 8 insertions(+), 5 deletions(-)
--
1.8.3.698.g079b096
--
To unsubscribe from
Le 07/06/2013 22:25, Eric Sunshine a écrit :
> If you do choose to be more precise, it should be done as a separate
> patch. Each conceptually distinct change should have its own patch.
> Doing so makes changes easier to review and (generally) easier to
> cherry-pick. For example, in this particula
On Thu, Jun 6, 2013 at 2:21 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> On Thu, Jun 6, 2013 at 1:30 PM, Junio C Hamano wrote:
>>> Felipe Contreras writes:
>>>
Pretty much what it says on the tin.
>>>
>>> And a bit more, isn't it?
>>>
>>> The --keep-redundant-commits option im
On Fri, Jun 7, 2013 at 1:04 PM, Célestin Matte
wrote:
> Le 07/06/2013 06:12, Eric Sunshine a écrit :
>> On Thu, Jun 6, 2013 at 3:34 PM, Célestin Matte
>> wrote:
>>> } elsif ($cmd[0] eq "import") {
>>> - die("Invalid arguments for import\n") unless
>>> ($cmd[
On Fri, Jun 7, 2013 at 2:55 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>>> I think we heard enough from packaging folks that a new dependency
>>> is unwelcome.
>>
>> What are you talking about? Which are these "packaging folks" we heard from?
>
> Dscho is one of the primary people beh
On 7 June 2013 13:13, Charles McGarvey wrote:
> On 06/07/2013 01:02 PM, Constantine A. Murenin wrote:
>>> That's a one-time penalty. Why would that be a problem? And why is wget
>>> even mentioned? Did we misunderstood eachother?
>>
>> `wget` or `curl --head` would be used to trigger the caching.
On 06/07/2013 01:02 PM, Constantine A. Murenin wrote:
>> That's a one-time penalty. Why would that be a problem? And why is wget
>> even mentioned? Did we misunderstood eachother?
>
> `wget` or `curl --head` would be used to trigger the caching.
>
> I don't understand how it's a one-time penalty.
On Sat, Jun 08, 2013 at 01:17:28AM +0530, Ramkumar Ramachandra wrote:
> SZEDER Gábor wrote:
> > because nowadays __git_complete_file() is a wrapper around
> > __git_complete_revlist_file().
>
> What? It was never anything different from a poorly-named alias for
> __git_complete_revlist_file().
A
Felipe Contreras writes:
>> I think we heard enough from packaging folks that a new dependency
>> is unwelcome.
>
> What are you talking about? Which are these "packaging folks" we heard from?
Dscho is one of the primary people behind msysgit effort, and I
consulted with others from the circle w
SZEDER Gábor wrote:
> because nowadays __git_complete_file() is a wrapper around
> __git_complete_revlist_file().
What? It was never anything different from a poorly-named alias for
__git_complete_revlist_file(). You have already agreed that
__git_complete_file() is a horrible name, so why not d
Ramkumar Ramachandra wrote:
> commit a lot of good ruby code to contrib*
Oh, by the way: I have a project idea. There's this really popular
project called hub[1] that has an implementation of the GitHub API in
ruby. Unfortunately, it's a terrible piece of software because it
creates an extra lay
SZEDER Gábor writes:
>> Now I do not recall suggesting it, and you (and I today after 2
>> years) may disagree with the rationale, but at least we can read
>> what was the "intended" meaning, I think.
>
> See
>
> http://thread.gmane.org/gmane.comp.version-control.git/167728/focus=168838
>
> I s
Felipe Contreras wrote:
> While at it, why not re-evaluate the whole msysgit approach? I bet we
> don't need a whole separate project just to create a Windows
> installer. I've written Windows installers before, it's very easy to
> do from Linux.
Yeah, taking the pain out of msysgit packaging woul
Am 07.06.2013 08:11, schrieb Martin von Zweigbergk:
> Changes since v5:
>
> * Improved test_linear_range
> * Changed TODOs to be about consistency, not --topo-order
>
> Martin von Zweigbergk (7):
> add simple tests of consistency across rebase types
> add tests for rebasing with patch-equiv
1 - 100 of 173 matches
Mail list logo
