Re: [RFC] Add basic syntax check on shell scripts

2012-12-03 Thread Nguyen Thai Ngoc Duy
On Mon, Dec 3, 2012 at 11:56 PM, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> The test suite needs to be run on different platforms. >> As it may be difficult for contributors to catch syntax >> which work on GNU/linux, but is unportable, make a quick check >> for the most common pro

[PATCHv2] l10n: de.po: translate 22 new messages

2012-12-03 Thread Ralf Thielow
Translate 22 new messages came from git.pot updates in 9306b5b (l10n: Update git.pot (3 new, 6 removed messages)), fe52cd6 (l10n: Update git.pot (14 new, 3 removed messages)) and f9472e3 (l10n: Update git.pot (5 new, 1 removed messages)). Signed-off-by: Ralf Thielow Reviewed-by: Michael J Gruber

Re: [RFC/PATCH] l10n: de.po: translate 825 new messages

2012-12-03 Thread Ralf Thielow
2012/12/3 Michael J Gruber : >> 1 file changed, 61 insertions(+), 62 deletions(-) > ... >> #: builtin/fsck.c:620 >> msgid "also consider packs and alternate objects" >> -msgstr "betrachtet auch Pakete und wechselnde Objekte" >> +msgstr "" > > Oops ;) > >> #: builtin/push.c:391 >> msgid "check"

Re: [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-03 Thread Junio C Hamano
Erik Faye-Lund writes: > That patch corrected the exit-code for our SIGALRM's SIG_DFL routine; > the old code did "die("Alarm");", but the new one does "fputs("Alarm > clock\n", stderr); exit(128 + SIGALRM)" > >> Please double check the result when I push out the 'pu' >> branch. > > The resolutio

Re: [PATCH v6 1/4] submodule: add get_submodule_config helper funtion

2012-12-03 Thread W. Trevor King
On Mon, Dec 03, 2012 at 11:30:12AM -0800, Junio C Hamano wrote: > > +get_submodule_config() > > +{ > > style (see CodingGuidelines): > > get_submodule_config () { Will fix. I was generally just copying the surrounding code. > > + name="$1" > > + option="$2" > > + default="$3" > > +

Re: [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-03 Thread Erik Faye-Lund
On Sun, Dec 2, 2012 at 11:42 AM, Junio C Hamano wrote: > Erik Faye-Lund writes: > >> @@ -1538,13 +1563,7 @@ static sig_handler_t timer_fn = SIG_DFL; >> static unsigned __stdcall ticktack(void *dummy) >> { >> while (WaitForSingleObject(timer_event, timer_interval) == >> WAIT_TIMEOUT) { >>

Re: [PATCH v7 p1 07/13] remote-testgit: remove irrelevant test

2012-12-03 Thread Pete Wyckoff
felipe.contre...@gmail.com wrote on Wed, 28 Nov 2012 23:11 +0100: > This was only to cover a bug that was fixed in remote-testpy not to > resurface. > > Signed-off-by: Felipe Contreras > Signed-off-by: Junio C Hamano > --- > t/t5801-remote-helpers.sh | 13 - > 1 file changed, 13 del

Re: Python extension commands in git - request for policy change

2012-12-03 Thread Philippe Vaucher
> Also, you are ignoring all the advantages that shell has and python does not. Out of curiosity, can you list the advantages? From what I gathered: - no need to install bash - git contributors are more used to bash - there's only one "version" of bash (no real need to handle different versions c

Re: [PATCH] gitk: read and write a repository specific configuration file

2012-12-03 Thread Stefan Haller
Lukasz Stelmach wrote: > Enable gitk read and write repository specific configuration > file: ".git/k" if the file exists. To make gitk use the local > file simply create one, e.g. with the touch(1) command. I'm not sure I like this proposal. While it may be desirable to have *some* settings sto

[ANNOUNCE] Git v1.8.1-rc0

2012-12-03 Thread Junio C Hamano
A release candidate preview, Git v1.8.1-rc0, is now available for testing at the usual places. This cycle has been a bit slow (perhaps because it had a major US holiday to slow people down) but we seem to have managed to apply reasonably large number of usability improvement changes, with a handfu

Re: [PATCH v6 2/4] submodule update: add --remote for submodule's upstream changes

2012-12-03 Thread Junio C Hamano
"W. Trevor King" writes: > As an example to make this clearer: > > $ cat .gitmodules > [submodule "sub1"] > path = sub1 > url = git://example.com/sub1.git > remote = remote1 > branch = branch1 > update-source = submodule-upstream > update = rebase > [submodule "sub2"

Re: [PATCH v2 0/4] git-svn: More docs for branch handling in

2012-12-03 Thread Junio C Hamano
I've sent comments on small nits I found but overall they looked quite well researched. Will tentatively queue on the 'pu' branch, expecting further updates and Acks from people involved polishing these patches. Thanks for writing it up. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v2 3/4] git-svn: Expand documentation for --follow-parent

2012-12-03 Thread Junio C Hamano
Sebastian Leske writes: > Describe what the option --follow-parent does, and what happens if it is > set or unset. > > Signed-off-by: Sebastian Leske > --- > Documentation/git-svn.txt | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/git-s

Re: [PATCH v2 2/4] Recommend use of structure options for git svn.

2012-12-03 Thread Junio C Hamano
Sebastian Leske writes: > Document that when using git svn, one should usually either use the > directory structure options to import branches as branches, or only > import one subdirectory. The default behaviour of cloning all branches > and tags as subdirectories in the working copy is usually

Re: [PATCH v6 1/4] submodule: add get_submodule_config helper funtion

2012-12-03 Thread Junio C Hamano
"W. Trevor King" writes: > From: "W. Trevor King" > > Several submodule configuration variables > (e.g. fetchRecurseSubmodules) are read from .gitmodules with local > overrides from the usual git config files. This shell function mimics > that logic to help initialize configuration variables in

Re: [PATCH v2 1/4] git-svn: Document branches with at-sign(@).

2012-12-03 Thread Junio C Hamano
Sebastian Leske writes: > git svn will sometimes create branches with an at-sign in the name It may be just me but "git svn sometimes creates" without "will" reads much better to me (there is the same phrasing in the patch text as well). > (branchname@revision). These branches confuse many user

Re: [PATCH v6 0/8] push: update remote tags only with force

2012-12-03 Thread Junio C Hamano
Thanks; will queue. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 2/4] submodule update: add --remote for submodule's upstream changes

2012-12-03 Thread W. Trevor King
As an example to make this clearer: $ cat .gitmodules [submodule "sub1"] path = sub1 url = git://example.com/sub1.git remote = remote1 branch = branch1 update-source = submodule-upstream update = rebase [submodule "sub2"] ... Means that `git submodule update sub1`

Re: [PATCH] status: respect advice.statusHints for ahead/behind advice

2012-12-03 Thread Jeff King
On Mon, Dec 03, 2012 at 09:11:32AM -0800, Junio C Hamano wrote: > > On top of mm/status-push-pull-advise. > > > > I left "git checkout" alone, though I'd also like to turn it off there, > > too. Should it get a separate advice option there? Should it simply > > respect statusHints (it seems odd be

Re: [PATCH v6 2/4] submodule update: add --remote for submodule's upstream changes

2012-12-03 Thread W. Trevor King
On Mon, Dec 03, 2012 at 08:46:46AM -0800, Junio C Hamano wrote: > As you hinted in the first paragraph, you could flip between merge, > rebase, and detach with a command line option when running the > "update" subcommand, but I would imagine that the expected use > pattern is that for a particular

Re: Ubuntu: gitweb always looks for projects in /var/cache/git (“404 - no projects found”)

2012-12-03 Thread Alfonso Muñoz-Pomer Fuentes
Thank you very much for the clarification. Noticing how this wasn’t documented anywhere I had the feeling that I was missing something. On Thu 29 Nov 2012 19:28:26 CET, Jeff King wrote: On Thu, Nov 29, 2012 at 01:55:57PM +, Alfonso Muñoz-Pomer Fuentes wrote: I’ve discovered this weird beh

Re: [PATCH] status: respect advice.statusHints for ahead/behind advice

2012-12-03 Thread Junio C Hamano
Jeff King writes: > If the user has unset advice.statusHints, we already > suppress the "use git reset to..." hints in each stanza. The > new "use git push to publish..." hint is the same type of > hint. Let's respect statusHints for it, rather than making > the user set yet another advice flag.

Re: [RFC] Add basic syntax check on shell scripts

2012-12-03 Thread Junio C Hamano
Torsten Bögershausen writes: > The test suite needs to be run on different platforms. > As it may be difficult for contributors to catch syntax > which work on GNU/linux, but is unportable, make a quick check > for the most common problems. > "sed -i", "echo -n" or "array in shell scripts" > This

Re: [PATCH] t9402: sed -i is not portable

2012-12-03 Thread Junio C Hamano
Torsten Bögershausen writes: > On some systems sed allows the usage of e.g. > sed -i -e "s/line1/line2/" afile > to edit the file "in place". > Other systems don't allow that: one observed behaviour is that > sed -i -e "s/line1/line2/" afile > creates a backup file called afile-e, which breaks th

Re: [PATCH v6 2/4] submodule update: add --remote for submodule's upstream changes

2012-12-03 Thread Junio C Hamano
"W. Trevor King" writes: > From: "W. Trevor King" > > The current `update` command incorporates the superproject's gitlinked > SHA-1 ($sha1) into the submodule HEAD ($subsha1). Depending on the > options you use, it may checkout $sha1, rebase the $subsha1 onto > $sha1, or merge $sha1 into $subs

Re: [RFC] remove/deprecate 'submodule init' and 'sync'

2012-12-03 Thread W. Trevor King
On Sun, Dec 02, 2012 at 04:11:59PM -0500, W. Trevor King wrote: > On Sun, Dec 02, 2012 at 09:29:29PM +0100, Jens Lehmann wrote: > > Am 01.12.2012 18:49, schrieb W. Trevor King: > > > On Sat, Dec 01, 2012 at 06:25:17PM +0100, Jens Lehmann wrote: > > >> What real world problems do we have with the cu

Re: [PATCH] l10n: de.po: translate 22 new messages

2012-12-03 Thread Michael J Gruber
Ralf Thielow venit, vidit, dixit 03.12.2012 05:49: > Translate 22 new messages came from git.pot > updates in 9306b5b (l10n: Update git.pot (3 new, > 6 removed messages)), fe52cd6 (l10n: Update git.pot > (14 new, 3 removed messages)) and f9472e3 > (l10n: Update git.pot (5 new, 1 removed messages)).

Re: [PATCH 6/8] imap-send: change msg_data from storing (char *, len) to storing strbuf

2012-12-03 Thread Thiago Farina
On Sat, Dec 1, 2012 at 11:48 PM, Junio C Hamano wrote: >> I suggest a separate patch series dedicated to deleting *all* the extra >> imap infrastructure at once. That being said, I'm not committing to do >> so. (We could add it to an "straightforward projects for aspiring git >> developers" list

Re: [RFC/PATCH] l10n: de.po: translate 825 new messages

2012-12-03 Thread Michael J Gruber
Ralf Thielow venit, vidit, dixit 03.12.2012 05:48: > Thanks Thomas and Michael! > > 2012/11/30 Thomas Rast : > >>> #: builtin/update-index.c:756 >>> msgid "mark files as \"index-only\"" >>> -msgstr "" >>> +msgstr "markiert Dateien als \"index-only\"" >> >> Likewise, but here I don't even unders

Re: does a successful 'git gc' imply 'git fsck'

2012-12-03 Thread Junio C Hamano
Matthieu Moy writes: > Junio C Hamano writes: > >> But a "gc" does not necessarily run "repack -a" when it does not see >> too many pack files, so it can end up scanning only the surface of >> the history to collect the recently created loose objects into a >> pack, and stop its traversal withou

Re: does a successful 'git gc' imply 'git fsck'

2012-12-03 Thread Matthieu Moy
Junio C Hamano writes: > But a "gc" does not necessarily run "repack -a" when it does not see > too many pack files, so it can end up scanning only the surface of > the history to collect the recently created loose objects into a > pack, and stop its traversal without going into existing packfile

Re: does a successful 'git gc' imply 'git fsck'

2012-12-03 Thread Sitaram Chamarty
On Sun, Dec 2, 2012 at 3:01 PM, Junio C Hamano wrote: > Sitaram Chamarty writes: > >> If I could assume that a successful 'git gc' means an fsck is not >> needed, I'd save a lot of time. Hence my question. > > When it does "repack -a", it at least scans the whole history so you > would be sure t

Re: [BUG?] git-subtree behavior when the -P tree is removed and recreated

2012-12-03 Thread Tomi Belan
Another bump. I reported this back in October, but there hasn't been any response yet... Note that the bug is still present in git 1.8.0.1. Tomi On Sun, Oct 21, 2012 at 11:18 PM, Tomi Belan wrote: > This probably got lost in the mail. Could somebody familiar with > git-subtree take a look? > To

Re: [PATCH] status: respect advice.statusHints for ahead/behind advice

2012-12-03 Thread Matthieu Moy
Jeff King writes: > If the user has unset advice.statusHints, we already > suppress the "use git reset to..." hints in each stanza. The > new "use git push to publish..." hint is the same type of > hint. Let's respect statusHints for it, rather than making > the user set yet another advice flag.