Re: Reviews on mailing-list

2012-11-10 Thread Ramkumar Ramachandra
Deniz Türkoglu wrote: > I have spoken to Shawn Pearce (gerrit project lead, google) and he > said he is OK with hosting the gerrit instance. > > I would like to hear your thoughts on this. I personally think email is by far the best interface for patches, reviews, and discussions. Git patches are

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Kalle Olavi Niemitalo
Paul Fox writes: > you're sending SIGINT to the cvs commit command, and that causes the > editor to die right away? That's right. It is not a quirk of shell-mode in Emacs, because I get the same result with ^C in xterm too. % EDITOR="$HOME/prefix/x86_64-unknown-linux-gnu/bin/emacsclient --curr

Re: Reviews on mailing-list

2012-11-10 Thread Junio C Hamano
Thiago Farina wrote: >Requiring a web browser is a huge requirement, ham?? No, but requiring reviews and discussions typed in the browser is. Pardon terseness, typo and HTML from a tablet. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@

[PATCH] gitweb: git_summary - show $project in title

2012-11-10 Thread Henrich Schuchardt
Gitweb pages are structured by divs of class title with grey background. The shortlog, and the log page show the project name as the first title. Page summary only shows an empty grey box above the project details. This provides an inconstent user experience. This patch adds the missing project ti

Re: [PATCH v4 3/6] Color skipped tests blue

2012-11-10 Thread Adam Spiers
On Fri, Sep 21, 2012 at 02:13:25AM -0400, Jeff King wrote: > On Wed, Sep 19, 2012 at 09:24:23PM +0100, Adam Spiers wrote: > > > t/test-lib.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/t/test-lib.sh b/t/test-lib.sh > > index 5293830..78c88c2 100755 > > ---

Re: Reviews on mailing-list

2012-11-10 Thread Deniz Türkoglu
On Sat, Nov 10, 2012 at 3:40 PM, Felipe Contreras wrote: > On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote: > >> This is my first mail to the git mailing list. I have been following >> the list for some time now and I would like to suggest moving the >> reviews out of the mailing list, for

Re: Reviews on mailing-list

2012-11-10 Thread Thiago Farina
On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras wrote: > On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote: > >> This is my first mail to the git mailing list. I have been following >> the list for some time now and I would like to suggest moving the >> reviews out of the mailing list, for

Re: t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 1:19 AM, Stefano Lattarini wrote: > On 11/11/2012 12:11 AM, Felipe Contreras wrote: >> On Sat, Nov 10, 2012 at 11:39 PM, Junio C Hamano wrote: >>> Felipe Contreras writes: >>> On Sat, Nov 10, 2012 at 3:37 PM, Torsten Bögershausen wrote: > The short version

Re: orphan blob or what?

2012-11-10 Thread bruce
Tomas Carnecky writes: > On Fri, 09 Nov 2012 11:37:04 -0800, bruce wrote: >> Tomas Carnecky writes: >> >> Just idiocy on my part. Thanks. >> >> > On Thu, 08 Nov 2012 16:24:36 -0800, bruce >> > wrote: >> >> In today's and older clones of https://github.com/mirrors/linux.git I >> >> find this

Re: t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Stefano Lattarini
On 11/11/2012 12:11 AM, Felipe Contreras wrote: > On Sat, Nov 10, 2012 at 11:39 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> On Sat, Nov 10, 2012 at 3:37 PM, Torsten Bögershausen wrote: The short version: echo -n doesn't seem to be portable. The following works for

[PATCH] git-credential-gnome-keyring: Remove die

2012-11-10 Thread Matt Kraai
git-credential-gnome-keyring defines die, but it is unused and incorrect (it passes a va_list to error, which does not expect one), so remove it. Signed-off-by: Matt Kraai --- .../credential/gnome-keyring/git-credential-gnome-keyring.c | 10 -- 1 file changed, 10 deletions(-) diff --

Re: Reviews on mailing-list

2012-11-10 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote: > This is my first mail to the git mailing list. I have been following > the list for some time now and I would like to suggest moving the > reviews out of the mailing list, for example to a gerrit instance, I > believe it would improve the

Reviews on mailing-list

2012-11-10 Thread Deniz Türkoglu
Hi all, This is my first mail to the git mailing list. I have been following the list for some time now and I would like to suggest moving the reviews out of the mailing list, for example to a gerrit instance, I believe it would improve the commits and the mailing list. I have a filter on 'PATCH',

Re: t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Felipe Contreras
On Sat, Nov 10, 2012 at 11:39 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Sat, Nov 10, 2012 at 3:37 PM, Torsten Bögershausen wrote: >>> The short version: >>> echo -n doesn't seem to be portable. >>> The following works for me: >> >> Right, I was supposed to change that to: >> >

Re: t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Junio C Hamano
Felipe Contreras writes: > On Sat, Nov 10, 2012 at 3:37 PM, Torsten Bögershausen wrote: >> The short version: >> echo -n doesn't seem to be portable. >> The following works for me: > > Right, I was supposed to change that to: > > true > marks-cur && Please make it like so: >marks-cur

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Paul Fox
kalle olavi niemitalo wrote: > Paul Fox writes: > > > when i implemented the change, i wondered if some twisted emacs > > workflow would be an issue. ;-) and i almost blocked SIGQUIT as > > well -- the two programs i looked at for precedent (CVS and MH) both > > block both SIGQUIT and SIGI

Re: t5801-remote-helpers.sh fails

2012-11-10 Thread Felipe Contreras
On Sat, Nov 10, 2012 at 8:20 PM, Torsten Bögershausen wrote: > On 11/10/2012 08:15 PM, Felipe Contreras wrote: >> >> Hi, >> >> On Sat, Nov 10, 2012 at 2:48 PM, Torsten Bögershausen >> wrote: >> >>> on peff/pu t5801 fails, the error is in git-remote-testgit, please see >>> below. >>> >>> That's on

Re: [msysGit] [PATCH] git tag --contains : avoid stack overflow

2012-11-10 Thread Pat Thoyts
On 10 November 2012 21:13, Jean-Jacques Lafay wrote: > Le samedi 10 novembre 2012 21:00:10 UTC+1, Philip Oakley a écrit : >> >> From: "Jean-Jacques Lafay" Sent: Saturday, >> November 10, 2012 5:36 PM >> > In large repos, the recursion implementation of contains(commit, >> > commit_list) >> > may

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Andreas Schwab
Kalle Olavi Niemitalo writes: > With strace, it looks like CVS sets SIG_IGN as the handler of > SIGINT and SIGQUIT only in the parent process after forking, not > in the child process that executes the editor. > > CVS also temporarily blocks signals by calling sigprocmask, but > it undoes that be

Re: git-reset man page

2012-11-10 Thread Krzysztof Mazur
On Sat, Nov 10, 2012 at 12:02:12PM -0800, Junio C Hamano wrote: > Krzysztof Mazur writes: > > > Maybe we should just add that is an shortcut for > > and fix places where paths and pathspec are mixed or is used as > > . > > We should unify uses of and (the former should be > ... or something

Re: git-reset man page

2012-11-10 Thread Junio C Hamano
Krzysztof Mazur writes: > Maybe we should just add that is an shortcut for > and fix places where paths and pathspec are mixed or is used as > . We should unify uses of and (the former should be ... or something). Some places you need to give exact path (iow, these places you cannot use pa

Re: [msysGit] [PATCH] git tag --contains : avoid stack overflow

2012-11-10 Thread Philip Oakley
From: "Jean-Jacques Lafay" Sent: Saturday, November 10, 2012 5:36 PM In large repos, the recursion implementation of contains(commit, commit_list) may result in a stack overflow. Replace the recursion with a loop to fix it. Signed-off-by: Jean-Jacques Lafay This is a change to the main git

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Junio C Hamano
SZEDER Gábor writes: >> I think it is better to keep the tests simple and maintainable. > > Maintainable? There is nothing to maintain here > ... > OTOH, this series has some serious drawbacks. > > It makes debugging more difficult Are these referring to the same aspect of the series?

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Kalle Olavi Niemitalo
Paul Fox writes: > when i implemented the change, i wondered if some twisted emacs > workflow would be an issue. ;-) and i almost blocked SIGQUIT as > well -- the two programs i looked at for precedent (CVS and MH) both > block both SIGQUIT and SIGINT when spawning an editor. > > but since emacs

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-10 Thread A Large Angry SCM
On 11/10/2012 01:43 PM, Felipe Contreras wrote: On Sat, Nov 10, 2012 at 6:28 PM, Michael J Gruber wrote: Felipe Contreras venit, vidit, dixit 09.11.2012 15:34: On Fri, Nov 9, 2012 at 10:28 AM, Michael J Gruber wrote: Hg seems to store just anything in the author field ("committer"). The v

Re: Help requested - trying to build a tool doing whole-tree commits

2012-11-10 Thread Felipe Contreras
On Fri, Nov 9, 2012 at 10:50 PM, Andreas Schwab wrote: > Unknown writes: Unknown Invalid? Please don't change the original email, makes it harder for other people to reply. >> I need a command or command sequence that will commit an entire file >> tree to a repository... >> >> (a) Allowing me t

Re: [PATCH v3 2/3] git-submodule foreach: export .gitmodules settings as variables

2012-11-10 Thread W. Trevor King
On Fri, Nov 09, 2012 at 05:45:22PM +0100, Heiko Voigt wrote: > > can now be reduced to > > > > git submodule foreach 'git checkout $submodule_branch && git pull' > > What other use cases are there? Would the need for this maybe go away > once you had floating submodules following branches? Non

Re: t5801-remote-helpers.sh fails

2012-11-10 Thread Torsten Bögershausen
On 11/10/2012 08:15 PM, Felipe Contreras wrote: Hi, On Sat, Nov 10, 2012 at 2:48 PM, Torsten Bögershausen wrote: on peff/pu t5801 fails, the error is in git-remote-testgit, please see below. That's on my Mac OS X box. I haven't digged further into the test case, but it looks as if "[-+]A m

Re: t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Felipe Contreras
On Sat, Nov 10, 2012 at 3:37 PM, Torsten Bögershausen wrote: > The short version: > echo -n doesn't seem to be portable. > The following works for me: Right, I was supposed to change that to: true > marks-cur && I don't think the code below works everywhere. > (And is this a typo: test_expec

Re: t5801-remote-helpers.sh fails

2012-11-10 Thread Felipe Contreras
Hi, On Sat, Nov 10, 2012 at 2:48 PM, Torsten Bögershausen wrote: > on peff/pu t5801 fails, the error is in git-remote-testgit, please see below. > > That's on my Mac OS X box. > > I haven't digged further into the test case, but it looks as if > "[-+]A make NAMEs associative arrays" > is not su

Re: [PATCH v3 1/3] git-submodule add: Add -r/--record option

2012-11-10 Thread W. Trevor King
On Fri, Nov 09, 2012 at 05:29:27PM +0100, Heiko Voigt wrote: > I think we should agree on a behavior for this option and implement it > the same time when add learns about it. When we were discussing floating > submodules as an important option for the gerrit people I already started > to implement

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Felipe Contreras
On Sat, Nov 10, 2012 at 1:32 PM, SZEDER Gábor wrote: > Hi, > > On Fri, Nov 09, 2012 at 07:33:31PM -0500, Jeff King wrote: >> On Sat, Nov 10, 2012 at 12:21:48AM +0100, Felipe Contreras wrote: >> > > * fc/completion-test-simplification (2012-10-29) 2 commits >> > > - completion: simplify __gitcomp

Re: [PATCH v3 1/3] git-submodule add: Add -r/--record option

2012-11-10 Thread W. Trevor King
On Fri, Nov 09, 2012 at 02:46:07AM -0800, Matt Kraai wrote: > On Thu, Nov 08, 2012 at 10:35:12PM -0500, W. Trevor King wrote: > > @@ -366,6 +379,10 @@ Use -f if you really want to add it." >&2 > > > > git config -f .gitmodules submodule."$sm_path".path "$sm_path" && > > git config -f .git

Re: [PATCH v3 1/3] git-submodule add: Add -r/--record option

2012-11-10 Thread W. Trevor King
On Thu, Nov 08, 2012 at 11:34:54PM -0800, Junio C Hamano wrote: > "W. Trevor King" writes: > > > By remaining agnostic on the variable usage, this patch makes > > submodule setup more convenient for all parties. > > I personally do not think "remaining agnostic on the usage" is a > good thing, a

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-10 Thread Felipe Contreras
On Sat, Nov 10, 2012 at 6:28 PM, Michael J Gruber wrote: > Felipe Contreras venit, vidit, dixit 09.11.2012 15:34: >> On Fri, Nov 9, 2012 at 10:28 AM, Michael J Gruber >> wrote: >> >>> Hg seems to store just anything in the author field ("committer"). The >>> various interfaces that are floating a

[PATCH] remote-curl.c: Fix a gcc warning

2012-11-10 Thread Ramsay Jones
In particular, gcc complains as follows: CC remote-curl.o remote-curl.c: In function `rpc_service': remote-curl.c:403: warning: 'gzip_size' might be used uninitialized \ in this function The 'gzip_size' variable would not, in fact, be used uninitialized. However, in order

Re: What's cooking in git.git (Oct 2012, #09; Mon, 29)

2012-11-10 Thread Ramsay Jones
Jeff King wrote: > On Fri, Nov 02, 2012 at 09:33:14PM +, Ramsay Jones wrote: > >> (Linux is my main platform, but I like to keep cygwin working because it has >> kept me sane on Windows ever since (about) 1995 ...) >> "Stranger in a strange land" ;-) > > I used a different trick around the sa

Re: old folders returning

2012-11-10 Thread Andy Hawkins
Hi, In article , David Coombes wrote: > The only suggestion I can think of is that the name wasn't cleared > after the "git add *" and then git went looking for an earlier copy. > But seems the issue is with the git client as well because of the > modified time. If it were pulled then t

old folders returning

2012-11-10 Thread David Coombes
Issue: I renamed a deprecated folder that i needed the code for, added ".old" to name. I then pushed to the repository and the original folder and the newly renamed are now in the repository and on my local branch. I renamed 'autoflow' to 'autoflow.old' and worked away ok. But after the p

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-10 Thread Michael J Gruber
Felipe Contreras venit, vidit, dixit 09.11.2012 15:34: > On Fri, Nov 9, 2012 at 10:28 AM, Michael J Gruber > wrote: > >> Hg seems to store just anything in the author field ("committer"). The >> various interfaces that are floating around do some behind-the-back >> conversion to git format. The m

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Junio C Hamano
Jeff King writes: > On Fri, Nov 09, 2012 at 12:27:35PM -0800, Junio C Hamano wrote: > >> What we should have arranged was to have https://github.com/git/git >> (which is not even owned by me, but I asked somebody at GitHub to >> assign me a write privilege) writable by the interim maintainer, so

Re: Help requested - trying to build a tool doing whole-tree commits

2012-11-10 Thread Junio C Hamano
Unknown writes: > (Apologies if this arrives twice. I'm on the road, with somewhat flaky email.) > > Because of my work on reposurgeon, I am sometimes asked to produce git > repositories for very old projects that not only are still using CVS > but have ancient releases not in the CVS repository,

Re: git-reset man page

2012-11-10 Thread Krzysztof Mazur
On Sat, Nov 10, 2012 at 10:55:13AM +0100, Angelo Borsotti wrote: > Hi > > the man page of git-reset, synopsys, does not allow for an > argumentless call, and the description does not tell either what is > the meaning of it. This issue was already reported by Bojan Petrović: http://thread.gmane.or

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread Paul Fox
kalle olavi niemitalo wrote: > Jeff King writes: > > > Comments welcome from people using unusual editors (e.g., a script that > > starts an editor in another window then blocks, waiting for the user to > > finish). > > I often run a shell in Emacs in X, then start git commit in that

http-backend GIT_COMMITTER_NAME & -EMAIL documentation bug

2012-11-10 Thread gima
Documentation says that envvars GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL formed from REMOTE_USER and REMOTE_ADDR, but doesn't mention that they are left alone if they have been set already. Referring to: https://github.com/git/git/blob/master/Documentation/git-http-backend.txt#L178 Source co

Re: Bizarre problem cloning repo from Codeplex

2012-11-10 Thread Andreas Schwab
Enrico Weigelt writes: > Their webserver seems to be configured quite restrictively > (eg. cannot access files like 'packed-refs'). Probably it just doesn't exist. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And n

overriding/removing inherited credential.helper

2012-11-10 Thread 乙酸鋰
In credential.c, line 67: if (!strcmp(key, "helper")) string_list_append(&c->helpers, value); In global config, I add one credential helper. But I do not want to use any credential helper in a specific repository. Currently there is no way in local config to override and remove inheri

Do not add an empty value from config credential.helper

2012-11-10 Thread 乙酸鋰
Below is current git message when a local config credential.helper has an empty value. Please skip an empty value. $ git push --force origin master git: 'credential-' is not a git command. See 'git --help'. Did you mean this? credential Total 0 (delta 0), reused 0 (delta 0) To https://u..

t9350-fast-export.sh broken on peff/pu under Mac OS X

2012-11-10 Thread Torsten Bögershausen
The short version: echo -n doesn't seem to be portable. The following works for me: (And is this a typo: test_expect_success 'test biridectionality' ') /Torsten diff ../../git.peff/t/t9350-fast-export.sh t9350-fast-export.sh 444,445c444,445 < echo -n > marks-cur && < echo -n > mar

t5801-remote-helpers.sh fails

2012-11-10 Thread Torsten Bögershausen
Hej, on peff/pu t5801 fails, the error is in git-remote-testgit, please see below. That's on my Mac OS X box. I haven't digged further into the test case, but it looks as if "[-+]A make NAMEs associative arrays" is not supported on this version of bash. /Torsten /Users/tb/projects/git/git.pef

Re: Workflow for templates?

2012-11-10 Thread Philip Oakley
From: "Enrico Weigelt" Sent: Saturday, November 10, 2012 10:29 AM This is often the key point that requires the 'new mindset'. Most folk use/used the directory heirarchy (subtle distinction with the .git 'repo' directory heirarchy to be noted) as a way of separating ownership between groups. The

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-10 Thread SZEDER Gábor
Hi, On Fri, Nov 09, 2012 at 07:33:31PM -0500, Jeff King wrote: > On Sat, Nov 10, 2012 at 12:21:48AM +0100, Felipe Contreras wrote: > > > * fc/completion-test-simplification (2012-10-29) 2 commits > > > - completion: simplify __gitcomp test helper > > > - completion: refactor __gitcomp related te

Re: Bizarre problem cloning repo from Codeplex

2012-11-10 Thread John Szakmeister
On Sat, Nov 10, 2012 at 2:49 AM, Enrico Weigelt wrote: [snip] > Their webserver seems to be configured quite restrictively > (eg. cannot access files like 'packed-refs'). > > Is there a way to trace the actual HTTP calls ? Try GIT_CURL_VERBOSE=1. GIT_TRACE_PACKET=1 can be helpful too. -John PS

git-status: Use "-sb" options by default?

2012-11-10 Thread Jason Timrod
Hi, I've been rooting around the "git-config" man page as well as the "git-status" man page, but couldn't find the following, which suggests it's not (yet) possible. I'm looking for a way to make the "-sb" options to git-status the default somehow.  That is, I would like the short form of git-

Re: [PATCH] cache-tree: invalidate i-t-a paths after writing trees

2012-11-10 Thread Nguyen Thai Ngoc Duy
On Fri, Nov 9, 2012 at 6:57 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> diff --git a/cache-tree.c b/cache-tree.c >> index 28ed657..30a8018 100644 >> --- a/cache-tree.c >> +++ b/cache-tree.c >> @@ -381,6 +381,9 @@ int cache_tree_update(struct cache_tree *it, >> i = update_

Re: bare vs non-bare <1.7 then >=1.7 ?

2012-11-10 Thread Philip Oakley
From: "Enrico Weigelt" Sent: Saturday, November 10, 2012 8:23 AM Wait, there *is* an usecase for such things, deploying trees (eg. webapps) some server: * application is developed in git * the final production-system tree is maintained in certian branch * a post-update hook acts on a specifi

Re: Workflow for templates?

2012-11-10 Thread Enrico Weigelt
> This is often the key point that requires the 'new mindset'. Most > folk > use/used the directory heirarchy (subtle distinction with the .git > 'repo' directory heirarchy to be noted) as a way of separating > ownership > between groups. They find it very hard to undo the old mindset and > use >

Re: Workflow for templates?

2012-11-10 Thread Philip Oakley
From: "Enrico Weigelt" Sent: Saturday, November 10, 2012 7:13 AM I've picked out Enrico's key points. Maybe I should try to explain the problem in terms of repository hierarchy. Let's assume, there is this hierarchy of repositories: Let's talk about branches instead - repos are just containe

Re: Support for a series of patches, i.e. patchset or changeset?

2012-11-10 Thread Eric Miao
Yeah, that's a very clean way I'd always want to follow, yet the kernel upstream isn't doing so. On Sat, Nov 10, 2012 at 4:52 PM, Enrico Weigelt wrote: > > > yet another idea: > > you coud always put your patchsets into separate branches, > rebase them ontop target branch before merging, and the

Re: Support for a series of patches, i.e. patchset or changeset?

2012-11-10 Thread Enrico Weigelt
yet another idea: you coud always put your patchsets into separate branches, rebase them ontop target branch before merging, and then do an non-ff-merge, which will make the history look like: * merged origin/feature_foo |\ | * first preparation fo feature foo | * part a | * part b |/ * merged

Re: bare vs non-bare <1.7 then >=1.7 ?

2012-11-10 Thread Enrico Weigelt
> When experimenting in order to train some colleagues, I saw that If I > clone a repository, I couldn't push to it because it was a non-bare > one. > Searchin for some explanations, I found this ressource: > http://www.bitflop.com/document/111 That's just a precaution (technically it's not neces

[PATCH] t9402: sed -i is not portable

2012-11-10 Thread Torsten Bögershausen
The command line sed -i -e "s/foo/bar/" filename works as expected under GNU/Linux: all "foo" are replaced by "bar" in the file "filename" sed on other systems like e.g. Mac OS X creates a backup file called filename-e, because the -i must be followed by a file name. As the -i is not in POSIX eith