Re: [PATCH v5 00/14] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 7:00 PM, Chris Webb wrote: > Felipe Contreras writes: > >> Yes, it seems this is an API issue; repo.branchtip doesn't exist in >> python 2.2. > > Hi. Presumably this is a problem with old mercurial not a problem with old > python as mentioned in the commit? Yeah, mercuria

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 8:47 PM, Felipe Contreras wrote: > On Wed, Oct 31, 2012 at 7:04 PM, Felipe Contreras > wrote: > >> How about performance? > >> 174.038642915 seconds time elapsed >> >> Compared to; > >> 340.976843750 seconds time elapsed >> >> Looks like there's something to impr

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 2:32 AM, Junio C Hamano wrote: > Johannes Schindelin wrote: > >>On Wed, 31 Oct 2012, Felipe Contreras wrote: >> >>> It doesn't get any more obvious than that. But to each his own. >> >>In my opinion, Jonathan does not deserve any of such condescending >>words. >>But maybe t

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 2:41 AM, Junio C Hamano wrote: > > > Johannes Schindelin wrote: > >>Junio wanted a more general solution, adding infrastructure to the >>rev-list engine that I did not need -- and did not see the need for, >>either -- and given the amount of time I had invested in a working

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 2:22 AM, Junio C Hamano wrote: > > > Felipe Contreras wrote: > >>And finally, what do more do you expect me to do? About the code, and >>only the code. > > The analysis that does in the log messages is an important part of "code" in > this project, so that may be a good pl

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Thu, Nov 1, 2012 at 12:14 AM, Daniel Barkalow wrote: > I think that may be true where you have "next" in both places, but I > think: > > $ git checkout -b new-branch master > $ git fast-export ^master new-branch > > ought to emit no "commit" lines, but needs to emit a "reset" line. After > all

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Junio C Hamano
Johannes Schindelin wrote: >Junio wanted a more general solution, adding infrastructure to the >rev-list engine that I did not need -- and did not see the need for, >either -- and given the amount of time I had invested in a working >remote-hg and given that I needed it desperately for my day-j

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Junio C Hamano
Johannes Schindelin wrote: >On Wed, 31 Oct 2012, Felipe Contreras wrote: > >> It doesn't get any more obvious than that. But to each his own. > >In my opinion, Jonathan does not deserve any of such condescending >words. >But maybe the Git maintainers are okay with such a tone on this list? Agr

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Junio C Hamano
Felipe Contreras wrote: >And finally, what do more do you expect me to do? About the code, and >only the code. The analysis that does in the log messages is an important part of "code" in this project, so that may be a good place to start. Both Jonathan and J6t asked specific updates to your

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Daniel Barkalow
On Wed, 31 Oct 2012, Felipe Contreras wrote: > Hi, > > On Wed, Oct 31, 2012 at 7:59 PM, Jonathan Nieder wrote: > > Felipe Contreras wrote: > >> On Wed, Oct 31, 2012 at 7:20 PM, Johannes Schindelin > >> wrote: > > > >>> I just tested this with junio/next and it seems this issue is still > >>> un

Git Gui not working on Mac book pro

2012-10-31 Thread Paul Grimes
Hello, Git-gui is not working on my Mac Book Pro. Here's relevant info. Any help getting this to work would be appriciated. $sw_vers -productVersion 10.7.5 $git --version git version 1.8.0 $git gui error: git-gui died of signal 11 $ This electronic mail message contains information that (

Re: Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 9:28 PM, Johannes Schindelin wrote: > Hi, > > On Wed, 31 Oct 2012, Felipe Contreras wrote: > >> It doesn't get any more obvious than that. But to each his own. > > In my opinion, Jonathan does not deserve any of such condescending words. > But maybe the Git maintainers are

Lack of netiquette, was Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Johannes Schindelin
Hi, On Wed, 31 Oct 2012, Felipe Contreras wrote: > It doesn't get any more obvious than that. But to each his own. In my opinion, Jonathan does not deserve any of such condescending words. But maybe the Git maintainers are okay with such a tone on this list? Hth, Johannes -- To unsubscribe from

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 7:04 PM, Felipe Contreras wrote: > How about performance? > 174.038642915 seconds time elapsed > > Compared to; > 340.976843750 seconds time elapsed > > Looks like there's something to improve in this area, but I wouldn't > be surprised if the reason for the be

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
Hi, On Wed, Oct 31, 2012 at 7:59 PM, Jonathan Nieder wrote: > Felipe Contreras wrote: >> On Wed, Oct 31, 2012 at 7:20 PM, Johannes Schindelin >> wrote: > >>> I just tested this with junio/next and it seems this issue is still >>> unfixed: instead of >>> >>> reset refs/heads/blub >>>

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Jonathan Nieder
Felipe Contreras wrote: > On Wed, Oct 31, 2012 at 7:20 PM, Johannes Schindelin > wrote: >> I just tested this with junio/next and it seems this issue is still >> unfixed: instead of >> >> reset refs/heads/blub >> from e7510461b7db54b181d07acced0ed3b1ada072c8 >> >> I get >> >>

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
Hi, On Wed, Oct 31, 2012 at 7:20 PM, Johannes Schindelin wrote: >> - What disadvantages? If this implementation goes into git.git, >> the msysgit one is likely to wane in popularity. What will we be >> losing by doing so? If the answer is not "nothing", how hard would >> it be to p

Re: [PATCH] test-lib: avoid full path to store test results

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 7:02 PM, Johannes Sixt wrote: > Am 31.10.2012 03:28, schrieb Felipe Contreras: >> Yeah, that would be nice. Too bad I don't have that information, and >> have _zero_ motivation to go and get it for you. > > Just to clarify: That information is not just for Jonathan, but fo

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Johannes Schindelin
Hi Peff, On Wed, 31 Oct 2012, Jeff King wrote: > I really like some of the directions the series is taking, and as the > maintainer, I'd like to pick it up. Code-wise, I agree. > But there is a big question mark for me still about how it relates to > the work in msysgit, especially: > > - Wh

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 4:55 PM, Michael J Gruber wrote: > Felipe Contreras venit, vidit, dixit 31.10.2012 16:39: >> Didn't think so. The truth of the matter is that it doesn't matter >> what I do code-wise. > > Just try, seriously. All right. First of all, I clone the repositories pointed out:

Re: [PATCH] test-lib: avoid full path to store test results

2012-10-31 Thread Johannes Sixt
Am 31.10.2012 03:28, schrieb Felipe Contreras: > On Wed, Oct 31, 2012 at 3:13 AM, Jonathan Nieder wrote: >> Felipe Contreras wrote: >> >>> It's all fun and games to write explanations for things, but it's not >>> that easy when you want those explanations to be actually true, and >>> corrent--you

Re: 'git describe' is very slow on development trees with lots of commits

2012-10-31 Thread Pavel Machek
Hi! > (Cc:-ed the Git development list.) > > * David Ahern wrote: > > > PERF-VERSION-GEN and specifically the git commands are the > > cause of more delay than the config checks, especially when > > doing the build in a VM with the kernel source on an NFS > > mount. > > Yes, I have noticed

Re: [PATCH] parse_dirstat_params(): use string_list to split comma-separated string

2012-10-31 Thread Matt Kraai
On Wed, Oct 31, 2012 at 10:06:36AM -0400, Jeff King wrote: > On Tue, Oct 30, 2012 at 06:43:51PM +, Matt Kraai wrote: > > > Michael Haggerty alum.mit.edu> writes: > > > + if (*params_copy) > > > > params_copy is set to the value returned by xstrdup, which cannot be NULL. > > This check can be

pre-receive hook output invalid characters

2012-10-31 Thread Erik Faye-Lund
Sorry for resending, but the previous version got dropped from the main git mailing list due to a HTML-subpart. Converted to plain-text. On Wed, Oct 31, 2012 at 4:45 PM, Erik Faye-Lund wrote: > > On Wed, Oct 31, 2012 at 4:24 PM, wrote: >> >> If you add pre-receive hook in your git repository wit

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 4:55 PM, Michael J Gruber wrote: > Felipe Contreras venit, vidit, dixit 31.10.2012 16:39: > >> This is precisely ad hominem; you are ignoring the code, not because >> of the code, because of the person. This is as ad hominem as it gets. > > I am not rejecting your code (I r

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
On Wed, Oct 31, 2012 at 11:27 AM, Jeff King wrote: > On Wed, Oct 31, 2012 at 10:30:50AM +0100, Michael J Gruber wrote: > >> For the record, Johannes is not the only one being kept from looking at >> this series (further) by the tone of this discussion. Per hominem >> attacks are neither profession

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Michael J Gruber
Felipe Contreras venit, vidit, dixit 31.10.2012 16:39: > This is precisely ad hominem; you are ignoring the code, not because > of the code, because of the person. This is as ad hominem as it gets. I am not rejecting your code (I reviewed an early series) but reject the communication style and ma

Re: Ŭŭ letter

2012-10-31 Thread Michael J Gruber
Usievaład Čorny venit, vidit, dixit 31.10.2012 16:27: > No, commit is the same as input. Only when I press key combination for > Ŭŭ (AltGr+Uu [like AltGr+Cc for Ćć, this works]) — simple Uu appears > in text form. Every other special letter (Šš, Čč, Žž, Śś, Łł, Źź, Ćć) > works. So it's really the

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Felipe Contreras
Hi, On Wed, Oct 31, 2012 at 10:30 AM, Michael J Gruber wrote: > [quotes heavily cut down by me] > Felipe Contreras venit, vidit, dixit 30.10.2012 21:15: >> On Tue, Oct 30, 2012 at 8:33 PM, Johannes Schindelin >> wrote: >>> On Tue, 30 Oct 2012, Felipe Contreras wrote: >>> But you mentioned

Re: Ŭŭ letter

2012-10-31 Thread Usievaład Čorny
No, commit is the same as input. Only when I press key combination for Ŭŭ (AltGr+Uu [like AltGr+Cc for Ćć, this works]) — simple Uu appears in text form. Every other special letter (Šš, Čč, Žž, Śś, Łł, Źź, Ćć) works. On Wed, Oct 31, 2012 at 6:15 PM, Michael J Gruber wrote: > Usievaład Čorny venit

Re: Ŭŭ letter

2012-10-31 Thread Michael J Gruber
Usievaład Čorny venit, vidit, dixit 31.10.2012 16:08: > Ok. I use Win7 sp1, syslang — be_BY, git version 1.8.0.msysgit.0 („git > version“ command). > Problem appears when I type this letter on keyboard; when I copy-paste > it everyrhing is ok. That is interesting. It means git-gui can make the com

Re: Ŭŭ letter

2012-10-31 Thread Usievaład Čorny
Ok. I use Win7 sp1, syslang — be_BY, git version 1.8.0.msysgit.0 („git version“ command). Problem appears when I type this letter on keyboard; when I copy-paste it everyrhing is ok. On Wed, Oct 31, 2012 at 5:57 PM, Michael J Gruber wrote: > Usievaład Čorny venit, vidit, dixit 31.10.2012 15:39: >>

Re: Ŭŭ letter

2012-10-31 Thread Michael J Gruber
Usievaład Čorny venit, vidit, dixit 31.10.2012 15:39: > Hello! > > When I type comment message in Git Gui (1.8.0 and previous), I can't > use Ŭŭ letter (U+016C, U+016D) — it just transforms into simple Uu. > Please fix it. Can you tell us more about your environment (LANG setting, OS)? I just mad

Re: [git-users] Git clone fails with "bad pack header", how to get remote log

2012-10-31 Thread kevin molcard
I forgot to mention that I am using scm manager: https://bitbucket.org/sdorra/scm-manager/wiki/Home So that maybe the " custom layer you are talking about. Kevin On 10/31/12 3:19 PM, Jeff King wrote: On Tue, Oct 30, 2012 at 03:57:36PM +0100, kevin molcard wrote: I tried to install git 1.8 on

Re: [git-users] Git clone fails with "bad pack header", how to get remote log

2012-10-31 Thread kevin molcard
Yes I can, can you tell me how I have to do that? thanks Kevin On 10/31/12 3:19 PM, Jeff King wrote: On Tue, Oct 30, 2012 at 03:57:36PM +0100, kevin molcard wrote: I tried to install git 1.8 on the remote server and get exactly the same problem :(. [...] Sometimes (very often when several git

Fwd: Re: [git-users] Git clone fails with "bad pack header", how to get remote log

2012-10-31 Thread kevin molcard
Hi all again, here is my second email :). It contains the git versions in my system. FYI, I updated git to 1.8.0 on my remote but still having the same issue. Another thing that might be interesting is that it seems to happen only when cloning from Windows build machine (i.e. I send 2 clone comma

Re: [git-users] Git clone fails with "bad pack header", how to get remote log

2012-10-31 Thread Jeff King
On Tue, Oct 30, 2012 at 03:57:36PM +0100, kevin molcard wrote: > I tried to install git 1.8 on the remote server and get exactly the > same problem :(. > [...] > >>Sometimes (very often when several git clone are sent at the same > >>time), I have the following error: > >> remote: internal ser

Fwd: Re: [git-users] Git clone fails with "bad pack header", how to get remote log

2012-10-31 Thread kevin molcard
Hi all, I am forwarding a reply I got from a message I sent to git user mailing list because of a "bad pack header error" (more information below). I will forward another email where I give all the git versions of my system. Any clue on this would be much appreciated. Thanks in advance Kevin

Re: [PATCH v6 2/3] completion: add new __gitcompadd helper

2012-10-31 Thread SZEDER Gábor
On Wed, Oct 31, 2012 at 12:05:34AM +0100, Felipe Contreras wrote: > On Tue, Oct 30, 2012 at 11:58 PM, SZEDER Gábor wrote: > > On Mon, Oct 22, 2012 at 03:45:41AM +0200, Felipe Contreras wrote: > >> The idea is to never touch the COMPREPLY variable directly. > >> > >> This allows other completion sy

Re: [OT] How to get the discussion details via notes

2012-10-31 Thread Jeff King
On Wed, Oct 31, 2012 at 10:53:27AM +0100, Peter Baumann wrote: > > covers the basics (current behavior and intent of the change) in its > > first two paragraphs and anyone wanting more detail can use > > > > GIT_NOTES_REF=refs/remotes/charon/notes/full \ > > git show --show-notes > > >

Re: [PATCH] parse_dirstat_params(): use string_list to split comma-separated string

2012-10-31 Thread Jeff King
On Tue, Oct 30, 2012 at 06:43:51PM +, Matt Kraai wrote: > Michael Haggerty alum.mit.edu> writes: > ... > > -static int parse_dirstat_params(struct diff_options *options, const char > > ... > > +static int parse_dirstat_params(struct diff_options *options, const char > > ... > >

Re: git-p4 clone @all error

2012-10-31 Thread Thomas Berg
Hi, Sorry, forgot to reply-to-all, here is my response again: On Tue, Oct 30, 2012 at 11:44 AM, Arthur wrote: > The problem : > > Importing revision 7727 (100%)Traceback (most recent call last): > File "/usr/bin/git-p4", line 3183, in > main() > File "/usr/bin/git-p4", line 3177, in mai

Re: change symlink

2012-10-31 Thread Jeff King
On Wed, Oct 31, 2012 at 08:30:57AM -0400, Jeff King wrote: > Something like this seems to fix it for me, but I am not sure if that > would affect other callers. > [...] > + return !is_dir || !S_ISGITLINK(istate->cache[pos]->ce_mode); That's completely wrong, of course. It should be:

Re: [PATCH] git-push: update remote tags only with force

2012-10-31 Thread Chris Rorvick
On Wed, Oct 31, 2012 at 7:26 AM, Drew Northup wrote: > On Wed, Oct 31, 2012 at 1:55 AM, Felipe Contreras > wrote: > >> but I wonder if it might be >> possible to split it to ease the review. > > Agreed. I'll look at splitting it up, probably not tonight though. :-) > Also, do please CC ALL int

Re: [PATCH] git-push: update remote tags only with force

2012-10-31 Thread Chris Rorvick
(oops, now my email was rejected) On Wed, Oct 31, 2012 at 12:55 AM, Felipe Contreras wrote: > Hi, > > (again because the mailing list rejected it) (Gmal switched interface > and HTML is the default) > > On Wed, Oct 31, 2012 at 6:37 AM, Chris Rorvick wrote: >> >> References are allowed to update

Re: change symlink

2012-10-31 Thread Jeff King
On Wed, Oct 31, 2012 at 08:05:05AM -0400, Jeff King wrote: > > however (what got me started wondering about this and a point i forgot > > about) - t2/one/test doesn't show up under 'untracked files' in in > > status that scenario. shouldn't it? > > Yes, I think that is a bug. > > My guess is tha

Re: [OT] How to get the discussion details via notes

2012-10-31 Thread Drew Northup
On Wed, Oct 31, 2012 at 5:53 AM, Peter Baumann wrote: > Dropping the Cc list, as this is off topic > > On Tue, Oct 30, 2012 at 11:05:29PM -0700, Jonathan Nieder wrote: >> Sverre Rabbelier wrote: >> >> > Thanks for the thorough explanation. Perhaps some of that could make >> > it's way into the com

Re: [PATCH] git-push: update remote tags only with force

2012-10-31 Thread Drew Northup
On Wed, Oct 31, 2012 at 1:55 AM, Felipe Contreras wrote: > but I wonder if it might be > possible to split it to ease the review. Agreed. Also, do please CC ALL interested parties from the pre-patch discussion thread as well as those who previously maintained that chunk of code. [Attempted to r

Re: change symlink

2012-10-31 Thread Jeff King
On Tue, Oct 30, 2012 at 10:22:04PM +, shawn wilson wrote: > On Tue, Oct 30, 2012 at 10:09 PM, Andreas Schwab > wrote: > > shawn wilson writes: > > > >> and once it's added, status says: > >> # renamed:t2 -> t2/one/test > >> > >> that's not exactly true, but... > > > > What's wrong

[PATCH 2/2] remote-curl: retry failed requests for auth even with gzip

2012-10-31 Thread Jeff King
Commit b81401c taught the post_rpc function to retry the http request after prompting for credentials. However, it did not handle two cases: 1. If we have a large request, we do not retry. That's OK, since we would have sent a probe (with retry) already. 2. If we are gzipping the request

[PATCH 1/2] remote-curl: hoist gzip buffer size to top of post_rpc

2012-10-31 Thread Jeff King
When we gzip the post data for a smart-http rpc request, we compute the gzip body and its size inside the "use_gzip" conditional. We keep track of the body after the conditional ends, but not the size. Let's remember both, which will enable us to retry failed gzip requests in a future patch. Signe

Re: git smart-http do not authent to allow git ls-remote to be called anonymously

2012-10-31 Thread Jeff King
[+cc git@vger; please keep discussion on the list] On Sun, Oct 28, 2012 at 01:26:51PM +0800, 乙酸鋰 wrote: > > POST /git/Cat1/SubCat1/xsp.git/git-upload-pack HTTP/1.1 > User-Agent: git/1.8.0 > Host: localhost > Accept-Encoding: gzip > Content-Type: application/x-git-upload-pack-request > Accept: app

Re: relative objects/info/alternates doesn't work on remote SMB repo

2012-10-31 Thread Nguyen Thai Ngoc Duy
On Tue, Oct 30, 2012 at 4:28 PM, Orgad Shaneh > Any news? This still doesn't work with 1.8.0. Nope, sorry. It's still in my todo list. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: Links broken in ref docs.

2012-10-31 Thread Kevin
Looks fixed here too On Wed, Oct 31, 2012 at 12:30 AM, Mike Norman wrote: > I just checked and the issue seems to be fixed! Clicked around on a > bunch of previously broken links and they work! > > On Tue, Oct 30, 2012 at 3:38 AM, Holger Hellmuth (IKS) > wrote: >> Am 30.10.2012 09:07, schrieb Mi

Re: Workflow for templates?

2012-10-31 Thread Josef Wolf
On Sat, Oct 27, 2012 at 08:45:45PM +0200, Enrico Weigelt wrote: > I'd suggest a 3 level branch hierachy (IOW: the lower level > is rebased ontop of the next higher level): > > * #0: upstream branch > * #1: generic local maintenance branch > * #2: per-instance cutomization branches > > Normal addi

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Jeff King
On Wed, Oct 31, 2012 at 10:30:50AM +0100, Michael J Gruber wrote: > For the record, Johannes is not the only one being kept from looking at > this series (further) by the tone of this discussion. Per hominem > attacks are neither professional nor helpful. We prefer to discuss code > here, just cod

[OT] How to get the discussion details via notes

2012-10-31 Thread Peter Baumann
Dropping the Cc list, as this is off topic On Tue, Oct 30, 2012 at 11:05:29PM -0700, Jonathan Nieder wrote: > Sverre Rabbelier wrote: > > > Thanks for the thorough explanation. Perhaps some of that could make > > it's way into the commit message? > > It's fine with me if it doesn't, since the or

Re: [PATCH v4 00/13] New remote-hg helper

2012-10-31 Thread Michael J Gruber
[quotes heavily cut down by me] Felipe Contreras venit, vidit, dixit 30.10.2012 21:15: > Hi, > > On Tue, Oct 30, 2012 at 8:33 PM, Johannes Schindelin > wrote: >> On Tue, 30 Oct 2012, Felipe Contreras wrote: >> >>> But you mentioned something about cooperation, and I've yet to see how >>> is it th

Re: [PATCH] test-lib: avoid full path to store test results

2012-10-31 Thread Stefano Lattarini
On 10/30/2012 11:17 PM, Elia Pinto wrote: > Thanks. I know that posix support these usages, but exists some > traditional shell that not support it. > True, but those shells are not POSIX shells -- the major example that comes to mind is the accursed Solaris /bin/sh. Since Git assumes a POSIX shel

Re: Can't understand the behaviour of git-diff --submodule

2012-10-31 Thread Francis Moreau
Hi, On Tue, Oct 30, 2012 at 10:17 PM, Jens Lehmann wrote: > Am 28.10.2012 01:02, schrieb Jens Lehmann: >> Am 26.10.2012 22:43, schrieb Francis Moreau: >>> On Fri, Oct 26, 2012 at 10:05 PM, Jens Lehmann wrote: >>> [...] That is weird, "git diff --submodule" should show that too. Is ther