Re: [PATCH 9/9] Add git-check-ignores

2012-09-02 Thread Nguyen Thai Ngoc Duy
On Sun, Sep 2, 2012 at 9:50 PM, Adam Spiers wrote: > I'm no expert on .gitattributes and check-attr, but AFAICS, all the > opportunities to share code in the plumbing and front-end seem to be > taken already, e.g. the directory traversal and path handling. The > CLI argument parsing is necessaril

Re: Test failures in t4034

2012-09-02 Thread Junio C Hamano
Ramsay Jones writes: > Yes, there was a net increase in the line count when I introduced > die(), but the main program flow was less cluttered by error handling. > The net result looked much better, so I thought it was worth it. > > What may not be too obvious, however, is that test-regex.c was w

Re: [PATCH 9/9] Add git-check-ignores

2012-09-02 Thread Junio C Hamano
Junio C Hamano writes: > Let's step back a bit and think what this command is about. What is > the reason why the user wants to run "check-ignore $path" in the > first place? I think there are two (or three, depending on how you > count). > > (1) You have one (or more) paths at hand. You want

Re: [RFC] i18n.pathencoding

2012-09-02 Thread Robin Rosenberg
Torsten Bögershausen skrev 2012-09-01 08.11:> Allow path names to be encoded in UTF-8 in the repository > and checkout out as e.g. ISO-8859-1 in the working tree. Ack for attempting this. Did it myself if 2007, but times weren't ripe then, I guess. > +i18n.pathEncoding:: > + This option is on

Re: [PATCH 6/9] For each exclude pattern, store information about where it came from

2012-09-02 Thread Philip Oakley
From: "Junio C Hamano" Sent: Sunday, September 02, 2012 8:02 PM "Philip Oakley" writes: Is there a way to identify the config core.excludesfile if present? i.e. that it is from that config variable, rather than directory traversal. If the code handles $GIT_DIR/info/exclude then that configu

Re: diff/merge tool that ignores whitespace changes

2012-09-02 Thread Enrico Weigelt
Hi, > Would that help ? > git help diff > [snip] > --ignore-space-at-eol >Ignore changes in whitespace at EOL. > >-b, --ignore-space-change >Ignore changes in amount of whitespace. This ignores >whitespace at >line end, and considers al

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-02 Thread Junio C Hamano
"Joachim Schmitz" writes: >> > > Should we leave tv_usec untouched then? That was we round up on >> > > the next (and subsequent?) round(s). Or just set to ENOTSUP in >> > > setitimer if ovalue is !NULL? >> > >> > I was alluding to the latter. >> >> OK, will do that then. Thanks. >> Unless I s

Re: [PATCH 9/9] Add git-check-ignores

2012-09-02 Thread Junio C Hamano
Adam Spiers writes: > +OPTIONS > +--- > +--stdin:: > + Read file names from stdin instead of from the command-line. > + > +-z:: > + Only meaningful with `--stdin`; paths are separated with a > + NUL character instead of a linefeed character. On input, or on output, or both? The

Re: [PATCH 9/9] Add git-check-ignores

2012-09-02 Thread Junio C Hamano
Adam Spiers writes: >>> +SYNOPSIS >>> + >>> +[verse] >>> +'git check-ignore' pathname... >>> +'git check-ignore' --stdin [-z] < >> >> Also --quiet option, where check-ignore returns 0 if the given path is >> ignored, 1 otherwise? I agree that multiple paths are problematic. We could er

Re: [PATCH 3/9] Rename cryptic 'which' variable to more consistent name

2012-09-02 Thread Junio C Hamano
Adam Spiers writes: > 'el' is only *slightly* less cryptic, but is already used as the > variable name for a struct exclude_list pointer in numerous other > places, so this reduces the number of cryptic variable names in use by > one :-) The name originally meant to mean "to which element of the

Re: [PATCH 0/9] new git check-ignore sub-command

2012-09-02 Thread Junio C Hamano
Adam Spiers writes: > I was browsing stackoverflow the other day and came across this question: > > > http://stackoverflow.com/questions/12144633/which-gitignore-rule-is-ignoring-my-file/ > > A quick google revealed this thread from 2009: > > http://thread.gmane.org/gmane.comp.version-co

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-02 Thread Junio C Hamano
Marco Stornelli writes: > Il 01/09/2012 15:59, Johannes Sixt ha scritto: > >> Look how you write: >> >>perl -e '... $ENV{'PATCHTMP'} ...' >> >> That is, perl actually sees this script: >> >>... $ENV{PATCHTMP} ... >> >> (no quotes around PATCHTMP). That my be perfectly valid perl, but is n

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-02 Thread Junio C Hamano
Marco Stornelli writes: >> I also wonder what would happen if To: and Cc: in the input were >> split into continuation lines, but that was already present in the > > Do you mean To: ,.\nCc: ,.? No, I meant "To: ,...\n \n". But see my response to J6t's message. -- To unsubscribe from thi

Re: [PATCH 6/9] For each exclude pattern, store information about where it came from

2012-09-02 Thread Junio C Hamano
"Philip Oakley" writes: > Is there a way to identify the config core.excludesfile if present? > i.e. that it is from that config variable, rather than directory > traversal. If the code handles $GIT_DIR/info/exclude then that configuration would also be handled the same way, no? -- To unsubscrib

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-02 Thread Junio C Hamano
Johannes Sixt writes: > Am 31.08.2012 16:09, schrieb Marco Stornelli: >> +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=; >> +close FILE; $addr = $1 if $text =~ /Cc: (.*?(,\n .*?)*)\n/s; $addr =~ >> s/\n//g; >> +print $addr;'` > > The quoting is broken in this line (sq within

Re: [PATCH 6/9] For each exclude pattern, store information about where it came from

2012-09-02 Thread Philip Oakley
From: "Adam Spiers" Sent: Sunday, September 02, 2012 1:12 AM Subject: [PATCH 6/9] For each exclude pattern, store information about where it came from For exclude patterns read in from files, the filename is stored together with the corresponding line number (counting starting at 1). Is t

Re: [PATCH 9/9] Add git-check-ignores

2012-09-02 Thread Adam Spiers
Hi there, Firstly, thanks for the quick feedback! On Sun, Sep 2, 2012 at 11:41 AM, Nguyen Thai Ngoc Duy wrote: > On Sun, Sep 2, 2012 at 7:12 AM, Adam Spiers wrote: >> This works in a similar manner to git-check-attr. Some code >> was reused from add.c by refactoring out into pathspec.c. > > Th

Re: [PATCH 9/9] Add git-check-ignores

2012-09-02 Thread Nguyen Thai Ngoc Duy
On Sun, Sep 2, 2012 at 7:12 AM, Adam Spiers wrote: > This works in a similar manner to git-check-attr. Some code > was reused from add.c by refactoring out into pathspec.c. Thanks, comments from a quick glance. First of all, can we make it work (or share code) with .gitattributes? We may need to

Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list

2012-09-02 Thread Michael Haggerty
On 08/23/2012 10:31 PM, Jeff King wrote: > On Thu, Aug 23, 2012 at 03:56:48PM -0400, Jeff King wrote: > >> This code blames back to: >> >> commit 4bcb310c2539b66d535e87508d1b7a90fe29c083 >> Author: Alexandre Julliard >> Date: Fri Nov 24 16:00:13 2006 +0100 >> >> fetch-pack: Do not fetch