Re: gitweb - feature request

2005-08-09 Thread Ian Campbell
On Tue, 2005-08-09 at 21:58 +0200, Kay Sievers wrote: > I was hoping people that want stuff like this would use a RSS reader. :) I used to subscribe to the kernel RSS feed (using blam) but I found I was only getting the most recent 20 commits, which wasn't much good when a big batch went in becau

Re: Sanity check of git-commit patch, was Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards

2005-08-09 Thread Junio C Hamano
Junio C Hamano <[EMAIL PROTECTED]> writes: >> - Multiple -m options was actually a feature of my version of the patch. > > Ah, OK. I said "OK" and thought about it again. While thinking about what is the right inter-message-piece separator for multiple -m parameters (you use "\n"), I got a heada

Re: gitweb - feature request

2005-08-09 Thread Sam Ravnborg
> Sam, > try it! :) Works excellent - and less than 12 hours after I posted my feautre reqest. That was quick! Thanks, Sam - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordom

[PATCH] Fix git-rev-parse's parent handling

2005-08-09 Thread Johannes Schindelin
git-rev-parse HEAD^1 would fail, because of an off-by-one bug (but HEAD^ would yield the expected result). Also, when the parent does not exist, do not silently return an incorrect SHA1. Of course, this no longer applies to git-rev-parse alone, but every user of get_sha1(). While at it, add a t

Re: gitweb - feature request

2005-08-09 Thread Kay Sievers
On Tue, Aug 09, 2005 at 11:14:02PM +0200, Kay Sievers wrote: > On Tue, Aug 09, 2005 at 10:18:36PM +0200, Sam Ravnborg wrote: > > On Tue, Aug 09, 2005 at 09:58:18PM +0200, Kay Sievers wrote: > > > On Tue, Aug 09, 2005 at 09:31:04PM +0200, Sam Ravnborg wrote: > > > > Hi Kay. > > > > > > > > When bro

Re: Newbie question: equiv of: cvs co -p ?

2005-08-09 Thread Linus Torvalds
On Tue, 9 Aug 2005, John Ellson wrote: > > I hacked this: > > #!/bin/bash > ID=`git-ls-files -s | grep $1 | cut -d ' ' -f 2` No. "git-ls-files" shows the latest _index_ state, not the latest committed state. Use "git-ls-tree HEAD pathname" to get the latest committed state for th

Re: Cannot install git RPM

2005-08-09 Thread Ryan Anderson
On Tue, Aug 09, 2005 at 10:13:32AM -0700, Junio C Hamano wrote: > Junio C Hamano <[EMAIL PROTECTED]> writes: > > >> But the resulting RPM cannot be installed either, at least not in > >> standard Fedora Core 2/3/4 installations: > >> ... > >> Is there at least some documentation which exter

Re: gitweb - feature request

2005-08-09 Thread Linus Torvalds
On Wed, 10 Aug 2005, Kay Sievers wrote: > > Firefox may need a plugin to be able to read it, I don't really know... Firefox definitely needs a separate plugin, at least for me. Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [EM

Re: gitweb - feature request

2005-08-09 Thread Kay Sievers
On Tue, Aug 09, 2005 at 02:53:58PM -0700, Linus Torvalds wrote: > > > On Tue, 9 Aug 2005, Johannes Schindelin wrote: > > > > You have Firefox, don't you? Next time you surf to gitweb, right click on > > the funny yellow symbol in the lower right corner of your Firefox. It > > should say someth

Re: Newbie question: equiv of: cvs co -p ?

2005-08-09 Thread Rene Scharfe
Johannes Schindelin wrote: > On Tue, 9 Aug 2005, John Ellson wrote: >>How can we cat the latest committed state of a file to stdout? >> >>I hacked this: >> >> #!/bin/bash >> ID=`git-ls-files -s | grep $1 | cut -d ' ' -f 2` > > > and now: > > git-cat-file blob $ID Still not prett

Re: Newbie question: equiv of: cvs co -p ?

2005-08-09 Thread Johannes Schindelin
Hi, On Tue, 9 Aug 2005, John Ellson wrote: > How can we cat the latest committed state of a file to stdout? > > I hacked this: > > #!/bin/bash > ID=`git-ls-files -s | grep $1 | cut -d ' ' -f 2` and now: git-cat-file blob $ID Voila, Dscho - To unsubscribe from this list: s

Re: gitweb - feature request

2005-08-09 Thread Linus Torvalds
On Tue, 9 Aug 2005, Johannes Schindelin wrote: > > You have Firefox, don't you? Next time you surf to gitweb, right click on > the funny yellow symbol in the lower right corner of your Firefox. It > should say something like "Subscribe to...". Do it. Left-click. And you need to be inside the

Re: gitweb - feature request

2005-08-09 Thread Kay Sievers
On Tue, Aug 09, 2005 at 10:18:36PM +0200, Sam Ravnborg wrote: > On Tue, Aug 09, 2005 at 09:58:18PM +0200, Kay Sievers wrote: > > On Tue, Aug 09, 2005 at 09:31:04PM +0200, Sam Ravnborg wrote: > > > Hi Kay. > > > > > > When browsing http://www.kernel.org/git I often find myself looking for > > > the

Re: gitweb - feature request

2005-08-09 Thread Kay Sievers
On Tue, Aug 09, 2005 at 03:51:37PM -0500, John Benes wrote: > Sam Ravnborg wrote: > >> You have Firefox, don't you? Next time you surf to gitweb, right click on > >> the funny yellow symbol in the lower right corner of your Firefox. It > >> should say something like "Subscribe to...". Do it. > >

Re: [PATCH] Use $DESTDIR instead of $dest

2005-08-09 Thread Petr Baudis
Dear diary, on Sat, Aug 06, 2005 at 01:17:17AM CEST, I got a letter where Junio C Hamano <[EMAIL PROTECTED]> told me that... > Petr Baudis <[EMAIL PROTECTED]> writes: > > > $DESTDIR is more usual during the build than $dest and is what is usually > > used in the makefiles, so let's use it too. >

[PATCH] Warning fix for gcc 4

2005-08-09 Thread Pavel Roskin
Hello! This patch fixes the only warning reported by gcc 4.0.1 on Fedora Core 4 for x86_64: sha1_file.c:1391: warning: pointer targets in assignment differ in signedness Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> diff --git a/sha1_file.c b/sha1_file.c --- a/sha1_file.c +++ b/sha1_file.c @@

Re: gitweb - feature request

2005-08-09 Thread John Benes
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sam Ravnborg wrote: >> You have Firefox, don't you? Next time you surf to gitweb, right click on >> the funny yellow symbol in the lower right corner of your Firefox. It >> should say something like "Subscribe to...". Do it. > > Unfortunately not on

Re: Template files location

2005-08-09 Thread Petr Baudis
Dear diary, on Fri, Aug 05, 2005 at 07:33:02PM CEST, I got a letter where Junio C Hamano <[EMAIL PROTECTED]> told me that... > *2* And I am sure many others shared the same objection but did > not even bother to say anything because what Johannes said made > a lot of sense and what the patch did wa

Re: gitweb - feature request

2005-08-09 Thread Sam Ravnborg
> You have Firefox, don't you? Next time you surf to gitweb, right click on > the funny yellow symbol in the lower right corner of your Firefox. It > should say something like "Subscribe to...". Do it. Unfortunately not on my firefox. 1.0.6 on gentoo. Puzzled... Sam - To unsubscribe fro

Re: gitweb - feature request

2005-08-09 Thread Johannes Schindelin
Hi, On Tue, 9 Aug 2005, Sam Ravnborg wrote: > On Tue, Aug 09, 2005 at 09:58:18PM +0200, Kay Sievers wrote: > > > > I was hoping people that want stuff like this would use a RSS reader. :) > Some day I will try to use such a beast... You have Firefox, don't you? Next time you surf to gitweb, rig

Re: gitweb - feature request

2005-08-09 Thread Sam Ravnborg
On Tue, Aug 09, 2005 at 09:58:18PM +0200, Kay Sievers wrote: > On Tue, Aug 09, 2005 at 09:31:04PM +0200, Sam Ravnborg wrote: > > Hi Kay. > > > > When browsing http://www.kernel.org/git I often find myself looking for > > the most recently changed tree. > > For this it is very good that you have th

Re: gitweb - feature request

2005-08-09 Thread Kay Sievers
On Tue, Aug 09, 2005 at 09:31:04PM +0200, Sam Ravnborg wrote: > Hi Kay. > > When browsing http://www.kernel.org/git I often find myself looking for > the most recently changed tree. > For this it is very good that you have the "last change" in italic and > bolded if newer than a few hours (I think

gitweb - feature request

2005-08-09 Thread Sam Ravnborg
Hi Kay. When browsing http://www.kernel.org/git I often find myself looking for the most recently changed tree. For this it is very good that you have the "last change" in italic and bolded if newer than a few hours (I think). A nice additional feature would be the possibility to sort the output

Re: [PATCH] -Werror fixes

2005-08-09 Thread Timo Sirainen
On Tue, 2005-08-09 at 18:30 +0300, Timo Sirainen wrote: > GCC's format __attribute__ is good for checking errors, especially with > -Werror=2 parameter. Patch below fixes most of the reported problems > against 2005-08-09 snapshot. Eh. -Wformat=2 of course. What was I thinking.. signature.asc D

Re: Cannot install git RPM

2005-08-09 Thread Junio C Hamano
Junio C Hamano <[EMAIL PROTECTED]> writes: >> But the resulting RPM cannot be installed either, at least not in >> standard Fedora Core 2/3/4 installations: >> ... >> Is there at least some documentation which external packages are >> needed, and where to find these? The problematic one

Re: Sanity check of git-commit patch, was Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards

2005-08-09 Thread Junio C Hamano
Johannes Schindelin <[EMAIL PROTECTED]> writes: >> True. My bad old habit. > > An elegant method to do that: > > case --some-long-option in "$1"*) ..; esac You are almost correct, but you need to realize that I generate that long "case -s|--s|--so|--som|..." chain using a script that takes all p

cg-clone http://www.kernel.org/pub/scm/git/git.git fails

2005-08-09 Thread Dirk Behme
Hello, with cogito-0.13.tar.bz2 git-2005-08-09.tar.gz clone of cogito over http > cg-clone http://www.kernel.org/pub/scm/cogito/cogito.git works fine. But clone of git itself fails: cg-clone http://www.kernel.org/pub/scm/git/git.git defaulting to local storage area warning: templates not f

Re: Cannot install git RPM

2005-08-09 Thread Clemens Koller
Hi, Linus! Linus Torvalds wrote: On Tue, 9 Aug 2005, Clemens Koller wrote: Over here - using a non-standard ELDK/LFS mixture, git depends at least on: ... diffstat (ftp://invisible-island.net/diffstat/diffstat-1.39.tgz) Hmm.. This should not be true. Any "diffstat"s should be converted to

[PATCH] -Werror fixes

2005-08-09 Thread Timo Sirainen
GCC's format __attribute__ is good for checking errors, especially with -Werror=2 parameter. Patch below fixes most of the reported problems against 2005-08-09 snapshot. Also how about trying to implement some kind of generically usable string object? Now the code uses sprintf/snprintf/etc. in var

Re: Cannot install git RPM

2005-08-09 Thread Linus Torvalds
On Tue, 9 Aug 2005, Clemens Koller wrote: > > Over here - using a non-standard ELDK/LFS mixture, git depends at least on: >... > diffstat (ftp://invisible-island.net/diffstat/diffstat-1.39.tgz) Hmm.. This should not be true. Any "diffstat"s should be converted to use "git-apply --stat" instead.

Re: Sanity check of git-commit patch, was Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards

2005-08-09 Thread Johannes Schindelin
Hi, On Tue, 9 Aug 2005, Junio C Hamano wrote: > Johannes Schindelin <[EMAIL PROTECTED]> writes: > > > - I don't like the GNU way to abbreviate long options too much... > > True. My bad old habit. An elegant method to do that: case --some-long-option in "$1"*) ..; esac Ciao, Dscho - To unsu

Re: Cannot install git RPM

2005-08-09 Thread Clemens Koller
Hello, Wolfgang! But the resulting RPM cannot be installed either, at least not in standard Fedora Core 2/3/4 installations: error: Failed dependencies: perl(Email::Valid) is needed by git-core-0.99.3-1 perl(Mail::Sendmail) is needed by git-core-0.99.3-1 Seems git is depen

Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards

2005-08-09 Thread Junio C Hamano
Ryan Anderson <[EMAIL PROTECTED]> writes: > I haven't really given a lot of thought to this yet, but I was thinking > of something along these lines: > > Rename tools/ to mail-tools/, push git-send-email-script into that. > Create a "porcelain" directory for things like git-bisect-script > Create

Re: Sanity check of git-commit patch, was Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards

2005-08-09 Thread Junio C Hamano
Johannes Schindelin <[EMAIL PROTECTED]> writes: > I just checked. Three nitpicks: > > - I don't like the GNU way to abbreviate long options too much... True. My bad old habit. > - Multiple -m options was actually a feature of my version of the patch. Ah, OK. > - The "case .. in x) .. ;; esac;

Re: use of temporary refs in resolve

2005-08-09 Thread Junio C Hamano
Catalin Marinas <[EMAIL PROTECTED]> writes: > If you plan to implement multiple values in FETCH_HEAD, StGIT won't be > able to use this since it doesn't do any merging for the base of the > stack. As I said above, this is not a problem and I was probably wrong > when decided to use git-fetch-scrip

Re: Cannot install git RPM

2005-08-09 Thread Junio C Hamano
Wolfgang Denk <[EMAIL PROTECTED]> writes: > A simple fix is of course: > > -> diff -u git-core.spec.in.ORIG git-core.spec.in > --- git-core.spec.in.ORIG 2005-08-09 10:26:50.845877000 +0200 > +++ git-core.spec.in2005-08-09 12:42:06.872310918 +0200 > @@ -40,6 +40,7 @@ > %{!?_without_docs:

Re: Cannot install git RPM

2005-08-09 Thread Wolfgang Denk
I wrote: > it is not possible to build RPMs from the current git code: > > RPM build errors: > Installed (but unpackaged) file(s) found: >/usr/share/git-core/templates/description >/usr/share/git-core/templates/hooks/post-update >/usr/share/git-core/templates/hooks/update >/us

Cannot build git RPM

2005-08-09 Thread Wolfgang Denk
Hello, it is not possible to build RPMs from the current git code: RPM build errors: Installed (but unpackaged) file(s) found: /usr/share/git-core/templates/description /usr/share/git-core/templates/hooks/post-update /usr/share/git-core/templates/hooks/update /usr/share/git-core/t

Re: Make git-rev-tree obsolete

2005-08-09 Thread Johannes Schindelin
Hi, On Mon, 8 Aug 2005, Junio C Hamano wrote: > Johannes Schindelin <[EMAIL PROTECTED]> writes: > > > Junio remarked that Jeff's git-changes-script still uses git-rev-tree, and > > therefore it should not be removed. This patch changes git-changes-script > > over to git-rev-list: > > Just to

Sanity check of git-commit patch, was Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards

2005-08-09 Thread Johannes Schindelin
Hi, On Mon, 8 Aug 2005, Junio C Hamano wrote: > Johannes, could you sanity check the commit change I have in the > proposed updates branch when things percolate through kernel.org > mirror network? I ended up pushing it out before I found you > already did a patch. I just checked. Three nitpick

Re: use of temporary refs in resolve

2005-08-09 Thread Catalin Marinas
Junio C Hamano <[EMAIL PROTECTED]> wrote: > If you are happy then I should not complain ;-), and I am > certainly not complaining, but I still have this feeling that I > do not get what you are getting at. You can change it to > directly use pull without intermediate fetch, in order to cope > with