[gentoo-dev] [PATCHES] multilib-build.eclass: getting 'long' ABI value & deprecating multilib_for_best_abi()

2014-05-05 Thread Michał Górny
Hi, Three quick patches for review: 1. adds multilib_get_enabled_abi_pairs() as a replacement for multilib_get_enabled_abis(). The latter returned just the value of ${ABI}, the new function returns ${use_flag}:${ABI} pairs. e.g.: multilib_get_enabled_abis: x86 amd64 multilib_get_enabled_abi

[gentoo-dev] [PATCH 1/3] Introduce multilib_get_enabled_abi_pairs().

2014-05-05 Thread Michał Górny
The multilib_get_enabled_abis() returns ${ABI} values only, losing the information about USE flags. Reverse mapping of those values may be unclear (two architectures may use the same ABI name), and therefore the function would to do that would be unnecessarily complex. Instead, introduce a new fun

[gentoo-dev] [PATCH 3/3] Deprecate multilib_for_best_abi().

2014-05-05 Thread Michał Górny
This was planned for a while. The concept of 'best' and 'native' that are not always the same ABI is confusing and mostly unnecessary. Additionally, we prefer people using multilib-minimal phases rather than multilib_for* functions. --- eclass/multilib-build.eclass | 3 +++ 1 file changed, 3 inser

[gentoo-dev] [PATCH 2/3] Export MULTILIB_ABI to obtain the USE flag for ABI.

2014-05-05 Thread Michał Górny
The main goal for this extra variable is to be able to uniquely identify an arch+ABI pair, with equality to USE flags being an extra benefit. Fixes: https://bugs.gentoo.org/show_bug.cgi?id=509478 --- eclass/multilib-build.eclass | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-)

Re: [gentoo-dev] [PATCHES] multilib-build.eclass: getting 'long' ABI value & deprecating multilib_for_best_abi()

2014-05-05 Thread Ulrich Mueller
> On Mon, 5 May 2014, Michał Górny wrote: > Three quick patches for review: > 1. adds multilib_get_enabled_abi_pairs() as a replacement for > multilib_get_enabled_abis(). The latter returned just the value > of ${ABI}, the new function returns ${use_flag}:${ABI} pairs. > e.g.: > multilib_

Re: [gentoo-dev] [PATCHES] multilib-build.eclass: getting 'long' ABI value & deprecating multilib_for_best_abi()

2014-05-05 Thread Ian Stakenvicius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 05/05/14 04:29 AM, Michał Górny wrote: > 3. deprecates multilib_for_best_abi() since having two separate > concepts of 'best ABI' and 'default ABI' is confusing, and mostly > doesn't serve any real purpose. > > For improved consistency, we wou

Re: [gentoo-dev] [PATCH 3/3] Deprecate multilib_for_best_abi().

2014-05-05 Thread hasufell
Michał Górny: > This was planned for a while. The concept of 'best' and 'native' that > are not always the same ABI is confusing and mostly unnecessary. > Additionally, we prefer people using multilib-minimal phases rather than > multilib_for* functions. > --- > eclass/multilib-build.eclass | 3 ++

Re: [gentoo-dev] [PATCHES] multilib-build.eclass: getting 'long' ABI value & deprecating multilib_for_best_abi()

2014-05-05 Thread Michał Górny
Dnia 2014-05-05, o godz. 11:02:33 Ulrich Mueller napisał(a): > > On Mon, 5 May 2014, Michał Górny wrote: > > > Three quick patches for review: > > > 1. adds multilib_get_enabled_abi_pairs() as a replacement for > > multilib_get_enabled_abis(). The latter returned just the value > > of ${ABI

Re: [gentoo-dev] [PATCHES] multilib-build.eclass: getting 'long' ABI value & deprecating multilib_for_best_abi()

2014-05-05 Thread Michał Górny
Dnia 2014-05-05, o godz. 09:23:56 Ian Stakenvicius napisał(a): > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 05/05/14 04:29 AM, Michał Górny wrote: > > > 3. deprecates multilib_for_best_abi() since having two separate > > concepts of 'best ABI' and 'default ABI' is confusing, and

Re: [gentoo-dev] [PATCH 3/3] Deprecate multilib_for_best_abi().

2014-05-05 Thread Michał Górny
Dnia 2014-05-05, o godz. 17:26:14 hasufell napisał(a): > Michał Górny: > > This was planned for a while. The concept of 'best' and 'native' that > > are not always the same ABI is confusing and mostly unnecessary. > > Additionally, we prefer people using multilib-minimal phases rather than > > mu

Re: [gentoo-dev] [PATCHES] multilib-build.eclass: getting 'long' ABI value & deprecating multilib_for_best_abi()

2014-05-05 Thread Ian Stakenvicius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 05/05/14 01:42 PM, Michał Górny wrote: > Dnia 2014-05-05, o godz. 09:23:56 Ian Stakenvicius > napisał(a): > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> On 05/05/14 04:29 AM, Michał Górny wrote: >> >>> 3. deprecates multilib_for_be