Re: [gentoo-dev] [RFC] office-ext.eclass

2011-08-30 Thread Ulrich Mueller
> On Tue, 30 Aug 2011, Tomáš Chvátal wrote: > See the attachment for the latest version :) > # @FUNCTION: office-ext_get_implementation > [...] > for i in "${implementations[$@]}"; do I think this should read "${implementations[@]}" instead, if the intention is to loop over all array e

[gentoo-dev] [RFC] check-reqs.eclass.patch

2011-08-30 Thread Tomáš Chvátal
Hi, I got enough annoyed by check-reqs.eclass using epause and other nasty things so I updated it to do this things: * eclassdoc * use pkg_pretend and pkg_setup phases to run the checks * warn if ebuild use deprecated calls and keep backompat * remove duplicated/unused code * support for metric

Re: [gentoo-dev] [RFC] office-ext.eclass

2011-08-30 Thread Tomáš Chvátal
Dne 30.8.2011 09:02, Ulrich Mueller napsal(a): On Tue, 30 Aug 2011, Tomáš Chvátal wrote: See the attachment for the latest version :) # @FUNCTION: office-ext_get_implementation [...] for i in "${implementations[$@]}"; do I think this should read "${implementations[@]}" instead, if

Re: [gentoo-dev] [RFC] check-reqs.eclass.patch

2011-08-30 Thread Michał Górny
On Tue, 30 Aug 2011 09:11:40 +0200 Tomáš Chvátal wrote: > @@ -66,80 +52,234 @@ > > # @ECLASS-VARIABLE: CHECKREQS_MEMORY > # @DESCRIPTION: > -# How much RAM is needed in MB? > +# @DEAULT_UNSET > +# How much RAM is needed? Typo. Also, shouldn't defaults go before @DESCRIPTION: ? > # @ECLASS-

Re: [gentoo-dev] [RFC] office-ext.eclass

2011-08-30 Thread Michał Górny
On Tue, 30 Aug 2011 09:26:16 +0200 Tomáš Chvátal wrote: > >> # @FUNCTION: office-ext_remove_extension > >> [...] > >>${UNOPKG_BINARY} remove --shared "${ext}" \ > > > > Not sure what unopkg accepts, but I guess you want to pass several > > arguments here. So ${ext} shouldn't be quoted. > > >

Re: [gentoo-dev] [RFC] check-reqs.eclass.patch

2011-08-30 Thread Tomáš Chvátal
Dne 30.8.2011 09:35, Michał Górny napsal(a): On Tue, 30 Aug 2011 09:11:40 +0200 Tomáš Chvátal wrote: @@ -66,80 +52,234 @@ # @ECLASS-VARIABLE: CHECKREQS_MEMORY # @DESCRIPTION: -# How much RAM is needed in MB? +# @DEAULT_UNSET +# How much RAM is needed? Typo. Also, shouldn't defaults go b

Re: [gentoo-dev] [RFC] office-ext.eclass

2011-08-30 Thread Tomáš Chvátal
Dne 30.8.2011 09:49, Michał Górny napsal(a): On Tue, 30 Aug 2011 09:26:16 +0200 Tomáš Chvátal wrote: # @FUNCTION: office-ext_remove_extension [...] ${UNOPKG_BINARY} remove --shared "${ext}" \ Not sure what unopkg accepts, but I guess you want to pass several arguments here. So ${ext}

Re: [gentoo-dev] [RFC] check-reqs.eclass.patch

2011-08-30 Thread Ulrich Mueller
> On Tue, 30 Aug 2011, Tomáš Chvátal wrote: > CHECKREQS_EXPORTED_FUNCTIONS="pkg_setup" > case "${EAPI:-0}" in > 0|1|2|3) ;; > 4) CHECKREQS_EXPORTED_FUNCTIONS="${CHECKREQS_EXPORTED_FUNCTIONS} > pkg_pretend" ;; > *) die "EAPI=${EAPI} is not supported" ;; > esac > EXPORT_FUNCT

Re: [gentoo-dev] [RFC] check-reqs.eclass.patch

2011-08-30 Thread Michał Górny
On Tue, 30 Aug 2011 10:04:50 +0200 Tomáš Chvátal wrote: > >> + [[ -n ${CHECKREQS_DISK_BUILD} ]]&& \ > >> + check-reqs_disk \ > >> + "${T}" \ > >> + "${CHECKREQS_DISK_BUILD}" > > > > Why not WORKDIR? > I thought workdir is present later than $T plus it

[gentoo-dev] Re: [RFC] office-ext.eclass

2011-08-30 Thread Jonathan Callen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Tomáš Chvátal wrote: > die "Unable not determine libreoffice/openoffice implementation!" "Unable to determine ..." - -- Jonathan Callen -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAEBCgAGBQJOXW2uAAoJELHSF2kinlg4Wgk