On Friday, February 03, 2012 10:14:42 PM Nirbheek Chauhan wrote:
> >> if [[ ${x} = en ]] || [[ ${x} = en-US ]]; then
> >
> > should be == imo
>
> Fixed
I prefer == for [[ too, but no difference. = is required for [ by POSIX but
Bash allows either (bad though). The real issue is ex
On Sat, Feb 4, 2012 at 12:57 AM, Mike Frysinger wrote:
> On Friday 03 February 2012 11:44:42 Nirbheek Chauhan wrote:
> > On Fri, Feb 3, 2012 at 3:26 PM, Mike Frysinger
> wrote:
> > >> mozlinguas() {
> > >
> > > missing eclass documentation
> >
> > Is it really needed for private functions? Nothi
On Friday 03 February 2012 11:44:42 Nirbheek Chauhan wrote:
> On Fri, Feb 3, 2012 at 3:26 PM, Mike Frysinger wrote:
> >> mozlinguas() {
> >
> > missing eclass documentation
>
> Is it really needed for private functions? Nothing should ever call this.
needed ? no. nice ? sure. up to you as t
On Fri, Feb 3, 2012 at 3:26 PM, Mike Frysinger wrote:
> please post it inline to make review easier
>
>> # @MAINTAINER: mozi...@gentoo.org
>> # @AUTHOR: Nirbheek Chauhan
>
> goes on newline, not inlined
>
Fixed
>> # @DESCRIPTION: Array containing the list of language pack xpis available
>
> tex
please post it inline to make review easier
> # @MAINTAINER: mozi...@gentoo.org
> # @AUTHOR: Nirbheek Chauhan
goes on newline, not inlined
> # @DESCRIPTION: Array containing the list of language pack xpis available
text starts on the next line, not the existing line
> # @ECLASS-VARIABLE: LANG
Le jeudi 02 février 2012 à 01:44 +0530, Nirbheek Chauhan a écrit :
> ECLASS-VARIABLE: FTP_URI
> # @DEFAULT-UNSET
> # @DESCRIPTION: The ftp URI prefix for the release tarballs and
> language packs.
> : ${FTP_URI:=""}
It might be a good idea to prefix this "generic" variable by MOZ_ as
well.
--
G
