Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-30 Thread Petteri Räty
Nirbheek Chauhan kirjoitti: On Sat, Sep 27, 2008 at 3:47 PM, Thomas Sachau <[EMAIL PROTECTED]> wrote: So what about this one? default_src_install() { if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then emake DESTDIR="${D}" install || die "emake install failed

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-28 Thread Nirbheek Chauhan
On Sat, Sep 27, 2008 at 3:47 PM, Thomas Sachau <[EMAIL PROTECTED]> wrote: > So what about this one? > > default_src_install() { >if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then >emake DESTDIR="${D}" install || die "emake install failed" >fi >

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-27 Thread Thomas Sachau
Nirbheek Chauhan schrieb: > On Wed, Sep 24, 2008 at 4:51 AM, Bo Ørsted Andresen <[EMAIL PROTECTED]> wrote: >> On Tuesday 23 September 2008 21:39:52 Thomas Sachau wrote: > >>> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then > [...] >>> fi > > - So if those makefiles don't

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-24 Thread Bo Ørsted Andresen
On Wednesday 24 September 2008 07:28:07 Alec Warner wrote: > > Now figure out the four flaws in the above code. > > Why not be helpful and point them out? > > I would call your comment 'UnGentooey', if I may use a work term.  I > don't think saying there are flaws in a given piece of code is really

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-24 Thread Santiago M. Mola
El mié, 24-09-2008 a las 02:35 +0200, Robert Buchholz escribió: > > Let's go with an even simpler default implementation: > > default_src_install() { > if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then > emake DESTDIR="${D}" install || die "emake install failed

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-24 Thread Nirbheek Chauhan
On Wed, Sep 24, 2008 at 4:51 AM, Bo Ørsted Andresen <[EMAIL PROTECTED]> wrote: > On Tuesday 23 September 2008 21:39:52 Thomas Sachau wrote: >> default_src_install() { >> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then >> if emake DESTDIR="${D} install || einstall ;

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-23 Thread Alec Warner
On Tue, Sep 23, 2008 at 4:21 PM, Bo Ørsted Andresen <[EMAIL PROTECTED]> wrote: > On Tuesday 23 September 2008 21:39:52 Thomas Sachau wrote: >> default_src_install() { >> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then >> if emake DESTDIR="${D} install || einstall ;

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-23 Thread Robert Buchholz
On Tuesday 23 September 2008, Thomas Sachau wrote: > Ulrich Mueller schrieb: > > And I still don't see why we would need the most general solution > > for a *default* function. There's always the possibility to write > > your own src_install() for the few ebuilds that need it. > > > > Ulrich > > I

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-23 Thread Bo Ørsted Andresen
On Tuesday 23 September 2008 21:39:52 Thomas Sachau wrote: > default_src_install() { >         if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then >                 if emake DESTDIR="${D} install || einstall ; then >                         die "install failed" >                 else >      

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-23 Thread Thomas Sachau
Ulrich Mueller schrieb: >> On Sun, 21 Sep 2008, Steve Long wrote: > >> That works for that specific case, yes, but it's still not a general >> solution, which is what BASH arrays were invented for. For instance, >> an ebuild author cannot specifically include a file with spaces, and >> ignore

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-21 Thread Alec Warner
On Sat, Sep 20, 2008 at 11:18 PM, Vaeth <[EMAIL PROTECTED]> wrote: > Steve Long wrote: > >> Thomas Sachau wrote: [...] >> >> > [[ -n ${DOCS} ]] && dodoc ${DOCS} > [...] >> >> It might be wise to use an array for DOCS there > > Since I have now seen suggestions for using arrays unnecessarily > at le

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-21 Thread Kent Fredric
On Mon, Sep 22, 2008 at 1:04 AM, Ulrich Mueller <[EMAIL PROTECTED]> wrote: > > > On Sun, 21 Sep 2008, Steve Long wrote: > > > Vaeth wrote: > >> let me remark that the more clever way to this is > >> [ -n "${DOCS}" ] && eval "dodoc ${DOCS}" > > > [...] > > BASH arrays will cope with *any* charac

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-21 Thread Thomas Anderson
On Sun, Sep 21, 2008 at 08:18:05AM +0200, Vaeth wrote: > Steve Long wrote: > > > Thomas Sachau wrote: [...] > > > > > [[ -n ${DOCS} ]] && dodoc ${DOCS} > [...] > > > > It might be wise to use an array for DOCS there > > Since I have now seen suggestions for using arrays unnecessarily > at least

Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI

2008-09-20 Thread Vaeth
Steve Long wrote: > Thomas Sachau wrote: [...] > > > [[ -n ${DOCS} ]] && dodoc ${DOCS} [...] > > It might be wise to use an array for DOCS there Since I have now seen suggestions for using arrays unnecessarily at least twice (see also [RFC] Ability to pass arguments to src_configure/src_compil