Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-08 Thread Natanael Olaiz
Hi, Thanks for the detailed explanation of your testing procedure! It is good to know what is behind a local patched driver, just in case.. :) Best regards, Natanael. On 6 August 2016 at 16:20, David Haller wrote: > Hello, > > On Sat, 06 Aug 2016, Natanael Olaiz wrote: > >Thank you for your p

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-06 Thread David Haller
Hello, On Sat, 06 Aug 2016, Natanael Olaiz wrote: >Thank you for your patch. It was a good example to answer my question. > >But about the patch itself, I see that you are commented the code for >radix_tree_empty(...). In my patch I renamed it and it only usage instead, >so I'm sure it's calling t

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-06 Thread Natanael Olaiz
s/you are commented/you commented/ :) On 6 August 2016 at 12:25, Natanael Olaiz wrote: > David, > > Thank you for your patch. It was a good example to answer my question. > > But about the patch itself, I see that you are commented the code for > radix_tree_empty(...). In my patch I renamed it

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-06 Thread Natanael Olaiz
David, Thank you for your patch. It was a good example to answer my question. But about the patch itself, I see that you are commented the code for radix_tree_empty(...). In my patch I renamed it and it only usage instead, so I'm sure it's calling the same code. I don't know the expected compatib

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-06 Thread Natanael Olaiz
Thank you for your explanations! :) Best regards, Natanael. On 6 August 2016 at 04:50, David Haller wrote: > Hello, > > On Fri, 05 Aug 2016, Mike Gilbert wrote: > >On Fri, Aug 5, 2016 at 3:10 PM, Natanael Olaiz wrote: > >> I know that. But the patch should be applied *only* for versions of > k

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-05 Thread David Haller
Hello, On Fri, 05 Aug 2016, Mike Gilbert wrote: >On Fri, Aug 5, 2016 at 3:10 PM, Natanael Olaiz wrote: >> I know that. But the patch should be applied *only* for versions of kernels >> 4.7+. So, I'm asking how is the policy for that. > >If you're asking for policy: The Gentoo packaging policy is

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-05 Thread Mike Gilbert
On Fri, Aug 5, 2016 at 3:10 PM, Natanael Olaiz wrote: > I know that. But the patch should be applied *only* for versions of kernels > 4.7+. So, I'm asking how is the policy for that. If you're asking for policy: The Gentoo packaging policy is not to do conditional patching. Instead, modify the pa

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-05 Thread Natanael Olaiz
Yes, thank you. I did the local repository path at the moment. I was thinking on pushing the patch upstream, but now I read on the ebuild I'm editing (using the check kernel_is :) ) : if use kernel_linux && kernel_is ge 4 7; then ewarn "Gentoo supports kernels which are supported by NV

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-05 Thread Natanael Olaiz
I know that. But the patch should be applied *only* for versions of kernels 4.7+. So, I'm asking how is the policy for that. I see in the linux-info eclass documentation ( https://devmanual.gentoo.org/eclass-reference/linux-info.eclass/index.html) that I can maybe apply it with a line like this?

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-05 Thread NP-Hardass
On 08/05/2016 02:34 PM, R0b0t1 wrote: > On Aug 5, 2016 1:23 PM, "Natanael Olaiz" > wrote: >> >> I applied the attached patch unconditionally locally, and it seems to > work. >> Which is correct way to apply the patch or not depending on the kernel > version? >> > > See eb

Re: [gentoo-dev] Patch for nvidia-drivers 367.35-r1 for kernels > 4.7.0

2016-08-05 Thread R0b0t1
On Aug 5, 2016 1:23 PM, "Natanael Olaiz" wrote: > > I applied the attached patch unconditionally locally, and it seems to work. > Which is correct way to apply the patch or not depending on the kernel version? > See ebuild, there is a patch phase. Shove it in proper directory. Will need local ove