Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Michał Górny
On Tue, 31 May 2011 13:40:42 -0700 Brian Harring wrote: > A function to generate a github url for SRC_URI is likely warranted; > should they ever grow mirrors/change their scheme, we can change it > in one spot. > > Plus it makes it easier for ebuild devs to specify the url ;) I thought about

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Brian Harring
On Tue, May 31, 2011 at 04:24:23PM +0200, Michał Górny wrote: > Hello all, > > As I suggested earlier, I'm attaching an example implementation > of github-snapshot.eclass. > > All the eclass does is providing a default src_unpack() unpacking > the github snapshot into ${S}. Right now it simply do

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Michał Górny
On Tue, 31 May 2011 14:28:00 -0500 William Hubbs wrote: > On Tue, May 31, 2011 at 04:24:23PM +0200, Michał Górny wrote: > > EAPI=4 > > > > inherit github-snapshot > > > > DESCRIPTION="Random github package" > > HOMEPAGE="https://github.com/foo/bar"; > > bar is actually ${PN}. AFAIK it is a ba

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread William Hubbs
On Tue, May 31, 2011 at 04:24:23PM +0200, Michał Górny wrote: > EAPI=4 > > inherit github-snapshot > > DESCRIPTION="Random github package" > HOMEPAGE="https://github.com/foo/bar"; bar is actually ${PN}. > SRC_URI="http://github.com/foo/${PN}/tarball/${P} -> ${P}.tar.gz" The first ${P} above is

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Michał Górny
On Tue, 31 May 2011 15:07:17 -0400 Mike Gilbert wrote: > case ${EAPI:-0} in > 0|1) die "EAPI ${EAPI} unsupported.";; > 2|3|4) ;; > *) die "github-snapshot.eclass API in EAPI ${EAPI} not yet > established." esac > > Why are EAPI 0 and 1 unsupported? I don't see anything that wou

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Mike Gilbert
On Tue, May 31, 2011 at 10:24 AM, Michał Górny wrote: > Hello all, > > As I suggested earlier, I'm attaching an example implementation > of github-snapshot.eclass. > case ${EAPI:-0} in 0|1) die "EAPI ${EAPI} unsupported.";; 2|3|4) ;; *) die "github-snapshot.eclass API in E

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Michał Górny
On Tue, 31 May 2011 13:41:03 -0500 William Hubbs wrote: > If you use this eclass, how should your ebuild specify the commit you > want to take the snapshot from? Your example doesn't show how to do > that. It's specified in SRC_URI, like usual. -- Best regards, Michał Górny signature.asc Des

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread William Hubbs
Hi, If you use this eclass, how should your ebuild specify the commit you want to take the snapshot from? Your example doesn't show how to do that. William pgpmaKTWUJ4tm.pgp Description: PGP signature