Re: [gentoo-dev] [RFC] xfconf.eclass - codename: keep it simple, stupid

2009-08-01 Thread Ciaran McCreesh
On Sat, 01 Aug 2009 21:26:09 +0300 Samuli Suominen wrote: > > += is bash 3.1, which isn't legal for use in the tree. > > It's been in use for a long time in xfce's ebuilds already, noone has > ever complained. One can easily match some hundreds of ebuilds in tree > where it's used. Yes, unfortun

Re: [gentoo-dev] [RFC] xfconf.eclass - codename: keep it simple, stupid

2009-08-01 Thread Fabian Groffen
On 01-08-2009 21:26:09 +0300, Samuli Suominen wrote: > Ciaran McCreesh wrote: > > On Sat, 01 Aug 2009 20:58:10 +0300 > > Samuli Suominen wrote: > >> Improved version attached. EAPI checking modification. > > > >>2) EXPF+=" src_configure" ;; > > > > += is bash 3.1, which isn't legal for use i

Re: [gentoo-dev] [RFC] xfconf.eclass - codename: keep it simple, stupid

2009-08-01 Thread Samuli Suominen
Ciaran McCreesh wrote: > On Sat, 01 Aug 2009 20:58:10 +0300 > Samuli Suominen wrote: >> Improved version attached. EAPI checking modification. > >> 2) EXPF+=" src_configure" ;; > > += is bash 3.1, which isn't legal for use in the tree. > It's been in use for a long time in xfce's ebuilds

Re: [gentoo-dev] [RFC] xfconf.eclass - codename: keep it simple, stupid

2009-08-01 Thread Ciaran McCreesh
On Sat, 01 Aug 2009 20:58:10 +0300 Samuli Suominen wrote: > Improved version attached. EAPI checking modification. > 2) EXPF+=" src_configure" ;; += is bash 3.1, which isn't legal for use in the tree. -- Ciaran McCreesh signature.asc Description: PGP signature

Re: [gentoo-dev] [RFC] xfconf.eclass - codename: keep it simple, stupid

2009-08-01 Thread Samuli Suominen
Samuli Suominen wrote: > Please comment if there's something to change. Keep it simple. Improved version attached. EAPI checking modification. Thanks, Samuli # Copyright 1999-2009 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ # @ECLASS: xfconf