On 13/06/2024 11.31, Ulrich Mueller wrote:
On Thu, 13 Jun 2024, Florian Schmaus wrote:
+# Copyright 1999-2024 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+# @ECLASS: greadme.eclass
+# @MAINTAINER:
+# Florian Schmaus
+# @AUTHOR:
+# Author: Florian Schmaus
> On Thu, 13 Jun 2024, Ulrich Mueller wrote:
>> +if $append; then
> Please use the conventional coding style, i.e. ${append}.
Or rather, assign the variable to empty or non-empty and test for
[[ -n ${append} ]] instead of executing it as a true or false command.
(I'm pretty sure that th
On 13/06/2024 12.42, Ulrich Mueller wrote:
On Thu, 13 Jun 2024, Florian Schmaus wrote:
+_GREADME_DOC_DIR="usr/share/doc/${PF}"
It is somewhat unusual to call insinto or docompress with a relative
path. I'd use "/usr/share/doc/${PF}" here.
+_GREADME_REL_PATH="${_GREADME_DOC_DIR}/${_GREADME_FIL
> On Thu, 13 Jun 2024, Florian Schmaus wrote:
>>> +_GREADME_DOC_DIR="usr/share/doc/${PF}"
>> It is somewhat unusual to call insinto or docompress with a relative
>> path. I'd use "/usr/share/doc/${PF}" here.
>>
>>> +_GREADME_REL_PATH="${_GREADME_DOC_DIR}/${_GREADME_FILENAME}"
>> Why must this
> On Thu, 13 Jun 2024, Florian Schmaus wrote:
> +# Copyright 1999-2024 Gentoo Authors
> +# Distributed under the terms of the GNU General Public License v2
> +
> +# @ECLASS: greadme.eclass
> +# @MAINTAINER:
> +# Florian Schmaus
> +# @AUTHOR:
> +# Author: Florian Schmaus
> +# @SUPPORTED_EAPIS
