Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Brian Evans
On 8/7/19 11:20 AM, Mikle Kolyada wrote: > Signed-off-by: Mikle Kolyada > --- > As discussed with mgorny at #gentoo-qa > glep-0081.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/glep-0081.rst b/glep-0081.rst > index 082e705..e5a4db2 100644 > --- a/glep-0081.rst > +++ b/glep-0081

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Mike Gilbert
On Wed, Aug 7, 2019 at 12:02 PM Kent Fredric wrote: > > On Wed, 07 Aug 2019 17:55:21 +0200 > Ulrich Mueller wrote: > > > Plus, the eclasses explicitly allow KEYWORDS to be overridden by the > > ebuild: > > > > : ${KEYWORDS:=alpha amd64 arm arm64 hppa ia64 m68k ~mips ppc ppc64 ~riscv > > s390 sh

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Kent Fredric
On Wed, 07 Aug 2019 17:55:21 +0200 Ulrich Mueller wrote: > Plus, the eclasses explicitly allow KEYWORDS to be overridden by the > ebuild: > > : ${KEYWORDS:=alpha amd64 arm arm64 hppa ia64 m68k ~mips ppc ppc64 ~riscv > s390 sh sparc x86 ~ppc-aix ~x64-cygwin ~amd64-fbsd ~x86-fbsd ~amd64-linux >

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Mikle Kolyada
On 07.08.2019 18:49, Michał Górny wrote: > On Wed, 2019-08-07 at 18:20 +0300, Mikle Kolyada wrote: >> Signed-off-by: Mikle Kolyada >> --- >> As discussed with mgorny at #gentoo-qa >> glep-0081.rst | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/glep-0081.rst b/glep-0081.rst >> ind

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Kent Fredric
On Wed, 7 Aug 2019 11:32:43 -0400 Brian Evans wrote: > I object to this as I feel they can incorrect such as on prefix. > > Also, this goes against the established practice of committing directly > to stable. These are exactly the same as virtuals as "they install > nothing" and "just run a scr

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Ulrich Mueller
> On Wed, 07 Aug 2019, Mikle Kolyada wrote: > +Both ``acct-group`` and ``acct-user`` eclasses have the ``KEYWORDS`` > +variable predefined, keywords must not be altered locally via ebuilds. > + GLEP 81 doesn't specify anything about the implementation. In fact, it neither requires that it i

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Michał Górny
On Wed, 2019-08-07 at 18:20 +0300, Mikle Kolyada wrote: > Signed-off-by: Mikle Kolyada > --- > As discussed with mgorny at #gentoo-qa > glep-0081.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/glep-0081.rst b/glep-0081.rst > index 082e705..e5a4db2 100644 > --- a/glep-0081.rst >

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Michał Górny
On Wed, 2019-08-07 at 11:32 -0400, Brian Evans wrote: > On 8/7/2019 11:20 AM, Mikle Kolyada wrote: > > Signed-off-by: Mikle Kolyada > > --- > > As discussed with mgorny at #gentoo-qa > > glep-0081.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/glep-0081.rst b/glep-0081.rst

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Mikle Kolyada
On 07.08.2019 18:32, Brian Evans wrote: > On 8/7/2019 11:20 AM, Mikle Kolyada wrote: >> Signed-off-by: Mikle Kolyada >> --- >> As discussed with mgorny at #gentoo-qa >> glep-0081.rst | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/glep-0081.rst b/glep-0081.rst >> index 082e705..e5

Re: [gentoo-dev] [PATCH] glep-0081: prohibit KEYWORDS altering

2019-08-07 Thread Brian Evans
On 8/7/2019 11:20 AM, Mikle Kolyada wrote: > Signed-off-by: Mikle Kolyada > --- > As discussed with mgorny at #gentoo-qa > glep-0081.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/glep-0081.rst b/glep-0081.rst > index 082e705..e5a4db2 100644 > --- a/glep-0081.rst > +++ b/glep-00