-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Dne 12.3.2011 11:37, "Paweł Hajdan, Jr." napsal(a):
> One of my ebuilds is using virtualx eclass, and I noticed the following
> code inside the eclass:
>
> retval=$?
>
> # Now kill Xvfb
> kill $(cat /tmp/.X${XDISPLAY}-lock)
>
On Sat, 12 Mar 2011 11:37:28 +0100
"Paweł Hajdan, Jr." wrote:
> Shouldn't that last line look more like this (notice $retval instead
> of $?):
>
> [[ $retval -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND}
> failed."
>
> What do you think?
I'd say even '${VIRTUALX_COMMAND}'.
--
Best
One of my ebuilds is using virtualx eclass, and I noticed the following
code inside the eclass:
retval=$?
# Now kill Xvfb
kill $(cat /tmp/.X${XDISPLAY}-lock)
else
debug-print "${FUNCNAME}: attaching to running X display"
# Normal make if we can connect
