Re: [gentoo-dev] src_configure

2005-08-23 Thread Paul de Vrieze
On Thursday 07 July 2005 03:14, Aron Griffis wrote: > Roy Marples wrote:[Wed Jul 06 2005, 08:51:17PM EDT] > > > ebuilds could be changed over time - unless I'm missing something > > basic here .. > > Yes, you're missing the default functions. Presently src_compile does > (effectively) "econf &

Re: [gentoo-dev] src_configure

2005-07-07 Thread Henrik Brix Andersen
On Thu, 2005-07-07 at 15:25 +0100, twofourtysix wrote: > Whilst you're at it... Why not split unpack up into, say, unpack and > prepare? Make src_unpack's default stay the same and use src_prepare > for patches and autotools things? This will avoid the pointless > duplication of the default src_unp

Re: [gentoo-dev] src_configure

2005-07-07 Thread twofourtysix
On 07/07/05, Sven Wegener <[EMAIL PROTECTED]> wrote: > I'm writing this mail to bring you a thought we had over on freenode in > the #gentoo-portage channel. We would like to split up src_compile. The > new src_configure should just do the econf part and src_compile should > do the emake part. This

Re: [gentoo-dev] src_configure

2005-07-07 Thread Martin Schlemmer
On Thu, 2005-07-07 at 08:08 +0100, Daniel Drake wrote: > Jonathan Smith wrote: > > you could simply make the default: > > > > src_configure() { > > [ -f ./configure ] && econf || die > > } > > > No need, this will do fine as a default: > > src_configure() { > econf || die > } > > Sin

Re: [gentoo-dev] src_configure

2005-07-07 Thread Martin Schlemmer
On Thu, 2005-07-07 at 02:04 +0200, Sven Wegener wrote: > Hi all! > > I'm writing this mail to bring you a thought we had over on freenode in > the #gentoo-portage channel. We would like to split up src_compile. The > new src_configure should just do the econf part and src_compile should > do the e

Re: [gentoo-dev] src_configure

2005-07-07 Thread Ned Ludd
On Thu, 2005-07-07 at 02:04 +0200, Sven Wegener wrote: > Hi all! > > I'm writing this mail to bring you a thought we had over on freenode in > the #gentoo-portage channel. We would like to split up src_compile. The > new src_configure should just do the econf part and src_compile should > do the e

Re: [gentoo-dev] src_configure

2005-07-07 Thread twofourtysix
On 07/07/05, Daniel Drake <[EMAIL PROTECTED]> wrote: > src_configure() { > econf || die > } > > Since econf already checks for a configure script and does nothing if it can't > find one... Yours might do. The one I have in /usr/sbin/ebuild.sh from portage 2.0.51.22-r1 says this: econf()

Re: [gentoo-dev] src_configure

2005-07-07 Thread Daniel Drake
Jonathan Smith wrote: > you could simply make the default: > > src_configure() { > [ -f ./configure ] && econf || die > } No need, this will do fine as a default: src_configure() { econf || die } Since econf already checks for a configure script and does nothing if it can't find

Re: [gentoo-dev] src_configure

2005-07-06 Thread Kumba
Diego 'Flameeyes' Pettenò wrote: That will be very very interesting but... but not everything uses ./configure, so we should add a bunch of dummy src_configure, and a call to econf || die "" for those packages not fixed to use that will return a bunch of erroneous packages not compiling. I

Re: [gentoo-dev] src_configure

2005-07-06 Thread Robin H. Johnson
On Thu, Jul 07, 2005 at 04:32:32AM +0200, Thomas de Grenier de Latour wrote: > Sure, spliting that will produce a bit of code duplication. It's > a bit less readable imho, but that's really just a cosmetic > issue: > > src_configure() { >

Re: [gentoo-dev] src_configure

2005-07-06 Thread Thomas de Grenier de Latour
On Thu, 7 Jul 2005 02:04:04 +0200 Sven Wegener <[EMAIL PROTECTED]> wrote: > We would like to split up src_compile. The new src_configure > should just do the econf part and src_compile should do the > emake part. Just by curiosity, i've run a grep on the tree to count occurences of "^[[:space:]]*

Re: [gentoo-dev] src_configure

2005-07-06 Thread Joshua Baergen
Aron Griffis wrote: It would be less annoying if you wouldn't quote the entire previous email in your replies. Ehhe, my apologies...I've been spoiled by Gmail's hiding of previous emails. Joshua Baergen -- gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] src_configure

2005-07-06 Thread Aron Griffis
Roy Marples wrote: [Wed Jul 06 2005, 08:51:17PM EDT] > ebuilds could be changed over time - unless I'm missing something basic > here .. Yes, you're missing the default functions. Presently src_compile does (effectively) "econf && emake" if the function isn't defined. That would be broken i

Re: [gentoo-dev] src_configure

2005-07-06 Thread Aron Griffis
Joshua Baergen wrote: [Wed Jul 06 2005, 08:43:34PM EDT] > P.S. I tried sending this earlier but my client barfed, so I apologize > if it ends up double. It would be less annoying if you wouldn't quote the entire previous email in your replies. Regards, Aron -- Aron Griffis Gentoo Linux Develo

Re: [gentoo-dev] src_configure

2005-07-06 Thread Roy Marples
On Wed, 2005-07-06 at 20:14 -0400, Aron Griffis wrote: > Sven Wegener wrote: [Wed Jul 06 2005, 08:04:04PM EDT] > > I'm writing this mail to bring you a thought we had over on freenode > > in the #gentoo-portage channel. We would like to split up > > src_compile. The new src_configure should just

Re: [gentoo-dev] src_configure

2005-07-06 Thread Joshua Baergen
Jonathan Smith wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Diego 'Flameeyes' Pettenò wrote: On Thursday 07 July 2005 02:04, Sven Wegener wrote: We would like to split up src_compile. The new src_configure should just do the econf part and src_compile should do the emake part

Re: [gentoo-dev] src_configure

2005-07-06 Thread Diego 'Flameeyes' Pettenò
On Thursday 07 July 2005 02:27, Jonathan Smith wrote: > src_configure() { > [ -f ./configure ] && econf || die > } I'm not still convinced about this. -- Diego "Flameeyes" Pettenò Gentoo Developer - http://dev.gentoo.org/~flameeyes/ (Gentoo/FreeBSD, Video, Gentoo/AMD64, Sound, PAM) pgprfA

Re: [gentoo-dev] src_configure

2005-07-06 Thread Joshua Baergen
Jonathan Smith wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Diego 'Flameeyes' Pettenò wrote: On Thursday 07 July 2005 02:04, Sven Wegener wrote: We would like to split up src_compile. The new src_configure should just do the econf part and src_compile should do the emake part

Re: [gentoo-dev] src_configure

2005-07-06 Thread Mike Frysinger
On Wednesday 06 July 2005 08:27 pm, Jonathan Smith wrote: > you could simply make the default: > > src_configure() { > [ -f ./configure ] && econf || die > } well you cant because then die would be called if ./configure isnt a file but i think that's irrelevant to the point you're trying to

Re: [gentoo-dev] src_configure

2005-07-06 Thread Ian Leitch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sven Wegener wrote: > Hi all! > > I'm writing this mail to bring you a thought we had over on freenode in > the #gentoo-portage channel. We would like to split up src_compile. The > new src_configure should just do the econf part and src_compile shoul

Re: [gentoo-dev] src_configure

2005-07-06 Thread Jonathan Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Diego 'Flameeyes' Pettenò wrote: > On Thursday 07 July 2005 02:04, Sven Wegener wrote: > >>We would like to split up src_compile. The >>new src_configure should just do the econf part and src_compile should >>do the emake part. > > That will be very

Re: [gentoo-dev] src_configure

2005-07-06 Thread Sven Wegener
On Wed, Jul 06, 2005 at 08:14:55PM -0400, Aron Griffis wrote: > Sven Wegener wrote: [Wed Jul 06 2005, 08:04:04PM EDT] > > I'm writing this mail to bring you a thought we had over on freenode > > in the #gentoo-portage channel. We would like to split up > > src_compile. The new src_configure shoul

Re: [gentoo-dev] src_configure

2005-07-06 Thread Diego 'Flameeyes' Pettenò
On Thursday 07 July 2005 02:04, Sven Wegener wrote: > We would like to split up src_compile. The > new src_configure should just do the econf part and src_compile should > do the emake part. That will be very very interesting but... but not everything uses ./configure, so we should add a bunch of

Re: [gentoo-dev] src_configure

2005-07-06 Thread Aron Griffis
Sven Wegener wrote: [Wed Jul 06 2005, 08:04:04PM EDT] > I'm writing this mail to bring you a thought we had over on freenode > in the #gentoo-portage channel. We would like to split up > src_compile. The new src_configure should just do the econf part and > src_compile should do the emake part.

[gentoo-dev] src_configure

2005-07-06 Thread Sven Wegener
Hi all! I'm writing this mail to bring you a thought we had over on freenode in the #gentoo-portage channel. We would like to split up src_compile. The new src_configure should just do the econf part and src_compile should do the emake part. This represents the general 3-step[1] installation in a