Re: [gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-29 Thread Ciaran McCreesh
On Thu, 27 Sep 2012 10:23:50 -0700 Zac Medico wrote: > Something like this would work with current versions of portage: > > if ! declare -F usex >/dev/null ; then > usex() { use "$1" && echo "${2-yes}$4" || echo "${3-no}$5" ; } > fi > > However, it's probably not a good idea to assume that

Re: [gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-28 Thread Ian Stakenvicius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 28/09/12 10:32 AM, Jeroen Roovers wrote: > On Thu, 27 Sep 2012 13:16:45 -0400 Ian Stakenvicius > wrote: > >> i actually just committed the fix discussed in #gentoo-dev , >> using 'declare -F' instead (similar to the eqawarn conditional >> de

Re: [gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-28 Thread Jeroen Roovers
On Thu, 27 Sep 2012 13:16:45 -0400 Ian Stakenvicius wrote: > i actually just committed the fix discussed in #gentoo-dev , using > 'declare -F' instead (similar to the eqawarn conditional declaration > already in eutils.eclass) You forgot to add an entry to eclass/ChangeLog. jer

Re: [gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-27 Thread Brian Harring
On Thu, Sep 27, 2012 at 10:30:21AM -0700, Zac Medico wrote: > On 09/27/2012 10:16 AM, Ian Stakenvicius wrote: > > On 27/09/12 01:07 PM, Zac Medico wrote: > >> On 09/27/2012 09:49 AM, Ulrich Mueller wrote: > >>> As far as I can see, only the definition of the usex function > >>> must be disabled. Pl

Re: [gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-27 Thread Zac Medico
On 09/27/2012 10:16 AM, Ian Stakenvicius wrote: > On 27/09/12 01:07 PM, Zac Medico wrote: >> On 09/27/2012 09:49 AM, Ulrich Mueller wrote: >>> As far as I can see, only the definition of the usex function >>> must be disabled. Please review the patch included below. >>> >>> Ulrich >>> >>> --- eutil

Re: [gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-27 Thread Zac Medico
On 09/27/2012 10:07 AM, Zac Medico wrote: > On 09/27/2012 09:49 AM, Ulrich Mueller wrote: >> As far as I can see, only the definition of the usex function must be >> disabled. Please review the patch included below. >> >> Ulrich >> >> --- eutils.eclass15 Sep 2012 16:16:53 - 1.403 >> ++

Re: [gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-27 Thread Ian Stakenvicius
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 27/09/12 01:07 PM, Zac Medico wrote: > On 09/27/2012 09:49 AM, Ulrich Mueller wrote: >> As far as I can see, only the definition of the usex function >> must be disabled. Please review the patch included below. >> >> Ulrich >> >> --- eutils.ecla

Re: [gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-27 Thread Zac Medico
On 09/27/2012 09:49 AM, Ulrich Mueller wrote: > As far as I can see, only the definition of the usex function must be > disabled. Please review the patch included below. > > Ulrich > > --- eutils.eclass 15 Sep 2012 16:16:53 - 1.403 > +++ eutils.eclass 27 Sep 2012 16:45:14 - >

[gentoo-dev] patch eutils.eclass for EAPI 5

2012-09-27 Thread Ulrich Mueller
As far as I can see, only the definition of the usex function must be disabled. Please review the patch included below. Ulrich --- eutils.eclass 15 Sep 2012 16:16:53 - 1.403 +++ eutils.eclass 27 Sep 2012 16:45:14 - @@ -1373,7 +1373,9 @@ # @DESCRIPTION: # If USE flag is