Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots

2015-08-05 Thread William Hubbs
On Tue, Aug 04, 2015 at 02:19:52PM -0500, William Hubbs wrote: > On Tue, Aug 04, 2015 at 12:17:50PM -0400, Mike Gilbert wrote: > > The documentation says you are extracting to ${S}, but the function > > actually extracts to ${WORKDIR}/${PN}. > > s/PN/P/ > > I would get rid of the useless "destdi

Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots

2015-08-04 Thread William Hubbs
On Tue, Aug 04, 2015 at 12:17:50PM -0400, Mike Gilbert wrote: > The documentation says you are extracting to ${S}, but the function > actually extracts to ${WORKDIR}/${PN}. s/PN/P/ > I would get rid of the useless "destdir" variable and replace all > usages with "${S}". Or update the docs. I

Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots

2015-08-04 Thread Mike Gilbert
On Mon, Aug 3, 2015 at 8:20 PM, William Hubbs wrote: > This eclass is meant to handle vcs snapshots of golang packages coming > from services like github. > > Let me know what you think. > > William > > # The location where the tarball is extracted is defined as > # ${S}/src/${EGO_PN}. > > # @FUNC

Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots

2015-08-03 Thread William Hubbs
On Mon, Aug 03, 2015 at 07:20:20PM -0500, William Hubbs wrote: *snip* > # Copyright 1999-2013 Gentoo Foundation I'll fix the year before I commit. William signature.asc Description: Digital signature

[gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots

2015-08-03 Thread William Hubbs
This eclass is meant to handle vcs snapshots of golang packages coming from services like github. Let me know what you think. William # Copyright 1999-2013 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ # @ECLASS: golang-vcs-snapshot.eclass # @