Re: [gentoo-dev] git-2.eclass review phase one

2011-02-06 Thread James Cloos
> # we can not jump between using and not using SUBMODULES so we need to > # refetch the source when needed In that section, please do not rm(1) the existing clone; move it out of the way just like portage does when checksums fail. Nothing under DISTDIR should /ever/ be subject to beh

Re: [gentoo-dev] git-2.eclass review phase one

2011-02-06 Thread Ulrich Mueller
> # Eclass for easing maitenance of live ebuilds using git as remote > repositories. Please keep lines below 80 characters if possible. > # @ECLASS-VARIABLE: ESCM_STORE_DIR > # @DESCRIPTION: > # Storage directory for git sources. > : ${ESCM_STORE_DIR:="${PORTAGE_ACTUAL_DI

[gentoo-dev] git-2.eclass review phase one

2011-02-06 Thread Tomáš Chvátal
Hello, so this is first attempt to create new eclass for git management that is more clean and neat. I would like to ask you guys to help me review it and suggest updates/cleanups. I really tried to make the eclass nicely separated to functions based on what it does and remove some obsolete code.