On Thursday, October 14, 2010 09:14:22 Michał Górny wrote:
> Ok, I think I've applied all your suggestions. Sorry for the delay.
> Anything else to change?
personally, i dont like "$...@}" over "$@", but maybe that's me
feel free to commit either way
-mike
signature.asc
Description: This is a d
Ok, I think I've applied all your suggestions. Sorry for the delay.
Anything else to change?
--
Best regards,
Michał Górny
? tests-common.sh.diff
Index: tests-common.sh
===
RCS file: /var/cvsroot/gentoo-x86/eclass/tests/tests-common.
On Sun, Oct 10, 2010 at 3:36 AM, Michał Górny wrote:
> On Sat, 9 Oct 2010 17:33:41 -0400 Mike Frysinger wrote:
>> On Saturday, October 09, 2010 11:16:38 Michał Górny wrote:
>> > + if [[ ${ECLASS_DEBUG_OUTPUT} = on ]]; then
>>
>> if you're going to use [[]], then also use ==
>
> Pointless.
On Sat, 9 Oct 2010 17:33:41 -0400
Mike Frysinger wrote:
> On Saturday, October 09, 2010 11:16:38 Michał Górny wrote:
> > +debug-print() {
> > + while [[ ${1} ]]; do
>
> use explicit -n here, although this could give incorrect behavior.
> better to use [[ $# -gt 0 ]].
True.
> > + if
On Saturday, October 09, 2010 11:16:38 Michał Górny wrote:
> +debug-print() {
> + while [[ ${1} ]]; do
use explicit -n here, although this could give incorrect behavior. better to
use [[ $# -gt 0 ]].
> + if [[ ${ECLASS_DEBUG_OUTPUT} = on ]]; then
if you're going to use [[]], th
Hello,
I'd like to add the tests-common*() family of functions to the
eclass/tests/tests-common.sh file as required for clean (garbage-free)
run of scons-utils tests.
I'm attaching the patch. Does anyone have any objections or
suggestions? The code was based on one used in Portage.
--
Best rega
