Re: [gentoo-dev] cmake-utils.eclass: fixes to ninja MAKEOPTS conversion

2016-05-26 Thread rindeal
> After the three-month review period I've decided to go ahead and push > it. Please notice that there is a much more comprehensive proposal for _ninjaopts_from_makeopts() in the review queue - https://github.com/gentoo/gentoo/pull/1481

Re: [gentoo-dev] cmake-utils.eclass: fixes to ninja MAKEOPTS conversion

2016-05-26 Thread Michał Górny
On Sun, 28 Feb 2016 20:01:56 +0100 Michał Górny wrote: > Hello, > > Just a quick two patches against cmake-utils that fix MAKEOPTS->ninja > conversion. In particular: > > 1. -k never takes value in make, so do not account for that, and always >convert '-k' to '-k 0', > > 2. -j and -l have

[gentoo-dev] cmake-utils.eclass: fixes to ninja MAKEOPTS conversion

2016-02-28 Thread Michał Górny
Hello, Just a quick two patches against cmake-utils that fix MAKEOPTS->ninja conversion. In particular: 1. -k never takes value in make, so do not account for that, and always convert '-k' to '-k 0', 2. -j and -l have optional values in make, so figure out if we're being passed a correct v