Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-14 Thread Mike Frysinger
On Friday 14 April 2006 13:47, Patrick McLean wrote: > There is a new version at http://dev.gentoo.org/~chutzpah/profile.bashrc > that should fix all these possible problems. Thanks for pointing them out, > let me know if you see anything else. that hasme() func can be replaced with 1 line of code

Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-14 Thread Harald van D??k
On Fri, Apr 14, 2006 at 01:47:41PM -0400, Patrick McLean wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Harald van D?k wrote: > > The only flags that are actually removed are the flags that are invalid > > _by themselves_. There are cases where flags are valid because of other > > fl

Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-14 Thread Patrick McLean
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Joshua Nichols wrote: > Patrick McLean wrote: >> There is a new version at >> http://dev.gentoo.org/~chutzpah/profile.bashrc that >> should fix all these possible problems. Thanks for pointing them out, > Around line 77, you have: > hasme ${fla

Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-14 Thread Joshua Nichols
Patrick McLean wrote: > Harald van D?k wrote: > >> The only flags that are actually removed are the flags that are invalid > >> _by themselves_. There are cases where flags are valid because of other > >> flags, such as anything following -X*. > >> > >> Two other problems I see with the code: > >>

Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-14 Thread Patrick McLean
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Harald van D?k wrote: > The only flags that are actually removed are the flags that are invalid > _by themselves_. There are cases where flags are valid because of other > flags, such as anything following -X*. > > Two other problems I see with the cod

Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-13 Thread Harald van D??k
On Thu, Apr 13, 2006 at 10:49:24PM -0400, Patrick McLean wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Alec Warner wrote: > > > > Except you need a way for them to turn it off, and you do not currently > > provide one. We can set default flags all we want, but I don't see > > filt

Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-13 Thread Patrick McLean
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alec Warner wrote: > > Except you need a way for them to turn it off, and you do not currently > provide one. We can set default flags all we want, but I don't see > filtering 'bad' flags as necessarily our problem. If you want to say: > > "Hey we

Re: [gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-13 Thread Alec Warner
Patrick McLean wrote: > For about a month now, we (amd64) have had some code in our > profile.bashrc that filters CFLAGS that are unrecognized by gcc, and > warnings the user about bad CFLAGS. > > So far it has worked fairly well, and it has really cut down on the > number of bugs that filed by pe

[gentoo-dev] automatically killing invalid CFLAGS/warning about bad CFLAGS

2006-04-13 Thread Patrick McLean
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 For about a month now, we (amd64) have had some code in our profile.bashrc that filters CFLAGS that are unrecognized by gcc, and warnings the user about bad CFLAGS. So far it has worked fairly well, and it has really cut down on the number of bugs tha