Re: [gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread kuzetsa
On 09/29/2018 10:52 AM, Thomas Deutschmann wrote: > On 2018-09-29 15:14, Jeroen Roovers wrote: >> Please: >> >> 0a) Explain to me how to fix my commits that I now can't push, or > > Like you have already figured out, "git commit --signoff" when doing > profile/eclass changes and to fix things, "gi

Re: [gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread Dirkjan Ochtman
On Sat, Sep 29, 2018 at 4:52 PM Thomas Deutschmann wrote: > I agree. Communication was bad. We should have included dev howto with > that announcement. > Thanks for the helpful pointers! Regards, Dirkjan

Re: [gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread Thomas Deutschmann
On 2018-09-29 15:14, Jeroen Roovers wrote: > Please: > > 0a) Explain to me how to fix my commits that I now can't push, or Like you have already figured out, "git commit --signoff" when doing profile/eclass changes and to fix things, "git commit --amend --signoff". > 1) Update repoman to enforc

Re: [gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread kuzetsa
On 09/29/2018 09:29 AM, Rich Freeman wrote: > On Sat, Sep 29, 2018 at 9:25 AM Dirkjan Ochtman wrote: >> >> Some kind of repoman support would make this much easier to handle. As >> it is, doing this by hand for the trivial case (only my own changes) >> is a PITA. repoman could grow some kind of --

Re: [gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread Jeroen Roovers
On Sat, 29 Sep 2018 15:25:25 +0200 Dirkjan Ochtman wrote: > On Sat, Sep 29, 2018 at 3:14 PM Jeroen Roovers wrote: > > > 0a) Explain to me how to fix my commits that I now can't push, or > Try git rebase -i and use "r" for "reword" on every commit. `git rebase ---signoff` did the trick. Kind

Re: [gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread Dirkjan Ochtman
On Sat, Sep 29, 2018 at 3:14 PM Jeroen Roovers wrote: > 0a) Explain to me how to fix my commits that I now can't push, or > 0b) disable that hook immediately. > Try git rebase -i and use "r" for "reword" on every commit. > 1) Update repoman to enforce it _before_ the commit is executed. > Som

Re: [gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread Rich Freeman
On Sat, Sep 29, 2018 at 9:25 AM Dirkjan Ochtman wrote: > > Some kind of repoman support would make this much easier to handle. As > it is, doing this by hand for the trivial case (only my own changes) > is a PITA. repoman could grow some kind of --sign-off option that > appends this to the commit

Re: [gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread Jeroen Roovers
On Sat, 29 Sep 2018 10:19:10 +0200 Michał Górny wrote: > Hi, everyone. > > Just FYI, I'm going to enable the git hook to verify Signed-off-by > tags on gentoo.git (most likely all repos later on). I've tested it > against all the test cases I could think of but if you have any > trouble pushing

[gentoo-dev] Signed-off-by verification incoming

2018-09-29 Thread Michał Górny
Hi, everyone. Just FYI, I'm going to enable the git hook to verify Signed-off-by tags on gentoo.git (most likely all repos later on). I've tested it against all the test cases I could think of but if you have any trouble pushing, please ping me or others in #-infra. Please note that for the hook