Re: [gentoo-dev] Re: git-2.eclass final review

2011-04-18 Thread James Cloos
> "TC" == Tomáš Chvátal writes: TC> No need to escape it if it is in "". it is parsed as the char itself TC> like this. The escaping is for grep(1), not for sh(1). -JimC -- James Cloos OpenPGP: 1024D/ED7DAEA6

Re: [gentoo-dev] Re: git-2.eclass final review

2011-04-18 Thread Tomáš Chvátal
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dne 17.4.2011 20:31, James Cloos napsal(a): > That looks good (by inspection). > > My only concern is the branch deletion in the non-bare update. > > First of all, * should be escaped. It seems to work OK with gnu grep, > but it would be better to b

Re: [gentoo-dev] Re: git-2.eclass final review

2011-04-17 Thread James Cloos
That looks good (by inspection). My only concern is the branch deletion in the non-bare update. First of all, * should be escaped. It seems to work OK with gnu grep, but it would be better to be explicit. (grep(1) says that only ?+{|() loose their meta-meaning in basic regexps.) Second, why de

[gentoo-dev] Re: git-2.eclass final review

2011-04-17 Thread Tomá? Chvátal
On Tuesday 22 of March 2011 22:07:25 you wrote: > Hi guys, > as there are no more complaints in kde overlay i would like you to test > your git using live ebuild with this new git-2 eclass and tell me how > you like it. > > Also usual review of what already is in is welcomed because i would > real

Re: [gentoo-dev] Re: git-2.eclass final review

2011-03-24 Thread Donnie Berkholz
On 10:44 Wed 23 Mar , James Cloos wrote: > TC> So live with it. > > I cannot. It makes the eclass useless. > > I have almost 2 gigs of bare repo in distdirs/git-src. > > A forced re-download of all of that is just not possible! > > The existing distdir clones *MUST* continue to work. >

Re: [gentoo-dev] Re: git-2.eclass final review

2011-03-24 Thread James Cloos
> "DB" == Donnie Berkholz writes: JC> Or better yet, git clone. DB> This could work well with --shared; even worked for me on separate DB> partitions. Yes, I did mean »git clone -l -s«. -JimC -- James Cloos OpenPGP: 1024D/ED7DAEA6

Re: [gentoo-dev] Re: git-2.eclass final review

2011-03-23 Thread Donnie Berkholz
On 08:28 Wed 23 Mar , James Cloos wrote: > > "MF" == Mike Frysinger writes: > > MF> ideally, the git eclass should be creating bare checkouts only in its > MF> store dir, in which case it could use `git archive | tar` to move > MF> things over ... > > Or better yet, git clone. This coul

Re: [gentoo-dev] Re: git-2.eclass final review

2011-03-23 Thread James Cloos
> "TC" == Tomáš Chvátal writes: TC> I explained multiple times already why bare checkouts are not TC> working in our case. Wait a minute. Not using bare clones in DISTDIR is completely unacceptable here. It is bad enough to have to use non-bare for repos which have submodules. Doing so fo

Re: [gentoo-dev] Re: git-2.eclass final review

2011-03-23 Thread Tomáš Chvátal
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dne 23.3.2011 13:28, James Cloos napsal(a): >> "MF" == Mike Frysinger writes: > > MF> ideally, the git eclass should be creating bare checkouts only in its > MF> store dir, in which case it could use `git archive | tar` to move > MF> things over

Re: [gentoo-dev] Re: git-2.eclass final review

2011-03-23 Thread James Cloos
> "MF" == Mike Frysinger writes: MF> ideally, the git eclass should be creating bare checkouts only in its MF> store dir, in which case it could use `git archive | tar` to move MF> things over ... Or better yet, git clone. Most builds from vcs work best when they know that they are building

Re: [gentoo-dev] Re: git-2.eclass final review

2011-03-22 Thread Mike Frysinger
On Tue, Mar 22, 2011 at 7:41 PM, Ryan Hill wrote: > On Tue, 22 Mar 2011 19:08:53 -0400 Mike Frysinger wrote: >> > rsync -rlpgo . "${EGIT_SOURCEDIR}" \ >> >> this means you need to have DEPEND="net-misc/rsync".  why not just use >> `cp -pPR` instead ?  i vaguely recall rsync being slower than a >> s

[gentoo-dev] Re: git-2.eclass final review

2011-03-22 Thread Ryan Hill
On Tue, 22 Mar 2011 17:41:27 -0600 Ryan Hill wrote: > On Tue, 22 Mar 2011 19:08:53 -0400 > Mike Frysinger wrote: > > > > > rsync -rlpgo . "${EGIT_SOURCEDIR}" \ > > > > this means you need to have DEPEND="net-misc/rsync". why not just use > > `cp -pPR` instead ? i vaguely recall rsync being

[gentoo-dev] Re: git-2.eclass final review

2011-03-22 Thread Ryan Hill
On Tue, 22 Mar 2011 19:08:53 -0400 Mike Frysinger wrote: > > rsync -rlpgo . "${EGIT_SOURCEDIR}" \ > > this means you need to have DEPEND="net-misc/rsync". why not just use > `cp -pPR` instead ? i vaguely recall rsync being slower than a > straight cp too ... not much point of doing a rsync wh