Re: [gentoo-dev] Re: bzr.eclass: The next level (this time with patch)

2009-03-30 Thread René 'Necoro' Neumann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Christian Faulhammer schrieb: > Hi, > > René 'Necoro' Neumann : >> So I'd vote for switching back to using normal checkouts (or branches >> - they don't really differ in bzr for that matter). > > My tests with Bazaar 1.13.1 show roughly the same tim

[gentoo-dev] Re: bzr.eclass: The next level (this time with patch)

2009-03-26 Thread Christian Faulhammer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, René 'Necoro' Neumann : > So I'd vote for switching back to using normal checkouts (or branches > - they don't really differ in bzr for that matter). My tests with Bazaar 1.13.1 show roughly the same time with and without --lightweight. Althoug

[gentoo-dev] Re: bzr.eclass: The next level (this time with patch)

2009-03-07 Thread Christian Faulhammer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, René 'Necoro' Neumann : > Perhaps add "> /dev/null" to the pushd/popd calls? To get rid of > unnecessary output. Done in the development branch of the Bazaar overlay. It will get some testing and within two weeks I want to bring it to the tree.

[gentoo-dev] Re: bzr.eclass

2009-03-01 Thread Christian Faulhammer
Hi, Brian Harring : > Kindly drop that; the REPO_URI/BRANCH seperation that is in use there > really isn't all that useful for bzr ebuilds in my experience- more > often then not it winds up biting me in the ass rather then being > useful. > My usage (and understanding of bzr), there isn't a s

Re: [gentoo-dev] Re: bzr.eclass

2009-02-24 Thread Brian Harring
On Mon, Feb 23, 2009 at 08:45:28PM +0100, Christian Faulhammer wrote: > > if [[ ${EBZR_REPO_URI} == */* ]]; then > > repository="${EBZR_REPO_URI}/${EBZR_BRANCH}" > > elif [[ -n ${EBZR_BRANCH} ]] ; then > > ... > > else > > ... > > fi > > > > If I see this correctly, this appends EBZR_B

[gentoo-dev] Re: bzr.eclass

2009-02-23 Thread Christian Faulhammer
Hi, René 'Necoro' Neumann : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Jorge Manuel B. S. Vicetto schrieb: > > Hi. > > > > Christian Faulhammer wrote: > >> Hi, > >> > >> a user maintained a Bazaar overlay for some time now and introduced > >> some changes to bzr eclass, I would like

[gentoo-dev] Re: bzr.eclass

2009-02-23 Thread Christian Faulhammer
Hi, Ulrich Mueller : > > On Fri, 20 Feb 2009, Christian Faulhammer wrote: > > > $ time (bzr diff --old lp:bzr-gentoo-overlay \ > > --new /media/disk/bzr-overlay/|diffstat) > > > real0m50.088s > > This is prohibitive. Drop it completely, or enable it only if some > environment varia

[gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Ulrich Mueller
> On Fri, 20 Feb 2009, Christian Faulhammer wrote: > $ time (bzr diff --old lp:bzr-gentoo-overlay \ > --new /media/disk/bzr-overlay/|diffstat) > real0m50.088s This is prohibitive. Drop it completely, or enable it only if some environment variable is set. Ulrich

[gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Christian Faulhammer
Hi, Ulrich Mueller : > > It produces Git-like output about how much has changed. I added a > > comment to the overlay. > > So it is just informational output and the dependency on > dev-util/diffstat is not essential. And the more at the current position, the bzr diff call does simply nothing,

Re: [gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Petteri Räty
Nirbheek Chauhan wrote: > On Thu, Feb 19, 2009 at 9:09 PM, Petteri Räty wrote: >> or use has_version dev-util/diffstat > > This is bike-shedding, but that assumes that dev-util/diffstat is the > only way diffstat can be installed on the system -- what if the user > has diffstat, but it isn't inst

Re: [gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Nirbheek Chauhan
On Thu, Feb 19, 2009 at 9:09 PM, Petteri Räty wrote: > > or use has_version dev-util/diffstat This is bike-shedding, but that assumes that dev-util/diffstat is the only way diffstat can be installed on the system -- what if the user has diffstat, but it isn't installed by dev-util/diffstat? ;p

Re: [gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Petteri Räty
Nirbheek Chauhan wrote: > On Thu, Feb 19, 2009 at 2:56 PM, Ulrich Mueller wrote: >> -DEPEND=">=dev-util/bzr-1.5 >> -dev-util/diffstat" >> +DEPEND=">=dev-util/bzr-1.5" >> >> -${EBZR_DIFF_CMD} | diffstat >> +[ -x /usr/bin/diffstat ] && ${EBZR_DIFF_CMD} | /usr/bin/diffstat >> > >

Re: [gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Nirbheek Chauhan
On Thu, Feb 19, 2009 at 2:56 PM, Ulrich Mueller wrote: > -DEPEND=">=dev-util/bzr-1.5 > -dev-util/diffstat" > +DEPEND=">=dev-util/bzr-1.5" > > -${EBZR_DIFF_CMD} | diffstat > +[ -x /usr/bin/diffstat ] && ${EBZR_DIFF_CMD} | /usr/bin/diffstat > Isn't this better? type diffstat &>

[gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Ulrich Mueller
> On Thu, 19 Feb 2009, Christian Faulhammer wrote: >> > +# The bzr command to get the diff output. >> > +EBZR_DIFF_CMD="bzr diff" >> >> > + ${EBZR_DIFF_CMD} | diffstat >> >> Why does this need to happen? Please add a comment. > It produces Git-like output about how much has change

[gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Christian Faulhammer
Hi, Donnie Berkholz : > On 17:19 Sat 14 Feb , Jorge Manuel B. S. Vicetto wrote: > > # @ECLASS-VARIABLE: EBZR_DIFFSTAT_CMD > > # @DESCRIPTION: > > -# The bzr command to get the diffstat output. > > -EBZR_DIFFSTAT_CMD="bzr diff" > > +# The bzr command to get the diff output. > > +EBZR_DIFF_CM

[gentoo-dev] Re: bzr.eclass

2009-02-19 Thread Christian Faulhammer
Hi, "Jorge Manuel B. S. Vicetto" : > Hi. > > Christian Faulhammer wrote: > > Hi, > > > > a user maintained a Bazaar overlay for some time now and introduced > > some changes to bzr eclass, I would like to introduce into the tree. > > Please review the attached patch. > > > > V-Li > > I'm atta

[gentoo-dev] Re: bzr.eclass

2009-02-14 Thread Christian Faulhammer
Hi, Ulrich Mueller : > > On Sat, 14 Feb 2009, Christian Faulhammer wrote: > > > Please review the attached patch. > > + local repo_type=3D$(bzr info "${EBZR_BRANCH_DIR}" | > head -n 1 | cut -d '= (' -f 1) > + if [[ "${repo_type}" !=3D "Lightweight checkout > " ]]; th

Re: [gentoo-dev] Re: bzr.eclass into Portage

2008-10-25 Thread Ulrich Mueller
> On Mon, 06 Oct 2008, Jorge Manuel B S Vicetto wrote: > Ulrich Mueller wrote: >> As I just learned there are (at least) three overlays using >> bzr.eclass, namely desktop-effects, emacs, and ltsp. >> >> So I think it is justified to move bzr.eclass to the Portage tree. > I'll be waiting for

Re: [gentoo-dev] Re: bzr.eclass into Portage

2008-10-13 Thread Bo Ørsted Andresen
On Monday 13 October 2008 04:43:48 Steve Long wrote: > EBZR_OPTIONS="${EBZR_OPTIONS:-}" (and similar variants) > doesn't do anything (beyond waste lex and yacc time.) It gets listed in the generated man page. [...] > The same consideration applies to all those "constant values" 'and indeed' > ${f

[gentoo-dev] Re: bzr.eclass into Portage

2008-10-12 Thread Ulrich Mueller
> On Mon, 13 Oct 2008, Steve Long wrote: > No objections, a minor point wrt bash: > EBZR_OPTIONS="${EBZR_OPTIONS:-}" (and similar variants) > doesn't do anything (beyond waste lex and yacc time.) It does something, namely assigns an empty string if the variable was undefined before. ;-) git.

[gentoo-dev] Re: bzr.eclass into Portage

2008-10-12 Thread Steve Long
Ulrich Mueller wrote: >> On Mon, 06 Oct 2008, Jorge Manuel B S Vicetto wrote: > >> No objections here, just a question. Do you know if the issue with the >> lp:// sources has been fixed in bzr? > No objections, a minor point wrt bash: EBZR_OPTIONS="${EBZR_OPTIONS:-}" (and similar variants) d

[gentoo-dev] Re: bzr.eclass into Portage

2008-10-05 Thread Ulrich Mueller
> On Mon, 06 Oct 2008, Jorge Manuel B S Vicetto wrote: > No objections here, just a question. Do you know if the issue with the > lp:// sources has been fixed in bzr? Looks like this is working fine with bzr-1.5, so I'll change the dependency. Ulrich

Re: [gentoo-dev] Re: bzr.eclass into Portage

2008-10-05 Thread Jorge Manuel B. S. Vicetto
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Ulrich. Ulrich Mueller wrote: >> On Fri, 21 Mar 2008, Christian Faulhammer wrote: > >> "Jorge Manuel B. S. Vicetto" <[EMAIL PROTECTED]>: >>> With the help of Ingmar we did some cleanup and added support for >>> eclass-manpages at >>> http://

Re: [gentoo-dev] Re: bzr.eclass into Portage

2008-10-05 Thread Jonas Bernoulli
Here is a patch that adds support for shared repositories. Since bzr is still a bit slow this is quite useful when using multiple branches. For example I have modified the live emacs(-cvs) ebuild to use the bzr mirror of emacs instead of cvs. I also have my own emacs branches, and sometimes want t

[gentoo-dev] Re: bzr.eclass into Portage

2008-10-05 Thread Ulrich Mueller
> On Fri, 21 Mar 2008, Christian Faulhammer wrote: > "Jorge Manuel B. S. Vicetto" <[EMAIL PROTECTED]>: >> With the help of Ingmar we did some cleanup and added support for >> eclass-manpages at >> http://git.overlays.gentoo.org/gitweb/?p=proj/desktop-effects.git;a=blob_plain;f=eclass/bzr.ecl

[gentoo-dev] Re: bzr.eclass into Portage

2008-03-25 Thread Christian Faulhammer
Hi, René 'Necoro' Neumann <[EMAIL PROTECTED]>: > I guess this fix will make it into bzr-1.4. Should the eclass then > depend on this version or should it still not allow the lp:-scheme? This eclass is still experimental...but I am all for raising the version requirement and allow as much feature

Re: [gentoo-dev] Re: bzr.eclass into Portage

2008-03-25 Thread René 'Necoro' Neumann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 René 'Necoro' Neumann schrieb: | Hi, | | Christian Faulhammer schrieb: | | We have a prior version for some time now in the Emacs overlay for two | | live ebuilds...so we go and merge your changed (ulm already did), test | | it and report any problem

Re: [gentoo-dev] Re: bzr.eclass into Portage

2008-03-24 Thread René 'Necoro' Neumann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Christian Faulhammer schrieb: | We have a prior version for some time now in the Emacs overlay for two | live ebuilds...so we go and merge your changed (ulm already did), test | it and report any problems. I just copied the bzr.eclass from the

[gentoo-dev] Re: bzr.eclass into Portage

2008-03-21 Thread Christian Faulhammer
Hi, "Jorge Manuel B. S. Vicetto" <[EMAIL PROTECTED]>: > you can check the current version used in desktop-effects at > http://git.overlays.gentoo.org/gitweb/?p=proj/desktop-effects.git;a=blob_plain;f=eclass/bzr.eclass;hb=master Yes, I did not find xeffects, but desktop-effects I now know. > Wi

Re: [gentoo-dev] Re: bzr.eclass into Portage

2008-03-20 Thread Jorge Manuel B. S. Vicetto
Christian Faulhammer wrote: "Jorge Manuel B. S. Vicetto" <[EMAIL PROTECTED]>: Petteri Räty wrote: Christian Faulhammer kirjoitti: in the Emacs overlay we imported the bzr.eclass from the xeffects overlay. In the near future Emacs development will switch from CVS to Bazaar and thus we need th

[gentoo-dev] Re: bzr.eclass into Portage

2008-03-20 Thread Christian Faulhammer
"Jorge Manuel B. S. Vicetto" <[EMAIL PROTECTED]>: > Petteri Räty wrote: > > Christian Faulhammer kirjoitti: > >> in the Emacs overlay we imported the bzr.eclass from the xeffects > >> overlay. In the near future Emacs development will switch from > >> CVS to Bazaar and thus we need the new eclass