Re: [gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-13 Thread Benda Xu
Michael Orlitzky writes: >> # Don't forget to make directory for sysfs >> -[[ ! -d ${ROOT}sys ]] && kernel_is 2 6 && mkdir ${ROOT}sys >> +[[ ! -d ${EROOT}sys ]] && kernel_is 2 6 && mkdir "${EROOT}"sys >> > > One more =) Nice catch! Jonathan Callen writes: > This one probably sh

[gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-12 Thread Jonathan Callen
On 06/12/2016 10:42 PM, Michael Orlitzky wrote: > On 06/12/2016 09:12 PM, Benda Xu wrote: >> Michael Orlitzky writes: >>> >>> Every rm, cp, mv, mkdir, dodir, cd, etc. needs "|| die". >> >> Thanks, updated. >> >> ... >> >> # Don't forget to make directory for sysfs >> -[[ ! -d ${ROOT}sys

Re: [gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-12 Thread Michael Orlitzky
On 06/12/2016 09:12 PM, Benda Xu wrote: > Michael Orlitzky writes: >> >> Every rm, cp, mv, mkdir, dodir, cd, etc. needs "|| die". > > Thanks, updated. > > ... > > # Don't forget to make directory for sysfs > - [[ ! -d ${ROOT}sys ]] && kernel_is 2 6 && mkdir ${ROOT}sys > + [[ ! -d

Re: [gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-12 Thread Benda Xu
Michael Orlitzky writes: > On 06/12/2016 05:21 AM, Benda Xu wrote: >> # let other packages install some of these headers >> -rm -rf "${D}"/${ddir}/scsi #glibc/uclibc/etc... >> +rm -rf "${ED}"${ddir}/scsi #glibc/uclibc/etc... > > Every rm, cp, mv, mkdir, dodi

Re: [gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-12 Thread Michael Orlitzky
On 06/12/2016 05:21 AM, Benda Xu wrote: > # let other packages install some of these headers > - rm -rf "${D}"/${ddir}/scsi #glibc/uclibc/etc... > + rm -rf "${ED}"${ddir}/scsi #glibc/uclibc/etc... Every rm, cp, mv, mkdir, dodir, cd, etc. needs "|| die".

Re: [gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-12 Thread Ulrich Mueller
> On Sun, 12 Jun 2016, Benda Xu wrote: >> Inside [[ ]] quotes are generally not needed. (There are several other >> instances of this.) > I thought so too, but with an experiment: > bash --version > GNU bash, version 4.3.30(1)-release (x86_64-pc-linux-gnu) > bash -l > $ [[ -f a b ]] && echo

Re: [gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-12 Thread Benda Xu
Zac Medico writes: > However, it behaves differently when you have a variable with "a b" as > its content. > > foo="a b" > [[ -f ${foo} ]] && echo hi Yeah, that's correct. My mistake. --- kernel-2.eclass 2016-02-17 22:46:25.235543840 +0900 +++ kernel-2.eclass 2016-06-12 18:17:15.983538

Re: [gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-12 Thread Zac Medico
On 06/12/2016 02:02 AM, Benda Xu wrote: > Hi Ulrich, > > Ulrich Mueller writes: > >>> I have added EPREFIX logics for EAPI<3 and improved the trailing >>> slashes and quotes. >> >>> - [[ -f ${ROOT}/usr/include/linux/autoconf.h ]] \ >>> + [[ -f "${EROOT}"usr/include/linux/auto

Re: [gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-12 Thread Benda Xu
Hi Ulrich, Ulrich Mueller writes: >> I have added EPREFIX logics for EAPI<3 and improved the trailing >> slashes and quotes. > >> -[[ -f ${ROOT}/usr/include/linux/autoconf.h ]] \ >> +[[ -f "${EROOT}"usr/include/linux/autoconf.h ]] \ > > Inside [[ ]] quotes are generally n

[gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-11 Thread Ulrich Mueller
> On Sun, 12 Jun 2016, Benda Xu wrote: > I have added EPREFIX logics for EAPI<3 and improved the trailing > slashes and quotes. > - [[ -f ${ROOT}/usr/include/linux/autoconf.h ]] \ > + [[ -f "${EROOT}"usr/include/linux/autoconf.h ]] \ Inside [[ ]] quotes are generally

[gentoo-dev] Re: RFC: kernel-2.eclass Prefix support

2016-06-11 Thread Benda Xu
Thanks Zac, Göktürk, I have added EPREFIX logics for EAPI<3 and improved the trailing slashes and quotes. Benda --- kernel-2.eclass 2016-02-17 22:46:25.235543840 +0900 +++ kernel-2.eclass 2016-06-12 11:48:19.843801138 +0900 @@ -105,6 +105,8 @@ HOMEPAGE="https://www.kernel.org/ https://w