Re: [gentoo-dev] Re: Proposal for flag-o-matic.eclass (append-ldflags)

2009-08-29 Thread Fabian Groffen
On 28-08-2009 16:08:59 -0400, Mike Frysinger wrote: > > As such, we will leave > > it local to Gentoo Prefix until we can come up with a better idea. > > stick it behind userland_GNU ? i dont mind extending append-ldflags > in such a way, but the "pro" you listed originally (protect users from >

Re: [gentoo-dev] Re: Proposal for flag-o-matic.eclass (append-ldflags)

2009-08-28 Thread Mike Frysinger
On Sunday 14 December 2008 16:39:17 Jeremy Olexa wrote: > On Mon, Dec 8, 2008 at 10:33 AM, Jeremy Olexa wrote: > > I am seeking a positive code review on the following change to > > flag-o-matic.eclass, diff is below (reasons are below that): > > Er, cancel that. The proposed patch isn't robust en

[gentoo-dev] Re: Proposal for flag-o-matic.eclass (append-ldflags)

2008-12-14 Thread Jeremy Olexa
On Mon, Dec 8, 2008 at 10:33 AM, Jeremy Olexa wrote: > Hello, > I am seeking a positive code review on the following change to > flag-o-matic.eclass, diff is below (reasons are below that): Er, cancel that. The proposed patch isn't robust enough to catch something like "append-ldflags -Wl,--bad-f